ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
421,396 Commits 3 Branches 3 Tags
940f90f3da170b62379e9d1d33d4e6d690997026
Commit Graph
117 Commits
Author SHA1 Message Date
Julien Nabet 823ef9ef32 Use for-range loops in framework 
Change-Id: I72ea832848fd7c76863bcee70a3303de488c0b0f
Reviewed-on: https://gerrit.libreoffice.org/51471
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-03-17 23:08:48 +01:00
Noel Grandin 2f5868c430 loplugin:redundantfcast look for redundant copies in return statements 
Change-Id: I5f416c865dfe1c36018784246a8007452eb42008
Reviewed-on: https://gerrit.libreoffice.org/50996
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-12 07:37:24 +01:00
Andrea Gelmini 240e67e37e Fix typos 
Change-Id: I005023337dbe593e0ac1d76f7b10848d24f314a5
Reviewed-on: https://gerrit.libreoffice.org/50785
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-03-06 09:42:04 +01:00
Andrea Gelmini cfffb09b3d Fix typos 
Change-Id: I2a578961837076ebce3c1fb2681b0785d1d490ac
Reviewed-on: https://gerrit.libreoffice.org/47857
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-01-14 16:24:04 +01:00
Stephan Bergmann cf8b8cad05 More loplugin:cstylecast: framework 
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: I8981ef6de675bf10c103e1af0afccd620762268d
 2018-01-12 20:23:23 +01:00
Noel Grandin 3af500580b loplugin:salcall fix functions 
since cdecl is the default calling convention on Windows for
such functions, the annotation is redundant.

Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d
Reviewed-on: https://gerrit.libreoffice.org/46164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-11 12:13:46 +01:00
Noel Grandin 87a9979c89 overload std::hash for OUString and OString 
no need to explicitly specify it anymore

Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec
Reviewed-on: https://gerrit.libreoffice.org/43567
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-23 08:15:35 +02:00
Noel Grandin 3697b87b70 use more OUString::operator== in forms..sal 
Change-Id: I70d7e50f8c1e019524ccad915f0cca912c5035dc
Reviewed-on: https://gerrit.libreoffice.org/39899
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-13 15:20:58 +02:00
Noel Grandin 6bbda13286 loplugin:unusedfields in forms..idlc 
Change-Id: If250ff47c1f375fe24c61b5bf271da9a9c330822
Reviewed-on: https://gerrit.libreoffice.org/39133
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-23 08:59:56 +02:00
Johnny_M fd48f39a7e Translate German comments and debug strings (leftovers in f... dirs) 
Translates all (leftovers) found using a custom regex, in directories not
shown by /bin/find-german-comments and beginning with "f".

Additionally:
- Fixed translation in formula/source/ui/dlg/funcutl.cxx (translated in
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=5e04331fc0a6434c61d3d18843cb4f80a44e5989 ),
because clearing an event is quite the opposite of its triggering.

Change-Id: I0fd62193a29883796cd05e5a80ce8a2900636b6c
Reviewed-on: https://gerrit.libreoffice.org/37839
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2017-05-20 13:43:17 +02:00
Noel Grandin 666403a4b6 loplugin:checkunusedparams in framework 
Change-Id: I963159550da9d735bb70636917ecc290744298b4
Reviewed-on: https://gerrit.libreoffice.org/37142
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-02 14:25:25 +02:00
Noel Grandin c0f9bdd3e6 unnecessary use of OUStringBuffer in throwing exceptions 
Change-Id: Iec1473264426f19c31e72260dfce9494389e474f
Reviewed-on: https://gerrit.libreoffice.org/33788
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-02 07:48:21 +00:00
Stephan Bergmann e57ca02849 Remove dynamic exception specifications 
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-01-26 12:54:43 +00:00
Stephan Bergmann fba7a44ee4 New loplugin:dynexcspec: Add @throws documentation, framework 
Change-Id: I19a4517449be3defe97fe0d78dd1a16b08b79247
 2017-01-19 18:03:20 +01:00
Stephan Bergmann 91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Noel Grandin 52b91f3454 new loplugin fragiledestructor 
fix up a small number of places that it finds

Change-Id: Iedc91e141edfb28f727454f698cd2155a7fd5bf4
Reviewed-on: https://gerrit.libreoffice.org/26566
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-12 08:45:14 +00:00
Stephan Bergmann ed467869d8 loplugin:salbool: Automatic rewrite of sal_False/True 
Change-Id: Idf27ee5370f1fa24adf22908d9e801c7d40db935
 2016-04-20 17:25:42 +02:00
Noel Grandin 789055bc2a clang-tidy performance-unnecessary-copy-initialization 
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.

Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 07:37:31 +00:00
Stephan Bergmann 4be81de0d6 Resolve OUStringList typedef 
Change-Id: Ifb5dc5128b5619abb83eea427c7fb1115fd825f3
 2016-04-07 21:44:02 +02:00
Stephan Bergmann f57c9921de Get rid of BaseHash wrapper (to unbreak Windows build) 
Change-Id: Ieae7d6af7a4753958ebf2aeae9d2ae6fafe5efe9
 2016-04-07 18:14:53 +02:00
Noel Grandin 0839f90394 convert EConfigurationModes to scoped enum 
Change-Id: I1e81c8d637e738f536f7efad8b67d0c9183e6483
 2016-02-24 11:48:38 +02:00
Caolán McNamara bea8a7ad63 cppcheck: noExplicitConstructor 
Change-Id: Ib43e53d5b6c9c130adb765ac9b769f58060ac640
 2015-12-29 19:46:23 +00:00
Noel Grandin 8e234c5b7d use initialiser syntax for Sequence<OUString> 
replaced using the script:

git grep -lP 'Sequence.*OUString.*\(1\)'
  | xargs perl -0777 -pi
    -e "s/Sequence< OUString > (\w+)\(1\);
.*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g"

Change-Id: I23688a91562051a8eed11fc2a85599545c285c34
Reviewed-on: https://gerrit.libreoffice.org/19967
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 10:13:08 +00:00
Stephan Bergmann 06c5c63020 loplugin:nullptr (automatic rewrite) 
Change-Id: Ie178c474921c1695927a9b01a9972baf09fbb73d
 2015-11-10 10:31:27 +01:00
Noel Grandin 5797d29e9e use uno::Reference::set method instead of assignment 
Change-Id: Ic979f8a7734d0ef7a915d47a875cdcd460c0cc58
 2015-11-02 12:23:16 +02:00
Noel Grandin d191d1f9b6 com::sun::star->css in framework 
Change-Id: If5a77db83fcbef5ed436f2043ddeb7c515a840dc
Reviewed-on: https://gerrit.libreoffice.org/19356
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-14 06:37:16 +00:00
Stephan Bergmann b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Noel Grandin 58aea3f36c loplugin:unusedmethods 
- improvements to the plugin to find more method calls
- improvements to python script to remove more false+
- fix the FORCE_COMPILE_ALL build flag to include code in
  the $WORKDIR

Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836
Reviewed-on: https://gerrit.libreoffice.org/19064
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-01 10:43:24 +00:00
Andrea Gelmini a50539e2aa Fix typos 
Change-Id: Iab78219aff60a7a45a319a96f326e27a6e8e25b8
Reviewed-on: https://gerrit.libreoffice.org/18953
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
 2015-09-30 12:41:09 +00:00
Stephan Bergmann e9b7506415 loplugin:stringconstant: OUStringBuffer: appendAscii -> append 
Change-Id: Iadb6e16a7aca322a78a82ae1a52f5d085b300efc
 2015-08-31 08:03:15 +02:00
Takeshi Abe 431f2ce818 framework: tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants.

Change-Id: I6acff50f23bcbac58c689caf2a7f07dbd5404e57
Reviewed-on: https://gerrit.libreoffice.org/17734
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-08-14 10:46:14 +00:00
Andrea Gelmini 465489d97a Fix typos 
Change-Id: Id884946cae0687d0b71c967e236e58df17567884
Reviewed-on: https://gerrit.libreoffice.org/16707
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-07-03 09:43:46 +00:00
Stephan Bergmann e4c1c0829a Replace remaining getCppuType et al with cppu::UnoType 
Change-Id: I320895b73f101986e1aab95668c7b76e04315aab
 2015-04-01 08:39:26 +02:00
Matthew Pottage 2c71f38301 fdo#75757: Remove inheritance from std::vector. 
In framework/inc/stdtypes.h. class OUStringList.

Removed inheritance and separated additional functionality into more general
functions. Changed to using std::vector<OUString> rather than SequenceAsVector.

The functions now work for any vector. Although they could be made more general
and support any container by altering the arguments.

Change-Id: I472267029dc69da1ad0a98d55e26e3784f6b07cd
Reviewed-on: https://gerrit.libreoffice.org/13612
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-01-07 15:47:42 +00:00
Stephan Bergmann b98352996c framework: Use appropriate OUString functions on string constants 
Change-Id: I5da5cd3254102c742021b3e7b4e1f907ca897ca5
 2014-12-18 14:12:22 +01:00
Brij Mohan Lal Srivastava d32be3ace8 fdo#86023 - O[U]String needs a 'clear' method 
Added clear() method to OString and OUString class, Updated appropriate call-sites.

Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2014-11-14 09:20:38 +01:00
Andrea Gelmini da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Tor Lillqvist a0de5cc93d fdo#529470: I can't remove a path in AutoText dialog 
This is, not surprisingly, somewhat weird code, but I think this patch does
what is necessary, it does fix the bug.

Change-Id: Ie1947b311f1455ba48a904f5ef42ad92899fac31
 2014-08-19 21:03:05 +03:00
Takeshi Abe 9bac4d413e typo: more then -> more than 
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
 2014-08-01 23:40:12 +09:00
Thomas Arnhold 92b447876d css already means ::com::sun::star 
Change-Id: I48d7b746d7cc49246743c62480b0d225d2519342
 2014-05-27 14:00:28 +02:00
Julien Nabet 68741d0055 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part13 
Change-Id: Ieecfd7ccb10c75ac639d0ba8e7cb588607097c2a
 2014-05-15 22:52:22 +02:00
Tor Lillqvist 728ec86062 Typo: s/cant/can't/ 
Change-Id: Id76b4ea569246c4b96da48dbc8d5a557367e0cca
 2014-04-18 00:30:35 +03:00
Noel Grandin a6287e21f1 framework: sal_Bool->bool 
Change-Id: Ia6e87e2b382bd4005637e14088bde9e809996a25
 2014-04-07 13:53:49 +02:00
Tor Lillqvist ee3945bd98 Kill superfluous spacing before semicolons 
Change-Id: I53689e78221f3fe074e47d6b47f1a2c3fef96222
 2014-04-06 19:37:48 +03:00
Tor Lillqvist 951ed199f1 Kill superfluous vertical whitespace 
Change-Id: Ia1bb2b40c74efb17e655dd6f00d7ba48c16c65ae
 2014-04-06 19:37:48 +03:00
Noel Grandin 5babf1b903 remove unnecessary scope qualifier from sal_Bool uses 
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
 2014-04-03 13:54:02 +02:00
Stephan Bergmann 70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
 2014-03-26 16:39:26 +01:00
Stephan Bergmann bcb01dd1df Use cppu::BaseMutex instead of plain osl::Mutex as base 
Change-Id: I1330f76e3137aaa8d00de82f136ee6968196db70
 2014-03-18 13:29:15 +01:00
Stephan Bergmann 5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Caolán McNamara 838b77f5f3 Resolves: rhbz#1065807 use xdg ~/Templates for default Template location 
(if it exists)

Change-Id: I98fc9fd54d1f56c8bed24ce4d2ebf53756ded2cc
 2014-02-25 10:45:27 +00:00