ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
421,396 Commits 3 Branches 3 Tags
940f90f3da170b62379e9d1d33d4e6d690997026
Commit Graph
108 Commits
Author SHA1 Message Date
Andrea Gelmini cfffb09b3d Fix typos 
Change-Id: I2a578961837076ebce3c1fb2681b0785d1d490ac
Reviewed-on: https://gerrit.libreoffice.org/47857
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-01-14 16:24:04 +01:00
Andrea Gelmini dbe0201d3a Fix typos 
Change-Id: I766862d255ac285329ae423629c7445837ddd55f
Reviewed-on: https://gerrit.libreoffice.org/47280
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2018-01-05 11:03:10 +01:00
Andrea Gelmini ca9897cf77 Fix typos 
Change-Id: I28d73221ea83d89f73460f591723c6f80594ff15
Reviewed-on: https://gerrit.libreoffice.org/46822
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-12-20 10:39:40 +01:00
Andrea Gelmini d71bcc4dc5 Fix typos 
Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91
Reviewed-on: https://gerrit.libreoffice.org/44654
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Page <aptitude@btconnect.com>
 2017-11-13 08:43:17 +01:00
Stephan Bergmann a457c7c6b0 loplugin:includeform: framework 
Change-Id: Ib5eaab06ff0cc1b44db9e4057ab349a0990af14d
 2017-10-23 22:46:07 +02:00
Noel Grandin 3dcf6dfcee remove unnecessary use of 'this->' 
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4
Reviewed-on: https://gerrit.libreoffice.org/40671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-02 13:45:36 +02:00
Jochen Nitschke 959496794c cleanup osl/diagnose.h includes 
with command
> git grep -l osl/diagnose.h *.cxx |
  xargs grep -L -w 'OSL_\w*' |
  xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d'

headers need more work

Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab
Reviewed-on: https://gerrit.libreoffice.org/37350
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-05-09 15:41:46 +02:00
Andrea Gelmini fba66b325c Fix typos 
Change-Id: I19d30a1ef4236dbe0a0053dad67a5ba7b1586fc8
Reviewed-on: https://gerrit.libreoffice.org/35054
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Johnny_M <klasse@partyheld.de>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-11 05:04:40 +00:00
Andrea Gelmini 34e1739d56 Fix typos 
Change-Id: Ieb35517ba57ca62526e84f6b6cee4c9129b4380a
Reviewed-on: https://gerrit.libreoffice.org/34805
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-03 06:57:58 +00:00
Stephan Bergmann e57ca02849 Remove dynamic exception specifications 
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-01-26 12:54:43 +00:00
Stephan Bergmann 7d8bdf8462 Clean up framework/inc/dispatchcommands.h 
Change-Id: I6a9a8ae34c2f5abafd4192287fb12d4289a761ff
 2016-04-18 17:32:45 +02:00
Noel Grandin 789055bc2a clang-tidy performance-unnecessary-copy-initialization 
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.

Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 07:37:31 +00:00
Noel Grandin f045c536db clang-tidy performance-unnecessary-value-param in framework 
Change-Id: I80987ea1bfac7478574de46ee30fc58fcc17eb68
 2016-04-12 11:56:07 +02:00
Maxim Monastirsky 21b92f386c MenuDispatcher::m_pMenuManager is always nullptr 
... as shown by 7da15debe3.
Which means that MenuManager is unused, and MenuDispatcher
does nothing useful.

Change-Id: Ic85619531054a573d971d38b52609e1cbcaf780c
Reviewed-on: https://gerrit.libreoffice.org/23117
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-03-10 15:23:31 +00:00
Noel Grandin 1d5c39192e new loplugin:unusedfields 
run it over the framework module

Change-Id: I1220a4be0936ba30136ce22ffd78633c8a7b9d35
 2015-11-20 10:12:58 +02:00
Stephan Bergmann 06c5c63020 loplugin:nullptr (automatic rewrite) 
Change-Id: Ie178c474921c1695927a9b01a9972baf09fbb73d
 2015-11-10 10:31:27 +01:00
Noel Grandin 5797d29e9e use uno::Reference::set method instead of assignment 
Change-Id: Ic979f8a7734d0ef7a915d47a875cdcd460c0cc58
 2015-11-02 12:23:16 +02:00
Andrea Gelmini a18fc918d5 Fix typos 
Change-Id: I051caee9ec6181074201ac4a8cb6fcec4fdf2293
Reviewed-on: https://gerrit.libreoffice.org/18951
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
 2015-09-30 13:50:06 +00:00
Andrea Gelmini 799cc41b53 Fix typos 
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0
Reviewed-on: https://gerrit.libreoffice.org/16834
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2015-07-08 05:48:18 +00:00
Andrea Gelmini 465489d97a Fix typos 
Change-Id: Id884946cae0687d0b71c967e236e58df17567884
Reviewed-on: https://gerrit.libreoffice.org/16707
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-07-03 09:43:46 +00:00
Julien Nabet d7f62705ab Typo: metod(s)->method(s) 
Change-Id: Ie8e8c33bba30ae454c4a0cb54eb6613293a398e6
 2015-04-01 21:15:57 +02:00
Andrea Gelmini da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Stephan Bergmann ad9498f8b8 More -Werror,-Wunused-private-field 
...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
 2014-10-15 15:58:56 +02:00
Julien Nabet 037d03b9fa Typo: (N|n)ormaly->(N|n)ormally 
Change-Id: I96d081f394b0b62d99ec1034bf5e99da9aedd9d9
 2014-09-10 22:35:39 +02:00
Takeshi Abe 9bac4d413e typo: more then -> more than 
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
 2014-08-01 23:40:12 +09:00
Tor Lillqvist 9a7fc5ee26 Typo: s/shure/sure 
Change-Id: I1c55d3ee8be06deb6d48a6ad5cd30d170c8b9dbb
 2014-04-18 00:30:35 +03:00
Noel Grandin a6287e21f1 framework: sal_Bool->bool 
Change-Id: Ia6e87e2b382bd4005637e14088bde9e809996a25
 2014-04-07 13:53:49 +02:00
Tor Lillqvist ee3945bd98 Kill superfluous spacing before semicolons 
Change-Id: I53689e78221f3fe074e47d6b47f1a2c3fef96222
 2014-04-06 19:37:48 +03:00
Tor Lillqvist 951ed199f1 Kill superfluous vertical whitespace 
Change-Id: Ia1bb2b40c74efb17e655dd6f00d7ba48c16c65ae
 2014-04-06 19:37:48 +03:00
Noel Grandin 5babf1b903 remove unnecessary scope qualifier from sal_Bool uses 
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
 2014-04-03 13:54:02 +02:00
Stephan Bergmann 15bb864ea8 Use SolarMutexGuard directly 
(and access safe data members directly)

Change-Id: I4a033fc2acd858534d329023c72c278f8b4b9244
 2014-03-18 09:43:17 +01:00
Stephan Bergmann ab3acb7ef7 Consolidate framework::{Read,Write}Guard 
...now that it is obvious that they both do the same

Change-Id: I6878acca4750ef4204fe32a695b6d9e1c5140115
 2014-03-17 16:52:34 +01:00
Stephan Bergmann 5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexander Wilms 0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Julien Nabet 6f0e7c36e4 Typo: seam(s) -> seem(s) 
Change-Id: I840d120644760b61a39ad88b4095056f0f753bb7
 2014-02-06 21:22:42 +01:00
Andras Timar b55259eeb5 typo fixes 
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
 2013-12-20 15:55:00 +01:00
Andras Timar 7f436c1fd3 typo fixes in comments 
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
 2013-09-26 11:47:45 +02:00
Tor Lillqvist 9a8e2d09bc Use SAL_WARN_IF instead of framework's home-grown LOG_ASSERT(2) 
Also remove declarations for debug function that don't exist (have been
removed (misguidedly?) as unused perhaps).

Change-Id: I0bc3320c52b3d50dc851a07fdc30b593cc4856b1
 2013-09-08 23:51:41 +03:00
Noel Grandin 376d5a6ad9 convert more services in framework module to WeakImplHelper 
Change-Id: I417ae2ce644f39fce0e8eb9fbe6a3a3c783b6227
 2013-07-23 10:05:46 +02:00
Caolán McNamara 7d257ffb13 misleading comment, beamer section, not removed helpagent section 
Change-Id: I1e4eb58809e471e9138895e7bb2e940a0299c1e9
 2013-06-06 13:33:27 +01:00
Noel Grandin fe1ac1bf90 fdo#46808, convert XMultiServiceFactory to XComponentContext 
Change-Id: I5ed0b12bf37e7d235fc88182c006a6ed07ef2343
 2013-05-22 15:20:07 +02:00
Thomas Arnhold 1264480bc3 fdo#60724 correct spelling 
Change-Id: I3d978cb657647b4a4e9709258c6a6a4ac1d339a9
 2013-04-15 05:39:31 +02:00
Luboš Luňák 1946794ae0 mass removal of rtl:: prefixes for O(U)String* 
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
 2013-04-07 14:23:11 +02:00
Noel Grandin 244c7cdede fdo#46808, convert task::StatusIndicatorFactory to new style 
the service already existed, it just needed an IDL file.

Change-Id: I84c8e48e176ec3a38ac48a7abcec7463390523b9
 2013-03-04 14:22:33 +02:00
Thomas Arnhold f5ca04caca Related to fdo#60724: correct spelling 
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
 2013-03-03 17:14:16 +01:00
Gregg King db7a441342 Typo fix: informations -> information and a few other adjacent typos. 
FDO:60724

Change-Id: I73ad9f1c37cbbcf28d996ed73c75cf09553e499b
Reviewed-on: https://gerrit.libreoffice.org/2479
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2013-03-02 02:45:55 +00:00
Ivan Timofeev e2f97dcc10 spelling: otherwhise -> otherwise 
Change-Id: I2d89edbb2574b4e677c9a0682bc829d9476b54db
 2013-02-17 13:57:44 +04:00
Noel Grandin e7018375cd fdo#46808, Adapt frame::StartModule UNO service to new style 
The service already existed, it just did not have an IDL file.

Change-Id: I400551d34d074cc8cf36fad58badc921422a2efa
 2013-01-15 09:56:00 +02:00
Michael Meeks 17ff7b41d1 re-base on ALv2 code. Includes: 
Patches contributed by: Armin Le Grand.
    #118558# Correcting OLE attributes of LO3.4 at load time by loading as OOo3.3, details see task.
    http://svn.apache.org/viewvc?view=revision&revision=1195906
    #118485# - Styles for OLEs are not saved.
    http://svn.apache.org/viewvc?view=revision&revision=1182166
    #118898# Adapted ImpGraphic::ImplGetBitmap to correctly convert metafiles
    http://svn.apache.org/viewvc?view=revision&revision=1293316
    #119337# Solves the wrong get/setPropertyValue calls in
    SvxShapeText (and thus in SvxOle2Shape)
    http://svn.apache.org/viewvc?view=revision&revision=1344156

    Patches contributed by Mathias Bauer (and others)
    gnumake4 work variously
    http://svn.apache.org/viewvc?view=revision&revision=1394707
    http://svn.apache.org/viewvc?view=revision&revision=1394326
    cws mba34issues01: #i117717#: remove wrong assertion
    http://svn.apache.org/viewvc?view=revision&revision=1172349

    Patch contributed by Herbert Duerr
    goodbye Registration and License dialogs, don't let the door hit you
    http://svn.apache.org/viewvc?view=revision&revision=1172613
    help gcc 4.6.0 on 32bit ubuntu 11.10"
    http://svn.apache.org/viewvc?view=revision&revision=1245357

    Do not add targets for junit tests when junit is disabled.
    Patch contributed by Andre Fischer
    http://svn.apache.org/viewvc?view=revision&revision=1241508

Revert "sb140: #i117082# avoid unncessary static class data members
    commit 21d97438e2.
remove obsolete FreeBSD visibility special case.
retain consolidated BSD bridge code, remove OS/2 pieces.
 2012-11-15 16:06:08 +00:00
Caolán McNamara 73fc75bf80 ditch SYNCHRONIZED_START/END 
Change-Id: I1c0c015f371346efc5712ead7abe9e7f2ec0f9d0
 2012-10-25 09:09:26 +01:00