Caolán McNamara
19ca4e8a5e
Resolves: tdf#116540 Revert "ofz infinite loop"
...
This reverts commit e4551b905e .
Change-Id: I95634dd166c51586b5da47b996993a098823ca32
Reviewed-on: https://gerrit.libreoffice.org/51941
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-03-27 15:49:23 +02:00
Noel Grandin
c98d330302
replace Color(COL_*) with COL_*
...
using
git grep -lwP "Color\s*\(\s*(COL_\w+)\s*\)"
| xargs perl -pi -e "s/Color\s*\(\s*(COL_\w+)\s*\)//g"
and then some manual fixup where the resulting expression no longer
compiled
Change-Id: I0e268d78611c3be40bba9f60ecfdc087a36c0df4
Reviewed-on: https://gerrit.libreoffice.org/50372
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-02-27 11:28:29 +01:00
Noel Grandin
19a906f096
drop Color::SetColor(ColorData) in favour of operator=
...
first stage of getting rid of ColorData
Change-Id: I5e4e95eb958722814c43c8d1ebfef17ad18c29ec
Reviewed-on: https://gerrit.libreoffice.org/49997
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-02-20 07:19:16 +01:00
Johnny_M
8f05a01bef
Translate German variable names
...
Akt -> Current in rtf (rtfitem)
Change-Id: I5925295c45d436c07e75b82cc0effea962bc1816
Reviewed-on: https://gerrit.libreoffice.org/49534
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2018-02-12 11:13:48 +01:00
Johnny_M
c0a2384390
Translate German variable names
...
Akt -> Current in rtf (svxrtf)
Change-Id: I5205654ec3b3d5dd1a7a611dc8f2e356a6290fc6
Reviewed-on: https://gerrit.libreoffice.org/49535
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2018-02-12 11:10:45 +01:00
Noel Grandin
cf4ee7b872
loplugin:useuniqueptr in SvxRTFParser
...
Change-Id: I0d01e8612ff4e8eb1eb53a817c8fb586b61aa5bb
Reviewed-on: https://gerrit.libreoffice.org/49150
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-02-05 07:52:11 +01:00
Noel Grandin
add8b70993
loplugin:useuniqueptr in SvxRTFItemStackType
...
Change-Id: I1677915d91fb151997d4bef18473f33ab2f09648
Reviewed-on: https://gerrit.libreoffice.org/49173
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-02-05 07:50:28 +01:00
Noel Grandin
73139fe600
loplugin:unusedmethods
...
Change-Id: If00b0e659e1818c29ae39b89f8b4f7ea29d14986
Reviewed-on: https://gerrit.libreoffice.org/48185
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-01-20 07:40:41 +01:00
Stephan Bergmann
54a8e708b4
More loplugin:cstylecast: editeng
...
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/ > "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files
Change-Id: I09a4d688e6f3c1ecbe05a7d27ebd955e8ba1eb65
2018-01-12 20:25:09 +01:00
Noel Grandin
a566fd1c1a
loplugin:unusedmethods
...
Change-Id: I2efb5c0e5735c179314c6c5de87821cee3b033e1
Reviewed-on: https://gerrit.libreoffice.org/45386
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-11-29 07:28:57 +01:00
Caolán McNamara
3c5addae5c
ofz: Timeout give up earlier on SvParserState::Error
...
Change-Id: I191f935c11bc59e0b1a990ac5d3c38a49390afd1
Reviewed-on: https://gerrit.libreoffice.org/44644
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-11-12 01:11:00 +01:00
Caolán McNamara
e4551b905e
ofz infinite loop
...
Change-Id: Iae9faaa86e4b3edb9a1fdfe9c6b67eee211c19a9
Reviewed-on: https://gerrit.libreoffice.org/44361
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-11-06 18:33:02 +01:00
Noel Grandin
4f798ed256
loplugin:constantparam in editeng
...
Change-Id: I0a07326d5b63e82ef16e02f75fd8523e3b73e1f4
Reviewed-on: https://gerrit.libreoffice.org/44096
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-10-31 13:58:23 +01:00
Michael Stahl
34f4446b0a
editeng: fix assert about wrong EE_PARA_OUTLLEVEL item
...
It's a SfxInt16Item in DefItems::DefItems().
Change-Id: I01644b0b9d689d4d8756c52f1c2868f03b3037a5
2017-10-05 22:48:21 +02:00
Noel Grandin
61d49afadb
loplugin:unusedmethods
...
Change-Id: Id66cf12e3a59aeed1b9a7a111b841e30b248635b
Reviewed-on: https://gerrit.libreoffice.org/40876
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-08-08 20:56:30 +02:00
Noel Grandin
9878293228
loplugin:unusedmethods
...
Change-Id: I7f26ee112ed89ee3e69c56930260565f66ff145b
Reviewed-on: https://gerrit.libreoffice.org/40442
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-07-26 12:25:56 +02:00
Noel Grandin
4ed70b89aa
loplugin:unusedfields
...
Change-Id: I21e538b8e9c7a5f0fb233019efac37a3555e3c93
Reviewed-on: https://gerrit.libreoffice.org/40438
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-07-26 11:15:52 +02:00
Noel Grandin
2fffaf6f05
loplugin:unusedmethods
...
Change-Id: Ia874baf21257e5fe41e104211068a2bcc50446eb
Reviewed-on: https://gerrit.libreoffice.org/40391
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-07-25 12:03:50 +02:00
Noel Grandin
5fad6eb1b3
loplugin:unusedfields in editeng
...
Change-Id: I61ddd2ce8ded65251fdf1903e6cb67f0d18c9451
Reviewed-on: https://gerrit.libreoffice.org/40293
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-07-22 08:51:32 +02:00
Noel Grandin
4b2262ab5b
new loplugin unnecessaryparen
...
Change-Id: Ic883a07b30069ca6342d7521c8ad890f4326f0ec
Reviewed-on: https://gerrit.libreoffice.org/39549
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-07-05 11:08:48 +02:00
Stephan Bergmann
d358fc1a45
-Werror=ignored-qualifiers (GCC 8)
...
Change-Id: I2a43ce3ca6af87ac53dd534c0c37150a000e7013
2017-06-28 10:24:53 +02:00
Noel Grandin
222bc56e21
loplugin:unusedfields in desktop..editeng
...
Change-Id: Ieea12d0790a1034eba8975fe74fa205f02003b7d
Reviewed-on: https://gerrit.libreoffice.org/39134
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-06-23 09:00:18 +02:00
Noel Grandin
e4e4d5713e
clang-tidy readability-delete-null-pointer
...
which in turn triggered some loplugin:useuniqueptr
Change-Id: I0c38561fc9b68dac44e8cf58c8aa1f582196cc64
Reviewed-on: https://gerrit.libreoffice.org/38281
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-06-12 08:43:48 +02:00
Stephan Bergmann
256dfb9e78
Improved loplugin:cstylecast to reference types: editeng
...
Change-Id: I0a9321baf91ea0b460f4d1b6a638278275b184d3
2017-06-05 21:18:11 +02:00
Noel Grandin
2ccde70d60
teach redundantcast plugin about functional casts
...
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0
Reviewed-on: https://gerrit.libreoffice.org/37910
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-30 08:50:31 +02:00
Noel Grandin
57f1934bda
convert HTML_TOKEN_IDS to scoped enum
...
Change-Id: I525506e0103e4f17e5b8b95f15c1285d65b93de9
Reviewed-on: https://gerrit.libreoffice.org/37220
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-05-05 08:38:36 +02:00
Noel Grandin
c70d49c7c8
use strong_int for LanguageType
...
Change-Id: If99a944f7032180355da291ad283b4cfcea4f448
Reviewed-on: https://gerrit.libreoffice.org/36629
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-04-26 08:50:54 +02:00
Chris Sherlock
da64d198ec
tools: svstream.hxx needs only errcode.hxx & not errinf.hxx
...
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca
Reviewed-on: https://gerrit.libreoffice.org/36896
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com >
2017-04-25 09:31:31 +02:00
Jens Carl
5aaaa9408a
tdf#39468 Translate German comments
...
Translate German comments and terms in editeng/
Change-Id: I9bd15ca0914b34839d83751f530dd212d91e029e
Reviewed-on: https://gerrit.libreoffice.org/35884
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2017-03-30 10:14:53 +00:00
Noel Grandin
9bfd742d8c
loplugin:unusedmethods
...
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0
Reviewed-on: https://gerrit.libreoffice.org/35834
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-29 11:43:40 +00:00
Andrea Gelmini
55cc79f33f
Fix typos
...
Change-Id: Ic823a46019138b8bbcacd7b52b48d7d7ead2fde2
Reviewed-on: https://gerrit.libreoffice.org/35629
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2017-03-25 09:27:18 +00:00
Stephan Bergmann
6291574d94
Remove unused #include <ctype.h>
...
Change-Id: I8bf3e30687e20151a9e1936e69362abfe9b3a99d
2017-03-23 17:55:31 +01:00
Noel Grandin
f2a873cd13
convert SvxBorderStyle to scoped enum
...
and rename to SvxBorderLineStyle
Change-Id: I19e530f162e4ca6290a0ad076e7fe3d5775ae6bc
Reviewed-on: https://gerrit.libreoffice.org/35265
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-17 06:04:30 +00:00
Noel Grandin
8ccbc16b5e
convert SvxFrameDirection to scoped enum
...
Based on the casts in chart2/source/view/main/ChartView.cxx
and the similarity of naming of values, I conclude that this
enum was intended to abstract over css::text::WritingMode2.
Added a comment to that effect.
Change-Id: I3af8bbe8b6ac8c4a9375f6ccde145b98b9c69a57
Reviewed-on: https://gerrit.libreoffice.org/35164
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-15 08:35:10 +00:00
Noel Grandin
1f4e0359d3
convert SvxShadowLocation to scoped enum
...
Change-Id: Ie51995579312328538263172cd3173641df89bca
Reviewed-on: https://gerrit.libreoffice.org/34965
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-08 09:07:34 +00:00
Noel Grandin
9cacb6ad9f
convert SvxCaseMap to scoped enum
...
Change-Id: Iea77ddc21e9b2d5a021c08e323da9ccabf9d46bd
Reviewed-on: https://gerrit.libreoffice.org/34963
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-08 09:04:30 +00:00
Noel Grandin
9cb57a50d7
convert SvxAdjust to scoped enum
...
Change-Id: I0df7a5313d6d62d0c657e62ef6014a3ddbab4639
Reviewed-on: https://gerrit.libreoffice.org/34941
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-03-08 06:30:49 +00:00
Stephan Bergmann
f407666ec9
loplugin:subtlezeroinit: editeng
...
Change-Id: I2fb3700f00ad76096d048747c8333337d5ffce8f
2017-02-21 07:35:07 +01:00
Tor Lillqvist
b57d51e32f
Drop :: prefix from std in [de]*/
...
Change-Id: I3247894fe022dce7f0aa351bd85fefcd7c545dd4
Reviewed-on: https://gerrit.libreoffice.org/34377
Reviewed-by: Tor Lillqvist <tml@collabora.com >
Tested-by: Tor Lillqvist <tml@collabora.com >
2017-02-17 18:41:19 +00:00
Noel Grandin
52305b6620
convert SvParserState to scoped enum
...
and drop unused WAITFORDATA enumerator
Change-Id: I658802d88a19dcc2d378456375810454e7426447
2017-02-14 14:22:24 +02:00
Noel Grandin
861a322c66
loplugin:expandablemethodds in include/editeng
...
Change-Id: Iaf56cb9c16a4cbfb9ab1636228c77d1033a334f5
Reviewed-on: https://gerrit.libreoffice.org/30132
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-21 13:00:01 +00:00
Jochen Nitschke
705574be7a
use SfxItemPool::IsWhich instead of custom implementation
...
Change-Id: I56cbdc1ede491486643f73a98117c5cd4ce77c1d
Reviewed-on: https://gerrit.libreoffice.org/28564
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-09-01 06:46:46 +00:00
Jochen Nitschke
95bfa2c03d
use SfxItemPool::IsSlot instead of custom implementation
...
Change-Id: I435fb78f10f361120ee1865465dab93aa4661806
Reviewed-on: https://gerrit.libreoffice.org/28565
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-09-01 06:38:06 +00:00
Noel Grandin
49561be0fd
convert SvxTabAdjust to scoped enum
...
Change-Id: I29a33b8ea5daaa4b9059d024ffa4a99ca924f7ef
2016-08-17 08:45:15 +02:00
Noel Grandin
42ab2cfbd9
convert SvxLineSpace to scoped enum
...
and rename to be more explicit
Change-Id: Id06e6b68ef30e1d0d0daf19c37a390060e8bcb01
2016-08-17 08:45:15 +02:00
Noel Grandin
b4e12269e8
loplugin:countusersofdefaultparams in editeng..fpicker
...
Change-Id: I6356c95296d81736fc6d66e510cd70606ee55f68
Reviewed-on: https://gerrit.libreoffice.org/27897
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-08-05 11:54:17 +00:00
Noel Grandin
6e72f0251b
new loplugin unnecessary override
...
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb
Reviewed-on: https://gerrit.libreoffice.org/27135
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2016-07-15 14:05:41 +00:00
Andrea Gelmini
a4d40892b7
Fix typos
...
Change-Id: I81671c9a8e7e5b878e605ac0ed6c3d8ef5c5b689
Reviewed-on: https://gerrit.libreoffice.org/27088
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: jan iversen <jani@documentfoundation.org >
2016-07-11 05:49:27 +00:00
Stephan Bergmann
e4651e2003
loplugin:passstuffbyref also for {css::uno,rtl}::Reference
...
Change-Id: I5bb3c63790cb153c0d6f57a681ec6dda71d482be
2016-07-07 18:59:55 +02:00
Noel Grandin
db12f068f8
loplugin:singlevalfields in editeng
...
Change-Id: I99c7ab28be7853535674cd7fab975da4252441f1
Reviewed-on: https://gerrit.libreoffice.org/26600
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-06-24 06:44:48 +00:00