Commit Graph
4814 Commits
Author SHA1 Message Date
Tor Lillqvist 1bf2ed44a1 Handle also []any in unoAnyToPropertyTree()
We add it as a subtree where each element in the sequence has as its
name its number.

Change-Id: I9422777d887d899f76ad6d259631d15c2db53f03
Reviewed-on: https://gerrit.libreoffice.org/51967
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-03-27 21:20:07 +02:00
Mert Tümer fc88892e99 .uno:Save callback for the Android Viewer
Change-Id: Ic2e16985e52869092faa2a31a59a85cb77b8e28c
Signed-off-by: Mert Tümer <merttumer7@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/51506
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-27 16:25:46 +02:00
Stephan Bergmann 045e275516 Fix typo ("x86_64" -> "X86_64")
...introduced with 2d2294fb82 "Add x64 Windows
here, too".  As reported by Richard Webb at
<https://lists.freedesktop.org/archives/libreoffice/2018-March/079870.html>
"Re: Manifest.xml for 64bit LO".

Change-Id: I1681908012e73e520bebd79b8149788358ea49a3
Reviewed-on: https://gerrit.libreoffice.org/51946
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-27 15:24:13 +02:00
Miklos Vajna 0518bb5c3a desktop lok: handle NoFileSync in saveAs()
Similar to TakeOwnership: detect this, remove it from FilterOptions and
turn it into its own sequence element. Online uses this for its
convert-to functionality.

The new cost for converting a small ODT file into PDF is 84% of the
original (when opting in for this flag).

Change-Id: Id2fcf5dd8b40eed04e0bc37f33519fd7691a9e5a
Reviewed-on: https://gerrit.libreoffice.org/51909
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2018-03-27 09:03:19 +02:00
Noel Grandin 862dc17e43 loplugin:expressionalwayszero improvements
Change-Id: I00bdbc58d2295a0be30b47c85eae6b9abfec17b2
Reviewed-on: https://gerrit.libreoffice.org/51868
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-27 08:22:09 +02:00
Caolán McNamara 4b785097f1 drop unnecessary includes
Change-Id: I1a817d5575bbd57ecaa874a27158b9218e4210cc
Reviewed-on: https://gerrit.libreoffice.org/51603
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20 13:08:20 +01:00
Jochen Nitschke b2147abdf6 remove unused ucbstreamhelper includes
and a few vclunohelper includes

Change-Id: I4803605766d155fe5044c2a65c0444631146831c
Reviewed-on: https://gerrit.libreoffice.org/51496
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-19 07:38:49 +01:00
Mert Tümer e5bc7fa4e8 tdf#96796 - Added clipboard actions for the Android Viewer
Change-Id: I52e134532ab70e765b6ccd929f189be84f9c9a90
Signed-off-by: Mert Tümer <merttumer7@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/51286
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-15 00:28:31 +01:00
Michael Meeks 005abf983d Allow lok to re-set temporary paths on second init.
Change-Id: I40cd0538b573c2d090f56424e1110b938981a878
Reviewed-on: https://gerrit.libreoffice.org/51292
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-03-14 19:51:34 +01:00
Thorsten Behrens b203e78a69 Revert "tdf#96796 - Added clipboard actions for the Android Viewer"
Breaks Android tinderbox

This reverts commit 31e939c9f4.

Change-Id: Id565c9ef8330c0b3bce2c678facb7605dcf3e356
2018-03-14 15:24:38 +01:00
Noel Grandin a1b58e93f6 loplugin:constantparam
Change-Id: I3ce653c0d9e517229dbbe32cc8d3ec3c206e364d
Reviewed-on: https://gerrit.libreoffice.org/51273
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-14 14:30:35 +01:00
Mert Tümer 31e939c9f4 tdf#96796 - Added clipboard actions for the Android Viewer
Change-Id: I2779ef9a9f68dcf08c3072ffe83b9f2450b7257e
Signed-off-by: Mert Tümer <merttumer7@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/50757
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-14 00:35:21 +01:00
Noel Grandin 2f5868c430 loplugin:redundantfcast look for redundant copies in return statements
Change-Id: I5f416c865dfe1c36018784246a8007452eb42008
Reviewed-on: https://gerrit.libreoffice.org/50996
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-12 07:37:24 +01:00
Noel Grandin b8fe96f1da loplugin:constantparam in desktop..i18npool
Change-Id: Ie2e1004c1ccc03777a8da9cb1144e89eb28ff313
Reviewed-on: https://gerrit.libreoffice.org/50928
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08 10:44:29 +01:00
Noel Grandin 7960ccb41d loplugin:constantparam in canvas..comphelper
Change-Id: Ia666cb46c409852a13789389c032f0ce4377c0d5
Reviewed-on: https://gerrit.libreoffice.org/50927
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08 10:34:50 +01:00
Noel Grandin b75632f308 use comphelper::containerToSequence
Change-Id: Ib1cd28c8cabf8899c43701cb638d1191c593dad0
Reviewed-on: https://gerrit.libreoffice.org/50872
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-07 11:58:59 +01:00
Julien Nabet 1b0beef879 Use for-range loops in desktop (part2)
+ use 1 time replace size() > 0 by !empty()

Change-Id: If62a17171fc09e0bead7c0a791758705f62920d1
Reviewed-on: https://gerrit.libreoffice.org/50847
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-07 07:20:18 +01:00
Julien Nabet cbc58ebf14 Use for-range loops in desktop (part1)
+ remove some useless typedef
+ some reindent

Change-Id: Ic1e445a7096b1663ca8cbc58c40bb8f7af0c70e1
Reviewed-on: https://gerrit.libreoffice.org/50787
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-05 23:58:20 +01:00
Noel Grandin 4516546b9e loplugin:useuniqueptr in TheExtensionManager
Change-Id: Ic45feadb64410b3f7833edd52af118436cd9763d
Reviewed-on: https://gerrit.libreoffice.org/50715
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05 07:30:01 +01:00
Stephan Bergmann f6a7527990 ...and some more asserts during CppunitTest_desktop_dialogs_test
Change-Id: I0a585ff4a0538c606153cb9d527838f5b50623a8
Reviewed-on: https://gerrit.libreoffice.org/50521
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-01 08:32:39 +01:00
Mike Kaganski 7dc93bbf8a Don't do unnecessary check for trailing slash
The check is done in utl::TempFile::SetTempNameBaseDirectory

Change-Id: I62b40a4f53f68da14aae6fcdfbf4c2dc7515a2c5
Reviewed-on: https://gerrit.libreoffice.org/50501
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-28 22:54:56 +01:00
Henry Castro e215310d6b lok: update main thread
In the pre-initialization phase of the tiled rendering case
the SvpSalInstance is created in a different process and when
a new process is created (fork), the main thread identifier
does not match so it is required to update it.

Change-Id: I189e53f0b46c60f34a8016222079c9b1e2b3fef8
Reviewed-on: https://gerrit.libreoffice.org/50477
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-02-28 22:47:52 +01:00
Stephan Bergmann e061f90a77 Clean up Desktop::CreateTemporaryDirectory
...avoiding the confusing, and apparently unnecessary back-and-forth between
system path and file URL.  (Superseding
<https://gerrit.libreoffice.org/#/c/50422/> "Don't overwrite system temppath
with old one that failed already".)

Change-Id: I247982a40d54565f5c98bda9a36209cba83c5c9f
Reviewed-on: https://gerrit.libreoffice.org/50494
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-28 15:08:06 +01:00
Caolán McNamara 6a0686e843 sneaky uppercase OK,CANCEL,HELP responses
Change-Id: I02324d31822c37daa1e5e1b8c87aa597def58957
Reviewed-on: https://gerrit.libreoffice.org/50437
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-28 09:40:38 +01:00
Pranav Kant f48c0d0999 lok sc: Post mouse events to main thread
Change-Id: I1311938d7c01d0e3bfd239743e6cb2148da56cdf
Reviewed-on: https://gerrit.libreoffice.org/50253
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-02-27 19:43:37 +05:30
Pranav Kant 0a1a3a6482 postExtTextInputEvent() -> postWindowExtTextInputEvent()
Let's avoid the confusion and name all these new APIs that can post both
to document and window to have 'Window' in their name. The ones without
window are the old APIs. In future, we can have
postWindow{Key,Mouse}Event() to post to both document and window and
deprecate the existing post{Key,Mouse}Event()s.

Change-Id: I1f55386e7790e9c5b5d023b8831f3cd1e6faa2bb
2018-02-27 19:43:25 +05:30
Jochen Nitschke 35fc452721 remove unused vclunohelper.hxx includes
Change-Id: I68178379e5493d0e738861a4dce5aa6e4b58cd22
Reviewed-on: https://gerrit.libreoffice.org/50393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27 15:00:06 +01:00
Noel Grandin c98d330302 replace Color(COL_*) with COL_*
using

    git grep -lwP "Color\s*\(\s*(COL_\w+)\s*\)"
    | xargs perl -pi -e "s/Color\s*\(\s*(COL_\w+)\s*\)//g"

and then some manual fixup where the resulting expression no longer
compiled

Change-Id: I0e268d78611c3be40bba9f60ecfdc087a36c0df4
Reviewed-on: https://gerrit.libreoffice.org/50372
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27 11:28:29 +01:00
Caolán McNamara 0fad8d3081 convert remaining WarningBox to weld::MessageDialog
Change-Id: I7e3c156a6ad47ac232636ae274280c1cb7556d4a
2018-02-27 09:52:32 +00:00
Noel Grandin 08ab1f46b1 loplugin:oncevar extend to tools/gen.hxx types
Change-Id: I5c75875da44334569c02e2ff039b33c38397a0a2
Reviewed-on: https://gerrit.libreoffice.org/50283
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26 07:21:04 +01:00
Noel Grandin ace95cf48e ColorData->Color in various
Change-Id: I22018b6a535224316d93bfd621771248b873a218
Reviewed-on: https://gerrit.libreoffice.org/50167
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26 07:20:25 +01:00
Thorsten Behrens ce43b10cca get headless build to work again for Linux
This makes --disable-gui option build successfully again - which
means we again run on a headless server w/o any X11 or OpenGL libs.

Change-Id: I60019af571aecdac277adbe6d34d5fff065014f9
Reviewed-on: https://gerrit.libreoffice.org/50214
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-23 08:41:11 +01:00
Caolán McNamara 6a4c464b49 weld native message dialogs
just the straight-forward MessageDialog cases first

a) remove border_width from message dialog .ui so as to take
the default border width
b) retain 12 as default message dialog border for vcl widget case
c) remove layour_style from message dialog button boxes so as to
take the default mode (a no-op for vcl widget case)
d) use gtk response ids (vcl builder will converts to vcl ones)

Change-Id: I7de281093a1b64f92f71ca11e7cbba42bb658154
Reviewed-on: https://gerrit.libreoffice.org/50143
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-22 22:07:38 +01:00
Andras Timar e73cba0cea lok: support of AutoCorrect -> While Typing menu in Writer
Change-Id: I7c07f3a6269cd4b92cc50f7aaf847faf04665029
Reviewed-on: https://gerrit.libreoffice.org/50068
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-02-21 08:44:08 +01:00
Stephan Bergmann ba8a70365e New loplugin:nestedunnamed
Change-Id: Ifb434589ef08428ce609bc7a40b015d4df13224c
Reviewed-on: https://gerrit.libreoffice.org/50048
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-21 08:09:46 +01:00
Markus Mohrhard 4f97bfb3c2 fix updater on windows
Change-Id: Ib6f2334a3f6f3f5c217a71e2967a69e354b0a473
Reviewed-on: https://gerrit.libreoffice.org/49956
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-19 00:44:39 +01:00
Noel Grandin 413c7b4265 Revert "loplugin:changetoolsgen in dbaccess..desktop" and reapply plugin
because I
(a) forgot to insert parentheses which changes the meaning of some expressions and
(b) I now use the AdjustFoo calls when changing unary operations, which reads much better

This reverts commit a9ca38bdf7.

Change-Id: I662ef2f1100a06a68decb2c71975fbc61aeaa47d
Reviewed-on: https://gerrit.libreoffice.org/49847
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-16 15:14:05 +01:00
Caolán McNamara 6a3f9de585 native dialog initial basis
Change-Id: I392be563e38257390f748c70bb71c67a66778ddd
Reviewed-on: https://gerrit.libreoffice.org/49677
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-16 00:35:34 +01:00
Miklos Vajna 4322b69dfc desktop: allow disabling recovery via config key
The documentation suggests this should disable recovery, so read the
config value at the same place where we disable recovery due to the
environment variable.

Change-Id: I342ae58201aa1d731a5913c2f0598ddff2a8d602
Reviewed-on: https://gerrit.libreoffice.org/49706
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-14 20:48:23 +01:00
Pranav Kant 712540224d lok IME: support dialogs as well
Change-Id: Ic78da45dadaa5a4e1ca78e20d04974108581121e
Reviewed-on: https://gerrit.libreoffice.org/49714
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-02-14 19:19:37 +01:00
Henry Castro 9763383ebb lok: check if an element exists in the container
Change-Id: I5987e90d92a2ebff654a993fb77e389bd036a8f8
Reviewed-on: https://gerrit.libreoffice.org/49693
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-02-14 12:41:39 +01:00
Noel Grandin a9ca38bdf7 loplugin:changetoolsgen in dbaccess..desktop
Change-Id: I713a320e46f93dedd11266ac12e52110d13f451a
Reviewed-on: https://gerrit.libreoffice.org/49655
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-14 07:27:38 +01:00
Stephan Bergmann 8da3121ac3 Increase resolveUnoURL timeout from 20 to 40 sec
(Used when a unopkg process talks to an soffice process, or a unopkg or soffice
process talks to a uno process.)  Jenkins lo_ubsan ASan+UBSan builds quite often
fail in CustomTarget_odk/build-examples with connections from an unopkg process
to a uno process (that has just been forked by the unopkg process) timing out.
Lets see if increasing the timeout will fix that.

Change-Id: Ifcd886f00670f86bb8975a206c89f565d409912e
2018-02-13 14:48:25 +01:00
Stephan Bergmann b75609faa1 In comments: fix typo and normalize on "sub-command"
Change-Id: I57f7d98edef10cb64b106b326869a594cc2f8d42
2018-02-13 09:07:08 +01:00
Michael Meeks 707f787cd9 lok: enable pre-loading with Vcl's builder
Cache vclbuilder's loaded modules globally & simplify logic.

Pre-populate that cache on preload for LOK vs. a somewhat
inelegant pre-canned list of dialog libraries.

Change-Id: I86d936862a41495fd37908f3ee7eb2e0c363d651
Reviewed-on: https://gerrit.libreoffice.org/49550
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-12 22:27:55 +01:00
Pranav Kant 7f9f58f3a3 sw lok: IME support + unit test
Change-Id: I557493db23dfa3529606050c86161628dbd722e7
Reviewed-on: https://gerrit.libreoffice.org/49354
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
2018-02-08 08:40:25 +01:00
Mike Kaganski be13e756d6 desktop: MSVC: pragma warning: make more specific, remove obsolete
Change-Id: I61ed9700c904b7499166d32e4ffda69811d64a8b
Reviewed-on: https://gerrit.libreoffice.org/48973
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-01 06:52:53 +01:00
Mike Kaganski 903627c069 Function already take const OUString&
Change-Id: I87af48158b4afaf81da8545f9bccf459f11031d6
Reviewed-on: https://gerrit.libreoffice.org/48823
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-29 14:43:58 +01:00
Andrea Gelmini c101df2171 Fix typos
Change-Id: Iedd82d035454c940d76a94c7e910c81827c1389c
Reviewed-on: https://gerrit.libreoffice.org/48828
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-29 13:26:15 +01:00
Jan Holesovsky 3a68b21c21 lok: Allow whitelisting languages that should be used by LibreOfficeKit.
LOK may get way too many languages if there are dictionaries for them
installed which blows the pre-init to >2G easily; let's allow limiting that.

Also make the preloading of languages work with the internal spell checking
dictionaries and thesauri.

Change-Id: I77119970030a7386a5cccbe4fdc89b15eab56ef1
Reviewed-on: https://gerrit.libreoffice.org/48720
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-01-27 11:04:32 +01:00