Commit Graph
12008 Commits
Author SHA1 Message Date
Noel Grandin f657ab7bbb loplugin:virtualdown in various
Change-Id: I4db71fda953ea1d20712ae8033f6fc09b3b2855d
Reviewed-on: https://gerrit.libreoffice.org/52068
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-30 12:55:56 +02:00
Tamas Bunth 606cf34740 dbahsql: Unit test for binary import
Also fix bugs shown by the unit test

Use boost date/time instead of std, because std::tm cannot handle dates
before 1970.

Change-Id: I7f5dbb3d828a591a4b51c7204dc3bd39fefc42ff
Reviewed-on: https://gerrit.libreoffice.org/51804
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-03-29 11:07:51 +02:00
Tamas Bunth 5dcd9be679 dbahsql: wrong variable
Change-Id: Ib0027bc8a84c2cfd5622e83c420434b3bb130c7c
Reviewed-on: https://gerrit.libreoffice.org/51974
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
Tested-by: Tamás Bunth <btomi96@gmail.com>
2018-03-28 00:55:04 +02:00
Tamas Bunth a11b728dae dbahsql: refactor move index parser to parseschema
Change-Id: I57820edc9ba8e9b8b11db78cf795fd5b1203db9b
Reviewed-on: https://gerrit.libreoffice.org/51733
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-03-22 13:49:00 +01:00
Tamas Bunth 9adc7bdf6d dbahsql: add unit tests for schema import
Change-Id: Ib666562f2d33824188ea3d643e6056f375a4339b
Reviewed-on: https://gerrit.libreoffice.org/51537
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-03-22 10:58:18 +01:00
Caolán McNamara a084d003a9 weld OSQLMessageBox
Change-Id: Idbdb07bc342a91695d15ea1a87d1863798ca34b0
Reviewed-on: https://gerrit.libreoffice.org/51676
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-22 00:27:49 +01:00
Caolán McNamara 12efe34abb support both vcl and weld in genericunodialog for interim
Change-Id: Ife85dd7a4bd27260514b390ca3928152db0d688f
Reviewed-on: https://gerrit.libreoffice.org/51699
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21 15:48:12 +01:00
Caolán McNamara f6d2aa0548 drop debugging test
Change-Id: I29f954684dd0e42f497bb4c166288217058171d9
Reviewed-on: https://gerrit.libreoffice.org/51680
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21 09:50:23 +01:00
Caolán McNamara dd4f1b1bd3 weld OExceptionChainDialog
Change-Id: I0092d2741055ab89ed4a97db9b8fad56144024c2
Reviewed-on: https://gerrit.libreoffice.org/51678
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21 00:23:00 +01:00
Caolán McNamara e3bd5ebf67 drop msgbox include
Change-Id: Ic7872adf8a7e8e4a8e1503dd21e22ec69509efaf
Reviewed-on: https://gerrit.libreoffice.org/51652
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20 18:11:20 +01:00
Jochen Nitschke b2147abdf6 remove unused ucbstreamhelper includes
and a few vclunohelper includes

Change-Id: I4803605766d155fe5044c2a65c0444631146831c
Reviewed-on: https://gerrit.libreoffice.org/51496
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-19 07:38:49 +01:00
Tomaž Vajngerl d775ef3601 change recursive ImageURL prop. search to use XGraphic
In two cases we need to traverse and gather all ImageURL properties
and get the URL string and store the graphic content to a storage
(like we do in xmloff filter). ImageURL property can now only store
external URL and Graphic stores the embedded XGraphic, so this was
changed to look into Graphic property first and then ImageURL.

We also don't gather URL sting anymore so they need to be loaded
to XGraphic when gathering them.

Change-Id: I5f3f4be2b403b9589d72b8733df0c97109f2b65d
Reviewed-on: https://gerrit.libreoffice.org/51308
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-15 04:11:02 +01:00
Noel Grandin 25f7be559d loplugin:useuniqueptr in DataSupplier_Impl
Change-Id: Ifa4b00bcefdab5d71f03121ae283bde6dbb147c8
Reviewed-on: https://gerrit.libreoffice.org/51197
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-13 13:24:25 +01:00
Noel Grandin e0d59468b1 loplugin:useuniqueptr in OSingleSelectQueryComposer
Change-Id: I02eb65c7a5a1dfd768e35b596303eb3e49c3dfd0
Reviewed-on: https://gerrit.libreoffice.org/51196
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-13 11:27:05 +01:00
Andrea Gelmini 17b59d49de Fix typo
Change-Id: If7667b9cda78b481de0048a459cef3de4642385a
Reviewed-on: https://gerrit.libreoffice.org/51084
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-03-12 13:57:06 +01:00
Tamas Bunth 6dad441bf5 dbahsql: use empty Any for "Other" column
Change-Id: Ie3e918956a25fba2831d3542e5f3d1b26c4fdc2a
Reviewed-on: https://gerrit.libreoffice.org/51117
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-03-12 13:45:07 +01:00
Noel Grandin a451edce98 another fix for Android
Change-Id: I21802c695e2ca4fbc7ff0dd08880dfa262ca9a33
2018-03-12 11:01:54 +02:00
Noel Grandin 886cf25268 blind fix for Android
Change-Id: I014e23da43292b458ca046ebdc7fd6a472c6dffb
2018-03-12 09:58:44 +02:00
Noel Grandin 2f5868c430 loplugin:redundantfcast look for redundant copies in return statements
Change-Id: I5f416c865dfe1c36018784246a8007452eb42008
Reviewed-on: https://gerrit.libreoffice.org/50996
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-12 07:37:24 +01:00
Tamas Bunth 813296d4a2 dbahsql: import DATE and DATETIME columns
Change-Id: Ibfd9340fad40efab891cba5b77ce3496424a3525
Reviewed-on: https://gerrit.libreoffice.org/51076
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-03-11 16:58:47 +01:00
Tomaž Vajngerl 7fbb96c2fb Move (and rename) graphic stuff from svtools to vcl
This is preparing to change how GraphicManager works where it
won't base itself around GraphicObject anymore but Graphic. No
functional or cosmetic change was made to the classes, only
changes that were needed because of the move and rename.

The only thing that wasn't moved is the GraphicRenderer as it
is not needed in vcl for now (but makes sense to move it in the
future to keep graphic stuff together).

grfmgr was renamed to GraphicObject as the GraphicManager will be
changed a lot and most likely moved out, so the name grfmgr won't
make any sense anymore.

All the UNO implementations were renamed with a prefix Uno and
used the same name as the class name. This is made to be more
specific which are the Uno objects (for example graphic.cxx
contained the implementation of XGraphic, which is similar to
graph.cxx contains Graphic).

Change-Id: I54a2fa6c7e997469aaa7770db05244adb9f64137
Reviewed-on: https://gerrit.libreoffice.org/51068
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-11 13:37:21 +01:00
Tamas Bunth f9831de353 dbahsql: import TIME columns
Change-Id: I8863127a4de1bfc06b13d008e037db2a4e60f1e7
Reviewed-on: https://gerrit.libreoffice.org/51059
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-03-11 11:34:16 +01:00
Tamas Bunth 6039d2463b dbahsql: Add numeric/decimal import
Change-Id: Icba170d586d35f890d5232463f89d547d526d885
Reviewed-on: https://gerrit.libreoffice.org/50937
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-03-10 21:15:05 +01:00
Tamas Bunth 5983cb047a dbahsql: add boolean
Change-Id: I1c18d40f6375d034e8de3c1bad6323b7cda052e6
Reviewed-on: https://gerrit.libreoffice.org/50975
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-03-10 20:01:28 +01:00
Julien Nabet ba98f6e3e4 Modernize a bit more dbaccess (part2)
mainly by using for-range loops but also by simplifying some simple algo

Change-Id: If5ce6d901761db2b872a99e6de0eb6d2f098df99
Reviewed-on: https://gerrit.libreoffice.org/51044
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-10 16:52:53 +01:00
Julien Nabet 5b2fc10f0c Modernize a bit more dbaccess
mainly by using for-range loops
but also by simplifying some simple algo

Change-Id: If04cd78e62f80f9575e24f3d50ff1e427454da79
Reviewed-on: https://gerrit.libreoffice.org/51019
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-10 09:44:56 +01:00
Caolán McNamara 48bca65f1c inherit welded dialogs from a common ancestor
Change-Id: Ifa6c871a134cf89bfba71b1049a115cf7c953c42
Reviewed-on: https://gerrit.libreoffice.org/50936
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-09 13:47:52 +01:00
Noel Grandin bb7ade140d loplugin:unusedmethods
Change-Id: Id6b4edd265cb6bef31c72e2a0a440211d51c7c33
Reviewed-on: https://gerrit.libreoffice.org/50900
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08 08:44:32 +01:00
Julien Nabet d6b33e49a5 Use for-range loops in dbaccess (part 3)
Change-Id: I4cec44ea6366b6a38992e583d6290223d5c469f6
Reviewed-on: https://gerrit.libreoffice.org/50849
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-08 00:15:34 +01:00
Tamas Bunth ed031c6cea dbahsql: add BINARY and VARBINARY import
Change-Id: Ibb4d5f8dda16dc7779b7a7b818a8bd2c49cbf283
Reviewed-on: https://gerrit.libreoffice.org/50844
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-03-07 11:31:41 +01:00
Noel Grandin 856c57f20f use more Color in cppcanvas..drawinglayer
Change-Id: Ib0f15e8d4c01c1d2059cf32cc882042766d2a682
Reviewed-on: https://gerrit.libreoffice.org/50861
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-07 09:00:34 +01:00
Stephan Bergmann ebb41767f3 Rename OCharsetMap::find overload to findIanaName
Change-Id: Id3fe81b41b92d6ad4e3f7127331d859a7b3c7f54
Reviewed-on: https://gerrit.libreoffice.org/50779
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-05 19:49:43 +01:00
Andrea Gelmini 65e98e66fe Removed duplicated include
Change-Id: I9baebc135d62fac29512ae5e8eb5e43d61ac227a
Reviewed-on: https://gerrit.libreoffice.org/50773
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>
2018-03-05 16:30:50 +01:00
Andrea Gelmini 85c1b7ed35 Fix typos
Change-Id: I70e7db0926f8c5815637ae14c1193130d52c3224
Reviewed-on: https://gerrit.libreoffice.org/50774
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>
2018-03-05 16:30:40 +01:00
Tamas Bunth 60ac741874 HSQLDB Binary import
C++ implementation of reading HSQL's binary file format. This file
contains the actual rows for the tables, represented in an AVL tree.

Import starts from HsqlImporter, which calls to SchemaParser for some
metadata (the positions of the trees in "data" file). After that it goes
through the tree and read up the rows using HsqlRowInputStream.

Finally, it uses sdbc's XPreparedStatement to insert the rows to the
actual database.

Change-Id: If4b17572e5989c218d45880bc3fd5a8820bb4101
Reviewed-on: https://gerrit.libreoffice.org/50536
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
Tested-by: Tamás Bunth <btomi96@gmail.com>
2018-03-05 10:18:13 +01:00
Noel Grandin 46b32a022e tdf#115998 base: crash on delete relationship
Change-Id: Ida8cc9ef0b812254990ac808f78ae183ae28a1c0
Reviewed-on: https://gerrit.libreoffice.org/50633
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05 08:38:09 +01:00
Noel Grandin 28799d303c loplugin:useuniqueptr in dbaccess(2)
Change-Id: I49e69d8ab5b7a9ce699a2e0e0cad7ce4c4d0b62f
Reviewed-on: https://gerrit.libreoffice.org/50714
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05 07:29:49 +01:00
Noel Grandin e1e1bd191a loplugin:useuniqueptr in dbaccess
Change-Id: I9b1892f3d453320302f5f82cb964aff5cd9fa643
Reviewed-on: https://gerrit.libreoffice.org/50713
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05 07:29:36 +01:00
Noel Grandin f77302d76a loplugin:useuniqueptr in OQueryDescriptor_Base
Change-Id: I9cea18df52bc0a35f94c2a42dfbe3edb61e1e8c0
Reviewed-on: https://gerrit.libreoffice.org/50699
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05 07:29:27 +01:00
Caolán McNamara d6f1c3dece weld SfxPasswordDialog Dialog
Change-Id: If8c9757986f4af7b7927717221860e65c8c7285e
Reviewed-on: https://gerrit.libreoffice.org/50755
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-05 00:32:13 +01:00
Noel Grandin d3510bef84 make Color::GetRGBColor return Color instead of ColorData
Change-Id: I532959a7103c3857510f26ecce2f942d676a233b
Reviewed-on: https://gerrit.libreoffice.org/50487
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-01 08:24:24 +01:00
Jochen Nitschke 35fc452721 remove unused vclunohelper.hxx includes
Change-Id: I68178379e5493d0e738861a4dce5aa6e4b58cd22
Reviewed-on: https://gerrit.libreoffice.org/50393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27 15:00:06 +01:00
Caolán McNamara cc92324bed split out GetStandardWarningBoxImage
Change-Id: I2c8315c7223adac2d7e0e2aa403db0f865bdc48e
Reviewed-on: https://gerrit.libreoffice.org/50377
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-26 22:15:19 +01:00
Caolán McNamara 942f05996b convert remaining ErrorBox to weld::MessageDialog
and

convert remaining QueryBox to weld::MessageDialog

Change-Id: Ifb4c316dee8eabf57c4940c44e29c65a2781aa6c
2018-02-26 15:27:09 +00:00
Caolán McNamara d75144cf44 convert remaining InfoBox to weld::MessageDialog
Change-Id: I91d828e38d96264cf4a76f30940942556b8f78d8
Reviewed-on: https://gerrit.libreoffice.org/50205
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-25 20:03:26 +01:00
Caolán McNamara 6a4c464b49 weld native message dialogs
just the straight-forward MessageDialog cases first

a) remove border_width from message dialog .ui so as to take
the default border width
b) retain 12 as default message dialog border for vcl widget case
c) remove layour_style from message dialog button boxes so as to
take the default mode (a no-op for vcl widget case)
d) use gtk response ids (vcl builder will converts to vcl ones)

Change-Id: I7de281093a1b64f92f71ca11e7cbba42bb658154
Reviewed-on: https://gerrit.libreoffice.org/50143
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-22 22:07:38 +01:00
Noel Grandin 331b4603be loplugin:redundantcopy extend to Color
Change-Id: I224cc955d49ee100d328e0171da710f38068d2d4
Reviewed-on: https://gerrit.libreoffice.org/50114
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-22 07:23:57 +01:00
Stephan Bergmann ba8a70365e New loplugin:nestedunnamed
Change-Id: Ifb434589ef08428ce609bc7a40b015d4df13224c
Reviewed-on: https://gerrit.libreoffice.org/50048
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-21 08:09:46 +01:00
Noel Grandin 413c7b4265 Revert "loplugin:changetoolsgen in dbaccess..desktop" and reapply plugin
because I
(a) forgot to insert parentheses which changes the meaning of some expressions and
(b) I now use the AdjustFoo calls when changing unary operations, which reads much better

This reverts commit a9ca38bdf7.

Change-Id: I662ef2f1100a06a68decb2c71975fbc61aeaa47d
Reviewed-on: https://gerrit.libreoffice.org/49847
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-16 15:14:05 +01:00
Noel Grandin a9ca38bdf7 loplugin:changetoolsgen in dbaccess..desktop
Change-Id: I713a320e46f93dedd11266ac12e52110d13f451a
Reviewed-on: https://gerrit.libreoffice.org/49655
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-14 07:27:38 +01:00