ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
421,396 Commits 3 Branches 3 Tags
940f90f3da170b62379e9d1d33d4e6d690997026
Commit Graph
643 Commits
Author SHA1 Message Date
Caolán McNamara bec100c074 coverity#1430229 Unchecked return value 
Change-Id: I100125d723a83ec7846cf9651ecebd3df697ce58
Reviewed-on: https://gerrit.libreoffice.org/51695
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-21 12:52:24 +01:00
Caolán McNamara 5163c4850d weld SvxIconChangeDialog warning dialog 
Change-Id: If90c8dc0e66678cec6b197e3f0c659e85484f5af
Reviewed-on: https://gerrit.libreoffice.org/51650
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-20 17:47:42 +01:00
Muhammet Kara 8567047218 tdf#116494: Don't ask parent if no help text 
And add/use an IsHelpInstalled() method to SfxHelp.

Change-Id: Ib87573067d6c44fa5adb22253c1a51a78580acf6
Reviewed-on: https://gerrit.libreoffice.org/51584
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
 2018-03-20 12:41:15 +01:00
Muhammet Kara 86b160886f tdf#115511: Make the description field keyboard-accessible 
in the Customize dialog. By setting an accelerator key, and
also manually setting the WB_TABSTOP bit to include it in the
tab navigation.

Change-Id: I02ce9e2e78404401c9fc124df07f4f0c0b1e110e
Reviewed-on: https://gerrit.libreoffice.org/51426
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
 2018-03-18 19:52:01 +01:00
Noel Grandin 3a0ae2aae3 fix crash on close customize dialog 
after
    commit 00431a8afc
    Date:   Tue Mar 13 11:57:33 2018 +0200
    loplugin:useuniqueptr in SvxEntries

Change-Id: Ia115454522b87db93cefcbd89ca5d965f9b431c7
 2018-03-14 16:55:51 +02:00
Noel Grandin d704ce2504 fix build in SvxMenuConfigPage 
mid-air patch collision

Change-Id: I183362aee3192893836eeb8138671a7fbe2da604
 2018-03-13 14:30:24 +02:00
Noel Grandin 00431a8afc loplugin:useuniqueptr in SvxEntries 
Change-Id: I4e105326ddba11822beb9affe97196c77a5baf4b
Reviewed-on: https://gerrit.libreoffice.org/51203
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-13 12:40:42 +01:00
Muhammet Kara 51617878dd tdf#114260: Allow moving top-level menus 
in the Customize dialog.

Change-Id: I0dafe59e017e05977d00cf564cfef21190a0a7a1
Reviewed-on: https://gerrit.libreoffice.org/51163
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-03-13 08:01:57 +01:00
Muhammet Kara a21744a726 tdf#114260: Add gear button to Customize dialog 
* Allow renaming custom toolbars, custom menus, and standard sub-menus.
  * Move plus and minus buttons into the gear button

Change-Id: Id856da2498412b52e44b5623c4a5b9a3ed439fe3
Reviewed-on: https://gerrit.libreoffice.org/50553
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
Tested-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-03-12 12:13:27 +01:00
Caolán McNamara c7a071b064 weld SvxNameDialog 
Change-Id: Iac7bdf9c998e611b56473a685aee276a56adf996
Reviewed-on: https://gerrit.libreoffice.org/50702
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-04 18:08:37 +01:00
Julien Nabet 81260c4489 Use for-range loops in cui 
Change-Id: I82cbea6d221ec0fd0e0d4620bdda698f2bed520e
Reviewed-on: https://gerrit.libreoffice.org/50472
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-02-28 11:02:12 +01:00
Johnny_M b6aee26f36 Translate German comments and debug strings 
Change-Id: Ie2da785cb674e21f042caa5e6d461e3489036003
Reviewed-on: https://gerrit.libreoffice.org/50467
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2018-02-28 10:51:36 +01:00
Jochen Nitschke 35fc452721 remove unused vclunohelper.hxx includes 
Change-Id: I68178379e5493d0e738861a4dce5aa6e4b58cd22
Reviewed-on: https://gerrit.libreoffice.org/50393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-27 15:00:06 +01:00
Jim Raykowski 1f74789f77 tdf#116043 fix customize dialog icons going away 
Change-Id: Id4022092765c085efcd71627a1dd8290f7441e74
Reviewed-on: https://gerrit.libreoffice.org/50407
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
 2018-02-27 13:12:25 +01:00
Noel Grandin c98d330302 replace Color(COL_*) with COL_* 
using

    git grep -lwP "Color\s*\(\s*(COL_\w+)\s*\)"
    | xargs perl -pi -e "s/Color\s*\(\s*(COL_\w+)\s*\)//g"

and then some manual fixup where the resulting expression no longer
compiled

Change-Id: I0e268d78611c3be40bba9f60ecfdc087a36c0df4
Reviewed-on: https://gerrit.libreoffice.org/50372
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-27 11:28:29 +01:00
Caolán McNamara 082e69fefb convert various MessBox to weld::MessageDialog 
Change-Id: I4d2d0393c753114aeb9bb7e646dfdc810f6caa38
Reviewed-on: https://gerrit.libreoffice.org/50398
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-02-27 11:22:49 +01:00
Caolán McNamara 0fad8d3081 convert remaining WarningBox to weld::MessageDialog 
Change-Id: I7e3c156a6ad47ac232636ae274280c1cb7556d4a
 2018-02-27 09:52:32 +00:00
Caolán McNamara cc92324bed split out GetStandardWarningBoxImage 
Change-Id: I2c8315c7223adac2d7e0e2aa403db0f865bdc48e
Reviewed-on: https://gerrit.libreoffice.org/50377
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-02-26 22:15:19 +01:00
Caolán McNamara 942f05996b convert remaining ErrorBox to weld::MessageDialog 
and

convert remaining QueryBox to weld::MessageDialog

Change-Id: Ifb4c316dee8eabf57c4940c44e29c65a2781aa6c
 2018-02-26 15:27:09 +00:00
Caolán McNamara d75144cf44 convert remaining InfoBox to weld::MessageDialog 
Change-Id: I91d828e38d96264cf4a76f30940942556b8f78d8
Reviewed-on: https://gerrit.libreoffice.org/50205
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-02-25 20:03:26 +01:00
Caolán McNamara 6a4c464b49 weld native message dialogs 
just the straight-forward MessageDialog cases first

a) remove border_width from message dialog .ui so as to take
the default border width
b) retain 12 as default message dialog border for vcl widget case
c) remove layour_style from message dialog button boxes so as to
take the default mode (a no-op for vcl widget case)
d) use gtk response ids (vcl builder will converts to vcl ones)

Change-Id: I7de281093a1b64f92f71ca11e7cbba42bb658154
Reviewed-on: https://gerrit.libreoffice.org/50143
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-02-22 22:07:38 +01:00
Noel Grandin eb5563e7e6 Revert "loplugin:changetoolsgen in canvas..cui" and reapply 
because I
(a) forgot to insert parentheses which changes the meaning of some expressions and
(b) I now use the AdjustFoo calls when changing unary operations, which reads much better

This reverts commit f841dada1a.

Change-Id: Iff19e1fc99812c086b0a39b71a3f67b98e2f9c8f
Reviewed-on: https://gerrit.libreoffice.org/49841
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-16 19:50:35 +01:00
Noel Grandin f841dada1a loplugin:changetoolsgen in canvas..cui 
Change-Id: I4e320055a3dbe4159c2aa2714e1ee98182e1e80a
Reviewed-on: https://gerrit.libreoffice.org/49642
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-14 12:50:37 +01:00
Jim Raykowski d6630ddc99 tdf#112239: Add icons to customize dialog function tree 
Change-Id: I68e908664d24c52657b3a073aae1c8cc41c3ce3e
Reviewed-on: https://gerrit.libreoffice.org/48556
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
 2018-02-06 00:19:57 +01:00
Gabor Kelemen 4fae455fcd tdf#42949 Remove unneeded helpids.h headers (1/3) 
A side effect of the .ui migration is that we use a lot less HIDs
in the code. A lot of files still contain helpids.h includes
even if no actual HID is referenced.

This cleans up directories b* - e*.
Found with:
git grep helpids.h | cut -d : -f 1 | xargs grep -c HID_  | grep :0$

Change-Id: I221d22f68584115d71660a97c4f108595625d12c
Reviewed-on: https://gerrit.libreoffice.org/46868
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2018-02-01 15:19:36 +01:00
Jim Raykowski 1c1c50e12c tdf#115129 Add function on double click in Customize Dialog 
Change-Id: I21a7f8b4fc05d55d1539a3fd148e5870899b1596
Reviewed-on: https://gerrit.libreoffice.org/48555
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-01-25 14:50:23 +01:00
Jim Raykowski bf5739d70d tdf#115129 change customize function tree expand collapse behavior 
Change-Id: I6c20957fe3f95a8e63b30e5c733b99f71c193972
Reviewed-on: https://gerrit.libreoffice.org/48290
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
 2018-01-24 16:02:20 +01:00
Stephan Bergmann f6e256c482 More loplugin:cstylecast: cui 
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: I04b0e0c0268cbcc1c7e7ff2174c5125785e09a07
 2018-01-12 20:26:08 +01:00
Noel Grandin f14b9d3029 convert (a>b?a:b) to std::max(a,b) 
with something like:
   git grep -nP '(.*)\s*>\s*(.*)\s*\?\s*\g1\s*:\s*\g2'

Change-Id: I60b9a3a2a09162bc0de4c13fdde2c209696e5413
Reviewed-on: https://gerrit.libreoffice.org/47602
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-11 07:35:43 +01:00
Maxim Monastirsky 1d55c1baed tdf#106784 Also handle automatic icon size 
... like before b1426b5b50
("tdf#95014 initial support for 32 px icons in toolbar").
The original code used SvtMiscOptions::AreCurrentSymbolsLarge()
which calls GetCurrentSymbolsSize() internally, thus properly
resolves the icon size, when the current setting is "automatic".

Change-Id: Iabcbbcff666eecc2e7534eb1533610f08ac28bf1
Reviewed-on: https://gerrit.libreoffice.org/46899
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
 2017-12-21 13:43:25 +01:00
Caolán McNamara fde38e3af0 sal_uLong->sal_Int32 for SfxAcceleratorConfigPage 
Change-Id: I2ec647b140c6be6c5cb6727873cca4cad16a664e
Reviewed-on: https://gerrit.libreoffice.org/46701
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-12-19 17:01:01 +01:00
Noel Grandin a5be07d6b6 inline use-once typedefs 
Change-Id: I5c3ffc03c26b3428f1f336e6ecba7838a1cf1157
Reviewed-on: https://gerrit.libreoffice.org/46764
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-19 11:57:57 +01:00
Maxim Monastirsky c8977c4465 tdf#98058 Respect menu:style="text" setting 
It was implemented on the xml handling side, but ignored
by the menubar code. In addition, make the menu:style
attribute survive customization (similar to tdf#114261).

Change-Id: I92a3517ee7ba2fe7a0782985d89fb5d0fdbac246
Reviewed-on: https://gerrit.libreoffice.org/46627
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
 2017-12-17 07:35:15 +01:00
Maxim Monastirsky 202f46bfde tdf#114261 Retain toolbar:style after customization 
Change-Id: I50170a2433f5e20809dd5bca8cb764039e8e0d84
Reviewed-on: https://gerrit.libreoffice.org/46169
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
 2017-12-10 00:35:48 +01:00
Noel Grandin 9036bf1832 loplugin:salcall vcl builder methods 
these don't need to be SAL_CALL, and the function pointer definition was
not annotated SAL_CALL either

Change-Id: I3082d3d34c53dc723ad8d2083010fd0de0e89a1e
Reviewed-on: https://gerrit.libreoffice.org/46067
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-08 09:46:56 +01:00
Noel Grandin 31b89aaeac loplugin:countusersofdefaultparams in cui 
Change-Id: Id3258a664c2ea740419331877f7ce6af5e2559e7
Reviewed-on: https://gerrit.libreoffice.org/45922
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-06 10:34:15 +01:00
Muhammet Kara cdb9e338f1 tdf#114091: Customize dialog: Rename 'All categories' to 'All commands' 
And put a separator before the 'Macros' category.

Change-Id: Ibcff6b6c6d3a4f72d5e06b519fe8245d9602ad3c
Reviewed-on: https://gerrit.libreoffice.org/45843
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
 2017-12-05 12:58:24 +01:00
Muhammet Kara 3f2915c40f tdf#112207: Allow assigning macros to ui elements 
* Adds "Macros" category to the categories list

* Search/filter feature now works also on the macros category

* Since macros category has multiple trees and subtrees, and many leaf
  elements (macros). I chose to implement the behavior like this:

  If there is no filter/search term, the trees will be presented as in the old
  macro selector dialog (collapsed), but if user types a search term, then
  filtering happens: non-matching elements and empty containers/(sub)trees
  are removed and everything is expanded so that user easily sees what
  (s)he is looking for.

Change-Id: I1a93f156a7293c7e61baac882a10ff631961e2af
Reviewed-on: https://gerrit.libreoffice.org/44938
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
 2017-12-04 09:28:01 +01:00
Noel Grandin f6b437c57d loplugin:singlevalfields 
Change-Id: I521d2efa641f3a14c48561e2e0f6d687e5807d93
Reviewed-on: https://gerrit.libreoffice.org/45662
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-04 07:25:00 +01:00
Noel Grandin a566fd1c1a loplugin:unusedmethods 
Change-Id: I2efb5c0e5735c179314c6c5de87821cee3b033e1
Reviewed-on: https://gerrit.libreoffice.org/45386
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-29 07:28:57 +01:00
Noel Grandin 2e5508a176 loplugin:unnecessaryparen check for (f1()).f2 
Change-Id: I93257b0ddd41c649875124d6d5c5faeaa431bae3
Reviewed-on: https://gerrit.libreoffice.org/45218
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-27 10:44:25 +01:00
Muhammet Kara 3b4d2cfaaf tdf#112207: Allow assigning styles to ui elements 
Change-Id: I777059e2c5139dcf1b24504023fb417b9b56b3d8
Reviewed-on: https://gerrit.libreoffice.org/42594
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
 2017-11-22 12:01:19 +01:00
Noel Grandin 32823280ef loplugin:unusedmethods 
Change-Id: I543b0943f0bc918d59debc8ee051f88c29d18454
Reviewed-on: https://gerrit.libreoffice.org/44553
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-10 12:56:14 +01:00
Michael Stahl 11d2f3d6e1 vcl: make MapMode constructor explicit 
Insert constructor everywhere, except a couple places that apparently
want to compare GetMapUnit().

Change-Id: I1910deb60562e5e949203435e827057f70a3f988
 2017-10-26 23:17:45 +02:00
Stephan Bergmann 7182283c13 loplugin:includeform: cui 
Change-Id: Ibd88b2ee4252733c5aeee97bec27f34b8e555364
 2017-10-23 22:46:10 +02:00
Noel Grandin 87a9979c89 overload std::hash for OUString and OString 
no need to explicitly specify it anymore

Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec
Reviewed-on: https://gerrit.libreoffice.org/43567
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-23 08:15:35 +02:00
Muhammet Kara d4daf634cd tdf#112136: Resolve confusion of two 'Reset' buttons 
in the Customize dialog.

Change-Id: I0703fccb45a3bac17890e481d6635872df7becd2
Reviewed-on: https://gerrit.libreoffice.org/43406
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
 2017-10-15 23:26:18 +02:00
Noel Grandin 2c05d758b2 add << operator for css::uno::Exception 
Change-Id: Ia23dafd07133779144965682df3b7125a3214235
Reviewed-on: https://gerrit.libreoffice.org/43046
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-10-04 15:18:00 +02:00
Noel Grandin 7ef3416321 loplugin:unusedmethods 
Change-Id: I5d75baa2af046f377b49e967783fb06cd9e885ef
Reviewed-on: https://gerrit.libreoffice.org/42841
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-27 10:43:35 +02:00
Samuel Mehrbrodt b9a8ac48d7 Rename GetSelectEntryData -> GetSelectedEntryData 
Change-Id: Ia6402f6d2c978cbd5557052a43e9728ca9e11173
Reviewed-on: https://gerrit.libreoffice.org/42285
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2017-09-25 10:54:53 +02:00