ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
421,396 Commits 3 Branches 3 Tags
940f90f3da170b62379e9d1d33d4e6d690997026
Commit Graph
888 Commits
Author SHA1 Message Date
Noel Grandin 08ab1f46b1 loplugin:oncevar extend to tools/gen.hxx types 
Change-Id: I5c75875da44334569c02e2ff039b33c38397a0a2
Reviewed-on: https://gerrit.libreoffice.org/50283
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-26 07:21:04 +01:00
Michael Meeks 720759ad34 Pre-load key UNO mappings. 
Change-Id: I415e07d737c734d63ac969783464babcbb9ea884
Reviewed-on: https://gerrit.libreoffice.org/48365
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
 2018-02-11 00:09:33 +01:00
Michael Meeks f215096c24 lok: allow libraries to pre-init themselves. 
Populate static module references before entering a jail
containing no code.

Implement for scfilt, scui, swui, sdui.

Change-Id: I8fec2aa78e67053a7945926c818122bd4290103c
Reviewed-on: https://gerrit.libreoffice.org/49545
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
 2018-02-11 00:05:57 +01:00
Mike Kaganski b23e4d2bac cppuhelper: MSVC: pragma warning: make more specific, remove obsolete 
Change-Id: Ib097ea1764d275a3123d0dccf05d52315b4858a1
Reviewed-on: https://gerrit.libreoffice.org/48971
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2018-02-01 06:52:50 +01:00
Stephan Bergmann 697f01e052 SAL_W32 is just an alias for _WIN32 
...so consistently use the latter instead of the former

Change-Id: I144d5e7c472632f93b2258461510346bc85892d9
Reviewed-on: https://gerrit.libreoffice.org/48135
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-01-19 08:19:38 +01:00
Andrea Gelmini 970b76816a Fix typos 
Change-Id: Id1c7ddf6c49ec709e38947a82731fe31a64aad04
Reviewed-on: https://gerrit.libreoffice.org/48076
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2018-01-17 21:03:44 +01:00
Stephan Bergmann 2fa1c894ec More loplugin:cstylecast: cppuhelper 
Change-Id: I193884eea6289653d648489edd1a8e929524a3c5
 2018-01-15 09:06:32 +01:00
Stephan Bergmann 71a6caf49b More loplugin:cstylecast: cppuhelper 
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: I3966d302241a52014aaad41f72924a2095ea6621
 2018-01-12 20:26:29 +01:00
Stephan Bergmann 7f063b77da Revert "Print the important failure messages on iOS even in a non-debug build" 
This reverts commit ab07f81d0b.

> Jan 12 10:21:35 <sberg> tml_, is ab07f81d0b
>  still relevant? (one could imagine that if one wants such debug output during
> development in a non-debug build, one could build with --enable-sal-log?)
> Jan 12 10:22:01 <tml_> I have no idea what's relevant on iOS any longer
> Jan 12 10:22:26 <tml_> ... but my gut feeling would be no, can be removed
> Jan 12 10:23:14 <tml_> the rationale in the commit message sounds a bit thin
> Jan 12 10:24:02 <tml_> surely one should test an ap well enough before
>  submitting, to verify that it isn't possible to get it to try to invoke a
>  constructor that isn't included

Change-Id: I20ce8aa40a00205c1cae9d6ed4a87a6093745dc4
Reviewed-on: https://gerrit.libreoffice.org/47791
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-01-12 16:52:36 +01:00
Tor Lillqvist 2ac1298b5f Log just one line in cppuhelper::ServiceManager::preloadImplementations() 
That *is* what we want, I guess, so better I do it proactively before
I am told to do it. Sorry for the back and forth, but my main point in
touching this code was anyway the filtering out of the component (the
KDE4Backend thing) that causes a crash for me, at least, and which it
presumably is fairly pointless to preload anyway.

Also, filter out libraries that for some reason have an empty name.

Change-Id: I2cffd51e67c23977e0779e7f0d6faaf59d8819d9
 2018-01-11 19:01:34 +02:00
Tor Lillqvist 29e7b95e9c Do use just std::cerr in cppuhelper::ServiceManager::preloadImplementations() 
As the 1aedb6c434 commit message said,
the point is that we want this output even with a LO built for
production where SAL_INFO() and SAL_WARN() are no-ops.

Change-Id: I5f788c3914286ca8df2c7e290150adae0be42820
 2018-01-10 20:07:12 +02:00
Tor Lillqvist 4a114d6295 Bin superfluous using declarations 
Change-Id: Icf8a2703b7e72f48bde1cc3bc6fd0de2e663a407
 2018-01-10 19:50:45 +02:00
Tor Lillqvist 35ec045f6e Don't try to preload the KDE4 shell backend as that crashes 
Change-Id: I1c1ff4ec7cda00a76bdeb018366afed2187c7ef8
 2018-01-10 19:50:45 +02:00
Tor Lillqvist f9f830ac31 Simplify logging in cppuhelper::ServiceManager::preloadImplementations() 
Use just SAL_INFO(), with tag "cppuhelper.preload". No unconditional
writes to std::cerr. Also, log the loading attempt beforehand, so that
it is printed before any crash during the loading of a component.

Change-Id: Ifde8be8cb5d18dd88df21c45c906deb575d36960
 2018-01-10 19:50:45 +02:00
Noel Grandin 2a1fb4401d loplugin:passstuffbyref improved returns 
improve the detection of stuff we can return by const &, instead of by
copying

Change-Id: I479ae89d0413125a8295cc3cddbc0017ed61ed69
Reviewed-on: https://gerrit.libreoffice.org/46915
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-23 08:04:54 +01:00
Noel Grandin 3af500580b loplugin:salcall fix functions 
since cdecl is the default calling convention on Windows for
such functions, the annotation is redundant.

Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d
Reviewed-on: https://gerrit.libreoffice.org/46164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-11 12:13:46 +01:00
Noel Grandin f7a57f3a1b loplugin:countusersofdefaultparams in comphelper 
Change-Id: Idb704adbe78a42bf2f2aaf7f6110698d5559e836
Reviewed-on: https://gerrit.libreoffice.org/45936
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-07 07:19:46 +01:00
Noel Grandin 9a06b99d2f loplugin:salcall fix non-virtual methods 
first, since those are safer to change than virtual methods

Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe
Reviewed-on: https://gerrit.libreoffice.org/45798
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-05 07:32:46 +01:00
Caolán McNamara 34a7e1b871 not used with disable-dynloading 
Change-Id: Idad8a7b9b984147b7a64caf7527d8ad21bdd55a2
Reviewed-on: https://gerrit.libreoffice.org/45433
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-28 21:28:41 +01:00
jan Iversen 6eeac3539e iOS, simplifyModule in cppuhelper is unused 
function simplifyModule is reported unused == error on iOS,
therefore guarded with an #ifndef IOS

Change-Id: I751cf68bd46ed17032251fede030f9082ce4e4f5
 2017-11-25 17:04:00 +01:00
Michael Meeks 1aedb6c434 LOK: provide user feedback while preloading. 
Problems are hard enough to debug in a jailed kit process inside
a docker image; provide some visual feedback via stderr.

Change-Id: I54b0a21c1375be2acc9da0bbacf959a419471b08
Reviewed-on: https://gerrit.libreoffice.org/45256
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
 2017-11-25 11:10:14 +01:00
Stephan Bergmann 11cf64b730 Better fix for CppunitTest_services 
...than 25313923b0 "Fix CppunitTest_services for
constructor-based implementations..." (which this commit reverts again).  My
claim that "the 'factory' would be the object itself" is nonsense, it would
rather be an ImplementationWrapper (but one that was freshly created for each
ServiceManager::createContentEnumeration).

Change-Id: I85c683cff6f9ba78d0f8567a53f8fcbc56fe55cf
 2017-10-27 10:37:26 +02:00
Noel Grandin 2559a2a056 loplugin:constmethod in cppu,cppuhelper,idlc 
Change-Id: I9138b7e5d53c30488f99e9f9b9fe3f98c8d6858b
Reviewed-on: https://gerrit.libreoffice.org/43583
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-23 08:15:50 +02:00
Noel Grandin 87a9979c89 overload std::hash for OUString and OString 
no need to explicitly specify it anymore

Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec
Reviewed-on: https://gerrit.libreoffice.org/43567
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-23 08:15:35 +02:00
Mike Kaganski 1944e3ddc0 Rename and move SAL_U/W to o3tl::toU/W 
Previosly (since commit 9ac98e6e34)
it was expected to gradually remove SAL_U/W usage in Windows code
by replacing with reinterpret_cast or changing to some bettertypes.
But as it's useful to make use of fact that LibreOffice and Windows
use compatible representation of strings, this commit puts these
functions to a better-suited o3tl, and recommends that the functions
be consistently used throughout Windows-specific code to reflect the
compatibility and keep the casts safe.

Change-Id: I2f7c65606d0e2d0c01a00f08812bb4ab7659c5f6
Reviewed-on: https://gerrit.libreoffice.org/43150
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2017-10-05 16:02:52 +02:00
Noel Grandin 2c05d758b2 add << operator for css::uno::Exception 
Change-Id: Ia23dafd07133779144965682df3b7125a3214235
Reviewed-on: https://gerrit.libreoffice.org/43046
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-10-04 15:18:00 +02:00
Mike Kaganski d32506e9f4 cppuhelper_detail_findSofficePath: use Unicode on Windows 
On Windows, UTF-8 is never current locale encoding; so using 8-bit
strings will always fail for paths containing characters outside
of current codepage.
Also fix leaks caused by failing to release its result: previously
it could return either result of getenv (that shouldn't get freed),
or an allocated string, but never got freed; now the result is
always allocated and properly freed.

Change-Id: I8b255dea20040eec0572de2b34280749fe8f071c
Reviewed-on: https://gerrit.libreoffice.org/42743
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2017-09-27 06:24:24 +02:00
Noel Grandin 2a612907ae loplugin:flatten in connectivity..desktop 
Change-Id: Iff59d3049ba40b4338ef8eec67d08a96b0834d2b
Reviewed-on: https://gerrit.libreoffice.org/42578
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-21 15:41:50 +02:00
Noel Grandin 7aa7f4d9e4 loplugin:unnecessaryparen include c++ casts 
Change-Id: I132d3c66f0562e2c37a02eaf4c168d06c2b473eb
Reviewed-on: https://gerrit.libreoffice.org/41874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-04 10:52:41 +02:00
Michael Stahl eda41a271e cppuhelper: fix double checked locking in getTypeEntries() 
Change-Id: I73674f0293a57ed7c4d54aa6b68ff64d5ca4e7bd
 2017-08-21 23:31:26 +02:00
Noel Grandin 9881bea8d4 remove unnecessary use of OUString::getStr 
Change-Id: I3d13e1c0bb6aa4a7aacc463198747c1368ebc9b4
Reviewed-on: https://gerrit.libreoffice.org/38114
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-17 11:55:13 +02:00
Noel Grandin db17a874af convert std::map::insert to std::map::emplace II 
Change-Id: Ief8bd59c903625ba65b75114b7b52c3b7ecbd331
Reviewed-on: https://gerrit.libreoffice.org/41019
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-11 13:51:29 +02:00
Noel Grandin ec340697d6 loplugin:constparams in soltools and various 
Change-Id: I5e8e4a9a31aa7c3ff54cc7ce137d08770ea297e1
Reviewed-on: https://gerrit.libreoffice.org/40279
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-21 17:11:15 +02:00
Noel Grandin 20571c4725 use more range-for on uno::Sequence 
Change-Id: Ifad32425d79be5a22d33d721bdc5fb993f699759
Reviewed-on: https://gerrit.libreoffice.org/39763
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-11 12:50:55 +02:00
Noel Grandin 4b2262ab5b new loplugin unnecessaryparen 
Change-Id: Ic883a07b30069ca6342d7521c8ad890f4326f0ec
Reviewed-on: https://gerrit.libreoffice.org/39549
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-05 11:08:48 +02:00
Stephan Bergmann d30f4e3647 loplugin:casttovoid: cppuhelper 
Change-Id: I70a8f00b5ec9d100185d2865bcf54ce96c93adc3
 2017-07-02 22:33:17 +02:00
brainbreaker a6a447b08d android:Supress the Clang's unneeded-internal-declaration warning 
Change-Id: I76359e98a41206f914c3c05149f0a7eeeff1acc8
Reviewed-on: https://gerrit.libreoffice.org/39007
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2017-06-20 17:04:34 +02:00
Jochen Nitschke a5dba7dbec remove unused osl/mutex.hxx includes 
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb
Reviewed-on: https://gerrit.libreoffice.org/38905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2017-06-18 13:38:25 +02:00
Noel Grandin ec8c98f598 use more SAL_N_ELEMENTS part 3 
Change-Id: I82e366fefd2e31928b99840fe76649cc3521e623
Reviewed-on: https://gerrit.libreoffice.org/38789
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-15 08:24:33 +02:00
Caolán McNamara d0069e5189 add COVERITY_NOEXCEPT_FALSE 
to markup dtors that coverity warns might throw exceptions
which won't throw in practice, or where std::terminate is
an acceptable response if they do

Change-Id: I32b94814e8245372e1d1dc36be0d81e3564042f4
Reviewed-on: https://gerrit.libreoffice.org/38318
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-06-06 14:15:43 +02:00
Stephan Bergmann 7392e1326d Improved loplugin:cstylecast to reference types: cppuhelper 
Change-Id: Id442b7a76072fb346d927a7dd8659a05bb491f9b
 2017-06-05 21:18:13 +02:00
Andrea Gelmini 1d857ca26f Fix typos 
Change-Id: I3cd50e374c45bc1c400b24c8fffd6d8f5cd1de56
Reviewed-on: https://gerrit.libreoffice.org/38208
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2017-06-01 10:51:01 +02:00
Stephan Bergmann 94d9d895ed Remove some unnecessary scaffolding around SAL_WARN calls 
Change-Id: Iaec105d85a283ad15fdca6ffc5cf3d2ec5acac18
 2017-05-31 18:17:03 +02:00
Noel Grandin 2ccde70d60 teach redundantcast plugin about functional casts 
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0
Reviewed-on: https://gerrit.libreoffice.org/37910
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-30 08:50:31 +02:00
Noel Grandin ef513fd4b0 remove unnecessary use of OString::getStr 
Change-Id: I0490efedf459190521f4339854b3394d57765fdb
Reviewed-on: https://gerrit.libreoffice.org/38058
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-28 19:44:08 +02:00
Noel Grandin 389da66dfc remove unused uno::Reference vars 
found by temporarily marking Reference as SAL_WARN_UNUSED.

Change-Id: I18809b62654467f890016adcc92576980ced393b
Reviewed-on: https://gerrit.libreoffice.org/37511
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-12 09:56:01 +02:00
Jochen Nitschke 959496794c cleanup osl/diagnose.h includes 
with command
> git grep -l osl/diagnose.h *.cxx |
  xargs grep -L -w 'OSL_\w*' |
  xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d'

headers need more work

Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab
Reviewed-on: https://gerrit.libreoffice.org/37350
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-05-09 15:41:46 +02:00
Chris Sherlock 97eb00c75e revert OSL_ASSERT changes 
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
 2017-05-07 17:03:35 +10:00
Chris Sherlock 9a274915a1 tdf#43157: convert cppuhelper and io from OSL_ASSERT to assert 
Change-Id: I56d49e1ce9f1c070fedcabb8f1637d17dee1083b
 2017-05-07 08:11:12 +10:00
dennisroczek 91a1342aa2 tdf#39468 cleanup source code comments 
* translate German source code comments
* remove ascii art
* remove bogus source Code comments
* remove old StarOffice/Sun internal bug tracker references

Change-Id: I443bf2fdba3780c411d69809111daf3aa3a48451
Reviewed-on: https://gerrit.libreoffice.org/36005
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-04-27 22:20:40 +02:00