Commit Graph
12 Commits
Author SHA1 Message Date
Noel Grandin 5c7b954935 loplugin:useuniqueptr in OTable
use rtl::Reference here since these are reference counted data
structures, and we hand out references to me via our API

Change-Id: I8f69dde2db08519cb3d9de20b4ad54462e3ecc98
Reviewed-on: https://gerrit.libreoffice.org/49180
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-05 12:04:36 +01:00
Stephan Bergmann f8558f8446 More loplugin:cstylecast: connectivity
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: Idbefb16acae20ab137497e78c9bc5dc5634c07fe
2018-01-12 20:27:27 +01:00
Noel Grandin 16a3594e6a inline typedefs in connectivity/StdTypeDefs
Change-Id: I614833ed2418ff99057c7d496ddb64f06e8395db
Reviewed-on: https://gerrit.libreoffice.org/46809
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-20 07:09:43 +01:00
Stephan Bergmann 25fd3077e8 loplugin:includeform: connectivity
Change-Id: I06596fac09f0568b8bab2e2e235a2b88bcd3fc7a
2017-10-23 22:46:11 +02:00
66kesara99 16549dc267 tdf#96505 Get rid of cargo cult "long" integer literals
Remove unnecessary "Long" literals in multiple locations

Change-Id: Icc44546f10fed841683053eee01b788274e0add1
Reviewed-on: https://gerrit.libreoffice.org/42683
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-24 20:18:56 +02:00
Miklos Vajna 020c3eebc2 connectivity DatabaseMetaData: pull out OComponent from OCalc/Writer
Only getURL() and getTables() is custom, the rest can be shared.

Change-Id: I9d282a30f722bce0c05b37c7d005c84193e01b7c
Reviewed-on: https://gerrit.libreoffice.org/42152
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-09-11 12:27:13 +02:00
Caolán McNamara b032f21b5e refactor to remove the gotos
no logic change intended

Change-Id: Ia787ff543ce7d55511656f5a462438378654f325
Reviewed-on: https://gerrit.libreoffice.org/40774
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-05 00:36:47 +02:00
Miklos Vajna 8a24df0bed connectivity: partially merge OWriterTable and OCalcTable
Factor out the common code of these into a new OComponentTable.

Change-Id: I57abac05c9b64cde69d17568e325e86b3c530b20
Reviewed-on: https://gerrit.libreoffice.org/40648
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-02 09:55:58 +02:00
Miklos Vajna d3d9292a0f connectivity: merge OCalcColumns and OWriterColumns
Turns out createObject() only needs the base class OFileTable, and then
these can be shared.

Change-Id: I6e8a83155dbbbc3d85794e190c2e710d01902017
Reviewed-on: https://gerrit.libreoffice.org/40183
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-19 19:53:20 +02:00
Miklos Vajna 196ee66d4a connectivity: merge OCalcPreparedStatement and OWriterPreparedStatement
Into a single OComponentPreparedStatement, as both of them just provide
prepared statement functionality based on a file loaded into an LO
component, so they can share code.

Change-Id: Ib1074871d63de83f16861081050e57442ebf0ffa
Reviewed-on: https://gerrit.libreoffice.org/40182
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-19 19:51:47 +02:00
Miklos Vajna 4073bc15d1 connectivity: merge OCalcStatement and OWriterStatement
Into a single OComponentStatement, as both of them just provide statement
functionality based on a file loaded into an LO component, so they can share
code.

Change-Id: Iad2852f93783ec3c4a672f4b86424b4aa0ae8eaf
Reviewed-on: https://gerrit.libreoffice.org/40181
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-19 19:50:27 +02:00
Miklos Vajna e473d49acc connectivity: merge OCalcResultSet and OWriterResultSet
Into a single OComponentResultSet, as both of them just provide data
source functionality based on a file loaded into an LO component, so
they can share code.

Change-Id: I19352e592a45d7a58d834e72645dec72d77ce7c9
Reviewed-on: https://gerrit.libreoffice.org/40180
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-19 19:49:20 +02:00