ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
421,396 Commits 3 Branches 3 Tags
940f90f3da170b62379e9d1d33d4e6d690997026
Commit Graph
8720 Commits
Author SHA1 Message Date
Jochen Nitschke b2147abdf6 remove unused ucbstreamhelper includes 
and a few vclunohelper includes

Change-Id: I4803605766d155fe5044c2a65c0444631146831c
Reviewed-on: https://gerrit.libreoffice.org/51496
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-19 07:38:49 +01:00
Noel Grandin 2f5868c430 loplugin:redundantfcast look for redundant copies in return statements 
Change-Id: I5f416c865dfe1c36018784246a8007452eb42008
Reviewed-on: https://gerrit.libreoffice.org/50996
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-12 07:37:24 +01:00
Noel Grandin 7960ccb41d loplugin:constantparam in canvas..comphelper 
Change-Id: Ia666cb46c409852a13789389c032f0ce4377c0d5
Reviewed-on: https://gerrit.libreoffice.org/50927
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-08 10:34:50 +01:00
Noel Grandin bb7ade140d loplugin:unusedmethods 
Change-Id: Id6b4edd265cb6bef31c72e2a0a440211d51c7c33
Reviewed-on: https://gerrit.libreoffice.org/50900
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-08 08:44:32 +01:00
Noel Grandin 44d5188b2f loplugin:unusedfields 
Change-Id: Id332557cbe7fb42d3d794612f26aa3ac161548d9
Reviewed-on: https://gerrit.libreoffice.org/50902
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-08 08:13:44 +01:00
Tamas Bunth c25b884d54 Firebird: allow setting BINARY fix and VARBINARY 
Allow setting BINARY (fix) and VARBINARY types in method setBytes.

Change-Id: I6c8cfc5aff6e1240eadd6b061d629586a25b71c3
Reviewed-on: https://gerrit.libreoffice.org/50735
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
 2018-03-07 11:31:12 +01:00
Stephan Bergmann ebb41767f3 Rename OCharsetMap::find overload to findIanaName 
Change-Id: Id3fe81b41b92d6ad4e3f7127331d859a7b3c7f54
Reviewed-on: https://gerrit.libreoffice.org/50779
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2018-03-05 19:49:43 +01:00
Stephan Bergmann 5ad62544bc tdf#116171: Tunnel arbitrary rtl_TextEncoding from sc to sdbc:dbase connection 
...including those that have no corresponding textual IANA character set name
representation, like RTL_TEXTENCODING_MS_950 which is apparently used in some
DBase files.

In the past, if eCharSet was RTL_TEXTENCODING_DONTKNOW in lcl_getDBaseConnection
it was sent as an empty string CharSet property, which the receiving
OConnection::construct translated back to

  else
      m_nTextEncoding = RTL_TEXTENCODING_DONTKNOW;

so the net effect remains the same for that special case.

Change-Id: I84eec8a93d000752b3c429976c58721ea9ea32a4
Reviewed-on: https://gerrit.libreoffice.org/50772
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-03-05 17:44:17 +01:00
Johnny_M b6aee26f36 Translate German comments and debug strings 
Change-Id: Ie2da785cb674e21f042caa5e6d461e3489036003
Reviewed-on: https://gerrit.libreoffice.org/50467
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2018-02-28 10:51:36 +01:00
Miklos Vajna 5b12898378 connectitivty: can use o3tl::make_unique<> here 
Change-Id: Ia01bf2866e3f688dfab64c5fd72e787e4409fb75
Reviewed-on: https://gerrit.libreoffice.org/49830
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-02-16 08:45:46 +01:00
Jochen Nitschke 4f759834d3 cppcheck useInitializationList 
unique_ptr don't need explicit nullptr initialization, same
goes for VclPtr in ImpEditEngine.

Change-Id: Id8f3163c2719bee6ee2724cae98449d564be5535
Reviewed-on: https://gerrit.libreoffice.org/49559
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-12 08:03:12 +01:00
Noel Grandin 5c7b954935 loplugin:useuniqueptr in OTable 
use rtl::Reference here since these are reference counted data
structures, and we hand out references to me via our API

Change-Id: I8f69dde2db08519cb3d9de20b4ad54462e3ecc98
Reviewed-on: https://gerrit.libreoffice.org/49180
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-05 12:04:36 +01:00
Noel Grandin 748167da4e loplugin:useuniqueptr in OStatement_Base 
Change-Id: I41bc59c7ff7d711e0fc877e843625fa54c96b6bc
Reviewed-on: https://gerrit.libreoffice.org/49183
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-05 07:53:55 +01:00
Noel Grandin 7dcf9db73b loplugin:useuniqueptr in OSQLParseNode 
Change-Id: Ibad6e4b32b19a925de621b9dea7070d3930f05ef
Reviewed-on: https://gerrit.libreoffice.org/49182
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-05 07:53:09 +01:00
Noel Grandin c81791db55 loplugin:useuniqueptr in OConnection 
Change-Id: I0f1069eefc6d0afa8aa852af76099e79c63cbed9
Reviewed-on: https://gerrit.libreoffice.org/49181
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-05 07:53:02 +01:00
Noel Grandin 1b67ad6ff8 remove connectivity OSubComponent 
push the logic that is still necessary down into the subclasses

Change-Id: I99424f0b3c654c5652991a4140b17ceb02224e50
Reviewed-on: https://gerrit.libreoffice.org/49087
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-02 11:21:36 +01:00
Chris Sherlock 192b2f754c connectivity: remove dead code 
Change-Id: Ia968179d90978dc6c737effce5447efda60c1f66
Reviewed-on: https://gerrit.libreoffice.org/47490
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2018-02-01 15:31:23 +01:00
Mike Kaganski b7c5ddcdd0 connectivity: MSVC: pragma warning: make more specific, remove obsolete 
Change-Id: I22553d7cbbae7cfaac3f39a17db54dfe06e2e5bc
Reviewed-on: https://gerrit.libreoffice.org/48989
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2018-01-31 21:03:22 +01:00
Caolán McNamara d7f5e7e04a coverity#1421119 Dereference after null check 
Change-Id: Ic5002a25ed51fe72e1f36f365707101632d786e1
Reviewed-on: https://gerrit.libreoffice.org/48905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-01-30 21:31:25 +01:00
Andrea Gelmini c101df2171 Fix typos 
Change-Id: Iedd82d035454c940d76a94c7e910c81827c1389c
Reviewed-on: https://gerrit.libreoffice.org/48828
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2018-01-29 13:26:15 +01:00
Miklos Vajna 4231073282 sw: prefix members of SwExtUserField, SwFileNameField and SwFileNameFieldType 
Change-Id: I0722417149c9fbcd2aee3491c841c036a5677c8d
Reviewed-on: https://gerrit.libreoffice.org/48807
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-01-29 10:59:03 +01:00
Noel Grandin 53d21a3143 loplugin:useuniqueptr in OCatalog 
Change-Id: Ie06456ac8971494f64711cd70fd2b32a4dce719d
Reviewed-on: https://gerrit.libreoffice.org/48740
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-29 07:21:16 +01:00
Julien Nabet 8d3d04ef58 Modernize a bit connectivity (part2) 
by using for range loops

Change-Id: Ibbc4cdaa78c4c9d88487132a2761ac1040b1ecd8
Reviewed-on: https://gerrit.libreoffice.org/48713
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-01-27 09:31:10 +01:00
Tamas Bunth 95bece38ac Add HSQLDB schema import 
It can be enabled by initializing the DBACCESS_HSQL_MIGRATION variable.

Create new library "dbahsql" which is responsible for migrating the
embedded hsql database to any database covered by sdbc.

The hsqldb schema is stored in a file named "script" in form of SQL
statements. The SQL statements used by DBMS's differ mostly by the
defined types. Because of that, only the create statements need to be
parsed, alter statements will work (with a little luck) without actually
modifying it.

User / security settings which can occur in the script file (e.g. GRANT
statements) are dropped. Statements starting with SET are also dropped
(they are hsql specific stuff)

Change-Id: I6a22942e8a9a76765f80e50f0ad68f4d72e1ff9d
Reviewed-on: https://gerrit.libreoffice.org/48260
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
 2018-01-27 09:30:29 +01:00
Julien Nabet 199b307be5 Modernize a bit connectivity (part1) 
by using for range loops
+ use returned iterator by erase call in ZConnectionPool

Change-Id: I97b14b24ebddefea909bc17cb3463f840fde38a0
Reviewed-on: https://gerrit.libreoffice.org/48634
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2018-01-26 09:07:59 +01:00
Jens Carl 583a574d04 Update comment to reflect the right type 
Follow up from commit 4cdb7fa375,
where it was missed.

Change-Id: Icfc123b0e238705f175fda6308ecc40569d3a31a
Reviewed-on: https://gerrit.libreoffice.org/48643
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Tested-by: Jens Carl <j.carl43@gmx.de>
 2018-01-26 02:33:04 +01:00
Jens Carl 4cdb7fa375 Change property value to get CellContentType in connectivity/ 
Follow up from commit cceaece18a.

Change-Id: I29df5403204279b038095156c85638877d2dc9ff
Reviewed-on: https://gerrit.libreoffice.org/48465
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
 2018-01-25 23:29:29 +01:00
Noel Grandin 0f28c8612f loplugin:unused-returns in basegfx..cppcanvas 
Change-Id: I32dc8c92871c8349651d2f4204a332d387e6e1b2
Reviewed-on: https://gerrit.libreoffice.org/48428
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-25 13:51:24 +01:00
Miklos Vajna fc2d155f42 Fix some IWYU warnings 
Change-Id: I4b6e799c1afc2a762a3729ee89f3226c59a6eef8
Reviewed-on: https://gerrit.libreoffice.org/48462
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-01-24 10:14:09 +01:00
Stephan Bergmann 9af8f190ed More loplugin:cstylecast on Windows 
Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after
cab0427cad "Enable loplugin:cstylecast for some
more cases" and a409d32e7f "More
loplugin:cstylecast"

Change-Id: Ib3355159dd08333e1b7a8d091caf2069cdcc7862
Reviewed-on: https://gerrit.libreoffice.org/48317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-01-23 07:54:51 +01:00
Noel Grandin 3b666f6819 remove some sal_Bool remnants 
Change-Id: I0a9637aca523a73fbdbbd22f9ad735d6d1ba6898
Reviewed-on: https://gerrit.libreoffice.org/48273
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-22 07:04:29 +01:00
Stephan Bergmann b670e88bc1 loplugin:emptyif (macOS) 
Change-Id: I0abd0ace30f172d0991be697e6f78edd50ddeaaa
Reviewed-on: https://gerrit.libreoffice.org/48214
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2018-01-20 10:47:32 +01:00
Stephan Bergmann fc528a4680 More loplugin:cstylecast on macOS 
Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after
cab0427cad "Enable loplugin:cstylecast for some
more cases" and a409d32e7f "More
loplugin:cstylecast"

Change-Id: Iff4877e8a42804c952c48c13332caf0a83c92870
Reviewed-on: https://gerrit.libreoffice.org/48216
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-01-20 10:45:48 +01:00
Stephan Bergmann 9ece0b1ada loplugin:unnecessaryparen (macOS) 
Change-Id: Ie4ae8459c0afbeac0cad1b8a30dad02535d558dd
Reviewed-on: https://gerrit.libreoffice.org/48190
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-01-19 21:17:13 +01:00
Noel Grandin be94207ecb new loplugin:emptyif 
Change-Id: I1092115a0ceb3a5e6680a4b724b129f98a892c42
Reviewed-on: https://gerrit.libreoffice.org/48128
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-19 13:25:54 +01:00
Stephan Bergmann 697f01e052 SAL_W32 is just an alias for _WIN32 
...so consistently use the latter instead of the former

Change-Id: I144d5e7c472632f93b2258461510346bc85892d9
Reviewed-on: https://gerrit.libreoffice.org/48135
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-01-19 08:19:38 +01:00
Andrea Gelmini 4d2fc77b5d Fix typos 
Change-Id: I18ce04cbaa79c827a52e2441e98ee2e3377b5877
Reviewed-on: https://gerrit.libreoffice.org/48077
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2018-01-17 21:05:01 +01:00
Noel Grandin 23885b06b1 loplugin:unnecessaryparen extend to delete statements 
Change-Id: Ic4383ea948876a26f791f0e5b0110cef978a26e1
Reviewed-on: https://gerrit.libreoffice.org/48027
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-17 09:32:03 +01:00
Andrea Gelmini f0b857310d Fix typos 
Change-Id: Ia976371bf52eb1216d8abe728d80bbb87a3c38a2
Reviewed-on: https://gerrit.libreoffice.org/47858
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-01-16 14:23:52 +01:00
Stephan Bergmann 9bff1e15e5 More loplugin:cstylecast: connectivity 
Change-Id: Id7cbe6a119b944813bc7638b08e59d4705607ece
 2018-01-15 09:06:50 +01:00
Noel Grandin 7d8e94444d convert a<b?a:b to std::min(a,b) 
with something like

    git grep -nP '(.*)\s*<\s*(.*)\s*\?\s*\g1\s*:\s*\g2' -- *.?xx

Change-Id: Id5078b35961847feb78a66204fdb7598ee63fd23
Note: we also convert a>b?b:a
Reviewed-on: https://gerrit.libreoffice.org/47736
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-15 07:26:17 +01:00
Andrea Gelmini 866fc4ddd3 Fix typos 
Change-Id: Icc5fc590a6a90e30afa5f61028d4dd0279fbe120
Reviewed-on: https://gerrit.libreoffice.org/47861
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-01-14 16:40:13 +01:00
Stephan Bergmann f8558f8446 More loplugin:cstylecast: connectivity 
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: Idbefb16acae20ab137497e78c9bc5dc5634c07fe
 2018-01-12 20:27:27 +01:00
Stephan Bergmann 28270d93c0 loplugin:redundantcast: connectivity 
(after a to-be-committed improved loplugin:cstylecast would have rewritten the
C-style casts into static_casts)

Change-Id: I43a148a0d192f85bbad95696c7c3c3e717c5b00a
 2018-01-11 17:38:37 +01:00
Miklos Vajna 74b3924a98 connectivity: various small cleanups in the Writer driver 
Change-Id: I91735c3e92262fd37966c53f973d5eee1522cd61
Reviewed-on: https://gerrit.libreoffice.org/47741
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-01-11 14:27:51 +01:00
Michael Stahl 162ffd57de (related:tdf#114939) connectivity: use real SHA1 
It looks like OConnectionWrapper::createUniqueId() doesn't really care
what particular hash is used, it just wants to create something unique,
so don't use the 'special' StarOffice SHA1 here.

Change-Id: I817be900ecc9c6d686f21cce4a46f9eadd244b71
 2018-01-11 11:04:59 +01:00
Noel Grandin f14b9d3029 convert (a>b?a:b) to std::max(a,b) 
with something like:
   git grep -nP '(.*)\s*>\s*(.*)\s*\?\s*\g1\s*:\s*\g2'

Change-Id: I60b9a3a2a09162bc0de4c13fdde2c209696e5413
Reviewed-on: https://gerrit.libreoffice.org/47602
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-11 07:35:43 +01:00
Lionel Elie Mamane 27da558d7c fixup tdf#104986 move named parameters substitution into generic layer 
remove now unused class member

Change-Id: I30ffcf60833580a5f0029fa4efef80507d7918df
Reviewed-on: https://gerrit.libreoffice.org/47524
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-01-07 09:30:39 +01:00
Julien Nabet 964cc98794 tdf#114495 ODBC: clear row status buffer *before* we throw away the statement 
Change-Id: I898e9d0e3e2cf1ed41489231d1cd761171bfcea4
Reviewed-on: https://gerrit.libreoffice.org/47514
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
 2018-01-07 08:10:32 +01:00
Julien Nabet 9dfd1f62ab Revert "tdf#114495: fix crash in odbc resultset dtr" 
This reverts commit 89e354eff9.

Change-Id: I73435ba76d7d7ca7ebf91eeced470fb792786c92
Reviewed-on: https://gerrit.libreoffice.org/47513
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2018-01-06 20:42:20 +01:00