mainly by using for range loops
+ by using empty() instead of comparing begin and iterator
or use size to test that a container has at least 2 elements
Change-Id: I81f168d8c36a8b4195fbb0c1aee4983dab25d22c
Reviewed-on: https://gerrit.libreoffice.org/50705
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.
Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly). The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually). There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).
Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code. Missing @throws
documentation has not been applied in such manual clean-up.
Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.
(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to
OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager();
in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)
Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
The VAxisBase::m_xNumberFormatsSupplier refers to the ChartModel itself,
and apparently that is a cyclic reference. Naively using the
ChartModel's m_xNumberFormatsSupplier in
ChartView::impl_createDiagramAndContent() because it will later be passed
to AxisHelper::getExplicitNumberFormatKeyForAxis(), which expects to be
able to convert it to a ChartModel.
Since passing around the ChartModel as an XNumberFormattingSupplier is
sort of un-intuitive anyway, refactor some methods to use XChartDocument
instead, and only create the VPolarAxis / VCartesianAxis with the
ChartModel's m_xNumberFormatsSupplier.
The drawback is that if ChartModel::attachNumberFormatsSupplier()
is called after ChartView::update() has created the axes, it may not
have an effect on them; not sure if that is a real or hypothetical
problem.
Change-Id: Ib5f0d5882b85adaf44f80e086f19178b3e64882f
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2006/10/18 17:20:48 bm 1.3.4.20: RESYNC: (1.5-1.6); FILE MERGED
2006/09/24 09:12:56 iha 1.3.4.19: #i61970# correct implementation of axis at
2006/08/25 17:16:47 iha 1.3.4.18: text- and diagram-size dependent auto main step width
2006/08/23 17:07:26 iha 1.3.4.17: enable axis to estimate the maximum automatic MainIncrementCount, reduce count to 2 for net charts
2006/08/10 15:53:58 iha 1.3.4.16: Axis Label Layout - Font&Diagram Size
2006/04/10 15:03:37 iha 1.3.4.15: api restructure axis, grids, scales and increments
2006/04/10 12:25:17 iha 1.3.4.14: api restructure axis, grids, scales and increments
2006/03/23 15:31:52 iha 1.3.4.13: cleanup category handling
2005/12/21 21:29:31 iha 1.3.4.12: remove identifiers from model objects and create an index based CID protocol instead for selection purposes
2005/11/25 16:32:06 iha 1.3.4.11: correct labels at z axis for deep stacking
2005/10/24 11:06:58 iha 1.3.4.10: coordinate system restructure
2005/10/13 17:39:10 iha 1.3.4.9: renamed BoundedCoordinateSystem to CoordinateSystem
2005/10/07 12:17:03 bm 1.3.4.8: RESYNC: (1.4-1.5); FILE MERGED
2005/06/07 16:03:25 iha 1.3.4.7: use numberformatter from model
2004/04/01 12:22:15 iha 1.3.4.6: make shape creation more fail save
2004/03/24 12:31:32 bm 1.3.4.5: RESYNC: (1.3-1.4); FILE MERGED
2004/03/22 19:35:58 iha 1.3.4.4: transport information bSwapXAndYAxis over method setScales not constructor; used new method getPropertySwapXAndYAxis
2004/03/22 17:35:12 iha 1.3.4.3: added parameter SwapXAndYAxis also to grid
2004/03/22 15:45:53 iha 1.3.4.2: read property SwapXAndYAxis from CoordinateSystem model and feed AxisProperties
2004/03/12 15:36:43 iha 1.3.4.1: get axis position from model
Szymon Kłos