Noel Grandin
8e27afa534
loplugin:unnecessaryvirtual
...
Change-Id: Ic044a6e4568e707022d87bc5712205fbdf084ba2
Reviewed-on: https://gerrit.libreoffice.org/52067
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-03-29 18:15:16 +02:00
Noel Grandin
87b0eb0183
loplugin:virtualdown in basctl,basic
...
Change-Id: If0d729ee84263a5afb2c7acb2d62b08602aa59f4
Reviewed-on: https://gerrit.libreoffice.org/52046
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-03-29 11:36:28 +02:00
Noel Grandin
47ccda36fc
loplugin:virtualdown in sfx2
...
Change-Id: I51e79a4a3d2c799e69bc13c66b5b84056bee6206
Reviewed-on: https://gerrit.libreoffice.org/52034
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-03-29 08:37:19 +02:00
Samuel Mehrbrodt
c12fc29365
Typo: GetSelectLanguage -> GetSelectedLanguage
...
Change-Id: Ia283812d4e9df87d875559af5366c2e36b19eab2
Reviewed-on: https://gerrit.libreoffice.org/51747
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2018-03-23 08:24:49 +01:00
Noel Grandin
b8512a1cc7
use more TypedWhichId in sfxsids
...
Change-Id: I136427319ce2f1117501517efec2f03019bbf71e
Reviewed-on: https://gerrit.libreoffice.org/51339
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-03-16 08:25:02 +01:00
Mike Kaganski
6ab9f0cfcd
SDI: don't #define/#undef names of actual classes for slot headers
...
Visual Studio 2015/2017 cannot handle that correctly, and emits a lot
of intellisense errors. So, just prepend the define with "ShellClass_"
Change-Id: I473ceb7e0a88e114b92e6342fd4ae63015cafd3e
Reviewed-on: https://gerrit.libreoffice.org/51135
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com >
2018-03-13 14:14:12 +01:00
Caolán McNamara
48bca65f1c
inherit welded dialogs from a common ancestor
...
Change-Id: Ifa6c871a134cf89bfba71b1049a115cf7c953c42
Reviewed-on: https://gerrit.libreoffice.org/50936
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-03-09 13:47:52 +01:00
Noel Grandin
ba43b0cb7a
drop getColor() method of Color
...
no longer necessary
Change-Id: I9e0fcea1134e8c5e27f9effbb5eb79fe5446e33d
Reviewed-on: https://gerrit.libreoffice.org/50925
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-03-09 07:14:22 +01:00
Caolán McNamara
d6f1c3dece
weld SfxPasswordDialog Dialog
...
Change-Id: If8c9757986f4af7b7927717221860e65c8c7285e
Reviewed-on: https://gerrit.libreoffice.org/50755
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-03-05 00:32:13 +01:00
Caolán McNamara
f705047867
weld new library dialog
...
Change-Id: I86c70a01e45a7e9f80c19f9a9b0e6307830ba722
Reviewed-on: https://gerrit.libreoffice.org/50685
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-03-04 16:27:12 +01:00
Noel Grandin
b8ececb409
drop old tools/gen methods in accessibility..formula
...
Change-Id: I075e29173945200854f2ef8e420867871659766a
Reviewed-on: https://gerrit.libreoffice.org/50446
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-03-01 07:19:10 +01:00
Shubham Verma
0b49701fa5
tdf#114441 sal_uLong to better integer types
...
Change-Id: I55b45821cf67a99f97ba067a3d4923d76c19696e
Reviewed-on: https://gerrit.libreoffice.org/50204
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2018-02-27 17:51:42 +01:00
Noel Grandin
c98d330302
replace Color(COL_*) with COL_*
...
using
git grep -lwP "Color\s*\(\s*(COL_\w+)\s*\)"
| xargs perl -pi -e "s/Color\s*\(\s*(COL_\w+)\s*\)//g"
and then some manual fixup where the resulting expression no longer
compiled
Change-Id: I0e268d78611c3be40bba9f60ecfdc087a36c0df4
Reviewed-on: https://gerrit.libreoffice.org/50372
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-02-27 11:28:29 +01:00
Caolán McNamara
082e69fefb
convert various MessBox to weld::MessageDialog
...
Change-Id: I4d2d0393c753114aeb9bb7e646dfdc810f6caa38
Reviewed-on: https://gerrit.libreoffice.org/50398
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-02-27 11:22:49 +01:00
Caolán McNamara
942f05996b
convert remaining ErrorBox to weld::MessageDialog
...
and
convert remaining QueryBox to weld::MessageDialog
Change-Id: Ifb4c316dee8eabf57c4940c44e29c65a2781aa6c
2018-02-26 15:27:09 +00:00
Noel Grandin
08ab1f46b1
loplugin:oncevar extend to tools/gen.hxx types
...
Change-Id: I5c75875da44334569c02e2ff039b33c38397a0a2
Reviewed-on: https://gerrit.libreoffice.org/50283
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-02-26 07:21:04 +01:00
Caolán McNamara
d75144cf44
convert remaining InfoBox to weld::MessageDialog
...
Change-Id: I91d828e38d96264cf4a76f30940942556b8f78d8
Reviewed-on: https://gerrit.libreoffice.org/50205
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-02-25 20:03:26 +01:00
Julien Nabet
8f2d6e8060
Modernize a bit accessibility and basctl
...
by using for range loops
+ compare end iterator with "!=" instead of "<"
Change-Id: I615a8ca417a58fde4976bb6d8d9112dc5d993a88
Reviewed-on: https://gerrit.libreoffice.org/50277
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2018-02-24 11:46:24 +01:00
Caolán McNamara
6a4c464b49
weld native message dialogs
...
just the straight-forward MessageDialog cases first
a) remove border_width from message dialog .ui so as to take
the default border width
b) retain 12 as default message dialog border for vcl widget case
c) remove layour_style from message dialog button boxes so as to
take the default mode (a no-op for vcl widget case)
d) use gtk response ids (vcl builder will converts to vcl ones)
Change-Id: I7de281093a1b64f92f71ca11e7cbba42bb658154
Reviewed-on: https://gerrit.libreoffice.org/50143
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-02-22 22:07:38 +01:00
Shubham Verma
0c371a6b5e
tdf#112689 : Replace chained O(U)StringBuffer::append() with operator+
...
Change-Id: I119d33b171da7024daab5c4ca4488ceb495eab2f
Reviewed-on: https://gerrit.libreoffice.org/49898
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr >
2018-02-22 13:57:00 +01:00
Noel Grandin
bddd6c7781
Revert "loplugin:changetoolsgen in avmedia..basic" and reapply plugin
...
because I
(a) forgot to insert parentheses which changes the meaning of some expressions and
(b) I now use the AdjustFoo calls when changing unary operations, which reads much better
This reverts commit 1adb1a320ahttps://gerrit.libreoffice.org/49848
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-02-16 19:50:47 +01:00
Caolán McNamara
7faa218231
ofz#6311 still problems with SdrEdgeObj listening to same obj at start as end
...
Change-Id: Ibd80b484788779b73943b28a5f36e51ebcacec30
Reviewed-on: https://gerrit.libreoffice.org/49821
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2018-02-16 00:35:10 +01:00
Noel Grandin
1adb1a320a
loplugin:changetoolsgen in avmedia..basic
...
Change-Id: I4e355ae27b9fad1cc6e8f8f408dbd9e93d7256d7
Reviewed-on: https://gerrit.libreoffice.org/49603
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-02-13 07:38:03 +01:00
Gabor Kelemen
4fae455fcd
tdf#42949 Remove unneeded helpids.h headers (1/3)
...
A side effect of the .ui migration is that we use a lot less HIDs
in the code. A lot of files still contain helpids.h includes
even if no actual HID is referenced.
This cleans up directories b* - e*.
Found with:
git grep helpids.h | cut -d : -f 1 | xargs grep -c HID_ | grep :0$
Change-Id: I221d22f68584115d71660a97c4f108595625d12c
Reviewed-on: https://gerrit.libreoffice.org/46868
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2018-02-01 15:19:36 +01:00
Noel Grandin
945a119675
loplugin:constparams
...
Change-Id: I7c695073d9a9d3b7a641d6eb9fe01a47d8c3a504
Reviewed-on: https://gerrit.libreoffice.org/48392
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-01-24 07:56:57 +01:00
Noel Grandin
be94207ecb
new loplugin:emptyif
...
Change-Id: I1092115a0ceb3a5e6680a4b724b129f98a892c42
Reviewed-on: https://gerrit.libreoffice.org/48128
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-01-19 13:25:54 +01:00
Stephan Bergmann
f867ead158
Fix callback function type
...
...that got broken with c394363c84#0 0x7ff6340234aa in SfxApplication::GlobalBasicErrorHdl_Impl(SfxApplication*, StarBASIC*) sfx2/source/appl/app.cxx:452:28
> #1 0x7ff63401cbef in SfxApplication::LinkStubGlobalBasicErrorHdl_Impl(void*, StarBASIC*) sfx2/source/appl/app.cxx:434:1
> #2 0x7ff639142148 in Link<StarBASIC*, bool>::Call(StarBASIC*) const include/tools/link.hxx:84:45
> #3 0x7ff63911f350 in StarBASIC::RTError(ErrCode, rtl::OUString const&, int, int, int) basic/source/classes/sb.cxx:1681:37
> #4 0x7ff63965aafe in SbiInstance::Abort() basic/source/runtime/runtime.cxx:518:16
> #5 0x7ff639664363 in SbiRuntime::Step() basic/source/runtime/runtime.cxx:865:28
> #6 0x7ff6392ec321 in SbModule::Run(SbMethod*) basic/source/classes/sbxmod.cxx:1141:25
[...]
Change-Id: I66bd1ca720cebca4fb5fd52d86920de3fc7a604e
Reviewed-on: https://gerrit.libreoffice.org/48142
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2018-01-19 08:20:01 +01:00
Andrea Gelmini
a6b69a9384
Fix typo
...
Change-Id: I51c97356c9c2939f2d94d6388c829a179ca00daa
Reviewed-on: https://gerrit.libreoffice.org/47853
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2018-01-15 13:53:21 +01:00
Stephan Bergmann
e662242ec0
More loplugin:cstylecast: basctl
...
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/ > "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files
Change-Id: I3bddf4b08e064dead05eae87619db2232744d7f8
2018-01-12 20:29:48 +01:00
Noel Grandin
f14b9d3029
convert (a>b?a:b) to std::max(a,b)
...
with something like:
git grep -nP '(.*)\s*>\s*(.*)\s*\?\s*\g1\s*:\s*\g2'
Change-Id: I60b9a3a2a09162bc0de4c13fdde2c209696e5413
Reviewed-on: https://gerrit.libreoffice.org/47602
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-01-11 07:35:43 +01:00
Caolán McNamara
e7980e60ee
Resolves: tdf#114766 gtk3 solar mutex assert
...
since
commit 33de587e95https://gerrit.libreoffice.org/47590
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Jenkins <ci@libreoffice.org >
2018-01-08 20:01:45 +01:00
Jan Holesovsky
028fd03cdf
lokdialog: Allow language switching in SfxModule(s).
...
Change-Id: Icef0b3610c3bfa858cdd61de6ef3f5edc1e3c96b
Reviewed-on: https://gerrit.libreoffice.org/47385
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Jan Holesovsky <kendy@collabora.com >
2018-01-05 09:51:23 +01:00
Noel Grandin
31b5c9b9bc
remove SfxUsrAnyItem typedef
...
and rename SfxUsrAnyItem class to SfxUnoAnyItem, the choice being made
by leaving the most popular one behind
Change-Id: If3818ee0966a50e3036d7e2db951910b6282c91f
Reviewed-on: https://gerrit.libreoffice.org/47313
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-01-04 07:17:38 +01:00
Johnny_M
ca58ddb012
Translate German comment
...
Change-Id: Id65ccfe3b2394c8c30d3531316b70b511e34e366
Reviewed-on: https://gerrit.libreoffice.org/47131
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2018-01-03 16:45:31 +01:00
Noel Grandin
acdba3c2ee
loplugin:passstuffbyref more return improvements
...
slightly less restrictive check when calling functions
Change-Id: I35e268ac611797b1daa83777cda02288a635aa32
Reviewed-on: https://gerrit.libreoffice.org/47259
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-01-03 08:07:41 +01:00
Noel Grandin
4b030651a0
loplugin:passstuffbyref improved return in various
...
Change-Id: I0a8282d8e0d9575b055243073fc89a7d6b67b560
Reviewed-on: https://gerrit.libreoffice.org/47173
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-12-29 18:19:37 +01:00
Noel Grandin
3af500580b
loplugin:salcall fix functions
...
since cdecl is the default calling convention on Windows for
such functions, the annotation is redundant.
Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d
Reviewed-on: https://gerrit.libreoffice.org/46164
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-12-11 12:13:46 +01:00
Noel Grandin
c947a25b3a
loplugin:countusersofdefaultparams in basctl..basegfx
...
Change-Id: I515acfb9de1f6dff1de94a60055c5b600e5e5241
Reviewed-on: https://gerrit.libreoffice.org/45957
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-12-07 07:19:59 +01:00
Noel Grandin
9a06b99d2f
loplugin:salcall fix non-virtual methods
...
first, since those are safer to change than virtual methods
Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe
Reviewed-on: https://gerrit.libreoffice.org/45798
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-12-05 07:32:46 +01:00
Noel Grandin
2e5508a176
loplugin:unnecessaryparen check for (f1()).f2
...
Change-Id: I93257b0ddd41c649875124d6d5c5faeaa431bae3
Reviewed-on: https://gerrit.libreoffice.org/45218
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-11-27 10:44:25 +01:00
Noel Grandin
7a1c21e53f
loplugin:simplifybool for negation of comparison operator
...
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791
Reviewed-on: https://gerrit.libreoffice.org/45068
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-11-23 06:59:31 +01:00
Caolán McNamara
2161d04688
drop duplicate method
...
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12
Reviewed-on: https://gerrit.libreoffice.org/45075
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-11-22 13:33:25 +01:00
Caolán McNamara
33a477004c
coverity warnings
...
Change-Id: I456210188ab96e6be03e65c94eedb348cc93a8e1
Reviewed-on: https://gerrit.libreoffice.org/45023
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-11-21 18:23:46 +01:00
tagezi
94c76b6d26
renameModuleOrDialog: add missing check for valid Reference
...
Change-Id: I2cf33a4fae4db45b854e77e31e166afa0281a054
Reviewed-on: https://gerrit.libreoffice.org/44956
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com >
2017-11-20 16:37:15 +01:00
tagezi
9abd653129
tdf#108872 Also remove VBA module info on module removal
...
If this information is left, then css.container.ElementExistException
is thrown on following creation of a module with the same name in
XVBAModuleInfo::insertModuleInfo called from
ScriptDocument::Impl::createModule
(see commit 2be139d76bhttps://gerrit.libreoffice.org/44940
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com >
Tested-by: Mike Kaganski <mike.kaganski@collabora.com >
2017-11-20 15:42:02 +01:00
Andrea Gelmini
d6d58bbef9
Fix typos
...
Change-Id: Ib138f971c4efcc67c68c901c9f08b4d1d95cdde2
Reviewed-on: https://gerrit.libreoffice.org/44933
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2017-11-20 11:23:12 +01:00
Caolán McNamara
5280b3eaa6
silence some coverity warnings
...
Change-Id: I5a530e37156b5cd36e8a07ac20851880a46f520d
Reviewed-on: https://gerrit.libreoffice.org/44875
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-11-18 21:59:23 +01:00
Johnny_M
97b5b99d71
Translate German debug strings
...
Change-Id: If4da1df3f7889d2b579fcde4fec5ac3c82026555
Reviewed-on: https://gerrit.libreoffice.org/44627
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Jens Carl <j.carl43@gmx.de >
2017-11-14 08:24:32 +01:00
Noel Grandin
1aba1955f1
loplugin:finalclasses in basctl
...
Change-Id: I5974cf3df434ebfff1e3748ddd291e2a21cbb0de
Reviewed-on: https://gerrit.libreoffice.org/44536
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-11-10 10:52:26 +01:00
Noel Grandin
3dde9d988f
loplugin:constparams in various(1)
...
Change-Id: Ic80ca59abc3e104c7adf0c1eff1d16addf48bc8b
Reviewed-on: https://gerrit.libreoffice.org/44261
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-11-04 07:50:01 +01:00
Noel Grandin