ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
421,396 Commits 3 Branches 3 Tags
940f90f3da170b62379e9d1d33d4e6d690997026
Commit Graph
162 Commits
Author SHA1 Message Date
Noel Grandin 3af500580b loplugin:salcall fix functions 
since cdecl is the default calling convention on Windows for
such functions, the annotation is redundant.

Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d
Reviewed-on: https://gerrit.libreoffice.org/46164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-11 12:13:46 +01:00
Julien Nabet 393fa77d27 Replace lists by vectors in animation parts (sd/animations) 
Change-Id: Ie5306041e5cde5617e460ae4d98861e8d26e389d
Reviewed-on: https://gerrit.libreoffice.org/44297
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-11-04 17:54:28 +01:00
Noel Grandin ec8c98f598 use more SAL_N_ELEMENTS part 3 
Change-Id: I82e366fefd2e31928b99840fe76649cc3521e623
Reviewed-on: https://gerrit.libreoffice.org/38789
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-15 08:24:33 +02:00
Noel Grandin a7e0a8901e loplugin:comparisonwithconstant in avmedia 
Change-Id: Iba0a1969648e95f6e0f6a947f067c5b8e4eb3406
Reviewed-on: https://gerrit.libreoffice.org/37667
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-16 13:48:43 +02:00
David Ostrovsky de030cd7a2 gbuild: Remove MSVC 2013 legacy code 
Uwinapi is discontinued.

Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01
Reviewed-on: https://gerrit.libreoffice.org/23198
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Tested-by: David Ostrovsky <david@ostrovsky.org>
 2017-04-21 18:18:44 +02:00
Andrea Gelmini 0a850f3e15 Fix typos 
Change-Id: Iaefa094c82006346897f5563ac3ddcdc60ab68a3
Reviewed-on: https://gerrit.libreoffice.org/34809
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-03 07:47:54 +00:00
Tor Lillqvist 013d9789c7 Drop :: prefix from std in [a-b]*/ 
Change-Id: I0422aaf39bbce889c95ed9a81a0784cb03a1badd
Reviewed-on: https://gerrit.libreoffice.org/34320
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2017-02-15 21:50:23 +00:00
Stephan Bergmann 6dce9c6757 Add missing #includes 
...and remove some unncessary using directives/declarations, in preparation of
removing now-unnecessary #includes from cppumaker-generated files, post
e57ca02849 "Remove dynamic exception
specifications".

Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
 2017-02-06 17:21:16 +01:00
Noel Grandin faf9b82d39 makeAny->Any in accessibility..avmedia 
Change-Id: I70f2dfa66d7b66738a840e4a7b5c7fb1b8d7b39f
Reviewed-on: https://gerrit.libreoffice.org/33756
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-01 06:22:09 +00:00
Stephan Bergmann e57ca02849 Remove dynamic exception specifications 
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-01-26 12:54:43 +00:00
Stephan Bergmann f963c98845 loplugin:unnecessaryoverride (dtors) in animations 
Change-Id: I51b94f43e27da93afb3c44ed5f68e70e457fe8ea
 2016-11-23 18:36:18 +01:00
Stephan Bergmann 91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Gökhan Gurbetoğlu f62d222869 tdf#43157 - Clean up OSL_ASSERT, DBG_ASSERT, etc. 
Change-Id: I8114e338451b5b2e79b2318f558cbd075f024f08
Reviewed-on: https://gerrit.libreoffice.org/28584
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-09-05 12:53:19 +00:00
Muhammet Kara 52f377c259 tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor 
in AnimationNode

Change-Id: I2612286632dddbf96cbf918ffbeb09ac0c99d398
Reviewed-on: https://gerrit.libreoffice.org/27774
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-02 05:44:57 +00:00
Stephan Bergmann 62c564ccd2 loplugin:redundantcast: redundant static_casts in animations 
Change-Id: I7449a82672d412a963eab7df793182af85b4cb53
 2016-07-08 16:47:31 +02:00
Chris Sherlock a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Noel Grandin 752cd07d08 InterfaceContainer2 with vector instead of Sequence 
create an InterfaceContainer2 class to replace InterfaceContainer.
It uses a std::vector instead of a Sequence for the mutable listener
list, which provides far better performance.

Switch all our internal use-sites to the new class.

Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
 2016-01-25 08:52:03 +02:00
Noel Grandin 54d22957bc use initialiser for Sequence<OUString> 
performed using:
git grep -lP 'Sequence.*OUString.*\(1\)'
| xargs perl -0777 -pi -e
  "s/Sequence<OUString> (\w+)\(1\);
.*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g"

Change-Id: I4da56c80fa09bfc1e8f868794001e9921431e09f
Reviewed-on: https://gerrit.libreoffice.org/19968
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 11:31:23 +00:00
Stephan Bergmann cb0fb3edd4 loplugin:nullptr (automatic rewrite) 
Change-Id: I11a107dadd064452b983c69356e7562ed36c8bc3
 2015-11-10 10:31:15 +01:00
Stephan Bergmann b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Tor Lillqvist 395d922f58 chmod -x 
Change-Id: I4a248b59e12587c3b2ce79676fdce29a348b6751
 2015-07-29 14:17:05 +03:00
Noel Grandin 40da0a9d1c com::sun::uno->css in avmedia and animations 
Change-Id: Ie4365a488728c39fedacae7650b4b90260e7e44a
Reviewed-on: https://gerrit.libreoffice.org/17153
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-17 10:21:15 +00:00
Takeshi Abe 15c0fba5c2 tdf#88206: replace cppu::WeakImplHelper1 with cppu::WeakImplHelper 
in animations.

Change-Id: I7d776ddb81e0943bf2ea5895ea26631db76546ac
Reviewed-on: https://gerrit.libreoffice.org/16645
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-06 07:36:07 +00:00
Stephan Bergmann 1cb0b37ad0 Rephrase comparisons between bool and sal_Bool 
...to cater for forthcoming loplugin:implicitboolconversion improvements

Change-Id: I88c0c4681137022005c3a4c418e91cb17bc17148
 2015-05-08 09:49:01 +02:00
Caolán McNamara 869e477484 cppcheck: noExplicitConstructor 
Change-Id: Iea5bb0504518b380c3fe7c238d376dc26be8a7ef
 2015-05-04 20:13:52 +01:00
Caolán McNamara 21773f6d9a cppcheck: noExplicitConstructor 
Change-Id: I0b1cac50f9e158004f8c1b8294b7a1b9f21f9628
 2015-05-02 16:45:18 +01:00
Noel Grandin 71b809959b remove unnecessary use of void in function declarations 
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
 2015-04-15 11:47:12 +02:00
Stephan Bergmann 3099c70b11 Fix various XServiceInfo implementations 
...to match what is recorded in the .component files

Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
 2015-03-17 12:25:11 +01:00
Miklos Vajna 657b42d7eb native-code: animcore_component_getFactory -> ctors 
Change-Id: Ife39c5114f946244691c72c9defa8854fdf8a1b6
 2015-03-12 13:08:45 +01:00
Stephan Bergmann 6d97df009d Clean up previous commit 
...and fix AnimationNode::getSupportedServiceNames

Change-Id: I199bc5a58174873794f082b149352359918bfc6b
 2015-03-11 18:27:36 +01:00
Chris Sherlock 063fea93d6 animations: convert animcore.component to constructor usage 
Change-Id: Ia623a19457000fe717e29d6b0e73f53b978f7de8
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2015-03-11 18:27:36 +01:00
Michael Stahl 15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use 
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
 2014-11-18 18:51:49 +01:00
Noel Grandin 0371a63365 remove unnecessary 'using namespace rtl' declarations 
It turns out that almost none of them were necessary.

Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-29 11:28:54 +00:00
Noel Grandin 9af0abebfd remove unnecessary use of Reference constructor in throw 
Convert code like this:
  throw IOException("xx",
     Reference< XInterface >(static_cast<OWeakObject*>(this)) );
to this:
  throw IOException("xx",
     static_cast<OWeakObject*>(this) );

Change-Id: Ife9f645f0f1810a8e80219126193015502c43dbb
 2014-05-27 08:20:11 +02:00
Julien Nabet b09b5f8f7c Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19 
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
 2014-05-22 23:21:18 +02:00
Thomas Arnhold 2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left 
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-05-15 12:50:46 +00:00
Stephan Bergmann c23bcc2331 Missing include 
Change-Id: I2e04a61cc682fd6390571807c547a713d224d32b
 2014-04-09 09:57:30 +02:00
Noel Grandin 718ec66252 animations: sal_Bool->bool 
Change-Id: I77d10e56389042dd3caa8ed4816afe9f3baf5b22
 2014-04-07 13:53:48 +02:00
Stephan Bergmann 70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
 2014-03-26 16:39:26 +01:00
Stephan Bergmann 557c0893f2 animations: simplify deprecated XTypeProvider.getImplementationId 
Change-Id: If677c147011799872cf5da2d148aacceebf5df42
 2014-03-10 17:39:52 +01:00
Marcos Paulo de Souza b8183958e6 fdo#60698: Split out slideshow code from animations 
Also remove the TargetPropertiesCreator service since just slideshow uses this.

Change-Id: I80816f6225b7bd9fb18f48e69eb5dfd6709b6e56
 2014-03-10 09:15:54 +01:00
Stephan Bergmann 5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexander Wilms f72ba18320 Remove visual noise from animations 
Change-Id: I45b8019bebf6530136642bf34be829d7e26e2454
Reviewed-on: https://gerrit.libreoffice.org/8228
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-25 16:20:02 +00:00
Alexander Wilms 0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Julien Nabet a4285867cd Typo: atribute(s) -> attribute(s) 
Change-Id: I5434402e372c4567b2c3f96f5c175618ba3e5cfb
 2014-02-06 21:32:04 +01:00
Caolán McNamara 8bc81f6f16 Related: fdo#69645 don't know if mxParent could become invalid.. 
after get and before call through mpParent. Probably can't, but
I don't know for sure.

Change-Id: Ib40e0709f1966687a37cc5b84bae1d554a5b4474
 2014-02-04 12:01:20 +00:00
Alexandre Vicenzi f9369d33a4 fdo#54938 Convert to cppu::supportsService 
Change-Id: I512c525029ebd63d261560d27e9f38bbe94f7e10
Reviewed-on: https://gerrit.libreoffice.org/7649
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Souza <marcos.souza.org@gmail.com>
 2014-02-03 14:35:46 +00:00
Stephan Bergmann 9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..." 
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
 2013-12-17 11:06:00 +01:00
Noel Grandin 2c35fff7ec remove most use of RTL_CONSTASCII_USTRINGPARAM macro 
This is largely unnecessary when working with OUString

Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
 2013-11-19 10:29:30 +02:00
Caolán McNamara 1563162131 Resolves: fdo#69645 Parent Node disposed and mpParent pointing to junk 
mpParent points the contents of mxParent which is a WeakReference, so
we can check if the WeakReference is still valid before using mpParent

Change-Id: I40424714865e506b8cf27017539795eb834e10d2
 2013-11-05 11:47:39 +00:00