Commit Graph
27 Commits
Author SHA1 Message Date
Noel Grandin 4b40797585 clang-tidy modernize-concat-nested-namespace in sd
Change-Id: I805cc225420de46d1fa7cbfcc22468e00cb5f5ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86805
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-15 06:58:44 +01:00
Arkadiy Illarionov 1d398fb983 tdf#39593 use getUnoTunnelImplementation
Change-Id: I78eb67913a568c610e38e5002f914773c4906dfd
Reviewed-on: https://gerrit.libreoffice.org/79350
Tested-by: Jenkins
Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-09-23 15:47:12 +02:00
Arkadiy Illarionov 038e4b3b1e Use hasElements to check Sequence emptiness in sax..sdext
Similar to clang-tidy readability-container-size-empty

Change-Id: If6a567708d3c59355d54933fad23c85195846624
Reviewed-on: https://gerrit.libreoffice.org/71763
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-12 14:18:12 +02:00
Gabor Kelemen 1d61d9ae72 tdf#42949 Fix IWYU warnings in sd/source/ui/f*
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I07d78df2d5aacbdaff7344a09812db91de17d535
Reviewed-on: https://gerrit.libreoffice.org/71113
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-24 12:28:09 +02:00
Noel Grandin 86e5ec2e5f loplugin:flatten in sd/source/ui/framework
Change-Id: Id1da25f6ee6ee867e93e0b4c58b6429e07b12429
Reviewed-on: https://gerrit.libreoffice.org/67834
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15 09:48:47 +01:00
Noel Grandin ccb2a1f650 clang-tidy readability-redundant-smartptr-get
redundant get() call on smart pointer

Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd
Reviewed-on: https://gerrit.libreoffice.org/61837
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17 08:25:47 +02:00
Gabor Kelemen 14198f2191 tdf#42949 Remove unnecessary localization headers from sd
Found by searching for the header names and the localization function:
git grep -l -e \<sdresid.hxx\> -e \<strings.hrc\> sd | xargs grep -c SdResId | grep :0$ | grep -v /pch

Change-Id: Ibcd9b8403c398ec205c9bcc2ed1f04a7ef6a37aa
Reviewed-on: https://gerrit.libreoffice.org/52199
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-03 09:40:49 +02:00
Stephan Bergmann 3784e4d5ef loplugin:includeform: sd
Change-Id: I4b75316c8644a591e6d1cfab4945ef123f945b53
2017-10-23 22:45:55 +02:00
Noel Grandin dafae0fe31 loplugin:constparams in sd
Change-Id: I833c6da99d5ccb8f6a8b5c905bee73b75fde0a89
Reviewed-on: https://gerrit.libreoffice.org/40700
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-03 11:06:54 +02:00
Noel Grandin d7e06e46ac use more OUString::operator== in scaddins..sdext
Change-Id: I8bc5c925f940283bc54698bbcba77efcca883273
Reviewed-on: https://gerrit.libreoffice.org/39937
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-14 10:12:31 +02:00
Stephan Bergmann e57ca02849 Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26 12:54:43 +00:00
Stephan Bergmann 92c697c0e3 loplugin:nullptr (automatic rewrite)
Change-Id: If1b80da64ba575f07b31dce9bc0e34b7eb9f11a4
2015-11-10 10:31:38 +01:00
Noel Grandin 1d67ca08da use uno::Reference::set method instead of assignment
Change-Id: Ib224c60d3e5afc968bf4ef5ff58c3a71893b811c
2015-11-05 07:41:29 +02:00
Caolán McNamara 177ea7a281 boost::shared_ptr->std::shared_ptr
Change-Id: I2c6ac98f0984534894759cfbf4449eb554801cf8
Reviewed-on: https://gerrit.libreoffice.org/18678
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-23 11:19:17 +00:00
Caolán McNamara d030c4a2a5 revert for mac and win unit case crashes after boost->std
Change-Id: I82c7084f203a834c2d42f9527705288e6036019b
2015-09-17 18:59:32 +01:00
Caolán McNamara 6f495a195b boost->std
Change-Id: I1e6a7fd66f90e6acd803c6cd464f1d73252f7bcb
2015-09-17 17:01:14 +01:00
Noel Grandin 71b809959b remove unnecessary use of void in function declarations
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
Markus Mohrhard ed6b8a100c remove whitespaces
Change-Id: I9daea42a433b5032931a722878874917cf37f4d1
2014-06-25 05:41:09 +02:00
Stephan Bergmann 5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Luboš Luňák 1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Michael Meeks b9042fad7c re-base on ALv2 code.
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00
Norbert Thiebaud 2a71139535 remove include of pch header from sd 2011-11-27 13:20:56 -06:00
Sebastian Spaeth 80b0861510 Add vim/emacs modelines to all source files
Fixes #fdo30794
Based on bin/add-modelines script (originally posted in mail
1286706307.1871.1399280959@webmail.messagingengine.com)

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-10-13 10:57:43 +02:00
Jens-Heiner Rechtien 9e19ff00c7 changefileheader2: #i109125#: change source file copyright notice from Sun Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision) 2010-02-12 15:01:35 +01:00
Rüdiger Timm c91fecfeba INTEGRATION: CWS changefileheader (1.2.234); FILE MERGED
2008/04/01 12:38:47 thb 1.2.234.2: #i85898# Stripping all external header guards
2008/03/31 13:58:01 rt 1.2.234.1: #i87441# Change license header to LPGL v3.
2008-04-10 19:07:34 +00:00
Kurt Zenker a451882d23 INTEGRATION: CWS presenterview (1.2.22); FILE MERGED
2007/07/10 14:24:33 af 1.2.22.2: #i18486# Converted several members of ViewShellBase to shared_ptrs.
2007/06/19 08:01:42 af 1.2.22.1: #i18486# Adaption to recent framework API changes.
2008-04-03 12:37:17 +00:00
Rüdiger Timm 0afc9e9816 INTEGRATION: CWS components1 (1.1.2); FILE ADDED
2007/03/07 15:44:03 af 1.1.2.9: #i75051# Using getFirstViewForAnchor() instead of getView().
2007/01/29 15:27:01 af 1.1.2.8: #68075# Resolved resync problems.
2007/01/22 15:12:57 af 1.1.2.7: #i68075 Introduction of XResourceId interface.
2006/11/01 13:15:16 af 1.1.2.6: #i70929# Adaption to changes in ViewShellBase.
2006/10/09 13:07:16 af 1.1.2.5: #i68075# Listening for ResourceActivationEvent.
2006/09/07 16:26:11 af 1.1.2.4: #i68075# Transition from URL to ResourceId.
2006/09/07 14:46:31 af 1.1.2.3: #i68075# Transition from URL to ResourceId.
2006/08/28 14:32:28 af 1.1.2.2: #i68075# Fixed compiler problems.
2006/08/18 14:06:59 af 1.1.2.1: #i68075# Initial revision.
2007-04-03 14:50:35 +00:00