Commit Graph
41 Commits
Author SHA1 Message Date
Caolán McNamara ac396f2f6b fix coverity parse errors
Change-Id: I3a1179947704452e3ffec02be59d0f7bf0b75ab0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109017
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-09 13:01:49 +01:00
Stephan Bergmann a3d0091d18 New loplugin:stringliteralvar
See the comment at the top of compilerplugins/clang/stringliteralvar.cxx for
details.

(Turned some affected variables in included files into inline variables, to
avoid GCC warnings about unused variables.)

Change-Id: Ie77219e6adfdaaceaa8b4e590b08971f2f04c83a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108239
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-26 14:51:15 +01:00
Stephan Bergmann 0cdcb21c90 Upcoming improved loplugin:staticanonymous -> redundantstatic: chart2
Change-Id: If4e61fdcf1749b2900512ae788422c435ae6af0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97541
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30 22:57:53 +02:00
Noel Grandin db54dd2351 clang-tidy modernize-concat-nested-namespace in chart2
Change-Id: I320234b60963d80f6870a9ce1fead8e29de437aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86759
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-14 18:09:25 +01:00
Stephan Bergmann 2d447ddc7a Improved loplugin:stringconstant (now that GCC 7 supports it): chart2
Change-Id: I9fb8e2853b5ddb1f9fe589f4e47828025ea52915
Reviewed-on: https://gerrit.libreoffice.org/76692
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-31 13:00:34 +02:00
Gabor Kelemen d9e0eade62 Remove unused using declarations in directories [a-d]*
Found with:
run-clang-tidy-7 -checks=-*,misc-unused-using-decls

Change-Id: I50f6dfa881ac4e752668e762ade0943aaf28ab96
Reviewed-on: https://gerrit.libreoffice.org/69601
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-27 10:44:44 +01:00
Gabor Kelemen 60706b01d1 tdf#42949 Fix IWYU warnings in chart2/source/model/*cxx
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ic4fdbad7469d506d7cf308cb96f069b781dd1f58
Reviewed-on: https://gerrit.libreoffice.org/61488
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-08 14:00:17 +02:00
Gabor Kelemen f50eb2d12e tdf#42949 Fix IWYU warnings in chart2/source/model/inc/
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here
and a bit of fallout management.

Change-Id: I2833ac36c359df76f46e7aa973c012a4d7cedc84
Reviewed-on: https://gerrit.libreoffice.org/54872
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-28 10:04:03 +02:00
Noel Grandin 48251502a8 loplugin:unusedfields
Change-Id: I84a7bcb891548416f0e1f1b20059f9b20c890d4c
Reviewed-on: https://gerrit.libreoffice.org/46686
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19 11:32:50 +01:00
Noel Grandin 3af500580b loplugin:salcall fix functions
since cdecl is the default calling convention on Windows for
such functions, the annotation is redundant.

Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d
Reviewed-on: https://gerrit.libreoffice.org/46164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-11 12:13:46 +01:00
Noel Grandin c4abbb6e10 inline ASSERT_EXCEPTION macro in chart2
Change-Id: I6bdcde5fd416531e2cdd3c9ec160833f1022247c
Reviewed-on: https://gerrit.libreoffice.org/44246
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-03 13:03:13 +01:00
Stephan Bergmann d63b706dad loplugin:includeform: chart2
Change-Id: I5b455c684e7cd689d5160135246f3400363c7d40
2017-10-23 22:46:12 +02:00
Stephan Bergmann e57ca02849 Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26 12:54:43 +00:00
Noel Grandin 22d0d2455f loplugin:expandablemethods in chart2
Change-Id: Ie6650628683ec7c67359351eec0e09033f2b50cb
Reviewed-on: https://gerrit.libreoffice.org/30750
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-11 06:59:15 +00:00
Noel Grandin b7914a9a56 loplugin:oncevar in chart2
Change-Id: Id9308f9265c2453075971c8105b4d161bd145da7
Reviewed-on: https://gerrit.libreoffice.org/30654
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07 11:54:20 +00:00
Muhammet Kara e50a95b829 tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctor
in chart2 module

Change-Id: I9c6f2efd59b3796e0e6f5389467fe888f4465586
Reviewed-on: https://gerrit.libreoffice.org/27895
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05 12:45:48 +00:00
Noel Grandin e5dd156a44 loplugin:constantparam
Change-Id: Ie690088d7a7d568703afd22f544628fc8012a7e1
2016-04-11 08:26:01 +02:00
Noel Grandin a7ec6c29aa loplugin:constantparam in chart2
Change-Id: I9adcf4516107aaa960463be13090c2ac15685e09
Reviewed-on: https://gerrit.libreoffice.org/23833
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-05 11:30:13 +00:00
Noel Grandin 96c26b0d9d use initialiser for Sequence<OUString>
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"

Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15 12:20:39 +00:00
Ursache Vladimir 917bd2350c Use constructors for services from chartcore.component.
Change-Id: I72227b45f305734060a669275044f6f9c8859bc5
2015-02-12 18:11:37 +01:00
Noel Grandin 360f40544d fix build under gcc
after my commit feb92a5
"inline some strings, they don't need to be in a shared header file"

Change-Id: I60a6fa11d56f3d4648dbedeca062ab27206f2a02
2014-12-09 13:29:12 +02:00
Noel Grandin feb92a5f3c inline some strings, they don't need to be in a shared header file
Change-Id: I058489d207510024ce722c4d03f9aac628b120b5
2014-12-09 12:55:38 +02:00
Noel Grandin c227d963d8 inline UNO helper macros
Change-Id: Ia401dd2f51108d2f3b08cd3d6d433a12ac17ee74
2014-12-09 12:55:38 +02:00
Noel Grandin 705c48d32e fdo#38835 strip out OUString globals
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.

Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-05 08:44:19 +02:00
Noel Grandin 329332ba52 chart2: sal_Bool->bool
Change-Id: I85751b4e636596ef88ef02bc958abdc6abf98427
2014-04-15 15:23:29 +02:00
Stephan Bergmann 5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Jelle van der Waa dd9c97d587 fdo#62475 removed pointless comments
Change-Id: I3f5e86dba2df950aeb12c895f52d99274c0959aa
Reviewed-on: https://gerrit.libreoffice.org/5148
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-07-29 11:34:33 +00:00
Luboš Luňák 1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Krisztian Pinter d05287a9f1 RTL_CONSTASCII_USTRINGPARAM removals
Removed all occurences of RTL_CONSTASCII_USTRINGPARAM in chart2.

Change-Id: I0ab188e2d67a5fc17a3653e5213031f6e2c2581d
Reviewed-on: https://gerrit.libreoffice.org/2244
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-02-20 22:58:20 +00:00
Jean-Noël Rouvignac 97eb8a6e0e Removed several useless macros: A2OU, A2S, C2U, C2S, OUSTR, OUSTRING
Change-Id: Ie859cb2dfdc7103c379fce56be88eef8fe390afd
Reviewed-on: https://gerrit.libreoffice.org/1924
Tested-by: Luboš Luňák <l.lunak@suse.cz>
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-30 12:54:40 +00:00
Michael Meeks b9042fad7c re-base on ALv2 code.
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00
Norbert Thiebaud 6da8379e14 remove include of pch header in chart2 2011-11-27 12:59:19 -06:00
Sebastian Spaeth 63bb42ab7d Add vim/emacs modelines to all source files
Fixes #fdo30794
Based on bin/add-modelines script (originally posted in mail
1286706307.1871.1399280959@webmail.messagingengine.com)

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-10-13 10:57:18 +02:00
Jens-Heiner Rechtien 4573ccfffd changefileheader2: #i109125#: change source file copyright notice from Sun Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision) 2010-02-12 15:01:35 +01:00
Rüdiger Timm 9fd079250c INTEGRATION: CWS changefileheader (1.6.126); FILE MERGED
2008/03/28 16:44:05 rt 1.6.126.1: #i87441# Change license header to LPGL v3.
2008-04-10 20:32:53 +00:00
Vladimir Glazounov dff74ff249 INTEGRATION: CWS chart2mst3 (1.3.4); FILE MERGED
2006/10/18 17:09:41 bm 1.3.4.6: RESYNC: (1.4-1.5); FILE MERGED
2006/04/11 15:41:32 bm 1.3.4.5: make creation of coordinate systems available via factory
2005/10/13 17:38:56 iha 1.3.4.4: renamed BoundedCoordinateSystem to CoordinateSystem
2005/10/07 11:51:29 bm 1.3.4.3: RESYNC: (1.3-1.4); FILE MERGED
2004/09/15 17:32:01 bm 1.3.4.2: API simplification
2004/04/01 10:53:06 bm 1.3.4.1: XChartType: may return a coordinate system now
2007-05-22 17:31:53 +00:00
Oliver Bolte d8b259570f INTEGRATION: CWS pchfix02 (1.4.80); FILE MERGED
2006/09/01 17:18:42 kaib 1.4.80.1: #i68856# Added header markers and pch files
2006-09-17 12:10:18 +00:00
Rüdiger Timm 1fbc7c592e INTEGRATION: CWS ooo19126 (1.3.110); FILE MERGED
2005/09/05 18:43:02 rt 1.3.110.1: #i54170# Change license header: remove SISSL
2005-09-07 23:53:45 +00:00
Björn Milcke 3fe1d17a07 drafts namespace of API removed
public API moved to offapi
Calc as DataEditor - first integration
2004-01-26 08:13:31 +00:00
Ingrid Halama b064ca8aa9 introduced polarcoordinate system + axis + grids + some cleanup 2004-01-17 12:10:08 +00:00
Björn Milcke 668c6b0245 initial import 2003-10-06 08:58:36 +00:00