At least the unrelated
<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/132372/> was killed
after 20 minutes of no stdout/-err activity, with CppunitTest_sc_opencl_test
still running. From its captured state, it looks like it was indeed still
making progress rather than being stuck: During
ScOpenCLTest::testLogicalFormulaXor, the main thread was waiting at
ScFormulaCell::InterpretFormulaGroupThreading ->
comphelper::ThreadPool::waitUntilDone, while four
comphelper::ThreadPool::ThreadWorker threads were each at
> #4 0x00007f70652f9234 in __gnu_debug::_Safe_iterator_base::_M_detach() () at /lib64/libstdc++.so.6
> #5 0x00007f7048d3e8e5 in __gnu_debug::_Safe_iterator_base::~_Safe_iterator_base() (this=0x7f703daa9f20) at /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/debug/safe_base.h:100
> #6 0x00007f7048d5d709 in __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<mdds::mtv::base_element_block* const*, std::__cxx1998::vector<mdds::mtv::base_element_block*, std::allocator<mdds::mtv::base_element_block*> > >, std::__debug::vector<mdds::mtv::base_element_block*, std::allocator<mdds::mtv::base_element_block*> > >::~_Safe_iterator() (this=0x7f703daa9f18) at /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/debug/safe_iterator.h:86
> #7 0x00007f7048d5d6cd in mdds::mtv::soa::detail::iterator_updater<mdds::mtv::soa::multi_type_vector<sc::CellStoreTraits>::const_iterator_trait>::grouped_iterator_type::~grouped_iterator_type() (this=0x7f703daa9ec8) at workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/./iterator.hpp:74
> #8 0x00007f7048d5d69d in mdds::mtv::soa::detail::iterator_updater<mdds::mtv::soa::multi_type_vector<sc::CellStoreTraits>::const_iterator_trait>::~iterator_updater() (this=0x7f703daa9e98) at workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/./iterator.hpp:55
> #9 0x00007f7048d5d665 in mdds::mtv::soa::detail::const_iterator_base<mdds::mtv::soa::multi_type_vector<sc::CellStoreTraits>::const_iterator_trait, mdds::mtv::soa::detail::iterator_base<mdds::mtv::soa::multi_type_vector<sc::CellStoreTraits>::iterator_trait> >::~const_iterator_base() (this=0x7f703daa9e98) at workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/./iterator.hpp:309
> #10 0x00007f704900b9bd in ScValueIterator::GetThis(double&, FormulaError&) (this=0x7f703daaa078, rValue=@0x7f703daaa1f8: -18.819375178914722, rErr=@0x7f703daaa1f6: NONE) at sc/source/core/data/dociter.cxx:141
> #11 0x00007f704900c652 in ScValueIterator::GetNext(double&, FormulaError&) (this=0x7f703daaa078, rValue=@0x7f703daaa1f8: -18.819375178914722, rErr=@0x7f703daaa1f6: NONE) at sc/source/core/data/dociter.cxx:297
> #12 0x00007f70496c3619 in ScInterpreter::ScXor() (this=0x48b93a0) at sc/source/core/tool/interpr1.cxx:1525
with three of them apparently waiting in pthread_mutex_lock but one in
pthread_mutex_unlock (and thus presumably making progress). It looks like with
a debug-mode libstdc++ these worker threads can easily compete for these
listdc++-internal debug-mode mutices. And execution of --enable-dbgutil
CppunitTest_sc_opencl_test on my Linux laptop under load easily took 35 minutes,
so it looks plausible that that unit test was just too big.
While splitting it in two (arbitrarily taking the first and second half of the
CPPUNIT_TEST list), use the opportunity to drop the redundant "_test" from the
two new target names CppunitTest_sc_opencl-1 and CppunitTest_sc_opencl-2.
Change-Id: I9b8f148db667ff9bbf1aacdcaf150e5cb9b8ae87
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146252
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
so Jenkins executes it in all platforms
also move it out of 'extra' folder so we can change the
inheritance to ScBootstrapFixture in a follow-up commit
Change-Id: I06cb594b7f13ece2eb71c2099b6119861b4674ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141504
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
This introduces a couple helper base classes for implementing
accessibility tests more easily, and includes a few tests as examples,
including basic document layout check and minimal UI interaction
through menus.
Change-Id: I8961af8be1e7d52dc55fe27c758806d9b4c3c5d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137337
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
it only contains one test and it does the same as
CppunitTest_chart2_xshape, so just move the test there.
I don't know whether ScChartRegressionTest::test was ever
executed but the reference needs to be adapted
Change-Id: I0447054d8692901c72a36be5f582723334d2acba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136737
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
The .cxx are already separated, use a different
makefile for vba-macro-test.cxx
This might help to mitigate the CppunitTest_sc_macros_test
failure happening in Jenkins on Windows
Change-Id: I5708de3527041a5fcb33287f75f0e14642a88c4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135862
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
On 32bit platforms tools::Long is 32bit, which is not enough
for pixel coordinates with 1m+ Calc rows+. So do not allow jumbo
sheets for such platforms.
Change-Id: I2ebd56a051470d33fca967918af3e7d2b0172dc7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130713
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
This reverts commit 6cb20e0b29, now that the test
failures have been identified as caused by -ffp-contract being enabled, and have
been addressed with 19559ebbee "Allow for a
presumably more precise result of BESSELY(80,9)",
04215f0349 "Allow for presumably more precices
results of some more Calc function calls", and
72b2561996 "For now, disable tests giving dubious
results on AArch64".
Change-Id: I78f9ddb04362d4026a272db0b8bbf4717fd75093
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126737
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Unfortunatly we cannot add --disable-scripting to
sub_conf_defaults, because Java currently has no
equivalent to the PYTHON_FOR_BUILD setting.
Change-Id: I89938a17307a363f5de808200914940503312829
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126186
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
in order to split sc_ucalc monster into smaller
modules
Now, we can change CppunitTest_sc_ucalc.mk to
use the template
- Enable testExternalRefUnresolved on Linux/Mac
- Remove testFormulaHashAndTag. it was disabled in
f4dc8a869a
< the idea behind the test can't work right now >
Change-Id: I864341442ccd321c8ef4f7147db4512bcc7a6b21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115595
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
in order to split sc_ucalc monster into smaller
modules
While at it, fix the clang-format issues in
sc/qa/unit/ucalc_copypaste.cxx
Change-Id: Ifd3af351f4b880da29e1f48c4852ac65fcd3276e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115696
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
in order to split sc_ucalc monster into smaller
modules
While at it, remove testCopyPasteSkipEmptyConditionalFormatting
it was added already disabled in 5915d38e84
<add disabled test for conditional formatting with skip empty cells>
and it fails if it's enabled
Change-Id: I6222849b38ab288b24432dc00698d72f5bcc5c2e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115677
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
this way, Jenkins executes this module on Windows and Mac as well.
Before I submitted this test, I ran
'make clean && make CppunitTest_sc_macros_test' on a Win machine
Change-Id: If84ea0ba5f7376f9cfe62836eb469e4c9e7ea44a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109994
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
and sort the list
this way, Jenkins executes this module on Windows and Mac as well.
Before I submitted this test, I ran
'make clean && make CppunitTest_sc_uicalc' on a Win machine
Change-Id: I906255bcf82e19917036aa3e99344f9ecf2a26fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109190
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
this way, Jenkins executes this module on Windows and Mac as well.
Before I submitted this test, I ran
'make clean && make CppunitTest_sc_uicalc' on a Win machine
Change-Id: I5bb708e3b61f16c3bd53da2222f19f2b73742819
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109106
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
and use in ScDrawLayer::RecalcPos and in ScDrawView::FitToCellSize().
Error was, that it was assumed, that SdObjCustomShape::SetSnapRect()
changes the shape so, that it fits into the passed rectangle. That is
true for other type of shapes, but not for custom shapes.
Change-Id: Ib00d52087509f459165000abf43c7f244980a01b
Reviewed-on: https://gerrit.libreoffice.org/84216
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
Move XNamed Java tests to C++ for ScStyleObj.
Change-Id: Idaff7307d15ca2665005e866dff36a033aa91354
Reviewed-on: https://gerrit.libreoffice.org/81553
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Test if calc crashes when copying a noncoherent range to the
clipboard
Change-Id: I64d436ffb01775df9d50eb966ea2a12040482517
Reviewed-on: https://gerrit.libreoffice.org/76348
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
Open a dialog, close it by the given button e.g. "cancel" or "close".
If the dialog has an enabled "OK" button open the dialog again
and try to close it also using the OK button.
For every dialog a complete new document is opened to ensure test-separation,
otherwise one action could hamper the next action.
For dialogs that already have other tests a "cancel/close" test was added to
the previous test. As far as possible opening new documents was avoided in those
cases. And in some cases a simple check was added to check if the "cancel" button
does not change anything.
Simmilar tests for calc have been renamed and code dublication has been
removed by moving main part of the code to a helper file
Change-Id: I01f197cae8bc6fe0345661fe042b655f16229485
Reviewed-on: https://gerrit.libreoffice.org/75124
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
Open a dialog, close it by the given button e.g. "cancel" or "close".
If the dialog has an enabled "OK" button open the dialog again
and try to close it also using the OK button.
For every dialog a complete new document is opened to ensure test-separation,
otherwise one action could hamper the next action.
E.g. ".uno:Protect" would hamper any edit action.
For dialogs that already have other tests a "cancel/close" test was added to
the previous test. As far as possible opening new documents was avoided in those
cases. And in some cases a simple check was added to check if the "cancel" button
does not change anything.
Change-Id: I727cad43603770245f27baf752a1985f9a754847
Reviewed-on: https://gerrit.libreoffice.org/74333
Tested-by: Jenkins
Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
Move XPropertSet Java tests to C++ for ScCellSearchObj.
Change-Id: I46e55794fe0b205173c3b208ba84c90d70aa2de0
Reviewed-on: https://gerrit.libreoffice.org/71608
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
mOve XCellRange Java test to C++ for ScTableColumnObj.
Change-Id: I165e5752fb679be6790c305a99f35da644e17d56
Reviewed-on: https://gerrit.libreoffice.org/70968
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Move XPropertySet Java tests to C++ for ScTableRowObj.
Change-Id: Ib448d6440cd6a285cd55297669bb19bd8aec6b07
Reviewed-on: https://gerrit.libreoffice.org/70156
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Correct class name to mirror the name of the object we are testing
against.
Change-Id: If26dc045f67df7725043f1b0ccd0d3c8ba73f4ed
Reviewed-on: https://gerrit.libreoffice.org/70030
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Stephan Bergmann