Commit Graph
496 Commits
Author SHA1 Message Date
Andrea Gelmini c588128993 Fix typo
Change-Id: I9a973141bdefca22dc24ecfaba58803dfc256e15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138239
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2022-08-14 19:43:00 +02:00
Stephan Bergmann 5687eba49f Drop obsolete preprocessor directives from UNOIDL files
...which were used by ildc, which is gone since
a8485d558f "[API CHANGE] Remove deprecated idlc
and regmerge from the SDK", and have always been ignored as legacy by its
unoidl-write replacement.

This change has been carried out (making use of GNU sed extensions) with

> for i in $(git ls-files \*.idl); do sed -i -z -E -e 's/\n\n((#[^\n]*\n)+\n)*(#[^\n]*\n)+\n?/\n\n/g' -e 's/\n(#[^\n]*\n)+/\n/g' "$i"; done && git checkout extensions/source/activex/so_activex.idl odk/examples/OLE/activex/so_activex.idl

which apparently happened to do the work.  (The final two files are not UNOIDL
source files.)

Change-Id: Ic9369e05d46e8f7e8a304ab01740b171b92335cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135683
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-13 16:27:45 +02:00
Stephan Bergmann 40f2aee658 Provide unoidl-write also for the SDK
...after the new types.rdb format that unoidl-write generates has been used
internally since LibreOffice 4.1 in 2013; following up on
6db34b6b33 "Directly build UNOIDL .rdb files from
.idl files" and its "The legacy tools idlc, regcompare, regmerge, and regview
are still contained in the URE or SDK for now."

The tools idlc and regmerge are deprecated but still shipped in the SDK for now.
The plan is to drop them completely for LO 7.5.

odk/examples/ and ure/source/uretest/ are adapted to use unoidl-write instead of
idlc and regmerge:

* unoidl-write does not use a C preprocessor and the # directives in .idl files,
  it supports reading a single .idl file (containing an arbitrary number of
  declarations) or a directory tree where each directory corresponds to a UNOIDL
  module of the same name and each .idl file contains the declaration of the
  (non-module) UNOIDL entity of the same name.  For some of the odk/examples/,
  that required moving individual .idl files into sub-directories named after
  the respective modules.  In odk/settings/std.mk, definitinos of IDL and
  REGMERGE have been replaced with a new UNOIDLWRITE.

* unoidl-write always enforces reserved UNOIDL identifier restrictions (see
  04af4e4f55 "[API CHANGE] Fix all bad UNOIDL
  identifiers across offapi" and 6201792406
  "Enforce the UNOIDL identifier scheme") (which idlc only enforced optionally
  with -cid -we).  That required renaming "my_module" in
  odk/examples/DevelopersGuide/Components/CppComponent/.

* The new types.rdb format is not compatibly with LibreOffice < 4.1.  Clients
  generating extensions containing such files are advised to use appropriate
  LibreOffice-minimal-version elements.

Change-Id: I1a248fd96e86ecbf407f829bc100d44bfe7f4e7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130533
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-02-25 16:46:26 +01:00
Stephan Bergmann 60b32d931d Remove spurious odk/examples/java/MinimalComponent/BuildMinimalComponent.xml
It had been added together with odk/examples/java/MinimalComponent/Makefile in
ff4c86ff37 "Added an example for a minimal UNO
component", and it apparently is an Ant build script that shall do the same as
the Makefile.  However, it is apparently unused:  For one, it does not
appear to get referenced from anywhere else in the code or to get mentioned at
<https://wiki.openoffice.org/wiki/Documentation/DevGuide/OpenOffice.org_Developers_Guide>.
And for another, it would apparently only work on Windows (using e.g.
"${ODKPATH}/windows/bin/idlc.exe"), but would typically fail even there with
something like

> > ant -f BuildMinimalComponent.xml
> Buildfile: C:\lo\core\instdir\sdk\examples\java\MinimalComponent\BuildMinimalComponent.xml
>
> init:
>
> unoidl:
>
> BUILD FAILED
> C:\lo\core\instdir\sdk\examples\java\MinimalComponent\BuildMinimalComponent.xml:35: The directory D:\cvs\api\odk\WINexample.out\misc does not exist

due to the hardcoded D:/cvs/api/odk paths.

Change-Id: Idd020bcf1a2383295704b208d3ac2be047f270ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121050
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-26 10:55:15 +02:00
Stephan Bergmann 15a15c2eb0 Fix corrupted odk/examples/java/ConverterServlet/web.xml
Instead of just adding a license header,
2b4fd2c89a "re-base on ALv2 code" had apparently
erroneously overwritten this file with the content of the completely unrelated
odk/examples/java/MinimalComponent/BuildMinimalComponent.xml.

Change-Id: Iee6dcb528dbb444a132c27e7183b3957319882c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121037
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-25 21:38:17 +02:00
Stephan Bergmann a344462ccb Remove unused DOCTYPE from odk/examples xcu file
The declared entities have apparently never been referenced ever since the
file's introduction in 9fa09d43d0 "INTEGRATION:
CWS sdkinspector2".  (And at least xmlreader skips and ignores the content of
such document type declarations anyway.)

Change-Id: I8263200f52bb5f1692090995574619f9c0ec478f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117658
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-23 06:28:36 +02:00
Andrea Gelmini 86b78dcfb8 Fix typo in code
It passed "make check" on Linux

Change-Id: I255b7a0873170d956c914d76fd363e358f807d7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101596
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-29 11:30:04 +02:00
Andrea Gelmini 9036f75064 Fix typo
Change-Id: I387f408aefc30132a65088bec05c733346e9d5a4
Reviewed-on: https://gerrit.libreoffice.org/84486
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-05 10:08:04 +01:00
Andrea Gelmini fce0104505 Fix typos
Change-Id: Ibc1b7393a8e65bf23c78fdb9da78c6b73b544cf3
Reviewed-on: https://gerrit.libreoffice.org/78793
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-10 11:56:52 +02:00
Andrea Gelmini 0940229305 Fix '..'
To complete this:
https://gerrit.libreoffice.org/#/c/78312/

This is a massive replace for lines ending with
".." instead of "..."

It passed "make check" on Linux.

Change-Id: I07fa7b2e30ba9ea17a1f9a5e21c57216ba958efe
Reviewed-on: https://gerrit.libreoffice.org/78356
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2019-09-01 11:15:11 +02:00
Andrea Gelmini ecada6d169 Fix typo
Change-Id: I46650797efa70d6b416356a3e5ed57d26d8e69be
Reviewed-on: https://gerrit.libreoffice.org/78252
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-29 09:03:17 +02:00
Andrea Gelmini f3261ba748 Fix typos
"its"

Change-Id: I02c660e46964270376a66210fdb5f1b1985ce5b6
Reviewed-on: https://gerrit.libreoffice.org/77255
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12 09:46:21 +02:00
Andrea Gelmini 46ce440cf8 Fix typo 'a SDK'
Partial revert of:
https://gerrit.libreoffice.org/#/c/76028/4

Change-Id: I94173556f1dff21ff47245f8b632411fc8be1ff6
Reviewed-on: https://gerrit.libreoffice.org/76200
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-07-24 11:53:09 +02:00
Andrea Gelmini dd950a6edb Fix typos
Change-Id: Ib361243332b7219c0073c787c378c648e44705f2
Reviewed-on: https://gerrit.libreoffice.org/75487
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-20 22:39:25 +02:00
Andrea Gelmini 2286eb08e7 Fix typos in code
Extracted from https://gerrit.libreoffice.org/#/c/75487/1

Change-Id: I80f9247c5c961a33c0d2c8354ea0524820b33409
Reviewed-on: https://gerrit.libreoffice.org/76028
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-20 22:36:27 +02:00
Andrea Gelmini 718f63002e Fix typos
Change-Id: I6ca53ead2b125618d0aceff05d5fdfa374662799
Reviewed-on: https://gerrit.libreoffice.org/58809
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29 17:10:21 +02:00
Andrea Gelmini b86ef3b7fa Fix typos
Change-Id: I326827c394347cbe9fad242e9da5702cba7a4d95
Reviewed-on: https://gerrit.libreoffice.org/57761
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-22 02:03:13 +02:00
dennisroczek e39c75b05c use https links for api.libreoffice.org and opengrok
Change-Id: I74dd0142562cb8698f19b2715fa1d514f82bd749
Reviewed-on: https://gerrit.libreoffice.org/52262
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-04-02 22:25:53 +02:00
Julien Nabet 840cb33c41 Typos concerning hierarchy
Change-Id: Ied3c6d1513f2181a5f7da2904a0df2f806146cec
Reviewed-on: https://gerrit.libreoffice.org/51465
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-17 18:56:05 +01:00
Tomaž Vajngerl 5b87abe06d Change ODK example to use Graphic property instead of GraphicURL
Change-Id: I0a8b518a62c35da52008668c6e8cc7d0fd74e1d4
Reviewed-on: https://gerrit.libreoffice.org/51105
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-13 00:35:32 +01:00
Andrea Gelmini 4c0735830b Fix typos
Change-Id: Ieef0e3f21eb12cb5b72d39da4bc0a8c60dd0d5ce
Reviewed-on: https://gerrit.libreoffice.org/48545
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-25 08:52:34 +01:00
Julien Nabet facfc2951e Typo: syles->styles
Change-Id: Ia93306eda5e09cc9cae62fc43c472d266ec03bfa
Reviewed-on: https://gerrit.libreoffice.org/47846
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-14 00:29:09 +01:00
Andrea Gelmini 3ee517d480 Fix typos
Change-Id: I6f0eb93ec654e629c8fbe761f000190ea9343103
Reviewed-on: https://gerrit.libreoffice.org/46824
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-20 10:41:32 +01:00
Andrea Gelmini 6e6e5cd3b6 Fix typos
Change-Id: Idc648e4673cca1b1dec8c1f009d52cfa290508ff
Reviewed-on: https://gerrit.libreoffice.org/44895
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-17 22:54:01 +01:00
Andrea Gelmini a26b6c5a37 Fix typos
Change-Id: I7b6c699b46fb71c1f19b5e5548c22a11efe8b864
Reviewed-on: https://gerrit.libreoffice.org/44836
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-16 21:05:44 +01:00
Andrea Gelmini a8f31d5120 Fix typos
Change-Id: I8bdced3fa572074aedabdcfce841adf525ae8b81
Reviewed-on: https://gerrit.libreoffice.org/44710
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Page <aptitude@btconnect.com>
2017-11-15 07:52:19 +01:00
Andrea Gelmini e44c188a73 Fix typos
Change-Id: I879a52820d78d9151ef64dd21612379f617f66e2
Reviewed-on: https://gerrit.libreoffice.org/42726
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-25 12:20:56 +02:00
Noel Grandin 146033f5da spelling instanciate -> instantiate
Change-Id: Ic1393da64328c0dc7e2860334b204139bf537d81
Reviewed-on: https://gerrit.libreoffice.org/38401
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-05 10:11:33 +02:00
Andrea Gelmini 095438e52c Fix typos
Change-Id: I14dca0d55c09187690dc1d94936c40b890ca5cea
Reviewed-on: https://gerrit.libreoffice.org/35637
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25 12:36:37 +00:00
Julien Nabet b5bef1f7d5 Typos
Change-Id: I13020539fe121151e884a90d72d47788fb3ae65c
Reviewed-on: https://gerrit.libreoffice.org/35436
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-19 18:50:33 +00:00
Andrea Gelmini 5bea199bae Fix typos
Change-Id: Ic6c41fbcc36c11a7528cde0986593a39c2d6738b
Reviewed-on: https://gerrit.libreoffice.org/34803
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02 12:39:35 +00:00
Takeshi Abe b4e3c29f8a Fix typo: completelly -> completely
Change-Id: I566c5554bf32ea18121c5a186365b97c91667c5d
2016-07-29 10:07:33 +09:00
Otto Kekäläinen 428e23f4f7 Fix some spelling errors in comments and strings
Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e
Reviewed-on: https://gerrit.libreoffice.org/26883
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-07-04 06:11:36 +00:00
Miklos Vajna 44aefdf90d odk: add missing modelines
Change-Id: I0bd2d761b5a75681c8c3e53664084dd3b8176107
Reviewed-on: https://gerrit.libreoffice.org/25051
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-05-17 09:03:30 +00:00
Andrea Gelmini 64d624b651 Fix typos
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10 14:17:20 +00:00
Andrea Gelmini 34ab9e2e17 Fix typos
Change-Id: I51ed2ccb06ba4ced15cd0b8e23e59a9609f07e93
Reviewed-on: https://gerrit.libreoffice.org/18961
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-10-02 08:45:48 +00:00
Andrea Gelmini 799cc41b53 Fix typos
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0
Reviewed-on: https://gerrit.libreoffice.org/16834
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-07-08 05:48:18 +00:00
Andrea Gelmini 7f73bb5b44 Fix typos
Change-Id: I8e429d1f03aac7c7cdb7ff4b43b3f46d40292510
Reviewed-on: https://gerrit.libreoffice.org/16709
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-03 08:19:04 +00:00
Stephan Bergmann 3b07120a72 Fix CalcAddins example
was broken with 70f56bc22f "java: reduce scope,
make member classes private"

Change-Id: I84a3fafbfdddf6bb04ab7787d344bf50ffd22994
2015-06-17 17:55:30 +02:00
Noel Grandin efd4bfa818 java:regulatize the order of 'final' and public/private
Make the order be 'public static' or 'private static'
Just makes the code nicer to read.

Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2
Reviewed-on: https://gerrit.libreoffice.org/16202
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11 09:34:00 +00:00
Julien Nabet 25d3c618d8 Typo: formated->formatted
Change-Id: Iefd4d375a0dfb36732233852f906c6b85dccc2a5
2015-03-25 21:12:16 +01:00
Noel Grandin ba233e87ef remove unnecessary parenthesis in return statements
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'

Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-23 09:26:58 +02:00
Noel Grandin 7320714922 java: fix non-public UNO implementation classes
which I messed up in commit 70f56bc22f
"java: reduce scope, make member classes private"

Change-Id: I817b2a571e2124f551ccd5c0d8e1099d89f0ec46
2014-12-12 13:41:21 +02:00
Noel Grandin 58eab57648 java: final fields that can be static
found by PMD

Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f
Reviewed-on: https://gerrit.libreoffice.org/13099
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-25 06:06:48 +00:00
Noel Grandin 0063cf2856 java: make fields final where possible
found by PMD

Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-18 12:44:28 +02:00
Andrea Gelmini da40cac540 Fix common typos. No automatic tools. Handmade…
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:04:11 +00:00
Andrea Gelmini 0c0e3e7539 Fixed typos. No automatic tools (sed, and so on).
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f
Reviewed-on: https://gerrit.libreoffice.org/12150
Reviewed-by: Bryan Quigley <gquigs@gmail.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-30 17:16:02 +00:00
Noel Grandin 12b01b920f java: no need to call String.valueOf to append to a String
Change-Id: I5ef45b971d24dde814ab8cbb2e9503d9da4f0d73
2014-10-17 08:26:19 +02:00
Noel Grandin f9be44340a java: use equals() to compare Strings, not ==
Change-Id: Ia41a4899fb82df7b580a020765404c4ef0cddfa2
2014-10-07 13:20:02 +02:00
Stephan Bergmann 28114b8d5d There is no com.sun.star.lib.util.ExceptionHelper
Regression introduced with 6884ef6317 "java: don't
catch and then just rethrow an exception."

Change-Id: I626eaefc7846e152dfb4cc105d665c9ccca68c08
2014-09-16 12:49:30 +02:00