ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
483,285 Commits 3 Branches 3 Tags
8ca611b2125a74cfdb273cfedfa3b94de14f628b
Commit Graph
37 Commits
Author SHA1 Message Date
Caolán McNamara ce89c11c5a pass the column names in as an external argument 
Change-Id: I14ab9e6de0a704076a1c632b6b33aaeabdfc23d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122660
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-09-27 16:37:15 +02:00
Caolán McNamara 138c6e7938 split getUniqueColumnName 
Change-Id: Ibcac473463c02e7ce6f853ac2dcdf953c13c14e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122659
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-09-27 15:42:33 +02:00
Caolán McNamara fefc215592 appendColumns is always called with m_aSelectColumns as 1st arg 
Change-Id: I791c0eef1fda97d21ba9efb170ef226c9a495eed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122658
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-09-27 14:41:50 +02:00
Caolán McNamara b63c5ade35 setSelectColumnName is always called with m_aSelectColumns as 1st arg 
Change-Id: If86c4f48ed7eb6860f461fe905c0628cb9b73043
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122657
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-09-27 13:01:49 +02:00
Noel bb06f51308 loplugin:stringviewparam extend to comparison operators 
which means that some call sites have to change to use
unicode string literals i.e. u"foo" instead of "foo"

Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-11-24 09:45:04 +01:00
Noel Grandin bc059c08d8 use std::optional for this error field 
otherwise when I add source/line to the uno::Exception in an
upcoming change, the message becomes non-empty, and hasErrors()
return true.

I note that we throw SQLException in lots of places without a
message, so it is possible that this change will cause us to notice
errors we previously missed.

Change-Id: Idf7c5b5143e20c992d8d7550043aa2ed875c78b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94108
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-05-13 14:06:49 +02:00
Gabor Kelemen 80aec8ef2a tdf#42949 Fix IWYU warnings in include/connectivity/* 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I02f75be483529ba1f7a6e460e34c4752b4265221
Reviewed-on: https://gerrit.libreoffice.org/68893
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2019-03-12 10:14:54 +01:00
Noel Grandin 4c945b22fc new loplugin:methodcycles 
look for closed cycles of methods i.e. unused code that would not
otherwise be found by the unusedmethods loplugin

Change-Id: I3fb052132d97aabca573bb8e9fc424201b1e2042
Reviewed-on: https://gerrit.libreoffice.org/60875
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-09-21 18:44:29 +02:00
Noel Grandin 9a831a6c19 remove no longer necessary operator new/delete overrides 
and use "using" statements for the places where the overrides were
resolving ambiguities

Change-Id: Icb1d1a41f19e00f28a19947aa2c40bd5778fff94
Reviewed-on: https://gerrit.libreoffice.org/52993
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-04-17 09:09:33 +02:00
Andrea Gelmini f0b857310d Fix typos 
Change-Id: Ia976371bf52eb1216d8abe728d80bbb87a3c38a2
Reviewed-on: https://gerrit.libreoffice.org/47858
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-01-16 14:23:52 +01:00
Andrea Gelmini 866fc4ddd3 Fix typos 
Change-Id: Icc5fc590a6a90e30afa5f61028d4dd0279fbe120
Reviewed-on: https://gerrit.libreoffice.org/47861
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-01-14 16:40:13 +01:00
Noel Grandin dd0dceb511 loplugin:salcall handle static methods 
Change-Id: Id6820abec4b8ca8bee26d62b333fd30b42a14aec
Reviewed-on: https://gerrit.libreoffice.org/46007
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-07 11:25:55 +01:00
Noel Grandin ded02dafbc loplugin:finalclasses in connectivity 
Change-Id: I0cd075efad83c0a8d6f05c91201a9aa86649590b
Reviewed-on: https://gerrit.libreoffice.org/44386
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-07 10:35:19 +01:00
Noel Grandin 30f7ce30c9 loplugin:constparams in connectivity 
Change-Id: I9b81c6227fb3c89a832640058a11444f72019694
Reviewed-on: https://gerrit.libreoffice.org/40155
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-19 09:35:59 +02:00
Stephan Bergmann 6cb9e6dad7 Remove redundant 'inline' keyword 
...from function definitions occurring within class definitions.  Done with
a rewriting Clang plugin (to be pushed later).

Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8
Reviewed-on: https://gerrit.libreoffice.org/34874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-03-03 20:55:50 +00:00
Noel Grandin 0d05173015 loplugin:constantparam 
Change-Id: Iced8ff99d52d55e6b6c3126affafbea6786e94f0
Reviewed-on: https://gerrit.libreoffice.org/30858
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-15 12:56:26 +00:00
Noel Grandin 5c2c2d8dc4 loplugin:expandablemethods in comphelper..cppuhelper 
Change-Id: I9d5487af4729bd3ee4f6450092e4b77f74a12e6d
Reviewed-on: https://gerrit.libreoffice.org/30717
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-10 06:51:53 +00:00
Noel Grandin e4cb0742c8 loplugin:expandablemethodds in include/connectivity..drawinglayer 
Change-Id: Ic58f86422ef8f1e2bb655157850e214fc3a1a9b4
Reviewed-on: https://gerrit.libreoffice.org/30136
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-23 12:09:33 +00:00
Noel Grandin ef26856260 loplugin:passstuffbyref in connectivity 
Change-Id: I751977ecc1b532f72dd5673767471cb0a2cdbd06
 2016-04-13 13:27:51 +02:00
Noel Grandin aa0a20bdcc convert TraversalParts to scoped enum 
Change-Id: I34797d6ccdf8b9c75004c129056f3a09f169e1b4
 2016-02-25 13:50:25 +02:00
Noel Grandin d6c28b11e5 convert OSQLStatementType to scoped enum 
Change-Id: I2df117cf0f405e88899e7ccab380156284720449
 2016-02-25 13:50:25 +02:00
Stephan Bergmann c0bd59c15b loplugin:nullptr (automatic rewrite) 
Change-Id: Iefeeb51c2b101c097a8d77a4625f84baf1f2da44
 2015-11-10 10:31:20 +01:00
Noel Grandin c7e8f21a53 loplugin:unusedmethods 
Change-Id: Id3b5cd75d4357336ed592ef11a3f34d209f8e95f
Reviewed-on: https://gerrit.libreoffice.org/19636
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-30 05:58:41 +00:00
Noel Grandin 12c4c9cbf3 com::sun::star->css in include/connectivity 
Change-Id: I74920b46144dbdde6abf9cf267fa508a3faea0ce
Reviewed-on: https://gerrit.libreoffice.org/19460
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-20 07:05:55 +00:00
Stephan Bergmann bff4c13475 Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code 
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
 2015-10-12 17:52:26 +02:00
Caolán McNamara a29d82d873 error C2039: ´getCreateColumns´ used in mozab/MStatement.cxx 
Change-Id: Ie1fb9718e094f02fe99a47f9fa8bd9f8db2be733
 2015-08-07 17:21:23 +01:00
Noel Grandin 403c13487c loplugin:unusedmethods 
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba
Reviewed-on: https://gerrit.libreoffice.org/17506
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-08-05 09:39:22 +00:00
Noel Grandin 6d5ae48427 loplugin:staticmethods 
Change-Id: I200fdb2e193127f0c9e8cec4859845d3ec19cea0
 2015-04-23 13:08:47 +02:00
Stephan Bergmann c6be3cf03b loplugin:deletedspecial 
Change-Id: I0faa47383f8952a74742a640ab2af602b4fcba8f
 2015-02-07 12:35:57 +01:00
Stephan Bergmann 43c47c6105 connectivity: std::auto_ptr -> std::unique_ptr 
Change-Id: I796dc05d1846f140a56b5a6f14a69a239324ae5b
 2014-09-25 08:40:12 +02:00
Noel Grandin 11383f56fb connectivity: remove SAL_THROW macro 
Change-Id: Id3bbb7a0d39a41b7106303f42d55ba4968235b63
 2014-06-05 08:17:47 +02:00
Noel Grandin 39d3f2bb3a connectivity: sal_Bool->bool 
Change-Id: Ice855d69c70d4f5fc119ddf1ddebf18ee6add270
 2014-04-01 07:38:09 +02:00
Norbert Thiebaud aff270d89a fdo#65108 inter-module includes <> 
Change-Id: I338b2f923a31058dc7a3a9a4dcefba52109aa3b0
 2013-11-09 18:48:39 -06:00
Thomas Arnhold 0bd7f12d41 fixincludeguards.sh: include/c* 
Change-Id: Icba422d99836518a1b662b15144bc9334bed1473
 2013-10-23 23:22:30 +02:00
Lionel Elie Mamane 7b4b3ad8c6 Don't clobber argument on failure 
Change-Id: I709305d4ec3c37d3fc1c2c911551174f8cfbb883
 2013-09-13 12:08:03 +02:00
Lionel Elie Mamane 40370f759c ORDER BY columns are prioritarily *SELECT* columns 
as opposed to *table* columns,
and notwithstanding HSQLDB 1.8 (our embedded database) bugs.
Actually, supporting ORDER BY on non-select (but table) columns is OPTIONAL for DBMSs
(but quite common)

Change-Id: I6725dfda36b09429a78262bff6f3d3e3dd9032b6
 2013-07-11 17:53:30 +02:00
Bjoern Michaelsen b9337e22ce execute move of global headers 
see https://gerrit.libreoffice.org/#/c/3367/
and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details

Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
 2013-04-23 22:20:31 +02:00