ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
483,285 Commits 3 Branches 3 Tags
8ca611b2125a74cfdb273cfedfa3b94de14f628b
Commit Graph
277 Commits
Author SHA1 Message Date
Stephan Bergmann 19691c3b68 Revert all the recent loplugin:unocast changes 
...as obsoleted by ef53355355 "Rudimentary support
for dynamic_cast on UNO proxy objects".

This reverts all of:
4cfcc9ac37 "loplugin:unocast (framework::Desktop)"
03efbf72f4 "loplugin:unocast
 (vclcanvas::TextLayout)"
80099fdd51 "loplugin:unocast (SalGtkXWindow)"
cc147f576d "loplugin:unocast
 (sdext::presenter::CachablePresenterView)"
40db42be1d "loplugin:unocast
 (vclcanvas::CanvasFont)"
2d1e7995ea "loplugin:unocast (CairoColorSpace)"
4c0bbe4bd9 "loplugin:unocast
 (canvas::ParametricPolyPolygon)"
8980366662 "loplugin:unocast
 (vclcanas::CanvasBitmap)"
d5e0c2c8db "loplugin:unocast
 (sfx2::DigitalSignatures)"
c0c4519e0d "loplugin:unocast
 (VCLXAccessibleComponent)"
feb8b833a6 "loplugin:unocast (VCLXDialog)"
1fa58cc6cc "loplugin:unocast (VCLXMultiPage)"
f481f036de "loplugin:unocast
 (DocumentSettingsSerializer)"
73df933f5f "loplugin:unocast
 (css::embed::EmbeddedUpdate)"
420165ab0e "loplugin:unocast
 (canvas::tools' StandardColorSpace, StandardNoAlphaColorSpace)"
9abe8ee067 "loplugin:unocast (MutableTreeNode)"
9f3022ceb0 "loplugin:unocast (VCLXTabPage)"
1be70dda02 "loplugin:unocast
 (vcl::unotools::VclCanvasBitmap)"
d6a70bb641 "loplugin:unocast
 (basegfx::unotools::UnoPolyPolygon)"
5a14f009e6 "loplugin:unocast
 (xmlsecurity::Certificate)"
99009c9535 "loplugin:unocast (sd::Annotation)"
0c7585c5fa "loplugin:unocast (sd::TextApiObject)"
24e14afd1b "loplugin:unocast
 (SignatureVerifierImpl)"
1a7ad0c10d "loplugin:unocast
 (pcr::PropertyEventTranslation)"
a97e2d2702 "loplugin:unocast (RangePageBreaks)"
19dfdf86ad "iloplugin:unocast
 (pcr::OFormattedNumericControl)"
f9785ea595 "loplugin:unocast
 (frm::OInterfaceContainer)"
5e5f40a4a9 "loplugin:unocast (ScVbaShapes)"
27b35b2c21 "loplugin:unocast (ScVbaShapeRange)"
cb3108f860 "cid#1517812 Dereference null return
 value"
feba0ddb15 "loplugin:unocast
 (weld::TransportAsXWindow)"
4d6c232165 "loplugin:unocast
 (oox::ForumlaImExportBase)"
4844c096a8 "loplugin:unocast
 (cairocanvas::SurfaceProvider)"
9a0b523e0a "loplugin:unocast
 (cairocanvas::CanvasBitmap)"
8a5648d8e5 "loplugin:unocast
 (cairocanvas::TextLayout)"
28c27a0623 "loplugin:unocast
 (cairocanvas::CanvasFont)"
53bc223cb3 "loplugin:unocast
 (cairocanvas::RepaintTarget)"
5f70b0b9f6 "loplugin:unocast (SvXMLImport)"
068187a898 "loplugin:unocast (VCLXWindow)"
88b4f96620 "loplugin:unocast
 (sfx2::sidebar::SidebarController)"
f1b7a69b28 "loplugin:unocast
 (SvxLineStyleToolBoxControl)"
ba76f0ba7e "loplugin:unocast
 (i18npool::Calendar_gregorian)"
840154daf9 "loplugin:unocast
 (framework::AddonsToolBarWrapper)"
b0e9c4c5f0 "loplugin:unocast
 (GrammarCheckingIterator)"
8ee6cfc965 "loplugin:unocast
 (ucb::ucp::ext::Content)"
5b8cd77c11 "loplugin:unocast
 (basic::SfxScriptLibraryContainer)"
9e73ff9fce "loplugin:unocast
 (sdext::presenter::PresenterNotesView)"
a98acca8fb "loplugin:unocast
 (SelectionChangeHandler)"
c0b59ad6e3 "Consistently use
 comphelper::getSomethingImpl<I>(aIdentifier, this)"
276e3ccbdd "loplugin:unocast
 (vclcanvas::RepaintTarget)"

Change-Id: I37c73e3422a5154bf6cb647640d2d3f23db8bc34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145063
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2023-01-05 11:45:51 +00:00
Stephan Bergmann feba0ddb15 loplugin:unocast (weld::TransportAsXWindow) 
(See the upcoming commit introducing that loplugin:unocast on why such
dynamic_casts from UNO types are dangerous.)

On macOS, where we implicitly use -fvisibility-inlines-hidden-static-local-var
since
<https://github.com/llvm/llvm-project/commit/d46f2c51e4c849683434bb5a0fb6164957474b8f>
"Make -fvisibility-inlines-hidden apply to static local variables in inline
functions on Darwin", the static id local var in
weld::TransportAsXWindow::getUnoTunnelId cannot be in an inline function
implicitly hidden via -fvisibility-inlines-hidden.  Explicitly marking the
function as VCL_DLLPUBLIC would help, but would in turn cause MSVC error 2487
("member of a dll interface class may not be declared with dll interface").  So
just make the function non-inline in a new vcl/source/window/weldutils.cxx
(which would arguably be the best approach for the whole class, anyway).

Change-Id: Ib5615f6aae19346ea05b8b85ff77c0e5ea860994
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144331
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-12-20 08:34:38 +00:00
Stephan Bergmann f1b7a69b28 loplugin:unocast (SvxLineStyleToolBoxControl) 
(See the upcoming commit introducing that loplugin:unocast on why such
dynamic_casts from UNO types are dangerous.)

Change-Id: I13f71f717a8661e0889ab7acf6fe7c7ebbe3dbe6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144332
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-12-16 20:17:17 +00:00
Noel Grandin 65062ceaae use more std::u16string_view in chart2 
Change-Id: I3617efa2e7fd55e6c1007338fd3c52aa9bbf13b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140232
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-09-20 13:11:56 +02:00
Stephan Bergmann 91ba9654ba Move tools/diagnose_ex.h to comphelper/diagnose_ex.hxx 
...so that its TOOLS_WARN_EXCEPTION can be used in
comphelper/source/misc/logging.cxx in a follow-up commit.  (And while at it,
rename from diangose_ex.h to the more appropriate diagnose_ex.hxx.  The
comphelper module is sufficiently low-level for this immediate use case, so use
that at least for now; o3tl might be even more suitable but doesn't have a
Library until now.  Also, for the immediate use case it would have sufficed to
only break DbgGetCaughtException, exceptionToString, TOOLS_WARN_EXCEPTION,
TOOLS_WARN_EXCEPTION_IF, and TOOLS_INFO_EXCEPTION out of
include/tools/diagnose_ex.h into an additional new
include/comphelper/diagnose_ex.hxx, but its probably easier overall to just move
the complete include file as is.)

Change-Id: I9f3222d4ccf1a9ac29d7eb9ba1530d53e2affaee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138451
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-08-18 17:10:19 +02:00
Samuel Mehrbrodt ecfb133598 tdf#128150 Adapt sidebar to new "use slide background" property 
Change-Id: Idce049a7498f98b0079c708236cfeff7fddd6e95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135963
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
 2022-06-22 16:54:21 +02:00
Noel Grandin b7c260aee3 clang-tidy modernize-pass-by-value in chart2 
Change-Id: I73ae444487571fb61a02a2c813c060d269d52a02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135723
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-06-13 16:04:27 +02:00
Stephan Bergmann 6ad8a6398d Just use Any ctor instead of makeAny in chart2 
Change-Id: I156cd5597a4b9e683913d9730b8d8bb22e8064f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133845
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-05-05 07:12:47 +02:00
Gabor Kelemen fef939d8ff Recheck module chart2 with IWYU 
See tdf#42949 for motivation

Change-Id: Id4cdca3eed8618c289f30913d506f8f2bd46f0bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133112
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
 2022-04-23 16:33:58 +02:00
Stephan Bergmann a29f055491 -Werror,-Wunused-but-set-variable 
...since its uses got commented out with
a9cc010064 "chart2: Weld ChartTypePanel"

Change-Id: I5296ba7ed746df13e8174063f148ff2ce970756c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132224
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-03-28 20:07:19 +02:00
Noel Grandin 7c62e59587 use more concrete types in chart2, Axis 
Change-Id: Ia47fd6deedd0a1cf6bedc882cb9817206dfa88b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129690
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-09 07:34:22 +01:00
Noel Grandin b314b5a061 use more concrete types in chart2, DataSeries 
Change-Id: I80bc8961832a20c29b31f7618b9d2609f15ab3c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129642
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-08 08:52:11 +01:00
Noel Grandin 333ccb081b use more concrete types in chart2, Axis 
Change-Id: If80b6487ad2b8ac75f98f798b839aff2b8a5c23e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129522
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-05 20:39:03 +01:00
Noel Grandin 9706ddb47c use more concrete types in chart2, RegressionCurveModel 
Change-Id: I844238da0ce0ce4aea308c652c341efa540149a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129234
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-01 08:28:02 +01:00
Noel Grandin 47bbacb2b1 use more concrete types in chart2, DataSeries 
Change-Id: Ib07ed6ec3321dc617cfec872d16683cf5de60907
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129181
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-31 10:39:29 +01:00
Noel Grandin 2781c7a50f use more concrete types in chart2, Legend 
Change-Id: Ifbf8ddd92eacd4caaf6fdaa061821222e543a1a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129133
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-29 15:51:30 +01:00
Noel Grandin 1be7f03c8f use more concrete types in chart2, ChartType 
Change-Id: I78fe27e14993b7a6e5d27662282241b3007ac03e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129113
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-29 12:52:43 +01:00
Noel Grandin 39f452953e use more concrete types in chart2, Diagram 
Change-Id: I40cd39d0878dc56e4e86e05149c9744cb563d745
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128942
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-25 20:23:08 +01:00
Noel Grandin 37d720b980 use more concrete types in chart2, ChartType 
Change-Id: Ife8d3f31d65e2911fa365a53f0defacde183f7b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128936
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-25 19:14:46 +01:00
Noel Grandin 928cb29638 use more concrete types in chart2, BaseCoordinateSystem 
Change-Id: I25fc26c9c3eb861d72c44ac04e502b2f002ef951
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128711
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-21 13:45:14 +01:00
Noel Grandin c53181f3e9 use more concrete types in chart2, Diagram 
Change-Id: Ib78f327c8bf1b71c3bb038c029b10e6fe54edaa1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128708
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-21 08:37:04 +01:00
Noel Grandin 19e962d15c use more concrete types in chart2, ChartModel 
Change-Id: Ic3020221111fea9c1026a91c72f7a2d1d5da42dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128666
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-20 16:37:52 +01:00
Noel Grandin b39bdb65b3 use more concrete types in chart2, ChartModel 
Change-Id: Ie38d941f855978b04995162040d8871a2577255c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128641
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-20 14:37:10 +01:00
Noel Grandin 4683eaa6f9 use more concrete types in chart2, ChartTypeTemplate 
and return data using a little struct rather than std::pair, to
make the call sites read a little better.

Change-Id: Ieb6fc24e053f50823789167ed0112aa04a083725
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128613
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-19 17:09:21 +01:00
Noel Grandin f0f87108ab use more concrete types in chart2, Diagram 
Change-Id: I870f6d9fa4c0b51cf7c887199079fdbabbca1fec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128597
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-19 13:46:01 +01:00
Noel Grandin f8a3ce5db8 use more concrete types in chart2, ChartTypeTemplate 
Change-Id: I1bfbc81ca0d44efc669e5bc2b525cfa8b51be1ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128561
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-19 07:05:00 +01:00
Noel Grandin b29e3131ea use comphelper::WeakComponentImplHelper in ChartPanelFactory 
Change-Id: Id81031b061981771a5f5dc91de3f5a404857164e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127692
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-12-30 06:46:57 +01:00
Miklos Vajna 7d5984d7ae sd theme: allow setting the color's theme index in the chardlg 
This routes not only the rgb color and a name, but also a theme index
from the color picker to the chardlg (only there as a start).

That way the picked color will be updated if the master page theme
changes.

Change-Id: I7a45d7cf63c7c36013e4656c66d9b2dbc3aa0b88
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127135
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
 2021-12-20 11:31:53 +01:00
Stephan Bergmann 0a710c5c44 cid#1494595,1494597: Silence UNCAUGHT_EXCEPT 
...after aa5ee0085c "Stop swallowing exceptions in
~ScopeGuard" had dropped the catch blocks from ~ScopeGuard to make it usable in
Library_salhelper in 0c1c300ed7 "Rather use
ScopeGuard to prevent catch and rethrow".  But using the original
suppress_fun_call_w_exception, which used css::uno::Exception, would have caused
the same circular-dependency issue again that
aa5ee0085c had solved, so drop the use of
css::uno::Exception (and SAL_WARN, which triggered a number of missing #include
<sal/log.hxx>) also from suppress_fun_call_w_exception.  After all, that was
__COVERITY__-only code that wasn't meant to be actually run, so it shouldn't
matter if we just catch everything and silently terminate.

Change-Id: If28a214709e4636e1c23a49f2d95d87c91492f14
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126404
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2021-12-06 14:25:41 +01:00
Noel Grandin ea014c324a loplugin:moveparam in chart2 
Change-Id: I6a47abf80f0f45bbb55bc9e0fe817f3c3650aff3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123351
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-10-11 12:18:47 +02:00
Szymon Kłos 3b72018b3c sidebar: update chart panel on checkbox change 
This fixes not working checkboxes for "title" and "subtitle" on mobile

Change-Id: I126bb020f669c8c4a34687f750a538513cd06eae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122876
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123132
Tested-by: Jenkins
 2021-10-06 14:14:15 +02:00
Noel Grandin 6191fc4473 clang-tidy:readability-redundant-member-init 
Change-Id: I5e8baec88d5f17ddda452bd945c87769623cb4e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121357
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-08-31 14:29:44 +02:00
Balazs Varga 3af7001d0a tdf#142793 chart UI: fix option "Secondary Y Axis" on sidebar 
Attaching a data series to the secondary axis didn't enable
the secondary axis at the right side of the chart using the
sidebar (unlike in data series local menu -> Format Data
Series... -> Options).

Test: Click on the chart, select one of the data series, and
enable Data Series -> Align Series to Axis -> Secondary Y Axis.

Change-Id: I2cb99458af724471d4d04cac8c2c9013f41634fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117048
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
 2021-06-24 15:12:49 +02:00
Caolán McNamara 9940f077fd add Toggleable as a separate thing to a Button 
and inherit ToggleButton from both it and Button

Change-Id: If0e500aca8d0ffa087cb5e2bfc1786372fbff4eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115921
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-05-21 18:19:58 +02:00
Caolán McNamara feb17e47bc tdf#142364 exception thrown during destruction 
Change-Id: I4e06ac82108e5381cd11fbd6407e1ce1e85c3ac6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115822
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-05-19 21:38:06 +02:00
Andreas Heinisch b238522ca1 tdf#124295 - Always select a 3D scheme in the chart wizard 
Change-Id: Ic0a39b4cb6f7af6fbdd99fc93677a0c2d966234d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115671
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
 2021-05-19 09:31:24 +02:00
Caolán McNamara 1653bb9bff remove intermediate containers in sidebars 
tested extension sidebars of:
a) Wollmux extension sidebars
b) Analog Clock Extension demo
   https://wiki.openoffice.org/wiki/Sidebar_for_Developers#Example:_Analog_Clock_Extension

Change-Id: If9729e20526681928137989f01a8ae733a9b0cb5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112035
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-03-11 17:42:22 +01:00
Caolán McNamara c7c99f89ee SidebarPanelBase is always created with a PanelLayout 
Change-Id: I825452fbd56435edcc0a2ffb7abe0f834bf10fb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111976
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-03-04 20:59:06 +01:00
Caolán McNamara 2dd772f921 drop some unused forward declares 
Change-Id: I57df9a6903c75ca8fc822431ae8294f76167cc97
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111939
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-03-04 10:08:10 +01:00
Quan Nguyen 62dff2844b tdf#92768 Add rendering support for hiding title object in chart2 
Change-Id: Ice6335d52d53dcbaa8711f9669597bf5321ecd7c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110889
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-02-18 09:49:06 +01:00
Noel 2f9a61e3c9 loplugin:referencecasting in chart2 
Change-Id: I4864b5f73a65de04ed3e3524e1331094049b1263
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111002
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-02-17 08:50:44 +01:00
Caolán McNamara e8ffe26c06 tdf#140387 grab focus to first panel widget on panel gaining focus 
otherwise focus is getting lost in these currently mixed vcl+gtk widget
panels.

Change-Id: I6488ddfc98afdedb55bb3217f3877e96258dd65a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110955
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-02-16 10:07:52 +01:00
Noel 1250aecd71 loplugin:stringviewparam extend to new.. 
O[U]StringBuffer methods

Change-Id: I0ffbc33d54ae7c98b5652434f3370ee4f819f6f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110090
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-01-29 09:25:12 +01:00
Noel 63a68064bb make the Color constructors explicitly specify transparency 
to reduce the churn, we leave the existing constructor in place,
and add a clang plugin to detect when the value passed to the
existing constructor may contain transparency/alpha data.

i.e. we leave expressions like Color(0xffffff) alone, but
warn about any non-constant expression, and any expression
like Color(0xff000000)

Change-Id: Id2ce58e08882d9b7bd0b9f88eca97359dcdbcc8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109362
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-01-16 10:07:07 +01:00
Stephan Bergmann b606d484a6 -Werror=maybe-uninitialized 
...in code introduced with 00140e3df4 "lok: send
chart line width updates".  Falling back to zero is in line with the preceding,
similar

  sal_uInt16 nLineTransparence = 0;
  ...

block (introduced with 3dc00a8de9 "handle line
dash in chart line panel"), but using o3tl::doAccess or o3tl::forceAccess might
be more appropriate.

Change-Id: I8c2286b386aa9052d1d2af0f9f25847829ca4df5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109081
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2021-01-12 11:41:23 +01:00
Szymon Kłos 00140e3df4 lok: send chart line width updates 
Change-Id: I4c9c4a977df12a1cefb81cfbcac73b61ff26e488
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108843
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108966
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
 2021-01-08 14:54:32 +01:00
Szymon Kłos 142803e207 lok: send chart color updates 
Change-Id: I037049fb19ddf4c1450d7d9327c574cb4e37977c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108793
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108927
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
 2021-01-08 12:59:09 +01:00
Noel 8332d6d820 loplugin:stringviewparam include comparisons with string literals 
Change-Id: I8ba1214500dddaf413c506a4b82f43d63cda804b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106559
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-11-30 12:32:14 +01:00
Philipp Hofer 79b6055acd tdf#123936 Formatting files in module chart2 with clang-format 
Change-Id: Ie4dea73190040e5716fe531cf35fae20d7e175db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105650
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
 2020-11-22 01:57:32 +01:00
Stephan Bergmann c446adbcbd Clarify signature of some opertor() that must match ColorSelectFunction 
Change-Id: Ibb71d1e993bbb0fa453c59f48ab5f7c79e1d8025
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106036
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2020-11-18 08:30:31 +01:00