ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
476,481 Commits 3 Branches 3 Tags
8a5beccc19b4fdffb7b82ba5fd26f4cf316d9811
Commit Graph
9 Commits
Author SHA1 Message Date
Miklos Vajna a12b4d548c CppunitTest_embeddedobj_general: put the base class into an anon namespace 
Which reduces the probability that the base class name collides with a
symbol from non-test code.

Change-Id: I7df17a76602b12da7b10cb77f6e44466676d15a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130811
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2022-03-02 08:14:21 +01:00
Stephan Bergmann 4bc32d5a1b loplugin:external (clang-cl) 
Change-Id: I0bd38acd8c562f4478831f278e7cfda54268849d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115747
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2021-05-19 07:27:09 +02:00
Miklos Vajna d5cd62164d embeddedobj: handle getting the visible area on a thread 
The Windows OLE2 implementation of the embedded object interface assumes
that the same thread is used for loading and saving the embedded
objects.

This means that in case the main thread is used for loading (e.g. from
remote UNO, but with OnMainThead=true), but a
thread is used for storing (without an explicit OnMainThead=true), then
the underlying win32 API call failed and we returned a fixed size in
EmbeddedObjectRef::GetSize().

Fix the problem by explicitly checking for RPC_E_WRONG_THREAD and adding
error handling for that case.

Change-Id: Icf1e7722d33a809fa671d1505b2a0155af040c71
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115236
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
 2021-05-07 14:21:40 +02:00
Stephan Bergmann 042033f1e6 loplugin:stringviewparam: operator + 
Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2020-12-29 16:42:33 +01:00
Miklos Vajna 00215edeb0 Remove some unused includes 
Change-Id: I28b007cff3a99bc40901ecdeaecacf42b4521574
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89058
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2020-02-20 08:44:08 +01:00
Miklos Vajna 75a7932bb4 test: move component context from subclasses to BootstrapFixture 
To avoid duplication.

Change-Id: I0ee7c26d5d55bd868ead04c77e7f4ef2582f90e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88138
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2020-02-07 09:13:50 +01:00
Miklos Vajna bdfa6b678b embeddedobj: allow controlling if PDF documents are converted to Draw or not 
This is a bit custom, since it's not a Microsoft filter.  At the moment
this affects only Insert -> Object -> OLE Object -> from file.

Change-Id: If79602742a533db1b04e11a90890f8768186046d
Reviewed-on: https://gerrit.libreoffice.org/77520
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
 2019-08-15 16:45:23 +02:00
Miklos Vajna 5827e30109 embeddedobj: allow controlling if Visio documents are converted to Draw or not 
At the moment this affects only Insert -> Object -> OLE Object -> from
file.

Change-Id: I8d1c6456481610491916e3be3766b0bb04dfa296
Reviewed-on: https://gerrit.libreoffice.org/77489
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
 2019-08-15 11:42:55 +02:00
Miklos Vajna 85a7bc13fe embeddedobj: add initial CppunitTest_embeddedobj_general 
Fails with commit 88afec7011 (embeddedobj:
respect config for Insert -> Object -> OLE Object -> from file,
2019-08-14) reverted.

Change-Id: I64f81642260f6eab5a86219d94553f09b67b3555
Reviewed-on: https://gerrit.libreoffice.org/77461
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
 2019-08-14 19:38:59 +02:00