Both are derived from SfxSetItem which means they contain
a SfxItemSet themselves. That leads to problems since at
their construction time a SfxItemPool has to be known and
it *should* not be different to the one of the ItemSet
that Item gets added later - that leads to the 2nd class
of problems.
In the long therm we should get rid of all SfxSetItems.
This change simplifies already some stuff, including that
the standard Items for DrawObjects reduces by two (and
more due to containing a whole ItemSet) and e.g. the
problem that these Items had to be converted to hard
attributes in the done fixes for copy/pasting Slides.
Signed-off-by: Armin Le Grand (collabora) <Armin.LeGrand@collabora.com>
Change-Id: I8b1c6cabdaa43ed6062811b5508ab3dece47a755
Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/6795
Reviewed-by: Armin Le Grand <armin.legrand@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit e67458a9b769fe7a3a7ee0739ed6d5c46dbc0692)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211734
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* Missing glyphs such as U+1234 are not detected as missing
* Missing variants such as 'Italic Light' are not detected
* Language on the font is not taken into account
Change-Id: I6329a2607f7e13b8ba09050b1037d4e33b4c7eb4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211324
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
* Makes the title show as "Slide Properties" instead of "Page
Properties".
* Makes the label for the resize all slides checkbox show as "Resize all
slides" instead of "Resize all pages"
Change-Id: Idda0bdf6ef6215696ae4189549f62c05ef0076c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209996
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
In case of mirrored pages the gutter cannot be left or right but
inner or outer. To make the dialog easier to understand the modifier
checkbox for Left turning this into Right was changed to radio buttons.
Change-Id: I71b32d89f9a9054f5351e3c0d51ba348b66c1f0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209072
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Copy the value from the status bar.
According to the checkboxes selected in the submenu.
If “None” is selected, choosing “Copy Value...” saves
an empty string to the clipboard.
This effectively clears the clipboard.
Support for multiple national languages has been added.
Change-Id: I662e8be8feaeac5bf2e4d69f557a8fec2420ff47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/207385
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
Added Undo/Redo SdrUndoDiagramDissolveModel that handles
changing the Diagram to a GroupObject when using the uno
command SID_DIAGRAM_TO_GROUP/".uno:DiagramToGroup". This
converts Diagrams to Group objects (and back with undo).
Moved the Undo/Redo functionality AFAP to the functions
offering the actions, so this only needs to be implemented
in one place. Adapted usages.
Removed flushing remaining UndoStack in SdrUndoManager,
the Undo/Redo is getting more complete and thbis should
no longer be needed.
Added SubSelection travel and MouseCklick SubSelection
functionality to Calc and Writer. This is now complete
for all apps.
Added im/export of Diagram ModelData to Calc and Writer,
it already was added to Draw/Impress to make copy/paste
work. Unfortunately that needed some digging due to
every app doing im/export of XShapes/SdrObjects slightly
different. Used already created toolinf AFAP.
Change-Id: Idb57dcec88f8ca2f37f7360f9ad433996819d122
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/202243
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Tested-by: Jenkins
- Introduce 'SvxAutoFormat' which combines the common funtionality of
Writer and Calc Autoformats.
- Replace module specific 'AutoFormat' dialog and preview with shared
dialog and preview in 'svx'.
- tdf#49437: Load and Save Autoformats through XML instead of
'autotbl.fmt'.
- New Dialog to edit and create table styles shared b/w Writer and Calc.
Change-Id: I7fa108e527141c05703e0e14298eea818fd10378
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190024
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
This commit adds a drop-down dialog that appears when the user pastes
plain text containing Markdown-formatted content, prompting the user
to choose between text and markdown.
Change-Id: I3b14b5a07f107de69825583f54023d2d98984288
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188067
Reviewed-by: Thorsten Behrens <thorsten.behrens@collabora.com>
Tested-by: Jenkins
The weld::Frame API implementations expect that
the `<child type="label">` child of a GtkFrame
object in a UI file is a GtkLabel.
In addition, QtBuilder also expects that when
processing the UI file as it doesn't use a
separate widget, but sets the label's text directly
for the QGroupBox (that's used for the GtkFrame
object in the .ui file).
The "Header"/"Footer" tab pages used e.g. in Writers
"Format" -> "Page Style" dialog however were using
a GtkBox child, containing 2 labels: One having the
string to be used for the "Header" dialog, one the
string to be used for the "Footer" dialog set as text,
and only that label was set to visible in the SvxHFPage
ctor.
Replace that approach by using a GtkLabel child,
and calling weld::Frame::set_label with the corresponding
string instead.
Change-Id: I86754be7c0ce068ceb6216fd0463657b05f4ca41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189111
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Align the NC_ macro parameter in the RID_SUBSETSTR_EGYPTIAN_HIEROGLYPHS_EXTENDED_A definition with the rest of the definitions for consistency.
Change-Id: Iebafe88a5665d93fe2d180bf0cf2bffc7e70b8b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183099
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Trying to replicate the behaviour implemented
in the search dialog, while trying to respect
the previous logic for search bar which
ignores diacritics and kashida if CTL font
is enabled.
In my opinion, the new checkbox should be the
only parameter ruling whether the search
should match diacritics or not, but we
can still ignore kashida if CTL font is
enabled.
Change-Id: I1b88be26dd80a1ebbcf78c32ade7d5a289e0766c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182212
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
- Add new text Glow effect properties for shapes
- Using TextGlowPrimitive for rendering uniform text glow in shapes
- Add/allow new UI Glow Effect for texts in shapes on sidebar
(Only for Impress/Draw and Calc)
- Import/Export ooxml files with Glow effect on texts in shapes
(Only PPTX/XLSX)
- Import/Export odf files with Glow effect on texts in shapes
- Add unit test for glow text attributes in ODF
- Add uni tests for OOXML import/export
Note: Also this patch effects on
tdf#144061 - Effects: Allow GLOW to apply to Text (as we have for shapes)
Change-Id: I16586c01654f197f532129e4e06aa2ef9f214395
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172216
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
remove CUI_DLLPUBLIC from stuff which is not exported
then drop the cui/include dir which is then empty and
the places we link to cui where we now don't need to
and restore cui back to a lib containing stuff that
doesn't need to be explictly linked to in keeping
with original #i106421# idea
Change-Id: I21894e6f8529dd3306df345fb52dbf5009015f3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162798
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
...by moving the char8_t -> char reinterpret_cast out of any potential constexpr
paths into a new TranslateId::getId. And demonstrate constexpr'ability by
making the aCategories var in OApplicationIconControl::Fill
(dbaccess/source/ui/app/AppIconControl.cxx) constexpr. (And there might be more
such cases that could now be made constexpr.)
Change-Id: I0b4e3292faf8f6b901f9b9e934e1aa6bf0f583ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157862
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* SdrObject new member m_IsDecorative
* new Undo SdrUndoObjDecorative
* surprising amount of changes in sw including additional SwUndoFlyDecorative
* svx API SvxShape property "Decorative"
* UI checkbox "Decorative"
* ODF import/export as loext:decorative on style:graphic-properties
* PDF/UA export: ViewObjectContcat tag shapes with this flag as Artifact
Change-Id: I37f7a0597eab92c6c6aff94fad6c16c59b231c80
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154063
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
The theme color generator needs to take color luminocity into
account, so that the very dark or very light colors are properly
shaded. Otherwise a too dark color will generate a too dark (almost
black) color variant, or a too light a too light (almost white)
color variant. However those colors aren't useful.
Change-Id: Id803a8f6f1a79cbc822ed2d7faca9bec228c0188
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152237
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
This patch brings order out of chaos,
organizing the outline choices into
academic, modern, simple numeric, and misc columns.
The very first suggestion should be the academic standard.
Next comes a distinctly different modern alternative
Simple numeric moves over to be above the other numeric,
followed by a demo of the kind of mixture that can be designed in LO.
Since the academic standard uses Roman numerals,
it is offset on the next row by the other one containing Roman numerals
followed by a modern classic,
and the all-numeric ISO standard retains it current position.
The bullet oddball logically remains as the last suggestion.
In this patch there was no change made to the actual suggestions
themselves. Earlier patches made changes to 3 definitions,
which allowed for the nice correlations.
I missed changing the descriptive "strings" in the earlier patches.
I had assumed earlier that these monotonous descriptions
were dynamically produced...
Since the English description should not be translated,
I added a comment that will be extracted to the PO as a comment.
(Thanks Andras).
I think it would be nice to use strings
"Academic MLA/CMOS/Turabian/OWL compliant outline"
"ISO 2145 outine"
but that could be made in a separate patch.
Let me just point out what happened with the strings
in case this helps with translation
NOTE: only languages that ultimately inherit from en_US need to re-translate:
old RID_SVXSTR_OUTLINENUM_DESCRIPTION_0
-no string change
-moved to _3
old RID_SVXSTR_OUTLINENUM_DESCRIPTION_1
-string changed / list modified earlier
-moved to _5
old RID_SVXSTR_OUTLINENUM_DESCRIPTION_2
-string changed / list modified earlier
-moved to _1
old RID_SVXSTR_OUTLINENUM_DESCRIPTION_3
-no string change
-moved to _2
old RID_SVXSTR_OUTLINENUM_DESCRIPTION_4
-string changed / list modified earlier
-moved to _0
old RID_SVXSTR_OUTLINENUM_DESCRIPTION_5
-no string change
-moved to _4
RID_SVXSTR_OUTLINENUM_DESCRIPTION_6
-no change
RID_SVXSTR_OUTLINENUM_DESCRIPTION_7
-no change
Suggested translation order:
-cut _3 and paste into _2
-cut _0 and paste into _3
-cut _4 and paste into _0 and fix definition
-cut _5 and paste into _4
-cut _1 and paste into _5 and re-define
-re-define _1
Change-Id: Ie4ec8423acddc24efefb270d9ed19ab77566e6e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150805
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Oringally, the zoom bar in both Draw and Impress show
"Fit slide to current window."
Now, the zoom bar in Draw is modified into
"Fit page to current window.", while Impress still uses "slide".
Change-Id: Iba25215d437b128f581bc5a8e6767f6b1f382be4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150650
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Armin Le Grand (collabora)