ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
368,405 Commits 3 Branches 3 Tags
74df327e1ef4edf4ca07d04ae72ee052d824564f
Commit Graph
1180 Commits
Author SHA1 Message Date
Noel Grandin fe480d8136 remove unused typedefs 
found with some minor modifications to find/find-unused-defines.sh

Change-Id: I18cc479adedc7a0dada68a4aeef08300e62631dd
Reviewed-on: https://gerrit.libreoffice.org/14194
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-01-28 06:19:49 +00:00
Michael Stahl ba68436e3f Win SDK 8.1: apparently VersionHelpers.h needs to be included explicitly 
http://ci.libreoffice.org/job/lo_gerrit_master/495/Gerrit=Gerrit,Platform=Windows/console

Change-Id: I0104d448906bd17857b3716856c544e632c1662c
 2015-01-23 14:04:24 +01:00
Stephan Bergmann dcfb17b805 Some more loplugin:cstylecast: shell 
Change-Id: I8d9846dcfd8b0f686f7321a3e7b7b0d70428723d
 2015-01-20 09:06:51 +01:00
Michael Stahl 4500afcc1b try to fix GetVersionEx deprecation warnings from Windows SDK 8.1 
Apparently GetVersionEx() is deprecated now, but the replacement header
"versionhelpers.h" does not exist in older SDKs (at least not in 8.0),
so try to determine the used SDK version by checking if the Windows 8.1
version constant _WIN32_WINNT_WINBLUE (0x0602) exists.

http://msdn.microsoft.com/en-us/library/windows/desktop/dn424972%28v=vs.85%29.aspx

Change-Id: Ia9224a8c76823ada7cb294a600046c6a0fc843ad
Reviewed-on: https://gerrit.libreoffice.org/14020
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2015-01-19 20:31:38 +00:00
Noel Grandin 54942f0d09 spelling: attachement -> attachment 
Change-Id: I1bb1ad04adec864b594d96711f85b8fcdc1d1ef2
 2015-01-05 12:57:18 +02:00
Michael Weghorn ea644f0e90 fdo#39440 reduce scope of local variables 
This addresses some cppcheck warnings.

Change-Id: I404f121ee2e5020359a662f54ffe341f466cd1d5
Reviewed-on: https://gerrit.libreoffice.org/13608
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-12-23 05:53:41 +00:00
Stephan Bergmann 7f09f384b2 shell: Use appropriate OUString functions on string constants 
Change-Id: I3b2c0a4200fa953162f40eff49289052962e73d2
 2014-12-18 14:12:32 +01:00
Stephan Bergmann 4888f82557 shell: Use appropriate OUString functions on string constants 
Change-Id: I2647295383085abf8f217693531ef82632eb4c52
 2014-12-15 10:17:33 +01:00
Michael Stahl 15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use 
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
 2014-11-18 18:51:49 +01:00
Caolán McNamara 357f9d22a0 give all the open-url scripts the same starting permissions 
Change-Id: I35fcb2d73accf20baa96b62d99be6d0a3ebb3ba2
 2014-11-17 14:53:23 +00:00
Caolán McNamara 20dab428f8 drop gnome-open-url binary 
we don't really need it anymore, fallback to our own open-url
if there is nothing else to take it

Change-Id: I7a4e841a53bda30e29d48b9c34d24af085f1b4b5
Related: coverity#706194 Use of untrusted string value
 2014-11-17 14:53:22 +00:00
Michael Stahl 6a0fe37dec sal: clean up public headers with include-what-you-use 
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
 2014-11-17 11:06:53 +01:00
Andrea Gelmini da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Richard PALO 88a40e70fe O_RDWR and O_CREAT are defined in fcntl.h 
Change-Id: I568ee2c3f103777720f6c39340a5915b10aeebb4
Signed-off-by: Michael Stahl <mstahl@redhat.com>
 2014-11-11 19:44:57 +01:00
Markus Mohrhard 89c47e4a3d that stuff seems to be totally unused 
Change-Id: Ice7bc99fc5f3d26ced1b7cd5a1dbf29b0e635471
 2014-11-10 07:58:34 +01:00
Stephan Bergmann fc0d57b7af Revert "use the new OUString::fromUtf8 method" 
This reverts commit 05050cdb23,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
 2014-11-06 17:24:13 +01:00
Noel Grandin 05050cdb23 use the new OUString::fromUtf8 method 
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
 2014-11-06 13:51:10 +02:00
Andrea Gelmini c70f1545e2 Removed duplicated includes 
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6
Reviewed-on: https://gerrit.libreoffice.org/12160
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2014-10-31 16:18:30 +00:00
Noel Grandin 0371a63365 remove unnecessary 'using namespace rtl' declarations 
It turns out that almost none of them were necessary.

Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-29 11:28:54 +00:00
Eike Rathke 04a810cee4 back out more wrong and confusing tools::Time comment changes 
Apparently fc04f76336 used some sed script
to change all ...

Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
 2014-10-08 14:24:21 +02:00
Stephan Bergmann 36d24bced0 shell (Windows): std::auto_ptr -> std::unique_ptr 
Change-Id: I44c843c028c2dfcfcea9f6a2196440ca700fc3a8
 2014-10-02 15:20:54 +02:00
Stephan Bergmann 5b401a06a6 shell: std::auto_ptr -> std::unique_ptr 
Change-Id: I6fc7ef7438e1b999b3b65e4e661b9e787a66cf47
 2014-10-01 17:35:09 +02:00
Noel Grandin fc04f76336 fdo#82577: Handle Time 
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-01 07:34:23 +00:00
Andras Timar ae4c836b49 bnc#887307 ODF files not showing up on Windows search 
Under Windows 7, ODF and OpenOffice.org 1.1 files were not found,
when the folder containing them was not indexed, and full text
search was switched on. The problem did not occur under Windows 8.

Apparently there is a bug in Windows 7, reading beyond the end of a
BufferStream resulted in 0 bytes read. So we take care not to read
beyond the end of stream.

Change-Id: Id01b08922121dabbb7b49c54f8ef11cb0e4ac413
 2014-09-18 00:57:21 +02:00
Stephan Bergmann 8405ee507e shell: sal_Bool -> bool 
Change-Id: Ie4fedd95752aa1212481bff0cda7c0045956b361
 2014-09-11 16:34:50 +02:00
Julien Nabet 037d03b9fa Typo: (N|n)ormaly->(N|n)ormally 
Change-Id: I96d081f394b0b62d99ec1034bf5e99da9aedd9d9
 2014-09-10 22:35:39 +02:00
Stephan Bergmann 83ac0fd7bd Fix *_component_getFactory function type 
Change-Id: I406e0b659f551f347a8fa9ae2a57ec7965ba7ea0
 2014-08-28 17:35:03 +02:00
Stephan Bergmann 5253732ca6 Fix some *_component_getFactory function types 
Change-Id: I8e7cc2d26df27e2eb48ddec53ea0a4f1d1381e23
 2014-08-28 16:40:02 +02:00
Thomas Arnhold e99535df4d remove executable bits 
Change-Id: Iec785ae538de81325812b1e6fe33115789b39770
 2014-08-17 05:50:13 +02:00
Thomas Arnhold 578d3fc5e6 warning C4505: unreferenced local function has been removed 
Change-Id: I2b9b43c40a467dd369f1eeb3623be388c51d3b4d
 2014-08-13 10:10:46 +02:00
Thomas Arnhold 4469c60ad8 warning C4296: '<' : expression is always false 
sread doesn't return negative values

Change-Id: I72caa9abe7081b7d88e412510d70ec3810634af1
 2014-08-13 10:10:33 +02:00
Tor Lillqvist 7182db5a67 Include <algorithm> for std::min() and max() 
Change-Id: I6a46e6466ab56aea14e16902cb51f9c3f088f30e
 2014-07-08 02:37:34 +03:00
Noel Grandin e2080e70fe new compilerplugin returnbyref 
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
 2014-06-24 11:34:21 +02:00
Stephan Bergmann a15715c343 -Wstrict-prototypes 
...no reason to not have it enabled for URE C include files and what
little real C code is still left.  (But note that Clang ignores that
warning.)

Change-Id: Ia6940f9f940a0c226e9b724331d65c9862ce32e6
 2014-06-17 15:51:54 +02:00
Noel Grandin 184a00b962 loplugin: inlinesimplememberfunctions 
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
 2014-06-09 10:10:13 +02:00
Thomas Arnhold c2034f3993 fixincludeguards: fix include guards 
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b
Reviewed-on: https://gerrit.libreoffice.org/9629
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-06-06 19:16:40 +00:00
Noel Grandin ebc0a15515 remove more unnecesary OUString constructor use 
when throwing exceptions

Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
 2014-05-29 09:01:40 +02:00
Noel Grandin f0ae48b684 remove unnecessary NULL parameter passed to UNO Exception 
.. now that we have a default value for that parameter

Change-Id: I54d6b0a0a01ce2f2e5168ada0c427424de0477bc
 2014-05-29 09:01:40 +02:00
Thomas Arnhold 01443bb1bc cppcheck: Variable 'i' is assigned a value that is never used 
Change-Id: I02e0f878e743576ebb3c80e3120fa1dc54e379ed
 2014-05-22 12:50:48 +02:00
Thomas Arnhold 2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left 
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-05-15 12:50:46 +00:00
Stephan Bergmann 8fd54c107a Related fdo#60338: Do not use umask(3) in a MT program 
Change-Id: Ie515201e44ad58faf623a04981e891c0b3f4a19d
 2014-05-13 11:39:30 +02:00
Stephan Bergmann 096d1d6e7c This code is not linked against sal 
Change-Id: I7f44cd54732a60e9655f0bbb90615f3d3988ce58
 2014-05-12 12:32:56 +02:00
Michaël Lefèvre 70e744b215 fdo#43157 Remove OSL_POSTCOND, prefer SAL_WARN_IF 
Change-Id: Ia89a2dce799c7ba90bcd19919195bfd2c7a4a180
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2014-05-12 11:32:38 +02:00
Thomas Arnhold c327acab9e remove globally disabled warnings from source files 
Change-Id: Ic7b092a24b4d1e48ca11e53b507da5c2bfdeabe8
 2014-05-10 13:03:20 +02:00
Thomas Arnhold 9037e2289d remove presys.h and postsys.h 
Both files are nearly identical to prewin.h and postwin.h

Change-Id: I1f45e46dfcc00043a9e2df82e0070cd1b976c4af
Reviewed-on: https://gerrit.libreoffice.org/9294
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-05-09 18:17:19 +00:00
Noel Grandin 177d32b6b8 shell: sal_Bool->bool 
Change-Id: I4313819fa40885a3cfa4a137888ae457d8d839a8
 2014-04-30 08:43:41 +02:00
Noel Grandin 5babf1b903 remove unnecessary scope qualifier from sal_Bool uses 
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
 2014-04-03 13:54:02 +02:00
Stephan Bergmann d59fe933fe Use boost::noncopyable 
Change-Id: I1cd2ad1284f2fb9f6847cdb9175a5872a66726cd
 2014-04-03 08:20:19 +02:00
Stephan Bergmann 6a3b0b7cc4 Explicitly mark overriding destructors as "virtual," Mac OS X redux 
Change-Id: Ib7ab02bc3cdadbdfe0e0787560d1dd562eb85be9
 2014-04-01 21:30:38 +02:00
Stephan Bergmann 362d4f0cd4 Explicitly mark overriding destructors as "virtual" 
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
 2014-04-01 19:22:54 +02:00