ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
368,405 Commits 3 Branches 3 Tags
74df327e1ef4edf4ca07d04ae72ee052d824564f
Commit Graph
171 Commits
Author SHA1 Message Date
Stephan Bergmann b9def20cea scripting: Use appropriate OUString functions on string constants 
Change-Id: Iacb434225e779de4911e9acc8431662f5eabcee3
 2014-12-18 14:12:30 +01:00
Stephan Bergmann ad9498f8b8 More -Werror,-Wunused-private-field 
...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
 2014-10-15 15:58:56 +02:00
Michael Stahl 212f25c227 scripting: another missing SolarMutex guard 
Change-Id: I762dad4d94ab4f27912b4ddac5b6a77f7d685cb8
 2014-09-30 17:34:26 +02:00
Noel Grandin 5bce329040 SfxHint: convert home-grown RTTI to normal C++ RTTI 
Also note that I fixed a bug in SvxFontMenuControl::Notify
where the if statement had the check the wrong way around.

Change-Id: I611e8929c65818191e36bd80f2b985820ada4411
Reviewed-on: https://gerrit.libreoffice.org/11147
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2014-09-06 15:47:44 -05:00
Noel Grandin 37b9ea92ba convert SBX flag bits to type-safe enum 
Change-Id: I18d5d6a27f06ee60a5cb3dc393bf05b51bba4817
Reviewed-on: https://gerrit.libreoffice.org/11070
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-08-26 04:30:03 -05:00
Stephan Bergmann c7d7582452 Fix *_component_getFactory function type 
Change-Id: I966824af73effed95d975c09cb8a7f9ae022843f
 2014-08-21 17:49:13 +02:00
Norbert Thiebaud d92aa2f445 remove SFX_APP() macro that was a mer wrapper for SfxGetApp() 
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
 2014-06-27 17:08:04 +02:00
Noel Grandin db246b491c scripting: remove SAL_THROW macro 
Change-Id: I535a57d043ac51926ae6f640d721d0dd1571c3fa
 2014-06-05 08:17:52 +02:00
Noel Grandin ebc0a15515 remove more unnecesary OUString constructor use 
when throwing exceptions

Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
 2014-05-29 09:01:40 +02:00
Noel Grandin e7bc3cab01 remove boilerplate in UNO Exception constructor calls 
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
 2014-05-23 15:06:00 +02:00
Chris Laplante 3c1e30b77d Correct common misspellings, and remove some ASCII art along the way. 
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c
Reviewed-on: https://gerrit.libreoffice.org/9356
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
 2014-05-17 12:38:38 +00:00
Noel Grandin 2ff8ae7c9e scripting: sal_Bool->bool 
Change-Id: I1550c49cce2ad64f9d62b06ec20512a750f83b84
 2014-04-24 10:53:16 +02:00
Thomas Arnhold 8bb2ce61c0 fixincludeguards.sh: some smaller dirs 
Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
 2014-04-19 11:10:13 +02:00
Stephan Bergmann 567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
 2014-03-27 18:12:18 +01:00
Stephan Bergmann 5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexander Wilms b0308236d2 Remove visual noise from scripting 
Change-Id: Id9f177a20d911ce1e041407aa556c9cf13f0efc8
Reviewed-on: https://gerrit.libreoffice.org/8305
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-26 08:37:40 -06:00
Alexander Wilms 0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Stephan Bergmann 9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..." 
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
 2013-12-17 11:06:00 +01:00
Noel Grandin 73342dbb82 remove unnecessary RTL_CONSTASCII_STRINGPARAM 
A final pass through the code, converting code to use the new
OUString and OString methods that can detect string literals.

Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
 2013-11-22 08:07:19 +02:00
Noel Grandin 610b2b94b3 remove unnecessary use of OUString constructor when assigning 
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
 2013-11-19 10:29:31 +02:00
Noel Grandin e52779d2f8 remove unnecessary use of OUString constructor 
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
 2013-11-11 11:21:26 +02:00
Noel Grandin 2ac50736e4 remove unnecessary use of OUString constructor in SCRIPTING module 
Change-Id: I87dd775949d1d3cc2c191e84e57b49cd66ecc750
 2013-11-11 08:36:06 +02:00
Noel Grandin aeb41c9b9b remove redundant calls to OUString constructor 
Change code like this:
  aStr = OUString("xxxx");
into this:
  aStr = "xxxx";

Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
 2013-11-04 10:11:07 +02:00
Noel Grandin e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith 
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
 2013-10-31 08:34:21 +02:00
Marcos Paulo de Souza ee5661ecd3 fdo#54938: Adapt supportsService implementations.. 
to cppu::supportsService

Change-Id: I0b03d3910f094f2183bf9859db9d5bcaf35d1f14
Reviewed-on: https://gerrit.libreoffice.org/6370
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2013-10-22 10:28:10 +00:00
Thomas Arnhold 349d3b2bb5 remove an unused header 
Change-Id: I2821879670e23e7b1ce9749acab1970098a0a38d
Reviewed-on: https://gerrit.libreoffice.org/4597
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
 2013-06-28 09:26:48 +00:00
Luboš Luňák 1946794ae0 mass removal of rtl:: prefixes for O(U)String* 
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
 2013-04-07 14:23:11 +02:00
Stephan Bergmann 4c0c23af21 Simplify equalsIgnoreAsciiCaseAscii[L] calls 
Change-Id: If5201bd772aed245e8f7f8b900d76ffe4ca57b49
 2013-03-19 11:32:20 +01:00
Thomas Arnhold 8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings 
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-03-19 09:00:26 +00:00
Thomas Arnhold ecf0040337 loplugin: improve indentation 
Change-Id: If0ddaa8fd7cfaf4df8589422cb50ce37f1be2ad1
 2013-03-03 17:14:15 +01:00
Noel Grandin 591ef78440 fdo#46808, Use singleton util::theMacroExpander new-style constructor 
And deprecate the old-style service util::MacroExpander

Change-Id: Ifcefe31a8f8c68c6d44d6ec19616727eb607e1cd
 2013-02-11 08:02:13 +02:00
Jean-Noël Rouvignac 97eb8a6e0e Removed several useless macros: A2OU, A2S, C2U, C2S, OUSTR, OUSTRING 
Change-Id: Ie859cb2dfdc7103c379fce56be88eef8fe390afd
Reviewed-on: https://gerrit.libreoffice.org/1924
Tested-by: Luboš Luňák <l.lunak@suse.cz>
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
 2013-01-30 12:54:40 +00:00
Noel Grandin bb121c864c fdo#46808, Convert frame::Desktop to new style service. 
I had to drop XEventBroadcaster from the merged interface
because it introduced method name conflicts (addEventListener).

Shouldn't be an issue since it was scheduled to be dropped anyhow,
and the service implementation still implements it, so existing clients
will be fine.

I dropped the interface XPropertySet from the combined IDL because nobody
seems to be using it, and it's primary purpose appears to be to set weird
flags.

I dropped the optional interfaces
   XStatusIndicatorFactory
   XDispatchInformationProvider
from the combined IDL because the service does not implement them, and
nobody seems to be using them. I suspect they were mistakenly copied
from XFrame.

I also did not convert the Title, UserDefinedAttributes and LayoutManager
properties to attributes, again because no-one is using them.

Change-Id: I678a00006ed2cca2d6c37c4e39465811442c33af
 2012-12-21 10:57:09 +02:00
Stephan Bergmann a9916dabb4 Remove xml2cmp leftovers 
Change-Id: I7c0ba8b653b8e0534ae17bd879b93b75c6554893
 2012-12-12 10:27:41 +01:00
Michael Stahl 0990da105f clean up more sbxToUnoValue declarations 
Change-Id: Ieff54baaff53031712f737dab84f840adb3bb09a
 2012-12-04 19:56:52 +01:00
Noel Grandin 5aa2cd1d3f fdo#46808, use service constructor for uri::UriReferenceFactory 
Change-Id: I4e72bf5880fa28cb96d93ede7730a63220af7fa6
 2012-10-23 11:45:47 +02:00
Noel Grandin f649c5acd4 sal_Bool->bool in scripting 
Change-Id: Ibb61dc696c4341a0b58d8fd7c2fdfb4c5b991596
 2012-10-04 21:29:34 +02:00
Tor Lillqvist 1b075ea2cb Use prefix 
Change-Id: I0323e3eb9446c4f2b18f84f5ed33909a877163c8
 2012-10-02 11:46:16 +03:00
Noel Grandin f789715a41 fdo#46808, Use factory methods for frame::DispatchHelper instances 
Change-Id: I7bdf16fc6d042e5ecd404c604a8b7c31c1ac7bc1
 2012-08-27 15:40:06 +02:00
Michael Meeks 3f281b6f0a re-base on ALv2 code. Includes: 
remove onlineregistration with dependencies
Patch contributed by Juergen Schmidt
http://svn.apache.org/viewvc?view=revision&revision=1249245
 2012-07-06 20:29:14 +01:00
Michael Stahl 1ab899c4c8 .xml files don't need executable bits 
Change-Id: I399d086181a9f513cd95157e815551f0be9b9e95
 2012-06-22 22:39:31 +02:00
Michael Meeks ecf943247f re-base on ALv2 code. 
Change-Id: I8018d9b5fa01d1720c0392dc5fdc4a0656f25a35
 2012-06-22 09:51:05 +01:00
Michael Meeks b9042fad7c re-base on ALv2 code. 
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
 2012-06-21 15:00:05 +01:00
Norbert Thiebaud 65269c97c3 targeted string re-work 
Change-Id: I37e225902bf7f3a6e007e7641b2b9898b044a45b
 2012-06-02 20:19:28 -05:00
Szabolcs Dezsi e4fb171d3a Replaced a few equal calls with == 2012-04-08 19:24:00 +02:00
Szabolcs Dezsi d6bc02f8c4 Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator 2012-04-06 20:03:42 +02:00
Szabolcs Dezsi 743f22045c Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator 
Pattern used:

find . -name "*.cxx" -exec sed -i 's/\( *\)\(else if\|if\) *( *\([^!()|&]*\)\.equalsAsciiL( *RTL_CONSTASCII_STRINGPARAM *( *\([^)]*\)) *) *)$/\1\2 ( \3 == \4 )/' \{\} \;
 2012-04-06 15:07:41 +02:00
Michael Stahl 9429bbb0c4 .component files don't need executable bits 2012-03-23 21:58:14 +01:00
Takeshi Abe 660e4481a4 Avoid temporary rtl::OUString 
in scripting / sdext / starmath / stoc / svtools / svx
 2012-02-28 01:55:00 +09:00
Takeshi Abe 3006397439 Prefer equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM("...")) 
to equalsIgnoreAsciiCaseAscii("...")
 2012-02-21 01:07:21 +09:00