Commit Graph
6 Commits
Author SHA1 Message Date
Miklos Vajna d5cd62164d embeddedobj: handle getting the visible area on a thread
The Windows OLE2 implementation of the embedded object interface assumes
that the same thread is used for loading and saving the embedded
objects.

This means that in case the main thread is used for loading (e.g. from
remote UNO, but with OnMainThead=true), but a
thread is used for storing (without an explicit OnMainThead=true), then
the underlying win32 API call failed and we returned a fixed size in
EmbeddedObjectRef::GetSize().

Fix the problem by explicitly checking for RPC_E_WRONG_THREAD and adding
error handling for that case.

Change-Id: Icf1e7722d33a809fa671d1505b2a0155af040c71
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115236
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2021-05-07 14:21:40 +02:00
Miklos Vajna 85a7bc13fe embeddedobj: add initial CppunitTest_embeddedobj_general
Fails with commit 88afec7011 (embeddedobj:
respect config for Insert -> Object -> OLE Object -> from file,
2019-08-14) reverted.

Change-Id: I64f81642260f6eab5a86219d94553f09b67b3555
Reviewed-on: https://gerrit.libreoffice.org/77461
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2019-08-14 19:38:59 +02:00
Stephan Bergmann df984a465c Clean up dead uses of DISABLE_ATL
...after e597ef0489 "No need for --disable-activex
and --disable-atl any longer"

Change-Id: I6ea0026fd18e0097aaaf0c1b05618e2a9ddf1a94
Reviewed-on: https://gerrit.libreoffice.org/66871
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-24 21:23:56 +01:00
Michael Stahl 9d7c5dcf44 do not build emboleobj library on --disable-atl
Change-Id: I4973cbdd8afead3f189874ef754d2b2eee4bfb9c
2013-08-29 22:38:00 +02:00
Michael Meeks 72e5d0c8fb Move to MPLv2 license headers, with ESC decision and author's permission. 2013-04-30 13:34:06 +01:00
Matúš Kukan d76e2d1cc3 embeddedobj: convert to gbuild 2012-03-01 20:49:13 +01:00