ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
401,594 Commits 3 Branches 3 Tags
64d80d22851a38eb3f320f4e2b2bdf875da4d8b4
Commit Graph
685 Commits
Author SHA1 Message Date
Stephan Bergmann 182dfdd00e loplugin:unnecessaryoverride (dtors) in xmloff 
Change-Id: I351ff5955d766118e3a6b2234181774af0d1f522
 2016-12-01 08:53:50 +01:00
Noel Grandin 1b36f23b51 loplugin:oncevar in xmloff..xmlsecurity 
Change-Id: I2353d3c73130ed9420e8d803a9a96a06549bb6bd
Reviewed-on: https://gerrit.libreoffice.org/30429
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-31 10:32:27 +00:00
Noel Grandin a41ecf9227 loplugin:expandablemethods in xmloff 
Change-Id: I995a4167ac4df5ca35d963dcf68ae802a997e1e1
 2016-10-24 13:35:36 +02:00
Noel Grandin 7477ab1391 loplugin:inlineablemethods in xmloff 
Change-Id: I22202f85c65a862ccdafe1d521e2945e3d99252a
 2016-10-18 08:51:07 +02:00
Noel Grandin e592877844 loplugin:unusedenumvalues 
Change-Id: Icf17f936ce6d07d0e152252833c8645cf9b1163b
Reviewed-on: https://gerrit.libreoffice.org/28942
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-18 11:02:45 +00:00
Noel Grandin 0ea50b5b43 loplugin:countusersofdefaultparams in xmloff 
Change-Id: Ia92a878ac97b3cc668594946e77a718f27a3e3ed
Reviewed-on: https://gerrit.libreoffice.org/28890
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-14 08:47:48 +00:00
Stephan Bergmann 91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Caolán McNamara 9b181fa48f coverity#1371368 Resource leak 
Change-Id: I5c35b3eaa6e9afe10096bf5013f83ff51cb870a4
 2016-08-18 21:08:40 +01:00
Noel Grandin 500a3be0ea loplugin:countusersofdefaultparams in vcl..xmlsecurity 
Change-Id: I538596a99e632178d928ff7e66ad45c71b73c6fd
Reviewed-on: https://gerrit.libreoffice.org/28018
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-12 06:54:08 +00:00
Noel Grandin 938821fb08 new loplugin overrideparam 
verify that parameters on override methods have the same set of default
values for their params as their parent/super-methods do.

Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2
Reviewed-on: https://gerrit.libreoffice.org/27437
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-25 06:09:17 +00:00
Noel Grandin 6e72f0251b new loplugin unnecessary override 
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb
Reviewed-on: https://gerrit.libreoffice.org/27135
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-07-15 14:05:41 +00:00
Stephan Bergmann 2cdc693c56 Remove __cplusplus-checks from apparently-C++-only files 
Change-Id: I87e9ce45cf945e75e8140a9d4608da8abcddada6
Reviewed-on: https://gerrit.libreoffice.org/27187
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-07-13 14:54:14 +00:00
Otto Kekäläinen 428e23f4f7 Fix some spelling errors in comments and strings 
Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e
Reviewed-on: https://gerrit.libreoffice.org/26883
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
 2016-07-04 06:11:36 +00:00
Stephan Bergmann 25dafb5f83 -Werror,-Wunused-private-field 
Change-Id: I23caef822107596c9c04a8d4c28b30f32b7095ba
 2016-06-24 09:33:34 +02:00
Noel Grandin 6a5e30d52c loplugin:singlevalfields in xmlhelp,xmloff 
Change-Id: Ia40d1c9a153b5237c46d5a2b807dceff30775f4a
Reviewed-on: https://gerrit.libreoffice.org/26589
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-24 06:46:01 +00:00
Noel Grandin e9af29ba83 loplugin:unusedmethods in writerfilter to xmloff 
Change-Id: If95890eff0f785111e8b511ac1d5481c6910f099
Reviewed-on: https://gerrit.libreoffice.org/25148
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-19 10:01:23 +00:00
Noel Grandin 96fab05132 clang-tidy modernize-loop-convert in writerfilter to xmlsecurity 
Change-Id: I334411c6b57c028ffb41b5deb72002f9d54038c3
Reviewed-on: https://gerrit.libreoffice.org/24923
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-13 08:09:03 +00:00
Stephan Bergmann 2ea7fe2522 Add SAL_FALLTHROUGH, where apparently appropriate 
Change-Id: I646abf83b4dce8c92a3ba1c136d968bb9291dd83
 2016-05-10 17:04:20 +02:00
Stephan Bergmann 14cd5182c5 Replace fallthrough comments with new SAL_FALLTHROUGH macro 
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough.  (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)

Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently.  (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.)  C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.

Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
 2016-05-10 16:42:16 +02:00
Stephan Bergmann 5ef76efb40 loplugin:salbool: Automatic rewrite of sal_False/True 
Change-Id: I5896c6b8bf2aa9c7c66ca5f7c50cee1b0738ea0a
 2016-04-20 17:27:32 +02:00
Noel Grandin 789055bc2a clang-tidy performance-unnecessary-copy-initialization 
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.

Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 07:37:31 +00:00
Noel Grandin 868444c803 loplugin:passstuffbyref in xmloff 
Change-Id: I5995510c5c0686e5e69e8853d81dcba83ae96211
 2016-04-14 09:21:39 +02:00
Stephan Bergmann 9b1307f790 Avoid reserved identifiers 
Change-Id: I759939aa74570be63f5d41814c22aad1851d65c4
Reviewed-on: https://gerrit.libreoffice.org/23587
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-03-29 07:11:31 +00:00
Noel Grandin 78f0d15893 loplugin:constantparam in xmloff/ 
Change-Id: I376f1d4ac65de584f9caa6ba8e25e43216374112
Reviewed-on: https://gerrit.libreoffice.org/23295
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-16 11:35:38 +00:00
Wastack 7a0b8decb7 tdf#97966: Remove 'static' keywords 
Change-Id: Id70f9e55fb4ad7d3a501399b055208ea10369c82
Reviewed-on: https://gerrit.libreoffice.org/23131
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-03-11 08:54:33 +00:00
Chris Sherlock a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Miklos Vajna f2d5d0ac1d xmloff: one more missing include 
Change-Id: I92080eefa485dec86c3a10f978831157b04a0c53
 2015-12-19 22:50:31 +01:00
Caolán McNamara 8f85595371 coverity#1343637 Double free 
and

coverity#1343638 Double free
coverity#1343639 Double free
coverity#1343640 Double free
coverity#1343641 Double free

Change-Id: I8ce42f03d40fe514f73b3a7eabdb4f323b2239e6
 2015-12-19 18:10:11 +00:00
Stephan Bergmann d138573103 Avoid memory leaks 
...when exceptions get thrown while a context owns an rewind map

Change-Id: I90d26caa57ef2ff508e6eae05ddbc62cdb3f01ea
 2015-12-17 16:51:17 +01:00
Stephan Bergmann ba3a918404 Remove trivial class XMLTransformerContextVector 
Change-Id: I140614895d5727ffd97681ddd06bf7439fe7a443
 2015-12-17 16:51:16 +01:00
Stephan Bergmann 21e72c5f1d Hold XMLTransformerContext by rtl::Reference 
Change-Id: I60b8d422d53d47537996756aa1b7fb3c26f8383a
 2015-12-17 16:51:16 +01:00
Noel Grandin 80735fcbb0 com::sun::star->css in xmloff/ 
Change-Id: Iee6e21e093fb1383f19a0716dbc1c341f446b8c2
Reviewed-on: https://gerrit.libreoffice.org/20192
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-26 10:47:02 +00:00
Oliver Specht fa91dd31f3 5th step to remove tools/rtti.hxx 
tools/rtti.hxx removed
completed the interface of some Sdr.*  Items
and removed pseudo items

Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a
Reviewed-on: https://gerrit.libreoffice.org/19837
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
 2015-11-11 10:49:30 +00:00
Stephan Bergmann 51b45df6bb loplugin:nullptr (automatic rewrite) 
Change-Id: I8690de2cb68dcfedc9f2239ce66cea06fd94bc16
 2015-11-10 10:32:01 +01:00
Stephan Bergmann 41a000b742 loplugin:stringconstant: elide explicit ctor usage (automatic rewrite) 
Change-Id: Ibb9372bc45a0bc0b9083ad0e405440bbbe5ef678
 2015-11-06 09:38:44 +01:00
Noel Grandin 9e8ff13eb2 use uno::Reference::set method instead of assignment 
Change-Id: I60e52ef2abc3107ba77e81811dfe1bffbfd77218
 2015-11-05 13:32:17 +02:00
Stephan Bergmann 9acfbf8294 loplugin:defaultparams 
Change-Id: I4f0a7baa517c2526dcea4d7fb779df6da32bda0f
 2015-10-19 17:52:17 +02:00
Stephan Bergmann b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Andrea Gelmini 4678982056 Fix typos 
Change-Id: I2cdfc4e9d8ba1acb7c2548f9394d320c6504207e
Reviewed-on: https://gerrit.libreoffice.org/18997
Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org>
Tested-by: Joren De Cuyper <jorendc@libreoffice.org>
 2015-09-29 22:13:57 +00:00
Takeshi Abe 8358eadcba xmloff: tdf#88206 replace cppu::WeakImplHelper* 
with the variadic variants.

Change-Id: I47002abab1e025d0683f4cf8ef7b6c99e668d425
Reviewed-on: https://gerrit.libreoffice.org/18479
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-09-11 17:16:17 +00:00
Noel Grandin a62129aa63 loplugin:unusedmethods xmloff 
Change-Id: I9d15d8edcc6746c055336bf31e5b0c15cb971ffe
Reviewed-on: https://gerrit.libreoffice.org/17061
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-15 10:36:25 +00:00
Andrea Gelmini 1c5f07e60c Fix typos 
Change-Id: I98b4dfb0f72f315065693335e2f882bb2eed3afe
Reviewed-on: https://gerrit.libreoffice.org/16713
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2015-07-03 09:14:23 +00:00
Andrea Gelmini 1a8915ef83 Fix typos 
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e
Reviewed-on: https://gerrit.libreoffice.org/16582
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
 2015-06-30 15:57:12 +00:00
Noel Grandin 4354341159 remove our custom RTTI from xmloff module 
not being used, anyhow

Change-Id: I0eb0d6377efe324d9a442a70fc2046a58ed2f3c4
 2015-06-25 11:50:10 +02:00
Andrea Gelmini ae150c6a54 Fix typos 
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8
Reviewed-on: https://gerrit.libreoffice.org/16314
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2015-06-18 11:44:56 +00:00
Stephan Bergmann 689a4a6973 loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I6fa6ee6d9eaf98a00624ad353dc6d2c5687b0547
 2015-06-08 16:30:03 +02:00
Caolán McNamara e50698c0ce cppcheck: noExplicitConstructor 
Change-Id: I8c9e970d5c5931de1a7526cbff3de626ef30bd74
 2015-05-24 20:58:24 +01:00
Stephan Bergmann 338358b0ca XMLTransformerActionInit parameters are generically of type sal_uInt32 
Change-Id: Ic36339fbb78a6ac3233f3d75a1309cf1b0642fe0
 2015-05-08 09:49:04 +02:00
Stephan Bergmann 2049e3ec22 XMLTransformerActionInit parameters are generically of type sal_uInt32 
Change-Id: I8a013c8ca8938ef2d8e1786cda3dba61fe3038a5
 2015-04-28 13:44:19 +02:00
Stephan Bergmann ba15d30e8d loplugin:simplifybool 
Change-Id: I4a7ba9192956941f05e68ae8df3263d609a7c4dc
 2015-04-24 12:36:31 +02:00