ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
401,594 Commits 3 Branches 3 Tags
64d80d22851a38eb3f320f4e2b2bdf875da4d8b4
Commit Graph
154 Commits
Author SHA1 Message Date
Noel Grandin d64395704e loplugin:unusedenumconstants in unotools..xmlhelp 
Change-Id: Id7ddc0fc1f57c5e8e7fb002e31d54fb8e9f8ffab
Reviewed-on: https://gerrit.libreoffice.org/28050
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-15 05:51:53 +00:00
Noel Grandin 508c95f1b6 improve passstuffbyref return analysis 
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-27 06:48:25 +00:00
Noel Grandin bc1e738708 Convert IteratorState to scoped enum 
Change-Id: I71850584a727261e9e7b2115bdfb488ba76b6d21
Reviewed-on: https://gerrit.libreoffice.org/25919
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-06 07:02:26 +00:00
Noel Grandin 96fab05132 clang-tidy modernize-loop-convert in writerfilter to xmlsecurity 
Change-Id: I334411c6b57c028ffb41b5deb72002f9d54038c3
Reviewed-on: https://gerrit.libreoffice.org/24923
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-13 08:09:03 +00:00
Noel Grandin 58a32075ca use Any constructor instead of temporaries 
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
 2016-05-04 12:39:40 +02:00
Noel Grandin 789055bc2a clang-tidy performance-unnecessary-copy-initialization 
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.

Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 07:37:31 +00:00
Noel Grandin 62633dfe02 clang-tidy performance-unnecessary-value-param in various 
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907
Reviewed-on: https://gerrit.libreoffice.org/24019
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-14 11:37:19 +00:00
Noel Grandin fa452b54a5 com::sun::star->css in xmlhelp 
Change-Id: Iaa57a071f8f0e6945d24f019cb4c06e02d066e0a
Reviewed-on: https://gerrit.libreoffice.org/20147
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-25 04:47:05 +00:00
Noel Grandin 25aec383f9 use initialiser for Sequence<OUString> 
replaced using:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)'
| xargs perl -0777 -pi -e
"s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\);
.*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g"

Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9
Reviewed-on: https://gerrit.libreoffice.org/19969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 12:18:55 +00:00
Stephan Bergmann 87bae0e188 loplugin:nullptr (automatic rewrite) 
Change-Id: Ibdc68ac3fa6e1424337096c720c8c9605b767480
 2015-11-10 10:32:01 +01:00
Stephan Bergmann fd80fa38db loplugin:stringconstant: elide explicit ctor usage (automatic rewrite) 
Change-Id: I9ee0d12d68cef7bd65d1e119d0272e356e7cf300
 2015-11-06 09:38:40 +01:00
Noel Grandin 9e8ff13eb2 use uno::Reference::set method instead of assignment 
Change-Id: I60e52ef2abc3107ba77e81811dfe1bffbfd77218
 2015-11-05 13:32:17 +02:00
Noel Grandin 3bc5df7f32 UNO: no need to use OUString constructor when calling createInstance 
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526
Reviewed-on: https://gerrit.libreoffice.org/19682
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-30 08:59:59 +00:00
Stephan Bergmann 6afc1202ae loplugin:stringconstant: OUStringBuffer: appendAscii -> append 
Change-Id: I816d2205dcd01d4566054da33439e943a3c6348b
 2015-08-31 08:00:15 +02:00
Andrea Gelmini 1c5f07e60c Fix typos 
Change-Id: I98b4dfb0f72f315065693335e2f882bb2eed3afe
Reviewed-on: https://gerrit.libreoffice.org/16713
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2015-07-03 09:14:23 +00:00
Stephan Bergmann 6390d2c52b Get rid of comphelper::string::is*Ascii functions 
Change-Id: I99912112e5b009d7a143f9816d757cdf6ebb1783
 2015-06-24 15:27:28 +02:00
Caolán McNamara cc0e9a37de cppcheck: variableScope 
Change-Id: If0c56c89e2722d47a401363f3854331229856490
 2015-06-09 10:33:59 +01:00
Stephan Bergmann e7b4225fc8 loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I4e24ee646763e758a404bf0832e31e5cebc9d71d
 2015-06-08 16:29:59 +02:00
Noel Grandin 6ef9f7e202 loplugin:loopvartoosmall 
Change-Id: Ib4def3435eab4625645c5afe3b151f9f430564ac
 2015-06-02 12:09:56 +02:00
Caolán McNamara acad8441cc cppcheck: noExplicitConstructor 
Change-Id: I62076450ab77472bfd09b3fb9824f54b6ea1e0f7
 2015-05-25 12:32:54 +01:00
Noel Grandin 0a7b739cc3 loplugin:staticmethods 
Change-Id: I2ee91d07cf9d46cdc385a4db8473550b05e2f0ad
 2015-04-23 13:08:48 +02:00
Noel Grandin 71b809959b remove unnecessary use of void in function declarations 
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
 2015-04-15 11:47:12 +02:00
Stephan Bergmann fa683a7020 const_cast: convert some C-style casts and remove some redundant ones 
Change-Id: I88d1d082cc25a185322435a75c94f4c6b4ad12f8
 2015-03-26 15:33:40 +01:00
Stephan Bergmann fb4fec646d xmlhelp: Use appropriate OUString functions on string constants 
Change-Id: I8642ec147cb0dca32dce7ec7f3efec93bcb99cb4
 2014-12-18 14:12:38 +01:00
Stephan Bergmann e09a8259e4 xmlhelp: Use appropriate OUString functions on string constants 
Change-Id: I28f68ff0c43366b3877244ba272acf967f141e54
 2014-12-15 10:22:06 +01:00
Andrea Gelmini da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Noel Grandin 705c48d32e fdo#38835 strip out OUString globals 
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.

Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
 2014-11-05 08:44:19 +02:00
Noel Grandin adc20c3937 compareToAscii -> equalsAscii 
convert places using compareToAscii that should be using equalsAscii

Change-Id: I97b4da7f6e867c3967b2f65b70d6886f83b4a4e5
 2014-06-04 11:52:31 +02:00
Noel Grandin e7bc3cab01 remove boilerplate in UNO Exception constructor calls 
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
 2014-05-23 15:06:00 +02:00
Noel Grandin abd8c2a0f6 xmlhelp: sal_Bool->bool 
Change-Id: I0aa1b7023b5100fb855a8a839e44036988d8bc2e
 2014-05-02 08:49:21 +02:00
Stephan Bergmann 9d9f8151f3 Remove unused code 
Change-Id: Ia624a624271b1143c96cd189cc9e4dab4c5ae302
 2014-04-15 09:30:36 +02:00
Norbert Thiebaud 27399c3433 de-macroize xmlhelp tvfactory 
Change-Id: Ie4b0e0923ade427f7ab637e8e76769a6dca957c5
 2014-03-20 18:03:00 -05:00
Norbert Thiebaud db5407b6ac de-macroize xmlhelp TVBase 
Change-Id: I92e9bc4bbdf18273d26d666d98401cd83a9b1560
 2014-03-20 17:56:12 -05:00
Marcos Paulo de Souza 4d6560f506 fdo#54938: Convert some places to use cppu::supportsService 
The last cases are non obvious, so it's pratically done

Change-Id: Icae1da8e238f516eaed0f7fbdf96fff778eac547
Reviewed-on: https://gerrit.libreoffice.org/8445
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
 2014-03-04 07:30:02 -06:00
Stephan Bergmann 5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Marcos Paulo de Souza 1c3d51fd68 fdo#60698: Merge tvhlp1 into ucpchelp1 
tvhlp1 just have 2 files, and this lib is used always with ucpchelp1. By
these reasons, we can merge these 2 libs.

Change-Id: I515f9c12893c986279ffac91b83879c467b091c7
Reviewed-on: https://gerrit.libreoffice.org/6820
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2013-12-02 05:15:36 -06:00
Noel Grandin 610b2b94b3 remove unnecessary use of OUString constructor when assigning 
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
 2013-11-19 10:29:31 +02:00
Noel Grandin d366c9b20e remove unnecessary sal_Unicode casts in various places 
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
 2013-11-14 08:17:32 +02:00
Norbert Thiebaud bd7f704ed4 xmlhelp: include <> for external includes 
Change-Id: I274968e015f1d0c3d06aa5040f53b72d14c45b9f
 2013-11-11 22:37:29 -06:00
Noel Grandin fcd1637d51 convert OUString compareToAscii == 0 to equalsAscii 
Convert code like
   aStr.compareToAscii("XXX") == 0
to
  aStr.equalsAscii("XXX")
which is both easier to read and faster.

Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
 2013-11-11 12:58:13 +02:00
Noel Grandin 58fa3d50aa remove unnecessary use of OUString constructor in XMLHELP module 
Change-Id: I033bcf9cddc58f605fe8d65731f8b312410da7e5
 2013-11-07 13:22:56 +02:00
Caolán McNamara ebfa1e6c86 CID#707598 uninitialized scalar values 
Change-Id: Id3c6488cfda25ab809bf554216bf2e5161456be0
 2013-09-21 12:36:43 +01:00
Luboš Luňák 64b993e046 finish deprecation of O(U)String::valueOf() 
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
 2013-08-21 15:10:35 +02:00
Jelle van der Waa 87b5ac652d fdo#57950: Remove some chained appends in xmhelp 
Change-Id: I4680547aa1d12d3e8eab3c33e3158845848c2068
Reviewed-on: https://gerrit.libreoffice.org/5376
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
 2013-08-13 11:11:42 +00:00
Jelle van der Waa 2f66b0cb11 fdo#62475 removed pointless comments 
Change-Id: I4fa01553246fa023806b3fec8e6e756a1efa59f1
Reviewed-on: https://gerrit.libreoffice.org/5342
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
 2013-08-10 19:23:25 +00:00
Thomas Arnhold ba0a57702c remove OUString wrap for string literals 
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-06-29 21:52:54 +00:00
Michael Stahl 52e0ff8363 stop this decadent waste of precious newlines 
Change-Id: I803d7d56ba7350fd0f5b2c4efa392d55a0fd4542
 2013-06-06 11:08:31 +02:00
Michael Stahl 3ddf70dc11 xmlhelp: fix reading symlinked .tree files 
Apparently the .tree files nowadays are symlinked, which was not the
case on the libreoffice-4-0 branch... and on viewing the Contents tab
it's evident we can't actually read symlinked .tree files, and crash
with an STL assert because the children vector is empty.

Change-Id: I5a543ef85b827e194120530a486cf19a76837d87
 2013-06-06 11:08:31 +02:00
Noel Grandin 27c6434fcc fdo#46808, Replace usage of SpecialConfigManager 
with usage of the underlying SvtPathOptions. The service is just
a thing wrapper that serves no real purpose.

Change-Id: Id762edf71ba0f699ef091261905c88c2d93e1c12
 2013-06-05 14:48:19 +02:00
Peter Foley cd79d51420 prefix all component_getFactory methods 
Change-Id: I954176fdab9103125444dd2fb397673406f7aff9
 2013-04-15 09:12:08 -04:00