ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
401,594 Commits 3 Branches 3 Tags
64d80d22851a38eb3f320f4e2b2bdf875da4d8b4
Commit Graph
37 Commits
Author SHA1 Message Date
Stephan Bergmann 91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Noel Grandin 20c14c812c loplugin:constantparam in sfx2 
Change-Id: If5d401001abb7bf3fc642d47f537b57836e6d9c5
Reviewed-on: https://gerrit.libreoffice.org/28772
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-09-09 12:42:25 +00:00
Wastack eea3f508c3 tdf#97966 Drop 'static' keywords 
Including no keywords from extern "C" blocks

Change-Id: I87f2ed75888b51ec9e0cb75566bf7c2351b479b4
Reviewed-on: https://gerrit.libreoffice.org/23675
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-04-01 06:46:02 +00:00
Stephan Bergmann 21f98618d8 -Werror=terminate (GCC 6) 
...when throwing an exception from implicitly noexcept ~GErrorWrapper.  So make
~GErrorWrapper noexcept(false) and see that no code executed while a
GErrorWrapper instance is active on the stack would throw an exception.  But the
design of GErrorWrapper, to throw an exception from a dtor, is very brittle and
should be fixed.

Change-Id: Ib04ff2b0497c160dc7ee44c3354fa9619285ec88
 2016-01-19 10:37:55 +01:00
Stephan Bergmann b8793748b0 Seems more natural to pass a homogenous list by initializer_list 
...than by template parameter pack (even if that requires using ServiceDecl*, as
initializer_list cannot take reference types)

Change-Id: Ia986201b52d8daedfe925f132ebc79bc2c0ba378
 2015-11-20 13:39:52 +01:00
Stephan Bergmann 7a8d48f57d loplugin:nullptr (automatic rewrite) 
Change-Id: Ied61699170bd5d2c3878135b1a43b4dc1deff4d4
 2015-11-10 10:31:39 +01:00
Noel Grandin 56c4032272 com::sun::star->css in shell 
Change-Id: Id74a5e79764f37944afab4d2a0dcfc7dbfc9b295
Reviewed-on: https://gerrit.libreoffice.org/19663
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-29 08:44:12 +00:00
Stephan Bergmann b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Stephan Bergmann bff4c13475 Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code 
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
 2015-10-12 17:52:26 +02:00
Takeshi Abe cfaebe5de9 shell: tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants.

Change-Id: I0eb2efbd123198c7d8a99e9dd7c613f9b2b23c2d
Reviewed-on: https://gerrit.libreoffice.org/18286
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2015-09-03 17:55:02 +00:00
Noel Grandin 46791546a8 cppcheck:noExplicitConstructor 
Change-Id: I940714e303b905b756ba077eeda6c41746bd421f
 2015-08-07 08:14:34 +02:00
Stephan Bergmann 4bf8384d97 loplugin:simplifybool 
Change-Id: I822967265cbe9f58641e2d9bd1260fd724df8ad1
 2015-07-16 14:00:20 +02:00
Noel Grandin 1afb790a11 inline COMPHELPER_SERVICEDECL_ macro 
it was not adding any value

Change-Id: I6a911aac81e883f9155ed0cf24bfb7904efb3f92
 2015-06-15 09:46:14 +02:00
Stephan Bergmann 2633a2a34e boost::shared_ptr -> std::shared_ptr 
Change-Id: Iff798bd2ae4fec97f0f1647ea33f6f6ff1f3b208
 2015-05-18 12:16:32 +02:00
Stephan Bergmann 2527a4d5a7 Implement some more XModify methods 
Change-Id: I1345d6a3d62f1e5c3353c5412024f6b47f824f7a
 2015-05-13 16:45:09 +02:00
Stephan Bergmann fe5644984a loplugin:deletedspecial 
Change-Id: I2a3d9deb9c71bb4dfe3ad9076d7202636001e0bb
 2015-02-07 12:36:02 +01:00
Noel Grandin 0371a63365 remove unnecessary 'using namespace rtl' declarations 
It turns out that almost none of them were necessary.

Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-29 11:28:54 +00:00
Stephan Bergmann 83ac0fd7bd Fix *_component_getFactory function type 
Change-Id: I406e0b659f551f347a8fa9ae2a57ec7965ba7ea0
 2014-08-28 17:35:03 +02:00
Noel Grandin e2080e70fe new compilerplugin returnbyref 
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
 2014-06-24 11:34:21 +02:00
Noel Grandin f0ae48b684 remove unnecessary NULL parameter passed to UNO Exception 
.. now that we have a default value for that parameter

Change-Id: I54d6b0a0a01ce2f2e5168ada0c427424de0477bc
 2014-05-29 09:01:40 +02:00
Noel Grandin 5babf1b903 remove unnecessary scope qualifier from sal_Bool uses 
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
 2014-04-03 13:54:02 +02:00
Stephan Bergmann 70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
 2014-03-26 16:39:26 +01:00
Noel Grandin 86a32589e9 Find places where OUString and OString are passed by value. 
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
 2014-03-18 08:32:26 +02:00
Stephan Bergmann 5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Stephan Bergmann 9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..." 
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
 2013-12-17 11:06:00 +01:00
Marcos Paulo de Souza bcb51cff22 fdo#63020: Replace ::comphelper::stl_begin()... 
And use some templates inside include/com/sun/star/uno/Sequence.hxx

Change-Id: I48875fa1517751fc4cb0cf2b6c08b88975a29b47
Reviewed-on: https://gerrit.libreoffice.org/6599
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2013-11-07 10:43:34 -06:00
Thomas Arnhold 48dd3571f8 fixincludeguards.sh: shell 
Change-Id: I987c54b15c271fc80b7efd25933e13950f974423
 2013-11-05 09:28:53 +01:00
Thomas Arnhold ba0a57702c remove OUString wrap for string literals 
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-06-29 21:52:54 +00:00
Ivan Timofeev 9dd52eb86a use GLIB_CHECK_VERSION instead of GLIB_VERSION_X_XX 
Michael Meeks pointed out that the latter can cause problems.

Change-Id: I68e7f8c6dcfae52305738b2a8cdee72e9c2c7f93
 2013-04-19 17:46:28 +04:00
Ivan Timofeev 025857d81d WaE: g_type_init has been deprecated since GLib 2.36 
Change-Id: Ied9b2c2424d780d589cb1b07df0ec38107d49829
Reviewed-on: https://gerrit.libreoffice.org/3434
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2013-04-18 09:19:46 +00:00
Peter Foley cd79d51420 prefix all component_getFactory methods 
Change-Id: I954176fdab9103125444dd2fb397673406f7aff9
 2013-04-15 09:12:08 -04:00
Luboš Luňák 1946794ae0 mass removal of rtl:: prefixes for O(U)String* 
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
 2013-04-07 14:23:11 +02:00
Michael Stahl ca00713a61 offapi: rename XModify.InstalliGStreamerResources 
...since GStreamer is not an Apple product it should not be
called iGStreamer.

Change-Id: Ia2b73ecb56dd7aee88b23b560430ffe94b455665
 2012-11-20 21:44:16 +01:00
Bjoern Michaelsen b6c6fc8ced template pack installer 
- so this adds a button to the templates dialog to install
  https://launchpad.net/ubuntu/+source/libreoffice-templates/0.1.20120814-0ubuntu2
  which is packed from
  http://cgit.freedesktop.org/libreoffice/templates
- could be packed and used like that on other distros
- disabled when service is not available

Change-Id: I55d5bada25693070aae5e5f9e0e77bf8aa52e982
Reviewed-on: https://gerrit.libreoffice.org/1071
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
 2012-11-16 11:38:19 +00:00
Caolán McNamara 15055466e0 fix annoying Ressource typo 
Change-Id: Ie6cf3cc8e672ad9499c55bda7c29b50140c6a57a
 2012-11-12 11:18:29 +00:00
David Tardon 40c1e728c4 WaE: unused parameter 
Change-Id: Ib9956bd2671434fc15905e7c4fd56bd8f7162b60
 2012-11-10 08:46:53 +01:00
Bjoern Michaelsen 8cd6a947d9 making org.freedesktop.PackageKit.Query and .Modify available 
- partial implementation of the SessionInstaller interfaces
 - accessable via service:
   org.freedesktop.PackageKit.SyncDbusSessionHelper

Change-Id: Ica91f481d041a066215fba3e808bf587e1271f1b
 2012-11-09 19:18:34 +01:00