ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
401,594 Commits 3 Branches 3 Tags
64d80d22851a38eb3f320f4e2b2bdf875da4d8b4
Commit Graph
312 Commits
Author SHA1 Message Date
Noel Grandin 3a705ab405 OSL_TRACE->SAL in avmedia..canvas 
Change-Id: Id9077ea29e7028c12f40abfd4c57756c863e3cd9
 2016-12-13 08:14:00 +02:00
Tor Lillqvist add4bc9636 loplugin:staticmethods 
Change-Id: Ic65f024fd88915544539dedf3aa1c68a945cddd3
 2016-12-08 10:29:14 +02:00
Jochen Nitschke 0c6c37cb01 cleanup unused includes (related to tdf#88206) 
cppuhelper/compbase*.hxx and cppuhelper/implbase*.hxx

compbase*.hxx includes implbase*.hxx replace compbase*.hxx if only
implbase*.hxx stuff is used.

Change-Id: I631a20aee411c6a32ffcf470f6e392621755f995
Reviewed-on: https://gerrit.libreoffice.org/31686
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-06 18:17:06 +00:00
Noel Grandin bfde4866e0 convert DecodeMechanism to scoped enum 
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
 2016-12-05 12:49:02 +02:00
Noel Grandin 803215142e convert INetURLObject::EncodeMechanism to scoped enum 
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
 2016-12-05 12:49:02 +02:00
Niklas Johansson 1453bc4ab3 tdf#93592 Make it possible to add default language resource to dialogeditor 
During the conversion of uno services a few lines where removed that
probably should not have been removed. This caused the dialog editor
to crash if you tried to add a new language resource to a document
fdo#93077. The fix for that bug fixed the crash but also made it
imposible to add a language resource to a dialog that isn't previously
translated.

With this patch the functionality should be back on track, adding/removing
language resources without problems at least as far as my testing goes.

Change-Id: Ie6e083837894a219bf8e9c75dec6bf7652d51615
Reviewed-on: https://gerrit.libreoffice.org/30462
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2016-12-02 09:07:35 +00:00
Noel Grandin f31d98f63c loplugin:expandablemethods in avmedia..canvas 
Change-Id: Ic230f1ef6b1dbe796ac7862a1a7e6a718f9e4e54
Reviewed-on: https://gerrit.libreoffice.org/30753
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-11 07:00:18 +00:00
Jochen Nitschke d1ea6ecda6 replace <<= with assign for <<= with rhs Any 
found by deleting specialization of '<<=' template

Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c
Reviewed-on: https://gerrit.libreoffice.org/29956
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2016-10-18 19:16:44 +00:00
Hieronymous 6956e3379b Improve UNO error reporting. Make exceptions more descriptive. 
Change-Id: I7f7462d2fe2fa29361fd51871bf43bcc5e817944
Reviewed-on: https://gerrit.libreoffice.org/29771
Tested-by: jan iversen <jani@documentfoundation.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
 2016-10-13 14:01:40 +00:00
Michael Stahl b647996a9b replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos) 
... except in include/rtl, include/sal, include/uno, where sal_Size is
retained for compatibility, and where callers of rtl functions pass in
pointers that are incompatible on MSVC.

Change-Id: I8344453780689f5120ba0870e44965b6d292450c
 2016-09-15 12:01:11 +02:00
Jochen Nitschke f1018190a8 tdf#88205 use list ctor for uno::Sequence a11y to canvas 
Change-Id: Ib719c94c0488b8a48fdb013bc8fbd1a988595d18
Reviewed-on: https://gerrit.libreoffice.org/28866
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-14 07:23:51 +00:00
nadith c85a3ac70d tdf#100726: Improve readability of OUString concatenation 
all most all of the places in the basic basctl modules this bug fixed

Change-Id: I1a4a03e207c1b520449c31a05265585120da07f6
Reviewed-on: https://gerrit.libreoffice.org/27662
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-04 05:53:34 +00:00
nadith 054cf21948 tdf#100726: Improve readability of OUString concatenation in basic module 
Change-Id: I96c3215cf9f8932127e681aaaaee649774cac2e4
Reviewed-on: https://gerrit.libreoffice.org/27229
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-15 08:39:51 +00:00
Stephan Bergmann 0b424c2506 loplugin:passstuffbyref also for {css::uno,rtl}::Reference 
Change-Id: I614d91e7e4a686613dc0cbe1b9f4fabb978ffc77
 2016-07-07 18:59:55 +02:00
Stephan Bergmann da50c790a7 loplugin:salbool: Automatic rewrite of sal_False/True 
Change-Id: Ib91f20761167ab78b68813d8877dceea5fef801f
 2016-04-20 17:25:35 +02:00
Noel Grandin f678b82f0e clang-tidy performance-unnecessary-value-param in basic 
Change-Id: I997213ca28efc2df04d454ffaf3c81c9cbad09ac
 2016-04-11 11:38:57 +02:00
Noel Grandin 8ca50d20c1 loplugin:constantparam in tools 
Change-Id: I3774661799c074561c694515baba42a375d0a077
Reviewed-on: https://gerrit.libreoffice.org/23301
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-03-17 06:09:42 +00:00
Caolán McNamara 4530bc5079 coverity#1355498 assume Unchecked return value is deliberate 
Change-Id: I8b0597a5ab87d4d4529e3ccc097902486a41e957
 2016-03-14 21:00:35 +00:00
Michael Stahl 6a351c5cf9 basic: tdf#87530 if a new password is set, must set mbLoadedSource flag 
... so that the library is stored (and encrypted), and not copied
unencrypted from source storage.

Change-Id: I9546087ec6f07007aa1ec377d2e959f2bae99a38
 2016-03-07 12:05:32 +01:00
Michael Stahl aeb4391636 basic: tdf#87530 don't copy storage that doesn't exist 
If the Basic library is newly created it may not have been stored to the
document storage yet.

(regression from 5246fa2624)

Change-Id: I9c2fc1d7446795b9c1c2224671118b2a671dcad8
 2016-03-07 12:05:32 +01:00
Arnaud Versini 14420e8329 BASIC : Add tools::make_ref and simplify SvRef usage 
Change-Id: I8fe846dbd353bace05a8732a9b961f3507d97ef8
Reviewed-on: https://gerrit.libreoffice.org/22587
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-22 12:33:52 +00:00
danielt998 2b31daf74e tdf#95857 Sort out German plurals ... 
Made a start in removing the incorrect 'Infos' German plural

Change-Id: Ie989351a7473fc35b563e63ce6a4fb229093af60
Reviewed-on: https://gerrit.libreoffice.org/22301
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2016-02-12 15:29:25 +00:00
Chris Sherlock a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Noel Grandin 4c411636d9 sequence->vector in basic 
Change-Id: Ic42f7218bda81effe870d950f666ba7653d60c66
Reviewed-on: https://gerrit.libreoffice.org/22177
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-08 12:31:10 +00:00
Noel Grandin 310b65e5e9 sequence->vector in basic 
Change-Id: Ic1b72a6c5e9df5d0fa65626ec1d8eda6a2d2feec
Reviewed-on: https://gerrit.libreoffice.org/22176
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-08 12:30:29 +00:00
Andrea Gelmini 92e60e1b80 Fix typos 
Change-Id: I1b79005d9c4e32325b8dadcc4f805975d6bf2727
Reviewed-on: https://gerrit.libreoffice.org/21103
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
 2016-01-05 07:32:28 +00:00
Noel Grandin 70d14d2ccd loplugin:unusedfields in basic 
Change-Id: I304f3903f305ba5b538964071ab95b57ebf2f970
 2015-12-23 09:46:48 +02:00
Stephan Bergmann 08e49fa337 loplugin:nullptr (automatic rewrite) 
Change-Id: I1ec9a671fe3ac838feb36297915e3cdf8749d944
 2015-11-10 10:31:17 +01:00
Stephan Bergmann a80bab7058 loplugin:stringconstant: elide explicit ctor usage (automatic rewrite) 
Change-Id: I9979100550a86ac3f42d74a5403fb3ffd9d5006b
 2015-11-06 09:34:39 +01:00
Noel Grandin 59b072e22b yyyyy 
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
 2015-11-04 14:10:44 +02:00
Noel Grandin 3bc5df7f32 UNO: no need to use OUString constructor when calling createInstance 
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526
Reviewed-on: https://gerrit.libreoffice.org/19682
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-30 08:59:59 +00:00
Noel Grandin 065c8b48a6 use uno::Reference::set method instead of assignment 
Change-Id: I58410209f32f988f258a588364e0b037c2790211
 2015-10-30 08:10:22 +02:00
Noel Grandin ccc5ea08d6 cppcheck:variableScope 
Change-Id: I037feb335499629300309851dcda3bb661f03d4f
Reviewed-on: https://gerrit.libreoffice.org/19316
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-12 06:52:56 +00:00
Caolán McNamara 3a00aaef2a boost->std 
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-09-18 07:59:14 +00:00
Laurent Godard 8a7b7b7b72 New identifier for save/open macro with user defined types 
no version bump but B_USERTYPE defined

fix test from commit de26ef85 that should be nMaxRecords

tested full round trip on password protected document (ie. use binary storage)
master --(0)--> master --(1)--> libreoffice 4.4 --(2)--> master --(3)--> master

(0) in master, User type supported, big module supported
(1) in libreoffice 4.4, user type not supported, big module supported, no loss of code
(2) in master, user type not supported, big module not found, no loss of code
    it is OK as libreoffice 4.4 saves to LegacyVersion
(3) in master, User type supported, big module supported (all is restored)
    it is OK as module was saved with CURRENT_VERSION (see sbxmod.cxx)

Change-Id: I237cf7de70adf1a755be1bc30987b21c43b6ab35
Reviewed-on: https://gerrit.libreoffice.org/17871
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-08-31 10:14:12 +00:00
Noel Grandin 2660d24a07 new loplugin: refcounting 
This was a feature requested by mmeeks, as a result of
tdf#92611.

It validates that things that extend XInterface are not
directly heap/stack-allocated, but have their lifecycle managed
via css::uno::Reference or rtl::Reference.

Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692
Reviewed-on: https://gerrit.libreoffice.org/16924
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-08-03 06:37:16 +00:00
Noel Grandin b4ee16da65 com::sun::star->css in basic 
Change-Id: I637fd7aedeb97b7dca22521474a54a1d4274f212
Reviewed-on: https://gerrit.libreoffice.org/17206
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-20 09:39:36 +00:00
Noel Grandin 22b094f5d8 loplugin:unusedmethods basic 
Change-Id: Iddfbde451088750f8c74f3ac72c35b5ccfbe0ab1
Reviewed-on: https://gerrit.libreoffice.org/17044
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-15 09:07:05 +00:00
Andrea Gelmini 799cc41b53 Fix typos 
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0
Reviewed-on: https://gerrit.libreoffice.org/16834
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2015-07-08 05:48:18 +00:00
Andrea Gelmini ffa8892c5a Fix typos 
Change-Id: I75b4ad61785bf0ba1cb07735d938c0977356b8cc
Reviewed-on: https://gerrit.libreoffice.org/16705
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2015-07-04 10:23:17 +00:00
Caolán McNamara 50bd0c8573 coverity#1308521 Uncaught exception 
Change-Id: I6a189e0d1c4eb04e727fdf12585d46a1f4121f68
 2015-06-28 17:55:52 +01:00
Stephan Bergmann 761e0ae0a7 loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I8bce930283301130ec7a2b1eab2a2c8f65c8abf9
 2015-06-08 16:23:17 +02:00
Stephan Bergmann dc47b2e513 Unwind SotStorageRef typedef 
Change-Id: I8d5363bb2ad813ef29b4078848914f4b0989b9f1
 2015-05-07 11:05:04 +02:00
Stephan Bergmann e19cd844be Rephrase comparisons between bool and sal_Bool 
...to cater for forthcoming loplugin:implicitboolconversion improvements

Change-Id: I801b6b73648715448198d582a087cc834f6e20c8
 2015-04-28 10:21:01 +02:00
Noel Grandin 71b809959b remove unnecessary use of void in function declarations 
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
 2015-04-15 11:47:12 +02:00
Caolán McNamara 5a308b1239 V801: Decreased performance 
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
 2015-03-09 12:41:09 +00:00
Caolán McNamara 32f95a3551 V813: Decreased performance 
Change-Id: I8a7528366156b288dc422b09cff0d5a32cde3c91
 2015-03-04 13:07:40 +00:00
Stephan Bergmann 164276a0d2 Clean up previous commit 
Change-Id: Iddade9d297be8f4a4e69b3bec5ab7588bf68c112
 2015-02-26 15:34:57 +01:00
Chris Sherlock a45a5501cc basic: convert sb.component to constructor usage 
Change-Id: I45ddf460fa7d673c5210f9415b2a8015988a643e
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2015-02-26 15:05:23 +01:00
Stephan Bergmann 39ddeb53c0 basic: Use appropriate OUString functions on string constants 
Change-Id: I43f99ba6759b0f8f633af784beaec583dbab0b9e
 2014-12-18 14:12:23 +01:00