ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
401,594 Commits 3 Branches 3 Tags
64d80d22851a38eb3f320f4e2b2bdf875da4d8b4
Commit Graph
90 Commits
Author SHA1 Message Date
Noel Grandin afabf409aa oops, wasn't supposed to commit that 
snuck in with commit 4d2c210c74
"use early return to simplify flow"

Change-Id: I2a5cbff01c5f40d879d320fd3934bc0856756d37
 2016-12-02 13:22:15 +02:00
Noel Grandin 4d2c210c74 use early return to simplify flow 
Change-Id: I98201eac2e038c152422bbc6380cfa321ba266df
Reviewed-on: https://gerrit.libreoffice.org/31534
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-02 11:17:12 +00:00
Pierre Lepage 379b7ffb68 tdf#80731 Closing parenthesis is now detected (Mid statement and functions). 
Change-Id: I5efdb6c3ce71148672a8b76d3f1cc87b0fe04994
Reviewed-on: https://gerrit.libreoffice.org/30593
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-30 06:42:48 +00:00
Noel Grandin b1f8cf3782 loplugin:singlevalfields 
Change-Id: I65f96d9cd24572c8d0946acf4d2d45eb3db83a76
Reviewed-on: https://gerrit.libreoffice.org/30476
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-02 13:06:37 +00:00
Arnaud Versini c0d7dfa56c BASIC : Add SbModule::FindMethod 
Change-Id: I3418c4a3d24b3b6630d6c80a6c8aa9d4ffb7e73a
Reviewed-on: https://gerrit.libreoffice.org/24346
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-12 07:43:03 +00:00
Noel Grandin f107d45381 Convert SbxClassType to scoped enum 
Change-Id: I48afcdd9924d22b52a8db21aa253061e4d38c85b
Reviewed-on: https://gerrit.libreoffice.org/25259
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-23 11:49:32 +00:00
Caolán McNamara a139320da2 deref of null 
regression from

commit f17a4694b0
Author: Arnaud Versini <arnaud.versini@gmail.com>
Date:   Sat Feb 13 20:17:41 2016 +0100

    BASIC : use std::unique_ptr for storing SbiExprList

    Change-Id: I37f2a1c837c6742cf6d403962d2730b5e80004ec
    Reviewed-on: https://gerrit.libreoffice.org/22345

because they have been moved into the container at this
point

Change-Id: If21e0321ffdce66aa9629637d0ff8c16efbbd25e
 2016-03-09 15:16:07 +00:00
Noel Grandin 2d0dab5b15 loplugin:commaoperator in basic/ 
Change-Id: I320a06e50d032a55d8d5e6354959c12327e319ee
 2016-02-22 16:55:11 +02:00
Arnaud Versini f17a4694b0 BASIC : use std::unique_ptr for storing SbiExprList 
Change-Id: I37f2a1c837c6742cf6d403962d2730b5e80004ec
Reviewed-on: https://gerrit.libreoffice.org/22345
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-17 07:08:59 +00:00
Arnaud Versini 6c6cb30bf4 BASIC : Use std::unique_ptr in SbiExpression and SbiExpList 
Change-Id: I6f09615d19560673319e103af36c40c94ea77f12
Reviewed-on: https://gerrit.libreoffice.org/22186
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-02-08 20:32:15 +00:00
Arnaud Versini c474e610e4 BASIC : Use vector in SbiExprList to avoid any dependencies 
Change-Id: I1ae88ae9c4276452a00aadaaadebf582e639b15a
Reviewed-on: https://gerrit.libreoffice.org/22174
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-08 06:06:40 +00:00
Arnaud Versini 4cac0c05c6 BASIC: SbiExpression::IsIntConstant has side effects. 
Also renames IsIntConstant to ConvertToIntConstIfPossible.

Change-Id: Ib4b465ac0d890762547fb2d83c26ad6be6ee75e8
Reviewed-on: https://gerrit.libreoffice.org/21746
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2016-01-27 15:36:52 +00:00
Arnaud Versini 7d0e520e22 BASIC : Remove class SbiDimList and SbiParameters 
Change-Id: I039bdc786a65ad534390e7138f584cdb470428af
Reviewed-on: https://gerrit.libreoffice.org/21734
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2016-01-24 17:43:15 +00:00
Arnaud Versini 49b5eed56c BASIC : Remove SbiExprList::pParser 
Change-Id: Ib9386d97ddb12f148cf76dc71aa8c41003286f50
Reviewed-on: https://gerrit.libreoffice.org/21534
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-24 06:48:45 +00:00
Stephan Bergmann 08e49fa337 loplugin:nullptr (automatic rewrite) 
Change-Id: I1ec9a671fe3ac838feb36297915e3cdf8749d944
 2015-11-10 10:31:17 +01:00
Stephan Bergmann 4d00131b67 Reduce variable scope 
Change-Id: I87850db982f413b328976e043d8386b7577ba17c
 2015-10-07 11:32:42 +02:00
Stephan Bergmann 1f6b082388 Fix previous commit 
...4b4a7c0d87eb580272aba0777c9021789025bdc0 "Revert a fix that can never have
worked in the first place?"---which presumably did work after all, as Noel
thankfully pointed out to me,
<http://lists.freedesktop.org/archives/libreoffice/2015-September/070193.html>
"Re: [Libreoffice-commits] core.git: basic/source 'Revert a fix that can never
have worked in the first place?'"

Change-Id: I411bfaacbfebf50589290c6a3040d0300c256439
 2015-09-09 10:54:03 +02:00
Stephan Bergmann 4b4a7c0d87 Revert a fix that can never have worked in the first place? 
clang-analyzer-deadcode.DeadStores finds that conditionally assigning

  eTok = SYMBOL

inside the "if( SbiTokenizer::IsKws( eTok ) )" block is useless, as the directly
following

  if( DoParametersFollow( pParser, eCurExpr, eTok = eNextTok ) )

will unconditionally assign into eTok again, without intermediate use of the old
eTok value.

Now, the conditional "eTok = SYMBOL" assignment was added as
5d98ed5c6a "INTEGRATION: CWS ab12fixes: #118234#
SbiExpression::Term(): Allow Input as symbol for action option compatible,"
while the unconditional "eTok = eNextTok" assignment had followed that block
ever since c25ec0608a "initial import."

The referenced "#118234#" was a Sun-internal bug and is no longer available, but
it does very much look as if this alleged bugfix never worked in the first
place.  So revert the code back to what it looked before
5d98ed5c6a, for now.

Change-Id: I1fe1178d2c5b0c0372da32b8dd0f2dfbdb22a1ae
 2015-09-08 10:57:54 +02:00
Noel Grandin b1c25a0d8f inline "old" SbERR constants 
Change-Id: I3e6665351de97692ae70207e8b623ad008ca8c9a
 2015-07-28 08:35:34 +02:00
Arnaud Versini fabe329412 BASIC : Remove SbCodeGen attribute from SbiExprNode and user std::unique_ptr. 
Change-Id: I9f44f6a4b61987de960b77f54bac8cf2c981bd2a
Reviewed-on: https://gerrit.libreoffice.org/16551
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
 2015-07-02 07:43:03 +00:00
Stephan Bergmann 761e0ae0a7 loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I8bce930283301130ec7a2b1eab2a2c8f65c8abf9
 2015-06-08 16:23:17 +02:00
Noel Grandin 539ba642d7 remove unnecessary header file 
Change-Id: I3b86a54a773341be7e7e69e88c59dc531ea49c5b
 2015-05-17 10:08:59 +02:00
Stephan Bergmann 39ddeb53c0 basic: Use appropriate OUString functions on string constants 
Change-Id: I43f99ba6759b0f8f633af784beaec583dbab0b9e
 2014-12-18 14:12:23 +01:00
Caolán McNamara 6b709b27b3 coverity#735399 Logically dead code 
we can only enter the bAssumeExprLParenMode controlled block once
because the block sets bAssumeExprLParenMode to false

bAssumeExprLParenMode is only true if the first token read in the
method is LPAREN

so we can only enter this block if the current token is LPAREN and
its the first token processed, so the token can't be BYVAL

Change-Id: I6e668fca4d127d7dbfe447e2d9f2231e05278a7d
 2014-11-17 14:53:24 +00:00
Stephan Bergmann f8ef1fe95b loplugin:staticcall 
Change-Id: I6cd46964c523c9393e9d249fdb43aaa38679fa06
 2014-06-13 17:54:23 +02:00
Stephan Bergmann f96f38f8f8 bool improvements 
Change-Id: I571354540f1ab108c55d32c20786d34a799c3bed
 2014-01-28 20:26:30 +01:00
Tor Lillqvist a7724966ab Bin comments that claim to say why some header is included 
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
 2013-10-22 16:56:28 +03:00
Caolán McNamara 3c2983ded9 CID#707646 uninitialized member variables 
also CID#707647

Change-Id: I9962bd2417119944a243d8a92711866548248e36
 2013-10-07 11:46:58 +01:00
Takeshi Abe ea1e3b77d4 sal_Bool to bool 
Change-Id: I16ddbcf100e21d6c05fccbe24faca2932a605902
 2013-10-02 10:00:44 +09:00
Markus Mohrhard ead0a6038b coverity#705627: fix memory leak 
Change-Id: I4f73f77b27d2ed28a9f97757105c8a6cc5521b33
 2013-03-09 17:59:12 +01:00
Markus Mohrhard 1544c17ffd coverity#705626 and coverity#705627: fix memory leak 
Change-Id: I68f43d07798ccb3fc3a5ab438992ac74f4cd262a
 2013-02-28 06:29:35 +01:00
Norbert Thiebaud 27239ad230 basic: String -> OUString 
Change-Id: I42479b4bade5111e38d69f04c889c166f340d5ba
 2012-11-07 02:14:53 -06:00
Norbert Thiebaud d92814f462 basic: preliminary cosmetic clean-up 
parsing 1000s of line of code is hard enough without having to fight
with weird indentation and irregular formatting.

So as the review progress, in order to follow the code, cosmetic changes
were made...

In order to minimize the task of the reviewers and allow them to
concentrate on what matter, an effort is made to collect these
cosmetic changes into this separate commit.

Change-Id: I3c9b04a0150d0d0a048c2e976fe24de4f2b6b98a
 2012-11-03 20:24:28 -05:00
Tor Lillqvist 38968e2963 WaE [loplugin]: statement alignment 
Change-Id: Ia09c74e02d261de5946e6d7e0530a7913e0bcb8d
 2012-10-10 14:59:24 +03:00
Takeshi Abe 1f224b02c8 sal_Bool to bool 
Change-Id: Idb5ef3cebdd45bd91f7c0ae34e422fd651d395c9
 2012-08-14 07:37:19 +09:00
Takeshi Abe 1817cf60d1 sal_Bool to bool 
Change-Id: I61a6675df622232923a827fc20bf121dd03cd7da
 2012-08-12 09:16:58 +09:00
Takeshi Abe 2eb40e3cec Remove a member variable no one reads 
Change-Id: Iacb037bebaf1c3d77ab61be6342b42319b8a2e7b
 2012-08-09 22:33:03 +09:00
Michael Meeks 63c508e3e8 re-base on ALv2 code. Includes: 
118568: switch to using ucpp
    Patch contributed by Juergen Schmidt
    http://svn.apache.org/viewvc?view=revision&revision=1209396
 2012-07-18 09:29:19 +01:00
Caolán McNamara ba23ece286 probably the last uses of the one argument String::CreateFromAscii variant 
Change-Id: I36aab317da2f69f12aaefc24895ad9eaa6b69a7c
 2012-06-28 13:53:36 +01:00
Caolán McNamara 08c475bb24 callcatcher: update unused code list 2012-02-16 10:26:03 +00:00
Caolán McNamara 3b4786b6b7 callcatcher: regenerate list 2012-02-13 11:02:46 +00:00
Caolán McNamara 849a2471bd update unused list 2012-02-08 09:12:27 +00:00
Caolán McNamara 2cae4ff166 callcatcher: update list, ByteString is on the ropes 2012-02-08 09:12:27 +00:00
Caolán McNamara 5833c182ed callcatcher: update list 2012-02-01 11:13:44 +00:00
August Sodora 809438ad92 Remove unused code 2012-01-07 17:47:06 -05:00
Norbert Thiebaud 2ca38d3c7c rmove include of pch header in basic 2011-11-27 12:55:59 -06:00
Ivan Timofeev 9b94d385f9 cppcheck: avoid possible null pointer dereferences 2011-11-04 23:01:17 +04:00
Allmann-Rahn 8b11173f34 Translated German comments, removed redundant ones till cairo (incl.) 2011-08-31 16:29:43 +03:00
David Tardon 38d503b64b this looks incorrect 2011-05-16 15:39:27 +02:00
Francisco Saito e60d365c86 drop bogus executable flag from [ch]xx/bas/asm files 2011-03-29 21:40:28 +01:00