ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
388,199 Commits 3 Branches 3 Tags
60d900254e93e8ac19fed3fa451b91c536efe930
Commit Graph
3834 Commits
Author SHA1 Message Date
Noel Grandin 2087484c65 use consistent #define checks for the Windows platform 
stage 2 of replacing usage of various checks for the windows platform
with the compiler-defined '_WIN32' macro

In this stage we focus on replacing usage of the WIN macro

Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84
Reviewed-on: https://gerrit.libreoffice.org/22393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-17 11:33:57 +00:00
Laurent Balland-Poirier d977a49ef0 tdf#40517 Unit test for question marks in number format 
Unit test for https://gerrit.libreoffice.org/21021/

Add unit test for Engineering format
Add unit test for optional sign in exponent

Change-Id: I958ccdcc68a4e496cbd4bdc74d0650c133f3a3f7
Reviewed-on: https://gerrit.libreoffice.org/21824
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-02-17 08:53:33 +00:00
Arnaud Versini f17a4694b0 BASIC : use std::unique_ptr for storing SbiExprList 
Change-Id: I37f2a1c837c6742cf6d403962d2730b5e80004ec
Reviewed-on: https://gerrit.libreoffice.org/22345
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-17 07:08:59 +00:00
Arnold Dumas fd3cb8d822 tdf#39440: reduce scope of local variables 
Change-Id: I6ba411d2e07240821518281996d543f71acf3259
Reviewed-on: https://gerrit.libreoffice.org/22378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-16 12:47:55 +00:00
Noel Grandin ce43d0ae92 use consistent #define checks for the Windows platform 
stage 1 of replacing usage of various checks for the windows platform
with the compiler-defined '_WIN32' macro

Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f
Reviewed-on: https://gerrit.libreoffice.org/22390
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-02-16 10:37:55 +00:00
Caolán McNamara 7347248254 cppcheck: unreadVariable 
Change-Id: I15f0320b646d20f0093c77286c1ff2715aacb8ce
 2016-02-15 11:45:53 +00:00
Caolán McNamara f3f67b770b fix indent 
Change-Id: I48552afc35c1f7cfff3562c36eca3f1cf6174077
 2016-02-15 11:45:53 +00:00
danielt998 2b31daf74e tdf#95857 Sort out German plurals ... 
Made a start in removing the incorrect 'Infos' German plural

Change-Id: Ie989351a7473fc35b563e63ce6a4fb229093af60
Reviewed-on: https://gerrit.libreoffice.org/22301
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2016-02-12 15:29:25 +00:00
Chris Sherlock a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Arnaud Versini 6c6cb30bf4 BASIC : Use std::unique_ptr in SbiExpression and SbiExpList 
Change-Id: I6f09615d19560673319e103af36c40c94ea77f12
Reviewed-on: https://gerrit.libreoffice.org/22186
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-02-08 20:32:15 +00:00
Noel Grandin 4c411636d9 sequence->vector in basic 
Change-Id: Ic42f7218bda81effe870d950f666ba7653d60c66
Reviewed-on: https://gerrit.libreoffice.org/22177
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-08 12:31:10 +00:00
Noel Grandin 310b65e5e9 sequence->vector in basic 
Change-Id: Ic1b72a6c5e9df5d0fa65626ec1d8eda6a2d2feec
Reviewed-on: https://gerrit.libreoffice.org/22176
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-08 12:30:29 +00:00
Noel Grandin b14224fe97 loplugin:unusedmethods 
using an idea from dtardon:

<dtardon> noelgrandin, hi. could you try to run the unusedmethods clang
plugin with "make build-nocheck"? that would catch functions that are
only used in tests. e.g., i just removed the whole o3tl::range class,
which has not been used in many years, but htere was a test for it...
<noelgrandin> dtardon, interesting idea! Sure, I can do that.

Change-Id: I5653953a426a2186a1e43017212d87ffce520387
Reviewed-on: https://gerrit.libreoffice.org/22041
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-08 06:08:14 +00:00
Arnaud Versini c474e610e4 BASIC : Use vector in SbiExprList to avoid any dependencies 
Change-Id: I1ae88ae9c4276452a00aadaaadebf582e639b15a
Reviewed-on: https://gerrit.libreoffice.org/22174
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-08 06:06:40 +00:00
Matúš Kukan aa20acb87d basic: Merge macro snippet tests 
Change-Id: Ia2d8944227c6be8b5ae7b42f7d566ac150d522b9
 2016-02-05 21:20:50 +01:00
Eike Rathke 599f0cbe1d interface to new XTextSearch2 with SearchOptions2, tdf#72196 
Places that had utl::TextSearch::UpgradeToSearchOptions2() introduced
are worth an inspection if the new SearchAlgorithms2::WILDCARD search
should be supported or at least use SearchOptions2 instead of
SearchOptions to eliminate the small performance penalty that conversion
involves.

Change-Id: I565f73af2b551ae9ad0f488e672823dc6c5c1109
 2016-02-05 17:02:47 +01:00
Andrea Gelmini 534b2a4b58 Fix typos 
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3
Reviewed-on: https://gerrit.libreoffice.org/21797
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-02-05 06:48:38 +00:00
Noel Grandin 4fa4b9addf loplugin:fpcomparison in basic/ 
Change-Id: I76ffac6a0f0b1525c85d1995277d3ca22ef268e1
Reviewed-on: https://gerrit.libreoffice.org/21869
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-02-04 06:41:19 +00:00
Noel Grandin 1ef9f3988e unnecessary use of OUString constructor 
Change-Id: Idd31b0a53c8318af69bbcd32f6798721ec8eb8e1
Reviewed-on: https://gerrit.libreoffice.org/21945
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-31 12:04:02 +00:00
Arnaud Versini 4cac0c05c6 BASIC: SbiExpression::IsIntConstant has side effects. 
Also renames IsIntConstant to ConvertToIntConstIfPossible.

Change-Id: Ib4b465ac0d890762547fb2d83c26ad6be6ee75e8
Reviewed-on: https://gerrit.libreoffice.org/21746
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2016-01-27 15:36:52 +00:00
Noel Grandin 752cd07d08 InterfaceContainer2 with vector instead of Sequence 
create an InterfaceContainer2 class to replace InterfaceContainer.
It uses a std::vector instead of a Sequence for the mutable listener
list, which provides far better performance.

Switch all our internal use-sites to the new class.

Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
 2016-01-25 08:52:03 +02:00
Arnaud Versini 7d0e520e22 BASIC : Remove class SbiDimList and SbiParameters 
Change-Id: I039bdc786a65ad534390e7138f584cdb470428af
Reviewed-on: https://gerrit.libreoffice.org/21734
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2016-01-24 17:43:15 +00:00
Arnaud Versini 49b5eed56c BASIC : Remove SbiExprList::pParser 
Change-Id: Ib9386d97ddb12f148cf76dc71aa8c41003286f50
Reviewed-on: https://gerrit.libreoffice.org/21534
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-24 06:48:45 +00:00
Arnaud Versini 3a97b3619a BASIC : Remove useless virtual function override 
Change-Id: I0f8e480bf73256e7f1284e11983cc70c0426172c
Reviewed-on: https://gerrit.libreoffice.org/21513
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-16 17:08:46 +00:00
Arnaud Versini 1ae5ceccb8 BASIC : Remove useless methods in StarBasic 
Change-Id: I9e8ce92b967ee9c9485b7af15280f6a212ff599d
Reviewed-on: https://gerrit.libreoffice.org/21498
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-16 17:06:26 +00:00
Michael Stahl 9694a0edfe basic: coverity#1348466 checked return 
Kind of unnecessary but let's hope it shuts up coverity.

Change-Id: I4903c9df788ce5fb9648c5fd68627ff21362828f
 2016-01-15 13:03:09 +01:00
Stephan Bergmann a20f9388f1 -Werror=misleading-indentation (GCC 6) 
Change-Id: Ia633b859df94ede325469ec8a20e7383d2a178d4
 2016-01-13 17:20:28 +01:00
Noel Grandin c93486bbb8 loplugin:loopvartoosmall 
Change-Id: Ifa813b91b153004aa0fba42cdc209f4c4fd9578f
 2016-01-12 08:59:48 +02:00
Noel Grandin bbfeab3b13 loplugin:unusedmethods unused return value in include/basic 
Change-Id: Ib1a006adaa92e257d40a20ff0d8beeb37e7c2fe0
Reviewed-on: https://gerrit.libreoffice.org/21360
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-01-12 06:40:03 +00:00
Arnaud Versini a5c2328313 BASIC: Store directly SbxVarEntry in SbxArray 
Change-Id: I64ae6c2a45e0ed880f5b76ca2ad420d684fdfeb4
Reviewed-on: https://gerrit.libreoffice.org/21308
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2016-01-12 06:06:49 +00:00
Noel Grandin 9a64d7f8dd fix windows build 
Change-Id: Ie00d2dd3fbf6ff498c652249797f8d01acef8a97
 2016-01-11 11:59:18 +02:00
Noel Grandin bc80f951c1 loplugin:unusedmethods unused return value in basic 
Change-Id: I0ccbf994d2c9be35f43fc3c62e60da90634bacdf
 2016-01-11 10:49:24 +02:00
Andrea Gelmini 64d624b651 Fix typos 
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-01-10 14:17:20 +00:00
Johannes Hauf bccd83ea54 Some cleanup for sal_uIntPtr usage 
Change-Id: Ia9779e6477d8848588f3543d09ea6b4477f594a2
Reviewed-on: https://gerrit.libreoffice.org/21022
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-01-07 14:13:49 +00:00
Arnaud Versini 5e0d36adc3 BASIC : use std::vector instead of SbArray for Modules. 
Change-Id: I9594efb13b3dccc637ccd61eea4b42255c2a775c
Reviewed-on: https://gerrit.libreoffice.org/20817
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-01-07 12:18:40 +00:00
Andrea Gelmini fbec6ac089 Fix typos 
Change-Id: I3fba2c76c83381eb398c80947ef4849bccf7ab27
Reviewed-on: https://gerrit.libreoffice.org/21078
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-01-05 13:40:54 +00:00
Andrea Gelmini 92e60e1b80 Fix typos 
Change-Id: I1b79005d9c4e32325b8dadcc4f805975d6bf2727
Reviewed-on: https://gerrit.libreoffice.org/21103
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
 2016-01-05 07:32:28 +00:00
Stephan Bergmann 38e965fe0f Use CPPUNIT_ASSERT_DOUBLES_EQUAL 
...except when checking for infinity

Change-Id: If6e3b8965169cc615fa5d76422e1925866714936
 2016-01-04 14:02:41 +01:00
Stephan Bergmann efcbfa6f42 loplugin:cstylecast 
Change-Id: I5ecd63d79e8be77879d3789c45079929696abe03
 2016-01-04 13:44:48 +01:00
Dipangar Niranjar 0e41527fd5 tdf#96136 replace CPPUNIT_ASSERT with CPPUNIT_ASSERT_EQUAL 
Change-Id: Ib45af8a56ac3adc428c530908cf1bbd95e9cc64c
Reviewed-on: https://gerrit.libreoffice.org/21065
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
 2016-01-04 11:40:41 +00:00
Arnaud Versini f146ddadf5 BASIC : Remove useless allocation operator overload 
Change-Id: I134cdbfe388347264a810bbfbff8b4f9f373e663
Reviewed-on: https://gerrit.libreoffice.org/20873
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2015-12-30 18:27:27 +00:00
Julien Nabet ec3e174569 Remove some includes (stdio/stdlib) 
Change-Id: I4aa649961efac521e72c363efb5d0a3192125da5
Reviewed-on: https://gerrit.libreoffice.org/20966
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2015-12-27 17:24:11 +00:00
Matteo Casalin cb98c423bb sal_uLong/sal_uIntPtr/sal_uInt16 to sal_uInt32 
also avoid some explicit temporaries and group some checks.

Change-Id: I7795b208dde53fd383b8c75f72dd9f56429aea2b
 2015-12-27 16:51:27 +01:00
Matteo Casalin 7d8919d2d5 sal_uLong/sal_uIntPtr for ScNumFormatAbbrev 
Change-Id: I45f2a43fe4295e44691ab00c93af3fca41b1dcfa
 2015-12-27 16:51:26 +01:00
Matteo Casalin 42798dc46a sal_uIntPtr to sal_uInt32 
Change-Id: I856ee7aa28d45dd69b030e3db05701b415009fde
 2015-12-27 16:51:25 +01:00
Noel Grandin 70d14d2ccd loplugin:unusedfields in basic 
Change-Id: I304f3903f305ba5b538964071ab95b57ebf2f970
 2015-12-23 09:46:48 +02:00
Arnaud Versini 4251e676bb BASIC : Refactor FoldConstants for extracting it from SwExprNode. 
Change-Id: Ia47597b26d63db216dd3ab71acbb18449ece7b1a
Reviewed-on: https://gerrit.libreoffice.org/16963
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>
 2015-12-22 11:13:03 +00:00
Julien Nabet 36984c75cc cppcheck: false positive deallocuse 
Help cppcheck by returning early and remove a now useless bool var

Change-Id: If4dcb6f64bcfd6c3cb22136163caf3679d6fd5a8
 2015-12-20 22:17:36 +01:00
Damjan Jovanovic a22702ab0d Resolves: #i126272# compile error : if statement followed by End If... 
- in next Line ???

Allow the Else in a single-line If statement to be terminated by a comment instead of only EOL.

Patch by: me

(cherry picked from commit cbd43d0cb1165add5b9b559c3608a93ea631da13)

Change-Id: I3dcf014c9fe501bc9770ae3cfd69e7730c0b86cb
 2015-12-16 09:18:23 +00:00
Damjan Jovanovic 98f0e0eda5 Resolves: #i19221# Print Tab(5); "Hello" does not work 
Implement the Tab() function in AOO Basic.

Patch by: me

(cherry picked from commit fa1315d25186643ea537972609c117e0c9bb1fbc)

Change-Id: Ifa9843661ce3862347c6351a078ddb207169182a
 2015-12-15 13:48:28 +00:00