ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
399,744 Commits 3 Branches 3 Tags
58e2f9a3e2b11d00aec85b2fdfd0fbf31101bf31
Commit Graph
180 Commits
Author SHA1 Message Date
Noel Grandin 5f77e6e930 update loplugin:unnnecessaryvirtual to handler destructors 
and update modules writerfilter..xmloff with the resulting changes

Change-Id: I54d19c22ddb0ff579b32e4934d266c925b19305c
Reviewed-on: https://gerrit.libreoffice.org/30530
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-04 07:15:03 +00:00
Tor Lillqvist 38dc4ea899 Bin unused XSecuritySAXEventKeeper::cloneElementCollector 
Change-Id: Icc0ead769fa0a052f7d4dfbc825c96dbb513b33f
 2016-11-03 11:10:59 +02:00
Stephan Bergmann 91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Noel Grandin 2383d557e5 clang-tidy misc-unused-alias-decls 
Change-Id: Iabde7a84b9c2758e0d2b2ffe0fb99fcfa51ff124
Reviewed-on: https://gerrit.libreoffice.org/25075
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-19 13:07:28 +00:00
Stephan Bergmann f3059ab1dc loplugin:salbool: Automatic rewrite of sal_False/True 
Change-Id: I96cef821fc1d87963b8928af5dfc8ba97557da74
 2016-04-20 17:27:32 +02:00
Noel Grandin b8eb294651 loplugin:passstuffbyref in various 
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
 2016-04-14 10:24:47 +02:00
Stephan Bergmann ec9b260029 Remove unused _USECOMPRESSEDDOCUMENTHANDLER 
...introduced with 9f34fde7a8 "libxmlsec" but
always unconditionally defined.  Fix some indentation.

Change-Id: Ib46d4d7153d84975e9bcd8351779634f8d43240c
 2016-04-12 15:50:21 +02:00
Noel Grandin 43d57d105d com::sun::star->css in xmlsecurity/ 
Change-Id: I4b89f97671ab526e5731d2f1f99802e23f3fd4b5
 2016-03-14 13:28:04 +02:00
Miklos Vajna eb63915f0a xmlsecurity: clean up no longer relevant email addresses 
Change-Id: I224a0914bd3506b4e2ce057c53838ec78187b060
 2016-03-11 09:11:38 +01:00
Noel Grandin b4fda7b3f9 new loplugin:constantparam 
finds parameters that are only ever being called with a single value

Change-Id: Ibd0c9b6e6dbc1d1b5d5a005eaa19959560a6e50f
 2016-03-08 09:04:47 +02:00
Chris Sherlock a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Andrea Gelmini 64d624b651 Fix typos 
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-01-10 14:17:20 +00:00
Noel Grandin a218039d2a loplugin:unusedfields in xmlscript,xmlsecurity 
Change-Id: I5239766f2105fb1a7823215a4ffe48891e000c3d
 2015-12-21 12:45:49 +02:00
Noel Grandin 96c26b0d9d use initialiser for Sequence<OUString> 
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"

Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 12:20:39 +00:00
Stephan Bergmann 3a2037b11c loplugin:nullptr (automatic rewrite) 
Change-Id: I2093e93e07ff19a1a1d2c8b6f221dac2bf2a2613
 2015-11-10 10:32:02 +01:00
Noel Grandin 9e8ff13eb2 use uno::Reference::set method instead of assignment 
Change-Id: I60e52ef2abc3107ba77e81811dfe1bffbfd77218
 2015-11-05 13:32:17 +02:00
Noel Grandin 3d784c4af6 remove extra spaces around :: 
just makes it harder to grep for methods

Change-Id: I0925db2f9284972fcf7e1e3adf90cbe21f69eb15
 2015-10-26 09:12:05 +02:00
Stephan Bergmann b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Andrea Gelmini 4678982056 Fix typos 
Change-Id: I2cdfc4e9d8ba1acb7c2548f9394d320c6504207e
Reviewed-on: https://gerrit.libreoffice.org/18997
Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org>
Tested-by: Joren De Cuyper <jorendc@libreoffice.org>
 2015-09-29 22:13:57 +00:00
Takeshi Abe 889d825879 xmlsecurity: tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants.

Change-Id: Ie8f972330f6bc88e205290dcbe666895b7bad43f
Reviewed-on: https://gerrit.libreoffice.org/18557
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-09-14 06:24:12 +00:00
Adolfo Jayme Barrientos 3e926736c7 Miscellaneous typos 
Change-Id: I5187364d420ab78c36a91632efab9c32951d867a
 2015-07-21 04:53:48 -05:00
Noel Grandin e963a88912 formatting of public/private/protected section qualifiers 
make it consistent across the codebase, no space between keyword
and the colon

Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5
Reviewed-on: https://gerrit.libreoffice.org/17148
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-17 09:49:35 +00:00
Andrea Gelmini 1a8915ef83 Fix typos 
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e
Reviewed-on: https://gerrit.libreoffice.org/16582
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
 2015-06-30 15:57:12 +00:00
Stephan Bergmann 46a1538d14 loplugin:stringconstant: handle OUString+=OUString(literal) 
Change-Id: I8e819192d4464c3d03feb908b9acae5f91161fe9
 2015-06-26 13:55:36 +02:00
Stephan Bergmann 642f4e574c loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: Idcaafa47f1891858d2ac4cdc536065cbc127b7c4
 2015-06-08 16:30:07 +02:00
Julien Nabet 16f1477a2d Remove include stdio (part7) 
Change-Id: I7058ac53f4bbf96eff9a36a03279ab0753cc42ba
Reviewed-on: https://gerrit.libreoffice.org/16135
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2015-06-07 15:33:38 +00:00
Stephan Bergmann 3f846cb7a4 loplugin:cstylecast: deal with those that are (technically) const_cast 
Change-Id: I7128d99926bddf5ffd0a87099c7fa3ce3a1e08e0
 2015-06-02 11:29:00 +02:00
Caolán McNamara dcee23b7f8 cppcheck: noExplicitConstructor 
Change-Id: Idcf5460ec59cfb6f13055652c094d460c15da5ed
 2015-05-20 20:40:54 +01:00
Caolán McNamara 869e477484 cppcheck: noExplicitConstructor 
Change-Id: Iea5bb0504518b380c3fe7c238d376dc26be8a7ef
 2015-05-04 20:13:52 +01:00
Stephan Bergmann 373a9b9bb6 loplugin:redundantcast: redundant const_cast followed by implicit upcast 
Change-Id: I58297ba336d96358eb0683684bbd763870ef56cb
 2015-04-13 12:36:36 +02:00
Noel Grandin 4cca0169aa loplugin:staticmethods 
Change-Id: I2177e424d54dc2b5e26b7bbfe073b524e9cc5bab
Reviewed-on: https://gerrit.libreoffice.org/15187
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-04-09 06:44:49 +00:00
Stephan Bergmann 698a6d4ab6 Reduce to static_cast any reinterpret_cast from void pointers 
Change-Id: I374bfba6ee7470044a677b7351cd59aac2e1b042
 2015-03-31 13:18:04 +02:00
Stephan Bergmann c5f1e8c3bb const_cast: convert some C-style casts and remove some redundant ones 
Change-Id: I42fdc042ed7317b5b6c337e7b38966e616f8e24b
 2015-03-26 15:33:41 +01:00
Stephan Bergmann 8d487ceba1 xmlsecurity: Use appropriate OUString functions on string constants 
Change-Id: I18370f6203455cf7568e48e49b7093d114656619
 2014-12-18 14:12:39 +01:00
Michael Stahl 15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use 
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
 2014-11-18 18:51:49 +01:00
Michael Stahl 6a0fe37dec sal: clean up public headers with include-what-you-use 
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
 2014-11-17 11:06:53 +01:00
Andrea Gelmini da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Noel Grandin 0371a63365 remove unnecessary 'using namespace rtl' declarations 
It turns out that almost none of them were necessary.

Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-29 11:28:54 +00:00
Noel Grandin fb7b1f45f9 loplugin: cstylecast 
Change-Id: I96a0d5d7ec3363076b0165f3c540c51ef01b58f3
 2014-10-15 13:57:08 +02:00
Noel Grandin 3e82897353 improve the inlinesimplememberfunctions clang plugin 
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
 2014-06-17 10:55:17 +02:00
Noel Grandin 184a00b962 loplugin: inlinesimplememberfunctions 
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
 2014-06-09 10:10:13 +02:00
Thomas Arnhold 4671e7b8a4 fix-includes.pl: xmlsecurity 
Change-Id: Ie3dd8674e1fa927d15eeb6a64a0cad24b8825262
 2014-05-19 20:04:27 +02:00
Noel Grandin e4e654e405 xmlsecurity: sal_Bool->bool 
Change-Id: I4f32fe3b5133e13dab88ca1c9acd021d84dc59a9
 2014-04-24 10:53:16 +02:00
Thomas Arnhold 55c70634b8 fixincludeguards.sh: xmlsecurity 2014-04-19 11:10:08 +02:00
Stephan Bergmann fb1b0c1f7b Use valid UNOIDL identifiers in XCompressedDocumentHandler 
...which is new in LO 4.3 and still unpublished.

Change-Id: I2d6b553c27906d7855c62f33fdf0060b58d3ec62
 2014-04-11 08:41:09 +02:00
Stephan Bergmann 70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
 2014-03-26 16:39:26 +01:00
Stephan Bergmann 5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexandre Vicenzi 92f162eb0b Convert xmlsecurity to cppu::supportsService 
Change-Id: Ifcec9e067e54cc8a3d1254d41d09ea251820849d
 2014-01-17 12:24:57 +01:00
Stephan Bergmann 8233226fe4 No need for implbase1.hxx to include XComponentContext.hpp 
...which it did unlike all the other implbaseN.hxx.  Required lots of downstream clean-up,
of course.

Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
 2013-12-17 17:32:58 +01:00
Noel Grandin 0121f632ef remove unnecessary use of OUString constructor in XMLSECURITY module 
Change-Id: I95b0eda83c60456f3db267183030fe5f6cd70bc4
 2013-11-07 11:28:38 +02:00