Caolán McNamara
adb9cbff1f
python macros aren't listed under scripting organize
...
since...
commit deb989dd6d
Author: Kenneth Koski <mechaxl@gmail.com >
Date: Mon Feb 29 22:22:10 2016 -0600
blew away the uno.ByteSequence(str) path
Change-Id: I8b73883c4f246ebafd2f810ca61b19da40f833e2
2016-08-09 15:32:05 +01:00
Noel Grandin
f12476f0f6
loplugin:countusersofdefaultparams in oox..sd
...
Change-Id: I4504939a3957606979c6ac36af6611e1fe072d01
Reviewed-on: https://gerrit.libreoffice.org/27902
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-08-05 11:50:45 +00:00
Noel Grandin
192365319d
remove dead ASYNC code
...
introduced in
commit 0b21b8b146
Author: Noel Power <noel.power@novell.com >
Date: Wed Oct 6 10:16:27 2010 +0100
initial commit for vba blob
and never activated or touched since then
Change-Id: I34f9a5f702dd8f2254aa1efb94de61569220b90c
2016-08-01 09:59:30 +02:00
Caolán McNamara
a860df25dd
masses of MessBoxes not being disposed promptly
...
since...
commit ba81e5c6bd
Date: Thu May 28 21:35:43 2015 +0100
tdf#91702 - fix stack-based MessBox allocation.
There is no special ScopedVclPtr<X>::Create or
ScopedVclPtrInstance<X>::Create just
VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo
doesn't call dispose on the owned X
Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-26 11:26:52 +01:00
Noel Grandin
6e72f0251b
new loplugin unnecessary override
...
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb
Reviewed-on: https://gerrit.libreoffice.org/27135
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2016-07-15 14:05:41 +00:00
Stephan Bergmann
623c2f723b
loplugin:passstuffbyref also for {css::uno,rtl}::Reference
...
Change-Id: I678e89d9ff562446e7bbe8542a616c1b083dfcd1
2016-07-07 18:59:55 +02:00
Michael Stahl
136a2fd6c0
compilerplugins: add OWeakObject::release() override check
...
Change-Id: I767857545d7c91615cf162790c04f0016de9fdf6
Reviewed-on: https://gerrit.libreoffice.org/26555
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2016-06-24 12:05:09 +00:00
Arnaud Versini
c0d7dfa56c
BASIC : Add SbModule::FindMethod
...
Change-Id: I3418c4a3d24b3b6630d6c80a6c8aa9d4ffb7e73a
Reviewed-on: https://gerrit.libreoffice.org/24346
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-06-12 07:43:03 +00:00
Noel Grandin
f107d45381
Convert SbxClassType to scoped enum
...
Change-Id: I48afcdd9924d22b52a8db21aa253061e4d38c85b
Reviewed-on: https://gerrit.libreoffice.org/25259
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-23 11:49:32 +00:00
Noel Grandin
2383d557e5
clang-tidy misc-unused-alias-decls
...
Change-Id: Iabde7a84b9c2758e0d2b2ffe0fb99fcfa51ff124
Reviewed-on: https://gerrit.libreoffice.org/25075
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-19 13:07:28 +00:00
Noel Grandin
265068d65b
clang-tidy modernize-loop-convert in scripting to svtools
...
Change-Id: I98229d14109cf243839d632feabde1391ea9bad5
Reviewed-on: https://gerrit.libreoffice.org/24847
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-11 06:54:34 +00:00
Arnaud Versini
6bcb322264
Don't use SolarMutexGuard for returning a constant
...
Change-Id: Ia6e31d7fe9d90f8094e2043de29a896c9e840c53
Reviewed-on: https://gerrit.libreoffice.org/24347
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-04-24 21:20:36 +00:00
Noel Grandin
5abc669599
new plugin stylepolice
...
check for local variables which follow our member field naming
convention, which is highly confusing
Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-21 08:32:47 +02:00
Stephan Bergmann
4b9573ba66
loplugin:salbool: Automatic rewrite of sal_False/True
...
Change-Id: Ic3e7658ccfd23fa29af46eac971deac5a0373377
2016-04-20 17:25:49 +02:00
Noel Grandin
789055bc2a
clang-tidy performance-unnecessary-copy-initialization
...
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.
Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-18 07:37:31 +00:00
Noel Grandin
62633dfe02
clang-tidy performance-unnecessary-value-param in various
...
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907
Reviewed-on: https://gerrit.libreoffice.org/24019
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-14 11:37:19 +00:00
Noel Grandin
b8eb294651
loplugin:passstuffbyref in various
...
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-14 10:24:47 +02:00
tymyjan
c20cc7e79b
tdf#97499 Fixed containers parameters clearing #4
...
Change-Id: I7c96181399f4d7e62d4aceca404b22d68f903513
Reviewed-on: https://gerrit.libreoffice.org/23754
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-04 05:49:06 +00:00
tymyjan
bfb9612226
tdf#97499 Fixed containers parameters clearing #3
...
Change-Id: I1c105de7e1df251533179fba77e3797ef1c4e2d4
Reviewed-on: https://gerrit.libreoffice.org/23752
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-04 05:46:34 +00:00
Noel Grandin
dba6451b2f
sequence->vector in scripting
...
Change-Id: I5efd5ed8755b6127f08f711b8b7337b87b89bbd4
Reviewed-on: https://gerrit.libreoffice.org/23700
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-01 07:33:39 +00:00
Noel Grandin
6439005484
use SAL_N_ELEMENTS more widely
...
found using
git grep -n 'sizeof.*/.*sizeof.*[0]'
Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-31 11:30:36 +02:00
Noel Grandin
8ca50d20c1
loplugin:constantparam in tools
...
Change-Id: I3774661799c074561c694515baba42a375d0a077
Reviewed-on: https://gerrit.libreoffice.org/23301
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-03-17 06:09:42 +00:00
Noel Grandin
435d6d50c3
loplugin:constantparam in sfx2
...
Change-Id: I50a2d8221f907f0e844e558f3dbdd0346c010201
2016-03-09 10:07:46 +02:00
Chris Sherlock
a238b1f8d3
Remove excess newlines
...
A ridiculously fast way of doing this is:
for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
--exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
perl -0777 -i -pe 's/^
{3,}/
/gm' $i
done
Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com >
2016-02-09 08:18:05 +00:00
Noel Grandin
752cd07d08
InterfaceContainer2 with vector instead of Sequence
...
create an InterfaceContainer2 class to replace InterfaceContainer.
It uses a std::vector instead of a Sequence for the mutable listener
list, which provides far better performance.
Switch all our internal use-sites to the new class.
Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-25 08:52:03 +02:00
Noel Grandin
aa6c54f337
loplugin:unusedfields
...
Change-Id: I321b594f1190cdd997b4769161e1c02d31f46213
Reviewed-on: https://gerrit.libreoffice.org/21566
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2016-01-18 08:37:10 +00:00
Noel Grandin
fe0e43a376
loplugin:unusedmethods unused return value in scripting
...
Change-Id: I9b203e255eddce59c37df1a94884e459df034459
2016-01-14 11:45:21 +02:00
Andrea Gelmini
64d624b651
Fix typos
...
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com >
2016-01-10 14:17:20 +00:00
Caolán McNamara
bea8a7ad63
cppcheck: noExplicitConstructor
...
Change-Id: Ib43e53d5b6c9c130adb765ac9b769f58060ac640
2015-12-29 19:46:23 +00:00
Noel Grandin
8ac44ca189
loplugin:unusedfields in scripting
...
Change-Id: Ida8fb31bd85f4807d74daab3d022d8e6340a774d
2015-12-22 09:53:26 +02:00
Noel Grandin
a508f639a0
mark UNO structs as SAL_WARN_UNUSED, where possible
...
Change-Id: Ie3de518f60c9f1313c68df54dbdc1fb2804f1f0d
2015-11-26 13:26:25 +02:00
Noel Grandin
fe3fd05966
add mapKeysToSequence/mapValuesToSequence methods to comphelper
...
and use them
Change-Id: If4dc9df63db37185228aeaaab2979498d61304ec
Reviewed-on: https://gerrit.libreoffice.org/20055
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-20 08:14:13 +00:00
Noel Grandin
2554efabb6
use comphelper::containerToSequence
...
in chart2, we remove a local equivalent of the method
Change-Id: I25129a3d1ea1dd724eb9cd38a57be37a78b3d100
2015-11-19 09:33:29 +02:00
Noel Grandin
21a9bc8716
no need to take a mutex when only dealing with stack-local data
...
Change-Id: Ie45e626aad55a8174a53b769a98601bf54dedf65
Reviewed-on: https://gerrit.libreoffice.org/19979
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-16 11:37:11 +00:00
Noel Grandin
8569c6d0ad
use initialiser list for Sequence<OUString>
...
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02
Reviewed-on: https://gerrit.libreoffice.org/19978
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-16 08:35:42 +00:00
Noel Grandin
96c26b0d9d
use initialiser for Sequence<OUString>
...
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"
Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-15 12:20:39 +00:00
Noel Grandin
8e234c5b7d
use initialiser syntax for Sequence<OUString>
...
replaced using the script:
git grep -lP 'Sequence.*OUString.*\(1\)'
| xargs perl -0777 -pi
-e "s/Sequence< OUString > (\w+)\(1\);
.*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g"
Change-Id: I23688a91562051a8eed11fc2a85599545c285c34
Reviewed-on: https://gerrit.libreoffice.org/19967
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-15 10:13:08 +00:00
Caolán McNamara
8325fcb56d
cppcheck: noExplicitConstructor
...
Change-Id: Ife26f55c28c4631aec4ba4105225bfca72da8bff
2015-11-13 10:17:26 +00:00
Stephan Bergmann
65464ed098
loplugin:nullptr (automatic rewrite)
...
Change-Id: I9b7d8de65780325175d24965057596b88d3c0f05
2015-11-10 10:31:37 +01:00
Noel Grandin
6c80a8fe89
new loplugin: oncevar
...
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f
Reviewed-on: https://gerrit.libreoffice.org/19815
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-09 08:34:40 +00:00
Stephan Bergmann
729c70a242
loplugin:stringconstant: elide explicit ctor usage (manually due to macros)
...
Change-Id: Ib023c89256d50ebe15231a96f6106f60198d362e
2015-11-06 12:32:43 +01:00
Stephan Bergmann
801b914324
loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)
...
Change-Id: If0f1446a25f423b8cbfe6346f7a691f4f2618ad0
2015-11-06 09:36:56 +01:00
Noel Grandin
0eb9f56db5
use uno::Reference::set method instead of assignment
...
Change-Id: I2b592fd3327f4bbe4685e84711dc9d6f19222a97
2015-11-05 07:41:29 +02:00
Noel Grandin
59b072e22b
yyyyy
...
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-11-04 14:10:44 +02:00
Stephan Bergmann
6ccf68622e
No need for this debug code
...
Change-Id: I05a6d15a0c54ca5457d662c2467cb15c14991a0a
2015-11-02 23:30:58 +01:00
Caolán McNamara
4ea0390faa
cppcheck: noExplicitConstructor
...
Change-Id: I06186e8f0bbc8522f538e8639a68e816093becc2
2015-11-02 10:16:38 +00:00
Noel Grandin
b5db48ada1
no need to use OUString constructor in call to createInstance
...
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296
Reviewed-on: https://gerrit.libreoffice.org/19704
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-01 15:25:43 +00:00
Noel Grandin
3bc5df7f32
UNO: no need to use OUString constructor when calling createInstance
...
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526
Reviewed-on: https://gerrit.libreoffice.org/19682
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-30 08:59:59 +00:00
Noel Grandin
d95a27f944
com::sun::star->css in scaddins,sccomp,scripting
...
Change-Id: Id9167341940bac65f055e1e33ff0670f6fa0f6c4
Reviewed-on: https://gerrit.libreoffice.org/19629
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-28 06:31:27 +00:00
Stephan Bergmann
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00