ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
423,489 Commits 3 Branches 3 Tags
3a51daeace695ead38cfd82b3a0f1e6f25a32e0f
Commit Graph
129 Commits
Author SHA1 Message Date
Noel Grandin 3a51daeace Improve re-throwing of UNO exceptions 
(*) if we are already throwing a Wrapped*Exception, get the
exception using cppu::getCaughtexception.

(*) when catching and then immediately throwing UNO exceptions,
use cppu::getCaughtException to prevent exception slicing

(*) if we are going to catch an exception and then
immediately throw a RuntimeException, rather throw a
WrappedTargetRuntimeException and preserve the original exception information.

Change-Id: Ia7a501a50ae0e6f4d05186333c8517fdcb17d558
Reviewed-on: https://gerrit.libreoffice.org/54692
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-25 21:46:49 +02:00
Tor Lillqvist 2147cbf620 Filter out "SynchronMode" too 
Change-Id: I2c5111ee34929b9740796f5e1f08b3a8a58218e4
Reviewed-on: https://gerrit.libreoffice.org/51964
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2018-03-27 20:52:27 +02:00
Tor Lillqvist 7e16966d51 Add a separator between two words in an exception message 
Change-Id: I5c2e01249058e03edfcf036036f9595b87f0a070
Reviewed-on: https://gerrit.libreoffice.org/51963
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2018-03-27 19:43:24 +02:00
Noel Grandin 3af500580b loplugin:salcall fix functions 
since cdecl is the default calling convention on Windows for
such functions, the annotation is redundant.

Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d
Reviewed-on: https://gerrit.libreoffice.org/46164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-11 12:13:46 +01:00
Stephan Bergmann 20c66302db loplugin:includeform: scripting 
Change-Id: I5b1280426667636703c996af8ee08ffeeffeb7e1
 2017-10-23 22:45:55 +02:00
Noel Grandin 2c05d758b2 add << operator for css::uno::Exception 
Change-Id: Ia23dafd07133779144965682df3b7125a3214235
Reviewed-on: https://gerrit.libreoffice.org/43046
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-10-04 15:18:00 +02:00
Noel Grandin 3dcf6dfcee remove unnecessary use of 'this->' 
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4
Reviewed-on: https://gerrit.libreoffice.org/40671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-02 13:45:36 +02:00
Noel Grandin c9253818ec loplugin:oncevar 
extend oncevar to any POD type

Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0
Reviewed-on: https://gerrit.libreoffice.org/40564
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-31 08:25:07 +02:00
Noel Grandin d7e06e46ac use more OUString::operator== in scaddins..sdext 
Change-Id: I8bc5c925f940283bc54698bbcba77efcca883273
Reviewed-on: https://gerrit.libreoffice.org/39937
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-14 10:12:31 +02:00
Stephan Bergmann f1cef09fcd loplugin:casttovoid 
...cases that were initially missed due to the broken
containsProcessingConditionalInclusion()

Change-Id: Ib7d801ab5173ee590ef35a9e075d3ce4d4aa06da
 2017-07-04 08:15:08 +02:00
Stephan Bergmann f6abc3f97e loplugin:casttovoid: scripting 
Change-Id: I9f77eca5a80ad4e9d3cee8f7400a245f5fa78bbb
 2017-07-02 22:30:49 +02:00
Jochen Nitschke a5dba7dbec remove unused osl/mutex.hxx includes 
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb
Reviewed-on: https://gerrit.libreoffice.org/38905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2017-06-18 13:38:25 +02:00
Jochen Nitschke 0d1a3593c2 cleanup unused css/uri/ includes 
Change-Id: I08c7981ecce45e343ff9e98277dd3aea4ed68ab9
Reviewed-on: https://gerrit.libreoffice.org/37860
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-20 18:00:23 +02:00
Andrea Gelmini 5a72da3d97 Fix typos 
Change-Id: I4e1a613fc99b931e84a1955695364e1d25e25e5c
Reviewed-on: https://gerrit.libreoffice.org/35642
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2017-03-25 17:24:16 +00:00
Noel Grandin 198c41c4fe new loplugin unoany 
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89
Reviewed-on: https://gerrit.libreoffice.org/34714
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-28 10:17:47 +00:00
Stephan Bergmann 6dce9c6757 Add missing #includes 
...and remove some unncessary using directives/declarations, in preparation of
removing now-unnecessary #includes from cppumaker-generated files, post
e57ca02849 "Remove dynamic exception
specifications".

Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
 2017-02-06 17:21:16 +01:00
Stephan Bergmann e57ca02849 Remove dynamic exception specifications 
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-01-26 12:54:43 +00:00
Stephan Bergmann 7b79e23260 New loplugin:dynexcspec: Add @throws documentation, scripting 
Change-Id: I3a3f8ad12bad448f0ea2beb698cf4e6636d4595a
 2017-01-19 18:03:14 +01:00
Noel Grandin 81f2a9f464 OSL_TRACE->SAL in sc..scripting 
Change-Id: I389d8cb733a5ee24d3119a1ebac5a5b70daff04e
Reviewed-on: https://gerrit.libreoffice.org/31900
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-13 06:07:57 +00:00
Stephan Bergmann 1800862c70 loplugin:stringconstant: look into 'char const * const var = "..."' 
Change-Id: I52a97b8ec273509131c2200e47527221cb62d7ee
 2016-11-25 16:42:23 +01:00
Noel Grandin 09cb920969 convert std::unique_ptr<VclAbstractDialog> to VclPtr 
Change-Id: Ifdd2a0599efd701def02b4a4d2a1c489cb1b27fa
 2016-10-28 09:12:27 +02:00
Stephan Bergmann 91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Noel Grandin 435d6d50c3 loplugin:constantparam in sfx2 
Change-Id: I50a2d8221f907f0e844e558f3dbdd0346c010201
 2016-03-09 10:07:46 +02:00
Noel Grandin 21a9bc8716 no need to take a mutex when only dealing with stack-local data 
Change-Id: Ie45e626aad55a8174a53b769a98601bf54dedf65
Reviewed-on: https://gerrit.libreoffice.org/19979
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-16 11:37:11 +00:00
Noel Grandin 8569c6d0ad use initialiser list for Sequence<OUString> 
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02
Reviewed-on: https://gerrit.libreoffice.org/19978
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-16 08:35:42 +00:00
Stephan Bergmann 65464ed098 loplugin:nullptr (automatic rewrite) 
Change-Id: I9b7d8de65780325175d24965057596b88d3c0f05
 2015-11-10 10:31:37 +01:00
Noel Grandin 0eb9f56db5 use uno::Reference::set method instead of assignment 
Change-Id: I2b592fd3327f4bbe4685e84711dc9d6f19222a97
 2015-11-05 07:41:29 +02:00
Caolán McNamara 4ea0390faa cppcheck: noExplicitConstructor 
Change-Id: I06186e8f0bbc8522f538e8639a68e816093becc2
 2015-11-02 10:16:38 +00:00
Noel Grandin d95a27f944 com::sun::star->css in scaddins,sccomp,scripting 
Change-Id: Id9167341940bac65f055e1e33ff0670f6fa0f6c4
Reviewed-on: https://gerrit.libreoffice.org/19629
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-28 06:31:27 +00:00
Stephan Bergmann b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Caolán McNamara 3a00aaef2a boost->std 
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-09-18 07:59:14 +00:00
Takeshi Abe f3c7e69536 scripting: tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants.

Change-Id: I2a59d42efbb1aeef5078d0b0744b5a3c0559affa
Reviewed-on: https://gerrit.libreoffice.org/18123
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2015-09-03 17:53:31 +00:00
Stephan Bergmann 6b97231ba3 Reduce to static_cast any reinterpret_cast from void pointers 
Change-Id: I7d6106bda60f8cae3e110e6757b3bf267ce15ec5
 2015-03-31 13:16:12 +02:00
Stephan Bergmann fe17eb9448 scripting: Use appropriate OUString functions on string constants 
Change-Id: I8ee8eb92ac95937893c894e67882e9df2c16a67d
 2014-12-15 10:15:16 +01:00
Takeshi Abe 4d32244437 Avoid possible memory leaks in case of exceptions 
Change-Id: Ib4a87cab2729e18b2c830cbd7e7a34d62b5f0f45
 2014-08-26 19:47:14 +09:00
Noel Grandin adc20c3937 compareToAscii -> equalsAscii 
convert places using compareToAscii that should be using equalsAscii

Change-Id: I97b4da7f6e867c3967b2f65b70d6886f83b4a4e5
 2014-06-04 11:52:31 +02:00
Noel Grandin e7bc3cab01 remove boilerplate in UNO Exception constructor calls 
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
 2014-05-23 15:06:00 +02:00
Tsutomu Uchino a00c4c5e2f Resolves: #i113481# query script invocation from the current frame... 
when the controller is not yet attached

(cherry picked from commit 03a410876fbdb5f9e1a7216d9d622557275d4896)

Change-Id: I1da3b3da258445d5187dcc75c4d151d08f9017dc
 2014-05-18 08:53:07 +01:00
Noel Grandin 2ff8ae7c9e scripting: sal_Bool->bool 
Change-Id: I1550c49cce2ad64f9d62b06ec20512a750f83b84
 2014-04-24 10:53:16 +02:00
Thomas Arnhold 8bb2ce61c0 fixincludeguards.sh: some smaller dirs 
Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
 2014-04-19 11:10:13 +02:00
Stephan Bergmann 567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
 2014-03-27 18:12:18 +01:00
Stephan Bergmann 5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Takeshi Abe a53577e6ff Replace deprecated std::auto_ptr with boost::scoped_ptr 
Change-Id: I55292f5f0049e7c77d5bb0e5ef5fa187b815d159
 2014-02-24 10:20:51 +09:00
Stephan Bergmann dbac5ccaf8 bool improvements 
Change-Id: I0ef2adc0bd4a4764c38094b2b7d27c3453ecc117
 2014-01-28 20:26:23 +01:00
Stephan Bergmann 9e1ec4df0b bool improvements 
Change-Id: I75c137c1ed0c6089c5dfa8131ffde76cadda0134
 2014-01-22 08:22:33 +01:00
Stephan Bergmann 9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..." 
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
 2013-12-17 11:06:00 +01:00
Noel Grandin 73342dbb82 remove unnecessary RTL_CONSTASCII_STRINGPARAM 
A final pass through the code, converting code to use the new
OUString and OString methods that can detect string literals.

Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
 2013-11-22 08:07:19 +02:00
Noel Grandin 610b2b94b3 remove unnecessary use of OUString constructor when assigning 
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
 2013-11-19 10:29:31 +02:00
Marcos Paulo de Souza ee5661ecd3 fdo#54938: Adapt supportsService implementations.. 
to cppu::supportsService

Change-Id: I0b03d3910f094f2183bf9859db9d5bcaf35d1f14
Reviewed-on: https://gerrit.libreoffice.org/6370
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2013-10-22 10:28:10 +00:00
Stephan Bergmann 3ef9fac503 -Werror,-Wunused-const-variable 
Change-Id: I5e00ce258e2dc2b13dc0f7a38f5a92bd1235e81e
 2013-10-02 16:49:37 +02:00