ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
476,260 Commits 3 Branches 3 Tags
30e6a4748bb29cc299c41755fbdf108db2c1c005
Commit Graph
412 Commits
Author SHA1 Message Date
Noel Grandin 5ecdedbf81 clang-tidy modernize-pass-by-value in basic 
Change-Id: I9034ab95a4ccb58e36e77d911dd33cc50857c03a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135176
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-31 15:11:27 +02:00
Noel Grandin 371886dd12 elide some OUString allocation 
Change-Id: Ia21421731dadc1d0e65da182471eb2b8d799782b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134918
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-25 16:00:48 +02:00
Noel Grandin 3c25a2a114 tdf#121740 dont bother checking for VBA libraries 
speeds up loading by 2%

Change-Id: I63bf7ea2ab8087d6bb60b655fdf7718532050b89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134114
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-10 19:41:31 +02:00
Noel Grandin e7d3243d22 move creation of xParser to where it is used 
Change-Id: I03511a8c7b01b0abb69b276b900bf712549e5873
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134113
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-10 19:25:41 +02:00
Stephan Bergmann b5ab864096 Just use Any ctor instead of makeAny in basic 
Change-Id: I21d9679064c4e68a1492d3550f083c3c91b5b43b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133848
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-05-05 07:13:54 +02:00
Noel Grandin d3849255b7 use more string_view in INetURLObject 
Change-Id: I4462f7cf4740fa4d1b129d76a0775f4250f41bbd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133555
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-04-29 08:53:22 +02:00
Caolán McNamara 09530aec3c cid#738565 Uninitialized scalar field 
Change-Id: I17a675d3b7468e528faef89de7ea862de37a57db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133504
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-04-27 15:58:45 +02:00
Andreas Heinisch e4bdf75260 tdf#75263 - Export VBA-Project using detected charset on import 
Change-Id: Ia1f1bb31e077dcb4293c1106ac324a25a975a656
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133064
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
 2022-04-25 22:10:42 +02:00
Noel Grandin f9f5c9f0d6 replace comphelper::OListenerContainer with OInterfaceContainerHelper3 
OInterfaceContainerHelper3 is in wide use and can do the same thing with
less ceremony

Change-Id: I5252738d6b7bda6245c66da46352944ead79bd52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126271
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-12-03 20:42:00 +01:00
Noel Grandin 11599f6f00 use more OInterfaceContainerHelper3 in NameContainer 
Change-Id: I75cb302156ea93fe0b545b22ca85a0c537cce760
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125919
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-11-27 06:48:07 +01:00
Mike Kaganski 81a7d46d9f Prepare for removal of non-const operator[] from Sequence in basic 
Change-Id: If048bc301c38ac5ac5412a7d8f69231705088a50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124343
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-10-29 06:50:32 +02:00
4k5h1t 5f4a84ce5b tdf#42982: improve UNO API error reporting 
Change-Id: I1252c89f23e70eb88744585bb2abd4fe3794e1d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121918
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
 2021-09-14 11:16:07 +02:00
Noel Grandin 1597cc5b3e convert #defines to OUStringLiteral 
mostly by doing

$ git grep -l '#define.*\"' -- *.cxx
    | xargs perl -pi -e
's/^#define\s+(\w+)\s+(\".*\")/constexpr OUStringLiteral \1 =
u\2;/g'

Change-Id: Idface893449b0ef2a3c5254865a300585d752fbb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119669
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-08-02 14:43:58 +02:00
Noel Grandin 004ddb8fdb fix leak in dbaccess 
when loading form controls

Change-Id: Ifa731ca1c7bc16579ce03d256691a50ccfbeb82b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116050
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-05-24 14:20:28 +02:00
Noel Grandin 39c3574b79 use string_view in INetURLObject::encode 
Change-Id: Ib686c6872388b02c8939d3b65f6bd25cda348bc8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114754
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-04-28 15:41:02 +02:00
Noel b624b13b3d loplugin:flatten 
Change-Id: Ib7a895fba66f8dc9b6501e61631c02694053b7fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113157
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-26 18:02:19 +01:00
ViKrAm-Bais 394ad7fa73 tdf#42982: improve UNO API error reporting 
Change-Id: I20080d81e0b08e6e0dcd421bd75cb7d796e97ea7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112149
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
 2021-03-08 11:08:06 +01:00
Noel 568b4e8d7a loplugin:refcounting in basic 
Change-Id: Idbee5b35215f794e6785925dafb6f160caa24a22
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111541
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-02-26 09:59:21 +01:00
Noel 1571fd8bfd loplugin:refcounting in basic 
Change-Id: I0c1e41436ddae176695a90c120303727aa3bc2ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111306
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-02-22 17:32:28 +01:00
vipbuoy 1775cd844b tdf#42982 updated RunTimeException with 2nd argument(pointer) 
Change-Id: I52dd9b9808e5fd61d07d4f8a6642124230ede23f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110971
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
 2021-02-17 13:24:30 +01:00
Noel 7874cba970 loplugin:referencecasting in basctl..binaryurp 
Change-Id: I3fbc287cf76e453e2c464837d2431ff19501fde3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110968
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-02-16 08:57:02 +01:00
Noel bca1b74c07 improve some IllegalArgumentException messages 
Change-Id: Id88f2a82bf2651e8b5895aa330f32b71ff5b0e48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109546
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-01-20 09:03:45 +01:00
Caolán McNamara ac396f2f6b fix coverity parse errors 
Change-Id: I3a1179947704452e3ffec02be59d0f7bf0b75ab0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109017
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-01-09 13:01:49 +01:00
Stephan Bergmann 042033f1e6 loplugin:stringviewparam: operator + 
Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2020-12-29 16:42:33 +01:00
Stephan Bergmann a3d0091d18 New loplugin:stringliteralvar 
See the comment at the top of compilerplugins/clang/stringliteralvar.cxx for
details.

(Turned some affected variables in included files into inline variables, to
avoid GCC warnings about unused variables.)

Change-Id: Ie77219e6adfdaaceaa8b4e590b08971f2f04c83a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108239
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2020-12-26 14:51:15 +01:00
Philipp Hofer 16389aae36 tdf#123936 Formatting files in module basic with clang-format 
Change-Id: I87736d6f1a1d069c990b4e7b9ca291634ab4fb44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105646
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
 2020-11-13 14:31:50 +01:00
Arnaud Versini 8ad514c665 BASIC : use std::make_unique instead of std::unique_ptr ( new ... ) 
Change-Id: Ic907f4711685539b6a89411e704845617cc5f04d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105375
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-11-05 20:39:26 +01:00
Noel 387a88fa25 use tools::Long in basegfx..chart2 
Change-Id: Ide4014348d51f0b5f59e1e91b8d41c7748853254
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104608
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-10-21 15:34:16 +02:00
Noel 38786f1df9 loplugin:reducevarscope in basctl,basic 
Change-Id: I32595921bf5ed26699bced3637302692c407d624
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103760
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-10-01 16:12:20 +02:00
Andrea Gelmini 881aca8eb1 Fix typo in code 
It passed "make check" on Linux

Change-Id: Iae7db8b7627c5e4715860eafda8df98d2cb8f781
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103308
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2020-09-24 18:32:07 +02:00
Noel Grandin e67657d521 loplugin:simplifybool more 
look for expressions like
    !(a && !b)
which can be expanded out

Change-Id: I72515a9638762b050f9a258c08da39ebfa2ef8e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100579
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-08-14 18:03:06 +02:00
Noel Grandin 898cbb22f0 use for-range on Sequence in basctl..canvas 
Change-Id: Idad3d8fbe785c7b1b8b287a3227372adb2757de8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94260
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-05-15 14:00:48 +02:00
Noel Grandin 8b0a69498b loplugin:flatten in basic 
Change-Id: Icb8e3cda312b50c9a9f12f96bec1c746f41c8979
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92483
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-04-19 08:30:49 +02:00
Noel Grandin 14471a6942 loplugin:buriedassign in b* 
Change-Id: Ic20f46105a30b54bc5a991b4070e6c8edb15376e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92189
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-04-14 16:17:55 +02:00
Noel Grandin 79b13b4d50 OSL_ASSERT->assert in basic 
Change-Id: I8abe14706e9c6d1323d5d66a8b700ddaa2803f2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91333
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-03-30 09:13:23 +02:00
Noel Grandin fb1eac64df sal_Char->char in avmedia..basic 
Change-Id: Ied1331d979539ef1183da64c55351b57d24f4a4f
Reviewed-on: https://gerrit.libreoffice.org/85371
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-12-18 12:23:44 +01:00
Gabor Kelemen 7ddedd2594 tdf#42949 Fix IWYU warnings in basic/ 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I325149be2ea7697b5b4a2ce4a662edd2f8be6e50
Reviewed-on: https://gerrit.libreoffice.org/82312
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2019-11-12 09:20:55 +01:00
Noel Grandin 889dc7bffa use more TOOLS_WARN_EXCEPTION 
Change-Id: Ic21ea11ff106e0732bb8fa600ef39a549d7bda86
Reviewed-on: https://gerrit.libreoffice.org/77569
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-08-16 13:31:26 +02:00
Stephan Bergmann d204b7f787 Improved loplugin:stringconstant (now that GCC 7 supports it): basic 
Change-Id: I174b057e29e5c0d56534fb1d2b6240880c7ddf2b
Reviewed-on: https://gerrit.libreoffice.org/76695
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-07-31 13:00:51 +02:00
Noel Grandin ee2bb23103 loplugin:referencecasting in avmedia..basic 
Change-Id: I6790b2e3902d64fb6f714f031affa221dbaba014
Reviewed-on: https://gerrit.libreoffice.org/75934
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-07-19 12:22:43 +02:00
Noel Grandin cdcc2f365b loplugin:logexceptionnicely in accessibility..basic 
Change-Id: I6e0b95b40e3d62db36352f3ea916f79f3dbc9084
Reviewed-on: https://gerrit.libreoffice.org/74018
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-06-14 11:29:43 +02:00
Noel Grandin a361231b13 fix wrong SET/QUERY flags passed to uno::Reference 
By creating deleted methods for the wrong calls.

Avoids the compiler needing to construct a temporary

Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a
Reviewed-on: https://gerrit.libreoffice.org/72103
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-05-13 08:15:27 +02:00
Caolán McNamara fbc038cc4f an uno -> a uno 
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d
Reviewed-on: https://gerrit.libreoffice.org/72105
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-05-10 14:50:59 +02:00
Noel Grandin d028c1be17 loplugin:sequentialassign in accessiblity..canvas 
Change-Id: I984717138ac85c1af5fc363fda06f5c2b5497965
Reviewed-on: https://gerrit.libreoffice.org/70641
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-04-12 13:06:26 +02:00
Noel Grandin 183debd7e0 pretty up logging of exceptions 
Add exceptionToString() and getCaughtExceptionAsString() methods in
tools.

Use the new methods in DbgUnhandledException()

Add special-case case code for most of the exceptions that contain extra
fields, so all of the relevant data ends up in the log

Change-Id: I376f6549b4d7bd480202f8bff17a454657c75ece
Reviewed-on: https://gerrit.libreoffice.org/67857
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-02-19 09:39:48 +01:00
Noel Grandin 587ac01f97 loplugin:indentation in basctl..bridges 
Change-Id: Ie4e27466c4258c6f774a3ebb82ec3a88c28fd753
Reviewed-on: https://gerrit.libreoffice.org/67525
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-02-08 10:01:05 +01:00
Noel Grandin 17dd2662cc convert "*xxx.get()" to "*xxx" 
Change-Id: Ic307226591ff9702957ccdec486ccf70357eb6d9
Reviewed-on: https://gerrit.libreoffice.org/65951
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-01-08 10:38:35 +01:00
Gabor Kelemen 00b49f9ff9 tdf#42949 Fix IWYU warnings in include/vcl/s* 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ie87d27dd2c385a63349e0b322fd067ba03d2d152
Reviewed-on: https://gerrit.libreoffice.org/64479
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2018-12-10 14:19:50 +01:00
Noel Grandin c0cc59adca loplugin:singlevalfields improvement 
look for any kind of types, not just POD types, helps to find
smart pointer fields that are only assigned nullptr

Change-Id: I2d887e98db012f03b646e1023985bcc196285abc
Reviewed-on: https://gerrit.libreoffice.org/62382
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-10-26 11:20:07 +02:00
Gabor Kelemen d90ec5d26f tdf#42949 Fix IWYU warnings in include/xmlscript/* 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Iacc5b98b947a26ca920cb9c49e579bc61d69b0c9
Reviewed-on: https://gerrit.libreoffice.org/62119
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2018-10-25 09:09:35 +02:00