Commit Graph
34979 Commits
Author SHA1 Message Date
Mark Wielaard 5c3f673c1f Robustify WW8FormulaControl::FormulaRead reading SvStream.
The >>operator of SvStream doesn't initialize a variable if the stream
is faulty. So initialize the variables before usage to prevent reading
wrong/random bits.

Change-Id: Ia66dd6d8574c36e7229a58347f2e2c1e0fe2e248
Reviewed-on: https://gerrit.libreoffice.org/4636
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-07-01 12:24:33 +00:00
Caolán McNamara 3090cfc972 Resolves: rhbz#979758 crash on 'Diagrammen in LibreOffice' help page
Change-Id: I269846840b8e2f67838da525c020a305901cf903
2013-07-01 12:56:17 +01:00
Caolán McNamara 20661599f4 add missing .ui
Change-Id: I3cf3d730fee95a54d8b51779835eda8d24d50ff3
2013-07-01 12:42:02 +01:00
Caolán McNamara 14c619f10f convert predefined label warning dialog to .ui
Change-Id: I6f7cbc6aea1acbd7c803cd418ba2e9ed71fb2c50
2013-07-01 11:50:33 +01:00
Luboš Luňák dc7498e4f0 don't show section/table nodes as plain start nodes in debug dump
Change-Id: I8b4901d98c210f5a3228981a2b180f2fcc06c768
2013-07-01 12:27:52 +02:00
Luboš Luňák ed1d006e1a remove strange #ifdefs, presumably a workaround for ancient compiler bug
Change-Id: I77287909b88be01615e2aae302c48904c1adf933
2013-07-01 12:27:52 +02:00
Miklos Vajna d892671c11 fdo#47802 testcase
Change-Id: Ib3e399efb0d1116473bc5ff0e1b858b2cfa4aec8
2013-07-01 11:43:57 +02:00
Caolán McNamara 6d866fec71 fix indent
Change-Id: I079e88700f3353b906f0d8fc85083695cfe569bb
2013-07-01 10:41:43 +01:00
Caolán McNamara f9acc916bf MSG_DISABLE_UNDO_QUESTION unused
Change-Id: I1e06ccae6c820715d2cea70d679bf7681bae711a
2013-07-01 10:41:42 +01:00
Caolán McNamara d2b2b79106 convert show redlines warning box to new-style message dialog
Change-Id: I5d7e205c8908fab6ff70065961d77b3b91d82461
2013-06-30 20:40:16 +01:00
Caolán McNamara 0306e253fe XubString->OUString
Change-Id: I40ff06facc304630ccedd82d2f20b3573bdc5cb4
2013-06-30 20:40:15 +01:00
Tor Lillqvist 90b27064b4 WaE: 'SwJavaEditDialog::GetText' hides overloaded virtual function
Change-Id: Ie0129f00f7abe925ad86547812b5b15986e42a78
2013-06-30 10:37:20 +03:00
Norbert Thiebaud 710f41b7ae Clean String and sal_Bool in tools
Change-Id: I6a92196f33d7a5278c7dcc426112e9c56d582655
Reviewed-on: https://gerrit.libreoffice.org/4627
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-06-30 04:58:49 +00:00
Thomas Arnhold ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
Thomas Arnhold 520cab064e merge string
Change-Id: I6d3a0bd7db7a6fa0d36fa2a614edf0ba7013bd81
2013-06-29 21:30:09 +02:00
Thomas Arnhold 318f2b64cc remove some createFromAscii usage
there are a lot more of them:

git grep 'createFromAscii[^)]*"'

Change-Id: Ibc2e9cae208d8b9c91667bb3b177c6bd6d3a9424
2013-06-29 16:23:23 +02:00
Michael Stahl fdf5152552 more README
Change-Id: I569e7fd3cf9e418af03285f4f499f5ea3a0c0dc0
2013-06-28 23:38:36 +02:00
Michael Stahl 7c3980053f remove unused DateTimeRange includes
Change-Id: Iedf60c9729067214365a74222be6a59c19d0f7d5
2013-06-28 17:37:13 +02:00
Thomas Arnhold 5cb2e3104b remove toolkit/unohlp.hxx hack
Change-Id: Idb9971d848870f4d00dbf77e80e48bf7dfde8913
Reviewed-on: https://gerrit.libreoffice.org/4601
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-28 11:49:28 +00:00
Caolán McNamara 1a05f14ba2 fix build for highest debugging level
Change-Id: Icc91931ec3eb4ea73476f3f570ca5eb7ef784dce
2013-06-28 11:50:15 +01:00
Adam Co 74c5ed19f4 DOCX import fix for table with auto size
Change-Id: Ic86f4f142e579bdef3e954492e1c1e382a545739
Reviewed-on: https://gerrit.libreoffice.org/4496
2013-06-28 11:43:48 +02:00
Julien Nabet 296c2af27a fdo#66101: lowriter crashed when trying to open .docx file
Change-Id: I516bcb4bc18806d5a83f94c0776bd0f918a1e927
Reviewed-on: https://gerrit.libreoffice.org/4550
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-28 09:22:31 +00:00
Caolán McNamara 7a61efe422 add missing VclBuilder::stringmap argument to some builder functions
Change-Id: I57e13920b4707ebe5b6a7149dbdbfc45593c0d9d
2013-06-27 16:45:11 +01:00
Michael Stahl fd2bd50bb4 Revert "Related: #i121925# fixed by reverting change for issue #i119652#"
This reverts commit e47b7f967b.

The original commit this reverts was never merged anyway and this adds
some line that were context in the AOO commit.
2013-06-27 15:38:33 +02:00
Michael Stahl 97e6ff086e Revert "Resolves: #119652# avoid invalid selection on..."
This reverts commit e6cd5d0b11.

The problem was already solved with
af4b6c94c6.

Change-Id: I21d7ca9fec601377967297bc42835573422c29a7
2013-06-27 15:38:32 +02:00
Oliver-Rainer Wittmann e47b7f967b Related: #i121925# fixed by reverting change for issue #i119652#
(cherry picked from commit be6ce149c164d8ac06f12a4a1cc04a9299f5fd07)

Conflicts:
	sw/source/core/edit/eddel.cxx

Change-Id: I13ff642a7d983a1a1ffe4e3e0b412ec190d900bb
2013-06-27 13:51:20 +01:00
Oliver-Rainer Wittmann e6cd5d0b11 Resolves: #119652# avoid invalid selection on...
Delete-To-Start-Of-Sentence action

(cherry picked from commit 562cc00ca57d00a22d56e61c5da307864e5db2f9)

Conflicts:
	sw/source/ui/wrtsh/wrtsh4.cxx

Change-Id: I56e104792f28b462327a53d243baa6c1413b3099
2013-06-27 13:45:42 +01:00
Oliver-Rainer Wittmann 11eb95f740 Resolves: #i120938# consider left indentation when converting...
tab stop positions of styles

(cherry picked from commit 7b20978d84db1f7f545ff608bdb09275813e2219)

Change-Id: I068a8dced069c4676623723f16ae4d85997f086d
2013-06-27 10:16:35 +01:00
Caolán McNamara a653bda02b fix highest debugging level build
Change-Id: I1f40bba348a3c0be7a892b56a9bf1b7da0b4435f
2013-06-27 10:16:35 +01:00
Oliver-Rainer Wittmann 7a22c4c519 Resolves: #i120582# consider the case that a right indent is set...
at the paragraph

- some minor reformatting and cleanup of older comments

(cherry picked from commit e4578fcc2408a530d373653b01c0a88ef46ea26f)

Conflicts:
	sw/source/core/text/txttab.cxx
	sw/source/filter/ww8/ww8par.cxx

Change-Id: I345a20c78f26be60de3eb01ac6f5303de46c2fc1
2013-06-26 20:35:57 +01:00
Miklos Vajna 55162d7422 bnc#823675 RTF import: fix import of numbering bullet associated font
There were multiple problems here:

- \f had a special handler for the listlevel destination, \af had not
- in case of multiple \f or \af, the first one is used for the bullet
  font
- in case only \af is used for the bullet font, its value should be used
  for \f as well

Change-Id: I6631504c1aa9f2e0792a3469a5fdce5b7bd49518
2013-06-26 17:30:02 +02:00
Oliver-Rainer Wittmann 25d84e2826 Resolves: #i121751# restore cursor/selection on Undo/Redo language...
change for all text

- group intrinsic actions of language change for all text into one Undo action
- secure <SwRootFrm::CalcRects(..)> - catch NULL pointer
- correct <CursorGuard> - really restore the cursor

(cherry picked from commit 4207db473430e02a65a5f4d57db6e46a8db29a19)

Conflicts:
	svl/inc/svl/undo.hxx
	svl/source/undo/undo.cxx
	sw/inc/IDocumentUndoRedo.hxx
	sw/source/core/edit/edundo.cxx
	sw/source/core/inc/UndoManager.hxx
	sw/source/core/layout/trvlfrm.cxx
	sw/source/core/undo/docundo.cxx

Change-Id: I972988bbc21a519e0956ff196aa93a46287b9a2e
2013-06-26 16:22:38 +01:00
Michael Stahl 19694e8449 SetFmtItemByAutoFmt/SetTxtFmtCollByAutoFmt called with SwTxtNode
... always so don't need to check for it.

Change-Id: I4bbc2a44a9c3d4ebde766a64a6ab78f7ead9c7af
2013-06-26 17:16:49 +02:00
Caolán McNamara 61533b8c54 Resolves: fdo#65743 MovePara gets stuck on hidden para fields
Change-Id: I03b26aaa9be491e760335185c5a9ffd5d04990bb
2013-06-25 20:22:18 +01:00
Miklos Vajna a8ee2ee752 fdo#66040 RTF import: initial groupshape support
There are two cases here: if the shapes contain tables (or other
Writer-specific features), we should use text frames and we should not
create the actual group shape, as Writer textframes can't be part of
such group shapes.  The other case is when the shapes contain simple
text, OTOH there are groupshape-level transformations defined, in that
case we should choose drawinglayer rectangles and actually create a
group shape.

This commit implements support for the first case only.

Change-Id: I9dc99b0711ce5c7a29ea0b14539df0121f9de3d0
2013-06-25 15:35:02 +02:00
Michael Stahl b8298f8e19 DocxAttributeOutput: -Werror=unused-macros, -Werror=sign-compare
Change-Id: I9d75b0a625009d483467042584d2d2f89501cb96
2013-06-25 12:49:17 +02:00
Adam Co 26d4068612 fdo65400: fix for Character Shading being lost
This bug fixes the DOCX import and export filters, adds a new property
to the document model and updates the UNO API.
There is no need to add layout \ UI updates, because in Word
the only way to turn this on\off is using a simple button,
and there is no way to control the shading color itself.
However, ODF import \ export filters should be updated in a future
commit.

Conflicts:
	sw/qa/extras/ooxmlexport/ooxmlexport.cxx

Change-Id: I1d34cec79289e38c08e42a4c6265d998e1edfdef
Reviewed-on: https://gerrit.libreoffice.org/4452
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
2013-06-25 10:04:01 +02:00
Michael Stahl 38dcfadda8 fdo#58029: replace quadratic child window loop with linear
... which should speed things up without introducing problems.

(Window::GetChild(n) is inefficient because the children are a linked
list)

Change-Id: I343d51a6866c5014cbca4c256b0c15f938958c39
2013-06-24 20:17:43 +02:00
Michael Stahl cfa994ccbd fdo#43765, fdo#57884, fdo#58052, fdo#63949: disappearing form controls
Transparent form controls in Writer may not be painted properly, if
painted from ViewShell::ImplUnlockPaint(true), called from
SwLayIdle::SwLayIdle.

The problem is that SdrPaintWindow::OutputPreRenderDevice will paint
the background of the transparent form controls (thus over-painting the
controls), so it has to be followed by painting the controls themselves.

Change-Id: Icda4ad835a398bbd50139be32ff5014a34f23bd5
2013-06-24 20:17:43 +02:00
Miklos Vajna ddddfe8d6f bnc#823655 fix RTF import of freeform shape coordinates
E.g. 0,1 was imported as 1,0, as we did not differentiate between not
having the coordinate yet and having it as zero.

Change-Id: Ia5fbbcc791dc9c6866ffd4c146793690661d81b4
2013-06-24 15:11:15 +02:00
Norbert Thiebaud 5ac84ff884 coverity#705766 Resource leak
Change-Id: I14ca19f33dd57ed1a4a52a8a02f213bada79c20c
Reviewed-on: https://gerrit.libreoffice.org/4409
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-06-24 12:25:44 +00:00
Norbert Thiebaud 37e1d7a0df coverity#705765: Resource leak
Change-Id: Ibf9d4716e5c5929fe47c836812879f815aa78d6c
Reviewed-on: https://gerrit.libreoffice.org/4408
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-06-24 12:22:50 +00:00
Mark Wielaard e4e9768e43 Fix memory leak in SwTOXBaseSection::GenerateText.
Delete LinkStruct created in TOKEN_LINK_END case after copying contents.

Change-Id: I294009ad62756996cf840ebf56b28d79dfd6e2f3
Reviewed-on: https://gerrit.libreoffice.org/4470
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-06-24 12:05:24 +00:00
Adam Co 6edcfde748 fdo#56679, fdo#65710 : fix for import and export of underline color
Change-Id: Ifc45900d73802ef99c55d7af4ee04314dd04f1c5
Reviewed-on: https://gerrit.libreoffice.org/4459
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-06-24 09:34:18 +00:00
Miklos Vajna c6a941b51b bnc#823655 RTF import: ignore styles without a type
Regression from 29dcdf6b56.

Change-Id: I970c0e7b3652d7e6f093815b90e04e0c45904b28
2013-06-21 16:11:01 +02:00
Norbert Thiebaud 0139e0b1cd coverity#707550, coverity#707549 : Unitialized scalar variable
Change-Id: I36026768fb51ed80a70addfcad9b831d8e7e6d7c
Reviewed-on: https://gerrit.libreoffice.org/4405
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-06-21 11:31:26 +00:00
Norbert Thiebaud 4cb05188fe coverity#707554 Unitialized scalar variable
Change-Id: I8df87c59926a62309e2ba342fe38b4915f81b3f7
Reviewed-on: https://gerrit.libreoffice.org/4404
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-06-21 11:29:59 +00:00
Miklos Vajna 832612bb6b fdo#43641 testcase
Change-Id: I3426c7c23eb23fa7f91320ac036b0eb565bbc330
2013-06-21 10:43:51 +02:00
Tor Lillqvist 5c214a04b3 Remove pointless overdose comment
Change-Id: I0e9a490ae4364b9bf14d6ad8766aef279a69db01
2013-06-20 12:40:59 +03:00
Tor Lillqvist 1410cac73f WaE: macro is not used
Change-Id: I2f55abf4526f4184ba04fc173df8cf5236219cfc
2013-06-20 12:40:59 +03:00