This reverts commit c656bab4c9.
Reason for revert: it breaks the Windows build with
[_RUN_____] MigrationTest::testBinaryImport
warn:sfx.appl:12852:4132:sfx2/source/appl/app.cxx:148: No DDE-Service possible. Error: 16399
warn:vcl:12852:4132:vcl/win/window/salframe.cxx:1046: WinSalFrame::SetIcon(): Could not load large icon !
warn:vcl:12852:4132:vcl/win/window/salframe.cxx:1047: WinSalFrame::SetIcon(): Could not load small icon !
warn:comphelper:12852:4132:comphelper/source/misc/logging.cxx:65: EventLogger_Impl::impl_createLogger_nothrow: caught an exception! com.sun.star.uno.DeploymentException message: "component context fails to supply singleton com.sun.star.logging.LoggerPool of type com.sun.star.logging.XLoggerPool at E:\jenkins\workspace\gerrit_windows_wsl\workdir\UnoApiHeadersTarget\offapi\normal\com/sun/star/logging/LoggerPool.hpp:38" context: class cppu::`anonymous namespace'::ComponentContext
warn:connectivity.firebird:12852:4132:connectivity/source/drivers/firebird/Util.cxx:58: firebird_sdbc error:
*Use of database at location E:\JENKINS\WORKSPACE\GERRIT_WINDOWS_WSL\TMP\TEST_DBACCESS_MIGRATION.DLL2JVD3.TMP\TEST_DBACCESS_MIGRATION.DLL2JVD4.TMP\FIREBIRD.FDB is not allowed by server configuration
caused by
'isc_create_database'
unknown:0:MigrationTest::testBinaryImport
An uncaught UNO exception
- com.sun.star.sdbc.SQLException: {Message: "firebird_sdbc error:
*Use of database at location E:\JENKINS\WORKSPACE\GERRIT_WINDOWS_WSL\TMP\TEST_DBACCESS_MIGRATION.DLL2JVD3.TMP\TEST_DBACCESS_MIGRATION.DLL2JVD4.TMP\FIREBIRD.FDB is not allowed by server configuration
caused by
'isc_create_database'
at E:/jenkins/workspace/gerrit_windows_wsl/connectivity/source/drivers/firebird/Util.cxx:69", Context: @00000054DD385300, SQLState: "", ErrorCode: 1, NextException: void: void}
warn:connectivity.firebird:12852:4132:connectivity/source/drivers/firebird/Util.cxx:58: firebird_sdbc error:
*Use of database at location E:\JENKINS\WORKSPACE\GERRIT_WINDOWS_WSL\TMP\TEST_DBACCESS_MIGRATION.DLL2JVD3.TMP\TEST_DBACCESS_MIGRATION.DLL2JVD4.TMP\FIREBIRD.FDB is not allowed by server configuration
caused by
'isc_service_start'
warn:cppuhelper:12852:4132:cppuhelper/source/implbase.cxx:82: class com::sun::star::uno::Exception msg: firebird_sdbc error:
*Use of database at location E:\JENKINS\WORKSPACE\GERRIT_WINDOWS_WSL\TMP\TEST_DBACCESS_MIGRATION.DLL2JVD3.TMP\TEST_DBACCESS_MIGRATION.DLL2JVD4.TMP\FIREBIRD.FDB is not allowed by server configuration
caused by
'isc_service_start'
at E:/jenkins/workspace/gerrit_windows_wsl/connectivity/source/drivers/firebird/Util.cxx:69 at E:/jenkins/workspace/gerrit_windows_wsl/connectivity/source/drivers/firebird/Connection.cxx:922
warn:dbaccess:12852:4132:dbaccess/source/core/dataaccess/ModelImpl.cxx:925: com.sun.star.uno.DeploymentException message: "component context fails to supply service com.sun.star.security.DocumentDigitalSignatures of type com.sun.star.security.XDocumentDigitalSignatures at E:\jenkins\workspace\gerrit_windows_wsl\workdir\UnoApiHeadersTarget\offapi\normal\com/sun/star/security/DocumentDigitalSignatures.hpp:79" context: class cppu::`anonymous namespace'::ComponentContext
MigrationTest::testBinaryImport finished in: 878ms
[_RUN_____] MigrationTest::testNumbers
warn:vcl:12852:4132:vcl/win/window/salframe.cxx:1046: WinSalFrame::SetIcon(): Could not load large icon !
warn:vcl:12852:4132:vcl/win/window/salframe.cxx:1047: WinSalFrame::SetIcon(): Could not load small icon !
warn:connectivity.firebird:12852:4132:connectivity/source/drivers/firebird/Util.cxx:58: firebird_sdbc error:
*Use of database at location E:\JENKINS\WORKSPACE\GERRIT_WINDOWS_WSL\TMP\TEST_DBACCESS_MIGRATION.DLL2JVD3.TMP\TEST_DBACCESS_MIGRATION.DLL2JVD6.TMP\FIREBIRD.FDB is not allowed by server configuration
caused by
'isc_create_database'
unknown:0:MigrationTest::testNumbers
An uncaught UNO exception
- com.sun.star.sdbc.SQLException: {Message: "firebird_sdbc error:
*Use of database at location E:\JENKINS\WORKSPACE\GERRIT_WINDOWS_WSL\TMP\TEST_DBACCESS_MIGRATION.DLL2JVD3.TMP\TEST_DBACCESS_MIGRATION.DLL2JVD6.TMP\FIREBIRD.FDB is not allowed by server configuration
caused by
'isc_create_database'
at E:/jenkins/workspace/gerrit_windows_wsl/connectivity/source/drivers/firebird/Util.cxx:69", Context: @00000054DD386320, SQLState: "", ErrorCode: 1, NextException: void: void}
warn:connectivity.firebird:12852:4132:connectivity/source/drivers/firebird/Util.cxx:58: firebird_sdbc error:
*Use of database at location E:\JENKINS\WORKSPACE\GERRIT_WINDOWS_WSL\TMP\TEST_DBACCESS_MIGRATION.DLL2JVD3.TMP\TEST_DBACCESS_MIGRATION.DLL2JVD6.TMP\FIREBIRD.FDB is not allowed by server configuration
*Exiting before completion due to errors
caused by
'isc_service_start'
warn:cppuhelper:12852:4132:cppuhelper/source/implbase.cxx:82: class com::sun::star::uno::Exception msg: firebird_sdbc error:
*Use of database at location E:\JENKINS\WORKSPACE\GERRIT_WINDOWS_WSL\TMP\TEST_DBACCESS_MIGRATION.DLL2JVD3.TMP\TEST_DBACCESS_MIGRATION.DLL2JVD6.TMP\FIREBIRD.FDB is not allowed by server configuration
*Exiting before completion due to errors
caused by
'isc_service_start'
at E:/jenkins/workspace/gerrit_windows_wsl/connectivity/source/drivers/firebird/Util.cxx:69 at E:/jenkins/workspace/gerrit_windows_wsl/connectivity/source/drivers/firebird/Connection.cxx:922
warn:dbaccess:12852:4132:dbaccess/source/core/dataaccess/ModelImpl.cxx:925: com.sun.star.uno.DeploymentException message: "component context fails to supply service com.sun.star.security.DocumentDigitalSignatures of type com.sun.star.security.XDocumentDigitalSignatures at E:\jenkins\workspace\gerrit_windows_wsl\workdir\UnoApiHeadersTarget\offapi\normal\com/sun/star/security/DocumentDigitalSignatures.hpp:79" context: class cppu::`anonymous namespace'::ComponentContext
MigrationTest::testNumbers finished in: 145ms
[_RUN_____] MigrationTest::testTime
warn:vcl:12852:4132:vcl/win/window/salframe.cxx:1046: WinSalFrame::SetIcon(): Could not load large icon !
warn:vcl:12852:4132:vcl/win/window/salframe.cxx:1047: WinSalFrame::SetIcon(): Could not load small icon !
warn:connectivity.firebird:12852:4132:connectivity/source/drivers/firebird/Util.cxx:58: firebird_sdbc error:
*Use of database at location E:\JENKINS\WORKSPACE\GERRIT_WINDOWS_WSL\TMP\TEST_DBACCESS_MIGRATION.DLL2JVD3.TMP\TEST_DBACCESS_MIGRATION.DLL2JVD8.TMP\FIREBIRD.FDB is not allowed by server configuration
caused by
'isc_create_database'
unknown:0:MigrationTest::testTime
An uncaught UNO exception
- com.sun.star.sdbc.SQLException: {Message: "firebird_sdbc error:
*Use of database at location E:\JENKINS\WORKSPACE\GERRIT_WINDOWS_WSL\TMP\TEST_DBACCESS_MIGRATION.DLL2JVD3.TMP\TEST_DBACCESS_MIGRATION.DLL2JVD8.TMP\FIREBIRD.FDB is not allowed by server configuration
caused by
'isc_create_database'
at E:/jenkins/workspace/gerrit_windows_wsl/connectivity/source/drivers/firebird/Util.cxx:69", Context: @00000054DD3863A0, SQLState: "", ErrorCode: 1, NextException: void: void}
warn:connectivity.firebird:12852:4132:connectivity/source/drivers/firebird/Util.cxx:58: firebird_sdbc error:
*Use of database at location E:\JENKINS\WORKSPACE\GERRIT_WINDOWS_WSL\TMP\TEST_DBACCESS_MIGRATION.DLL2JVD3.TMP\TEST_DBACCESS_MIGRATION.DLL2JVD8.TMP\FIREBIRD.FDB is not allowed by server configuration
*Exiting before completion due to errors
caused by
'isc_service_start'
warn:cppuhelper:12852:4132:cppuhelper/source/implbase.cxx:82: class com::sun::star::uno::Exception msg: firebird_sdbc error:
*Use of database at location E:\JENKINS\WORKSPACE\GERRIT_WINDOWS_WSL\TMP\TEST_DBACCESS_MIGRATION.DLL2JVD3.TMP\TEST_DBACCESS_MIGRATION.DLL2JVD8.TMP\FIREBIRD.FDB is not allowed by server configuration
*Exiting before completion due to errors
caused by
'isc_service_start'
at E:/jenkins/workspace/gerrit_windows_wsl/connectivity/source/drivers/firebird/Util.cxx:69 at E:/jenkins/workspace/gerrit_windows_wsl/connectivity/source/drivers/firebird/Connection.cxx:922
warn:dbaccess:12852:4132:dbaccess/source/core/dataaccess/ModelImpl.cxx:925: com.sun.star.uno.DeploymentException message: "component context fails to supply service com.sun.star.security.DocumentDigitalSignatures of type com.sun.star.security.XDocumentDigitalSignatures at E:\jenkins\workspace\gerrit_windows_wsl\workdir\UnoApiHeadersTarget\offapi\normal\com/sun/star/security/DocumentDigitalSignatures.hpp:79" context: class cppu::`anonymous namespace'::ComponentContext
MigrationTest::testTime finished in: 128ms
##Failure Location unknown## : Error
Test name: MigrationTest::testBinaryImport
An uncaught UNO exception
- com.sun.star.sdbc.SQLException: {Message: "firebird_sdbc error:
*Use of database at location E:\JENKINS\WORKSPACE\GERRIT_WINDOWS_WSL\TMP\TEST_DBACCESS_MIGRATION.DLL2JVD3.TMP\TEST_DBACCESS_MIGRATION.DLL2JVD4.TMP\FIREBIRD.FDB is not allowed by server configuration
caused by
'isc_create_database'
at E:/jenkins/workspace/gerrit_windows_wsl/connectivity/source/drivers/firebird/Util.cxx:69", Context: @00000054DD385300, SQLState: "", ErrorCode: 1, NextException: void: void}
##Failure Location unknown## : Error
Test name: MigrationTest::testNumbers
An uncaught UNO exception
- com.sun.star.sdbc.SQLException: {Message: "firebird_sdbc error:
*Use of database at location E:\JENKINS\WORKSPACE\GERRIT_WINDOWS_WSL\TMP\TEST_DBACCESS_MIGRATION.DLL2JVD3.TMP\TEST_DBACCESS_MIGRATION.DLL2JVD6.TMP\FIREBIRD.FDB is not allowed by server configuration
caused by
'isc_create_database'
at E:/jenkins/workspace/gerrit_windows_wsl/connectivity/source/drivers/firebird/Util.cxx:69", Context: @00000054DD386320, SQLState: "", ErrorCode: 1, NextException: void: void}
##Failure Location unknown## : Error
Test name: MigrationTest::testTime
An uncaught UNO exception
- com.sun.star.sdbc.SQLException: {Message: "firebird_sdbc error:
*Use of database at location E:\JENKINS\WORKSPACE\GERRIT_WINDOWS_WSL\TMP\TEST_DBACCESS_MIGRATION.DLL2JVD3.TMP\TEST_DBACCESS_MIGRATION.DLL2JVD8.TMP\FIREBIRD.FDB is not allowed by server configuration
caused by
'isc_create_database'
at E:/jenkins/workspace/gerrit_windows_wsl/connectivity/source/drivers/firebird/Util.cxx:69", Context: @00000054DD3863A0, SQLState: "", ErrorCode: 1, NextException: void: void}
Failures !!!
Run: 3 Failure total: 3 Failures: 0 Errors: 3
Change-Id: I5a4c4b072cc1898340eac176d23a689a3cb67128
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208154
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Give the driver a directory of its own, extract each embedded database
into a subdirectory of it, and set DatabaseAccess so firebird keeps any
associated files it makes for a database in the same directory.
A distro firebird reads only firebird.conf from the directory the
FIREBIRD variable names and finds its other resources at their normal
absolute paths. A bundled firebird finds everything relative to it.
Change-Id: If082a30d2426e7942fc9dd48f7124928fc984434
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.collaboraoffice.com/c/core/+/6701
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins CPCI <releng@collaboraoffice.com>
(cherry picked from commit 520d8173cef39a4da85b3ba21bdaaa3150384c25)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/208039
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
When an SQL query has comments then those were deleted
when switching to design view. This is fixed and the comments
are maintained. In the case the query is edited in design
view then the comments are inevitably lost.
Change-Id: Ibcf6e36fce88a526c7340d352aca9859b1b3714e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205441
Tested-by: Jenkins
Reviewed-by: Vissarion Fisikopoulos <vfisikop@libreoffice.org>
Add cases for date, time and timestamp data types in prepared statement
of firebird embedded database. Add unit tests for this particular case
and for testing the DBTypeConversion functions toDate, toTime,
toDateTime that used in the fix.
Change-Id: I91fd2322598b14f84a96f071ed029c9b3e64d51e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204841
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
The macOS headers included do not collide with LibreOffice types, so the
premac/postmac wrappers are unnecessary.
Change-Id: I3671e6af5f84144eab3439eea076192342ad9fa6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201677
Reviewed-by: Dan Williams <dcbw@libreoffice.org>
Tested-by: Jenkins
commit a726c634ac
Date: Mon Jan 12 23:02:34 2026 +0100
Fix "unable to find library -lcrypt" with recent glibc
added a use of CRYPT_LIBS, but that doesn't appear in config_host.mk.in
so effectively that universally removed -lcrypt from the mysqlc link line
Change-Id: I58f49cddeec2b2d3445e569610e4848d310c84d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198886
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
It won't even be attempted, make will complain:
.../solenv/gbuild/ComponentTarget.mk:81: *** No LIBFILENAME set at component target: .../workdir/ComponentTarget/connectivity/source/drivers/mysqlc/mysqlc.component. Stop.
Change-Id: I7be5953fb40bfc2034ed4ddf348e1c5e68a85b19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197256
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@iki.fi>
After checking all modules with
bin/find-unneeded-includes --finderrors --headers --recursive
these subdirectories seemed to need custom assumes for an
error free run of IWYU
Change-Id: I8e0553355809e49e3ec3d06aa4404e6cd7b72aff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196631
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
Replace by operator[], begin() and end(), which don't have overhead
since commit 2484de6728 (Remove non-
const Sequence::begin()/end() in internal code, 2021-10-15)
and commit fb3c04bd19 (Drop non-const
Sequence::operator[] in internal code, 2021-11-05).
Change-Id: I221470b3439bb0dc6e7705b0d99deb3cd2063484
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195176
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
rBHelper was a local variable with the same name of a member variable of
the class ODatabaseMetaDataResultSet. With this patch, we avoid this
name duplication.
The above duplication was causing build problem with the latest VS 2026
compiler:
error C2220: the following warning is treated as an error
warning C4458: declaration of 'rBHelper' hides class member
Change-Id: Id70c690c3b09611aefab720aef1f8c8c1dd46829
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193965
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
After recent commit 851fb75779
recheck these directories in include/ again
to test drive the new --headersfwd mode of bin/find-unneeded-includes
Change-Id: I0ede437c4f9958cd98210ed1760a5b98ea8bd1ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192377
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
In Base if you create a new table with:
- Insert -> Table Design...
when saving this new table with:
- File -> Save As
If the underlying database supports catalogs and/or schemas, it will always be proposed as a table name: Table1
It is necessary to propose a table name that does not yet exist in the pre-selected catalog and/or schema.
Change-Id: I4ca8cb8013f34e1c92211040c7ab0558d94c4243
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190289
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Accessing an address book contact's Note field requires an entitlement since
Mac OS 13. Without that entitlement the following error occurs:
CoreData: error: Unhandled error occurred during faulting: Error Domain=NSCocoaErrorDomain Code=134092 "(null)"
It seems unlikely that the Note field functionality is widely used for
anything the address book functionality is used for, so just ignore the
field entirely.
Signed-off-by: Dan Williams <dan@ioncontrol.co>
Change-Id: I694f3ac40a8dccb49f51818dcdb3da7948f560d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191057
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Tested-by: Jenkins
When constructing a MacabRecords by passing an existing MacabRecords
object, the new object allocates storage for records but does not copy
them, which is left up to the caller. But if the caller does not copy
records, the 'records' array elements are uninitialized garbage, leading
to a crash when the new MacabRecords object is disposed and those
garbage pointers are freed.
Signed-off-by: Dan Williams <dan@ioncontrol.co>
Change-Id: I6d381e523dd3f252f088bb879e886854ffe0163a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191058
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
It seems it was never built in our CI. That it needs an environment
variable to run, doesn't mean it can't build - at least to prevent
bitrot.
This adds conditions to execute setup/teardown, and specific tests.
Modernizes the string literals, and fixes the types in asserts to
enable building on Windows.
Change-Id: Ie46333b5b5e516328d7236de1ff1f3b17181c789
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189968
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
and
cid#1659699 Overflowed return value
cid#1659759 Overflowed return value
cid#1659922 Overflowed return value
cid#1660190 Overflowed return value
cid#1660286 Overflowed return value
cid#1660457 Overflowed return value
Change-Id: Ie9fffe4994b10ed3d4feb14eaf7950e3f01714ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189927
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
and
cid#1659793 Variable copied when it could be moved
cid#1659830 Variable copied when it could be moved
cid#1659841 Variable copied when it could be moved
cid#1659856 Variable copied when it could be moved
cid#1659863 Variable copied when it could be moved
cid#1659864 Variable copied when it could be moved
cid#1659865 Variable copied when it could be moved
cid#1659903 Variable copied when it could be moved
cid#1659909 Variable copied when it could be moved
cid#1659917 Variable copied when it could be moved
cid#1659924 Variable copied when it could be moved
cid#1659929 Variable copied when it could be moved
cid#1659930 Variable copied when it could be moved
cid#1659932 Variable copied when it could be moved
cid#1660056 Variable copied when it could be moved
cid#1660112 Variable copied when it could be moved
cid#1660169 Variable copied when it could be moved
Change-Id: I623009beb8e4a61b2253a17f356576bd3ac3f06c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189402
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Xisco Fauli