all three variables were unused ever since the code's introduction in
229a0de9c8 "CWS-TOOLING: integrate CWS
appleremote01"
Change-Id: Ib755b86c81a6823c440f9f6a392b8f4b7de973ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116984
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
(That warning is probably new in recent Clang 10 trunk, hence the issue only got
reported now.)
To me, this looks like a bug introduced with
> commit aaf218d025
> Author: ericb2 <ericb2@apache.org>
> AuthorDate: Sun Oct 30 22:57:34 2011 +0000
> Commit: Thorsten Behrens <tbehrens@suse.com>
> CommitDate: Mon Dec 5 13:00:11 2011 +0100
>
> Propragating the modif in the implementation (HIDRemoteControlDevice.m)
>
> * found under MIT-style at svn rev 1195272 (http://svn.apache.org/viewvc?view=revision&revision=1195272)
>
> diff --git a/apple_remote/HIDRemoteControlDevice.m b/apple_remote/HIDRemoteControlDevice.m
> index 94215900717b..2cd7506e60d3 100644
> --- a/apple_remote/HIDRemoteControlDevice.m
> +++ b/apple_remote/HIDRemoteControlDevice.m
> @@ -281,7 +281,17 @@ - (void) handleEventWithCookieString: (NSString*) cookieString sumOfValues: (SIn
>
> NSNumber* buttonId = [[self cookieToButtonMapping] objectForKey: cookieString];
> if (buttonId != nil) {
> - [self sendRemoteButtonEvent: [buttonId intValue] pressedDown: (sumOfValues>0)];
> + switch ( (int)buttonId )
> + {
> + case kMetallicRemote2009ButtonPlay:
> + case kMetallicRemote2009ButtonMiddlePlay:
> + buttonId = [NSNumber numberWithInt:kRemoteButtonPlay];
> + break;
> + default:
> + break;
> + }
> + [self sendRemoteButtonEvent: [buttonId intValue] pressedDown: (sumOfValues>0)];
> +
> } else {
> // let's see if a number of events are stored in the cookie string. this does
> // happen when the main thread is too busy to handle all incoming events in time.
(which indeed appears to be a faithful copy of all the non-whitespace changes
made at the cited <http://svn.apache.org/viewvc?view=revision&revision=1195272>
"Propragating the modif in the implementation (HIDRemoteControlDevice.m)").
I assume that my fix here is what was originally intended, but I don't know how
to actually test this code (if it is still testable at all).
Change-Id: If8faa8e068c7d7dffb4677efdaa5896cf6fd4c0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89209
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Some .m/.mm files that still contained tabs instead of spaces have been
cleaned up with Emacs' untabify (and
apple_remote/source/HIDRemoteControlDevice.m needed further manual adaptions):
apple_remote/source/GlobalKeyboardDevice.m
apple_remote/source/HIDRemoteControlDevice.m
apple_remote/source/KeyspanFrontRowControl.m
apple_remote/source/RemoteControl.m
vcl/osx/a11yrolehelper.mm
* Some of the changes predate 0626e66d76 "Avoid
loplugin:indentation after preproc conditional inclusion lines" and would
likely have no longer been flagged since.
Change-Id: Ibf5faffa743c7f79b36109d9879eb79d63c8c40f
Reviewed-on: https://gerrit.libreoffice.org/68090
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
module appropriately
to make the source of some log messages more clear
(cherry picked from commit fe4ae4735c5a5e2b2210e684e97228cd91174e4c)
Conflicts:
apple_remote/AppleRemote.m
apple_remote/source/HIDRemoteControlDevice.m
apple_remote/source/RemoteControl.m
apple_remote/source/RemoteControlContainer.m
Change-Id: Ie57114f4d2d67f258808d03e01dff8bc05ba9f2c
Stephan Bergmann