ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
474,272 Commits 3 Branches 3 Tags
29578ae1394de2fffae2e34326d03d81b4c4f475
Commit Graph
1534 Commits
Author SHA1 Message Date
Noel Grandin ddff74993f no need to have duplicate m_bIsRoot fields 
Change-Id: I4f8777462d0bb8cb9f1a6065a548a794d842d815
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131678
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-03-17 08:17:50 +01:00
Noel Grandin 9a9bb1f212 no need to have duplicate m_nStorageType fields 
Change-Id: I65bfce88e2bb1d32ec6c292e7e5f020904405bed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131677
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-03-17 08:17:36 +01:00
Noel Grandin 17d2cf3076 flatten OStorage a little 
Change-Id: I4a380d036c3e94f2df41d2c583d51f574d2c161d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131675
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-03-17 07:34:53 +01:00
Stephan Bergmann 83dd8deed7 loplugin:trivialdestructor (-stdlib=libc++) 
That these are only flagged when building against libc++ and not against
libstdc++ is a consequence of the plugin's dependence on implementation details
of the relevant classes, but so be it.

Change-Id: I6b96f81939edab2b8e618aa53c9fe23492edfbbd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131562
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-03-14 22:30:44 +01:00
Noel Grandin 7002caa97e new loplugin:trivialdestructor 
look for potentially trivial destructors that can then be elided

Change-Id: I435c251bd4291b5864c20d68f88676faac7c43fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131318
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-03-11 09:06:06 +01:00
Caolán McNamara 3c06623733 cid#1500664 Dereference before null check 
this looks sensible at:

commit e7c7d6f0e9
Author: Kurt Zenker <kz@openoffice.org>
Date:   Thu Sep 11 09:16:30 2003 +0000

    INTEGRATION: CWS mav05 (1.1.2); FILE ADDED

as:

if ( (*pElementIter)->m_bIsStorage )
{
    OSL_ENSURE( (*pElementIter)->m_pStorage && (*pElementIter)->m_pStorage->m_xPackageFolder.is(),
                "An inserted storage is incomplete!\n" );
    if ( !(*pElementIter)->m_pStorage || !(*pElementIter)->m_pStorage->m_xPackageFolder.is() )
        throw uno::RuntimeException(); // TODO

    xNewElement = uno::Reference< lang::XUnoTunnel >( (*pElementIter)->m_pStorage->m_xPackageFolder,
                                                        uno::UNO_QUERY );
    (*pElementIter)->m_pStorage->Commit();
}

and then didn't after:

commit 8c64f087f8
Author: Rüdiger Timm <rt@openoffice.org>
Date:   Thu Oct 30 08:48:27 2003 +0000

    INTEGRATION: CWS mav08 (1.2.10); FILE MERGED
    2003/10/15 08:07:55 mav 1.2.10.2: #i21121# substorages implement transacted mode
    2003/10/13 14:26:33 mav 1.2.10.1: #i21121# Transacted mode for storages

Change-Id: Ib05359b282d078cd40b41ed8f2fe9242235c9c83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130417
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-02-23 12:16:00 +01:00
Gabor Kelemen 7b5193e2ae Recheck modules [o-r]* with IWYU 
See tdf#42949 for motivation

Change-Id: I6b4b05a5e59b256653c4caf5297fffd601b45083
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128845
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
 2022-01-30 16:10:57 +01:00
Armin Le Grand (Allotropia) 4a0ccb5fec WASM make test file loading work 
Change-Id: Ic34104534c3e0e73791cf867bfb2e1246dc79cf8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128653
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
 2022-01-20 14:27:16 +01:00
Noel Grandin 5c00fadcc9 optimise and simplify ZipOutputEntryInThread 
by just using the tempfile service as intended, we can stay
on the "happy path" which means that, on Windows, if there is
sufficient system RAM, the temporary file never even hits
the disk.

Change-Id: I3b27cf09bd40a4cfee01c23273af05860708a16f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128258
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-11 07:19:25 +01:00
Noel Grandin a3fa2c3bad Simplify some TempFile service code 
Change-Id: Id39be33dcc5aa9378e29c850cb71d3662093ab25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128189
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-01-09 18:02:08 +01:00
Mike Kaganski 9c95415de8 Let comphelper::Base64::decode* take std::u16string_view 
Change-Id: I5b04f7adf11c61f52b7bfb0f52c8c075f838f0f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127480
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-12-26 23:09:20 +01:00
Noel Grandin 494b3e69fd loplugin:flatten in package..reportdesign 
Change-Id: I2da242fcb59709ebdd0819ec04d051d794da71e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127277
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-12-22 07:43:35 +01:00
Noel Grandin 1a122a5bce use more OInterfaceContainerHelper3 in package 
Change-Id: I4a9f0f4ae95ec236ef32462c1aaa8d774be15378
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125938
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-11-27 13:56:43 +01:00
Stephan Bergmann 1298a6ae9a Fix typo 
...in 2132da5066 "loplugin:stringliteraldefine in
package", which caused CppunitTest_xmlsecurity_signing to fail with

> [_RUN_____] testODFEncryptedGPG::TestBody
> librdf error ¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾ - XML parser error - Document is empty
> warn:sw:113776:113776:sw/source/filter/xml/swxml.cxx:214: SAX parse exception caught while importing: com.sun.star.xml.sax.SAXParseException message: [ line 1]: Document is empty
>  ~/lo/core/sax/source/fastparser/fastparser.cxx:609
>     wrapped: void message: /home/sbergman/lo/core/tools/source/debug/debug.cxx:104 PublicId:  SystemId:  LineNumber: 1 ColumnNumber: 1
> warn:sw:113776:113776:sw/source/filter/xml/swxml.cxx:214: SAX parse exception caught while importing: com.sun.star.xml.sax.SAXParseException message: [ line 1]: Document is empty
>  /home/sbergman/lo/core/sax/source/fastparser/fastparser.cxx:609
>     wrapped: void message: /home/sbergman/lo/core/tools/source/debug/debug.cxx:104 PublicId:  SystemId:  LineNumber: 1 ColumnNumber: 1
> warn:sw:113776:113776:sw/source/filter/xml/swxml.cxx:214: SAX parse exception caught while importing: com.sun.star.xml.sax.SAXParseException message: [ line 1]: Document is empty
>  /home/sbergman/lo/core/sax/source/fastparser/fastparser.cxx:609
>     wrapped: void message: /home/sbergman/lo/core/tools/source/debug/debug.cxx:104 PublicId:  SystemId:  LineNumber: 1 ColumnNumber: 1
> warn:sfx.view:113776:113776:sfx2/source/view/frmload.cxx:489: DBG_UNHANDLED_EXCEPTION in impl_handleCaughtError_nothrow exception: com.sun.star.task.ErrorCodeIOException message: SfxBaseModel::handleLoadError: 0x0x11b /home/sbergman/lo/core/sfx2/source/doc/sfxbasemodel.cxx:2787 errcode: 283
> warn:fwk.loadenv:113776:113776:framework/source/loadenv/loadenv.cxx:202: caught LoadEnvException 6 "interaction request", com.sun.star.task.ErrorCodeRequest "/home/sbergman/lo/core/sfx2/source/doc/objmisc.cxx:1698" while loading <file:///home/sbergman/lo/core//xmlsecurity/qa/unit/signing/data/encryptedGPG.odt>
> /home/sbergman/lo/core/unotest/source/cpp/macros_test.cxx:67:testODFEncryptedGPG::TestBody
> assertion failed
> - Expression: xComponent.is()
> - loading failed: file:///home/sbergman/lo/core//xmlsecurity/qa/unit/signing/data/encryptedGPG.odt

for me

Change-Id: I0326d5ab33a9cfe9c23aab4120b49f37548aea39
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125936
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2021-11-27 12:59:27 +01:00
Noel Grandin 2132da5066 loplugin:stringliteraldefine in package 
Change-Id: I91ce2f65513ea9ae74841c6b0286c01d4e6dd82f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125812
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-11-26 09:46:13 +01:00
Noel Grandin a069fac4a0 loplugin:stringliteraldefine in comphelper 
Change-Id: I60ccd6049db65fef2397798ab916b0d1e24c0fdc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125531
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-11-24 13:23:59 +01:00
Mike Kaganski d0a8d4a973 Prepare for removal of non-const operator[] from Sequence in package 
Change-Id: Ib5d7fa143c4c5e3b4862ed4b91acf1e2dfc4d8bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124378
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-10-30 20:17:13 +02:00
Mike Kaganski 2484de6728 Remove non-const Sequence::begin()/end() in internal code 
... to avoid hidden cost of multiple COW checks, because they
call getArray() internally.
This obsoletes [loplugin:sequenceloop].

Also rename toNonConstRange to asNonConstRange, to reflect that
the result is a view of the sequence, not an independent object.

TODO: also drop non-const operator[], but introduce operator[]
in SequenceRange.

Change-Id: Idd5fd7a3400fe65274d2a6343025e2ef8911635d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123518
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-10-15 10:36:36 +02:00
Noel Grandin 0eb51b92e0 loplugin:moveparam in package 
Change-Id: I681a6b0b30aeff9a51e36050629d8a617797a21f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123419
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-10-11 18:36:42 +02:00
Julien Nabet 28480639b4 drop 'using namespace std' in package 
Change-Id: Ifa9f5c310a8be988c1058644540ac52f160bc156
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123018
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2021-10-03 22:16:55 +02:00
Noel Grandin 581efdec36 loplugin:constmethod 
Change-Id: I3ed657c5c5e6840e38e3c8505505b4b372125df0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122910
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-10-01 20:58:11 +02:00
Noel Grandin 3b8e53f66f loplugin:constparams improve handling of pointer params 
Change-Id: I4c0002e72703eded435bfe4985f5b0121bf8524b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122843
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-09-30 11:24:33 +02:00
Mike Kaganski 96bd77de5a Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 5 
- Revise uses of getSomething to use getFromUnoTunnel

Where that is impossible, use getSomething_cast to unify casting,
and minimize number of places doing low-level transformations.

The change keeps the existing tunnel references that last for the
duration of the pointers' life, because sometimes destroying such
reference may destroy the pointed object, and result in use after
free.

Change-Id: I291c33223582c34cd2c763aa8aacf0ae899ca4c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122101
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-09-15 06:08:27 +02:00
Mike Kaganski 3f65724ec5 Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 4 
- Change implementations of getSomething to use getSomethingImpl

Or where that's impossible, use getSomething_cast to unify this and
reduce number of places where we reinterpret_cast.

All static methods getting tunnel ids were renamed to getUnoTunnelId,
to comply with the convention used in <comphelper/servicehelper.hxx>.

TODO (in separate commits):
- Revise uses of getSomething to use getFromUnoTunnel

Change-Id: Ifde9e214b52e5df678de71fcc32d2199c82e85cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122100
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-09-15 06:08:14 +02:00
Mike Kaganski 6444b026b4 Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 3 [API CHANGE] 
- Replace all uses of OImplementationId in core with UnoIdInit
- Deprecate OImplementationId in <cppuhelper/typeprovider.hxx>

OImplementationId uses broken double checked locking; additionally,
it uses it at the first call to getImplementationId, not when the
object is constructed. This implementation can't be changed, cince
it's part of published API; it can't rely on C++11, which would be
required for use of thread-safe statics and move the initialization
to ctor.

The class has obsolete _bUseEthernetAddress member, that is unused
and ignored since 4e9fa7e339. No need
to implement it when replacing its uses to UnoIdInit.

The deprecation is the API CHANGE. No published API is introduced to
replace it; 3rd-party code should seek alternative solutions, or just
keep using the deprecated functionality.

TODO (in separate commits):
- Change implementations of getSomething to use getSomethingImpl
- Revise uses of getSomething to use getFromUnoTunnel

Change-Id: I8b6e684e5389bc0d5bb3b7f21f72a4c8f684107d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122077
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-09-15 06:08:01 +02:00
Mike Kaganski 05bc93db2d Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 1 
The header got some changes:
1. Move UnoTunnelIdInit and isUnoTunnelId into 'comphelper' namespace
2. Rename UnoTunnelIdInit to UnoIdInit, as a precondition to replace
   of uses of OImplementationId with it, including in XTypeProvider
3. Introduce convenience functions 'getSomething_cast' to cast between
   sal_Int64 and object pointers uniformly.
4. Rename getUnoTunnelImplementation to getFromUnoTunnel, both to make
   it a bit shorter, and to reflect its function better. Templatize it
   to take also css::uno::Any for convenience.
5. Introduce getSomethingImpl, inspired by sw::UnoTunnelImpl; allow it
   handle cases both with and without fallback to parent.
6. Adjust UNO3_GETIMPLEMENTATION_* macros

TODO (in separate commits):
- Drop sw::UnoTunnelImpl and sw::UnoTunnelGetImplementation
- Replace all uses of OImplementationId in core with UnoIdInit
- Deprecate OImplementationId in <cppuhelper/typeprovider.hxx>
- Change implementations of getSomething to use getSomethingImpl
- Revise uses of getSomething to use getFromUnoTunnel

Change-Id: If4a3cb024130f1f552f988f0479589da1cd066e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122022
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-09-15 06:07:36 +02:00
Noel Grandin ad4d09db4a clang-tidy:readability-redundant-member-init 
Change-Id: Ic5abfe2d047750d8dfd3ae8cc733fa15d34ea505
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121432
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-09-01 11:20:17 +02:00
Noel Grandin 8a54339fc8 loplugin:referencecasting look through more clang Types 
Note that because of where the fix resides, loplugin:redundantcast
also notices a few more things.

Change-Id: I0b66047fadfff2c5ceafcbd3eab085de00d861a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120865
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-08-23 15:25:26 +02:00
Noel Grandin 7bdb3a77d0 flatten OZipFileAccess a little 
Change-Id: Ib03dadcd69a65493ddd9c0437fc654beef039ad8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120341
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-08-12 09:32:10 +02:00
Noel Grandin b4376538d9 flatten ZipPackage a little 
Change-Id: I0295bd8d72686996afb9d361db12b6014594b402
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120340
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-08-12 09:31:52 +02:00
Noel Grandin 86abf3a682 create comphelper::OMultiTypeInterfaceContainerHelper2 and use it 
based on OInterfaceContainerHelper2 which is considerably
faster than the original OInterfaceContainerHelper

Change-Id: I9c8b6d0e5382018824bf7188a26343703abf2d51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120161
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-08-07 21:34:33 +02:00
Noel Grandin 05ab38359a Consolidate on C++17 std::scoped_lock instead of std::lock_guard 
as in commit 9376f65a26

Change-Id: I3ad9afd4d113582a214a4a4bc7eea55e38cd6ff9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119927
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-08-03 12:20:53 +02:00
Mike Kaganski 93e90309b3 Use ZLIB_CONST to avoid const_cast 
It is available since 2011 [1]. CentOS 7, which is the baseline,
included zlib 1.2.7, which was released in 2012, and included [1].

[1] https://github.com/madler/zlib/commit/5ab9f47745fe9353291b217f705086b6070575d5,

Change-Id: Ie6cf2e934579620787426d95380f8ff6d6423b7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119627
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-07-31 23:27:25 +02:00
Noel Grandin 95f5c4fb55 getArray->getConstArray in package 
so we can avoid the const of making the Sequence singular

Change-Id: I939d573c0f1e7a5d3b09a8589c0fda1e9ea38208
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119739
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-07-31 18:21:42 +02:00
Noel Grandin a943936eef rtl::Static -> static local 
in a handful cases, like a map or a vector, we don't need init on demand
at all, the default constructor can be laid out at compile time

Change-Id: Ifa3188af7a65cd475ce0f603d15a8c26bcda7e6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119710
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-07-31 08:55:29 +02:00
Noel Grandin 4bf1fbc957 tsan:data race in XBufferedThreadedStream 
cannot read from maInUseBuffer without holding the lock

Change-Id: I4244e1132595a18c1a7ab33803e10b6c29684bf9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119707
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-07-30 17:54:32 +02:00
Noel Grandin 0c3da17e41 pass ZipEnumeration around by value 
Change-Id: I8418bd3eb6a8013f55f4283c7d96755d95a60c1a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119305
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-07-21 12:20:23 +02:00
Noel Grandin 0f580560e9 osl::Mutex->std::mutex in StarOfficeSHA1DigestContext 
Change-Id: I924796823230151a3edde2ead875cfc5bc5072d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119282
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-07-20 21:03:38 +02:00
Noel Grandin 0c14226903 osl::Mutex->std::mutex in CorrectSHA1DigestContext 
Change-Id: Ia81e8edd84080a2cb750e2dce7b2e8879b66498e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119281
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-07-20 21:03:16 +02:00
Noel Grandin 9bae1f1ad6 no need to use a pImpl in CorrectSHA1DigestContext 
Change-Id: If7404f63833373c5ac2954c4aac129c52582989c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119280
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-07-20 21:02:52 +02:00
Noel Grandin 966ae2345c osl::Mutex->std::mutex in BlowfishCFB8CipherContext 
Change-Id: Id70ec156ab9e06a48a5a2571fc0186bd63b280a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119279
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-07-20 19:36:59 +02:00
Noel Grandin d9f92805f1 osl::Mutex->std::mutex in SwitchablePersistenceStream 
Change-Id: I4f34f9df3f760f112244845688b34663e5febb79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119278
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-07-20 19:24:14 +02:00
Noel Grandin a4a023f7f4 osl::Mutex->std::mutex in ByteGrabber 
Change-Id: I96ea49da6708041ac19e147f192c7e996d44b8ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119276
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-07-20 19:23:49 +02:00
Noel Grandin afc9c4454f osl::Mutex->std::mutex in OChildDispListener_Impl 
Change-Id: I0aa9e24d3ebcb5f89f2bf5b5759fa44985495b6f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119277
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-07-20 18:55:28 +02:00
Noel Grandin 711269c61a OStorage can be final 
Change-Id: I8c55993040245c51cd499d00757065e9914a18fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119204
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-07-19 19:24:50 +02:00
Noel Grandin a1cb4c7665 reduce allocation in ZipContentInfo map 
This is a small struct, no sense in allocating it separately

Change-Id: I709daebbde648a79f175f74c207bdf4871ae6ff1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117604
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-06-22 15:13:05 +02:00
Noel Grandin 3ffb7efa95 remove some unnecessary OUString::intern 
Change-Id: Ia0f41dfc8a00c115ad544b8236d751e6b2dae5ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117577
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-06-21 15:02:53 +02:00
Julien Nabet 7af40a4455 Simplify Sequences initializations (i*->p*) 
Change-Id: I6bf0eaa2233de2487d90a2f9ae7de263b4ddf1bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116865
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2021-06-09 10:49:26 +02:00
Noel Grandin 46a662ea56 improve exception message 
Change-Id: I8ce4e6afff2dd7b029c7e557739a3c3e0b361c98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116578
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-06-02 13:32:08 +02:00
Noel Grandin 601e9d4bad inline some typedefs 
Change-Id: I1608e03ff9f6fbc55987010e88897e034b690b3a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115552
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-05-13 17:03:26 +02:00