ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
474,272 Commits 3 Branches 3 Tags
29578ae1394de2fffae2e34326d03d81b4c4f475
Commit Graph
347 Commits
Author SHA1 Message Date
Noel Grandin 1927b51993 loplugin:stringviewparam convert methods using indexOf 
.. and lastIndexOf, which convert to find and rfind

Change-Id: I6c4156cf904774c0d867f85a4c2785dba7593f62
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132445
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-04-02 13:31:19 +02:00
Noel Grandin a997f62242 cleanup AcceleratorCache 
(1) reduce visibility of stuff nothing is using outside the class
(2) remove noise comments

Change-Id: Icea829ef92d6121b957ad47a992ef7ac04656af9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127324
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-12-22 17:17:48 +01:00
Noel Grandin 7fe0a4cddf osl::Mutex->std::mutex in StorageHolder 
Change-Id: Ie0ababcea79b445ac73ffd4e69d260a7641af663
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127106
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-12-20 08:33:50 +01:00
Noel Grandin c36a21e4a3 osl::Mutex->std::mutex in WindowCommandDispatch 
Change-Id: Ia89f4a7b1f444a031e8f58f644ba9129f8c48942
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125622
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-11-22 07:55:42 +01:00
Noel Grandin 449977192b osl::Mutex->std::mutex in ActionLockGuard 
Change-Id: I8081d017f8a03be94b60011fcd4eb34eba786aa9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125623
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-11-21 19:43:10 +01:00
Noel Grandin 66fec11a62 loplugin:finalclasses in framework 
Change-Id: I64e7b65337d283567bb6030a626303de477346cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117891
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-06-26 13:14:18 +02:00
Vincent LE GARREC 90c978f839 tdf#124176 Use pragma once in f* 
filter, forms, fpicker, framework

Change-Id: I55a25ad2dc3749e63465e638e8eeea3c322eabbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112047
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
 2021-03-23 13:07:09 +01:00
Noel 1250aecd71 loplugin:stringviewparam extend to new.. 
O[U]StringBuffer methods

Change-Id: I0ffbc33d54ae7c98b5652434f3370ee4f819f6f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110090
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-01-29 09:25:12 +01:00
Caolán McNamara ac396f2f6b fix coverity parse errors 
Change-Id: I3a1179947704452e3ffec02be59d0f7bf0b75ab0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109017
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-01-09 13:01:49 +01:00
Stephan Bergmann 042033f1e6 loplugin:stringviewparam: operator + 
Change-Id: I044dd21b63d7eb03224675584fa143009c6b6008
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108418
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2020-12-29 16:42:33 +01:00
Stephan Bergmann 9013dc1650 Simplify loplugin:stringviewparam comparison operator handling 
In practice, it works fine to look at all of them, regardless of actual argument
types.

Change-Id: Ifc49cbcd6003c8837c1b3f81d432c59fb0657bf1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108366
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2020-12-27 11:26:32 +01:00
Stephan Bergmann a3d0091d18 New loplugin:stringliteralvar 
See the comment at the top of compilerplugins/clang/stringliteralvar.cxx for
details.

(Turned some affected variables in included files into inline variables, to
avoid GCC warnings about unused variables.)

Change-Id: Ie77219e6adfdaaceaa8b4e590b08971f2f04c83a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108239
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2020-12-26 14:51:15 +01:00
Noel 8332d6d820 loplugin:stringviewparam include comparisons with string literals 
Change-Id: I8ba1214500dddaf413c506a4b82f43d63cda804b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106559
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-11-30 12:32:14 +01:00
Andrea Gelmini c9a0cbc856 Fix typos 
Change-Id: I58c510121a9f535b2a31854f10b5f6535554d379
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100988
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2020-08-19 15:41:21 +02:00
Noel Grandin da7489eb6a compact namespace decl 
used
   git grep -lw namespace
    | xargs perl -i -p0e 's/(\w+)\s*.\{.\s*namespace\s*(\w+)/\1::\2/smg;'
 to do the initial replace, then compiled and fixed.

Change-Id: If69904d75940c851aeffab0e78c4ba02cc968d44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98526
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-07-20 10:12:57 +02:00
Andrea Gelmini 8611787aa3 Removed duplicated include 
Change-Id: I8caa3f1be66ca8cf236e9ada8487ea81f45b1377
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98470
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2020-07-12 18:21:32 +02:00
Noel Grandin 6653107b83 clean up macro usage 
Change-Id: I06669718f692cc5e9e209b4e490365f4f016afdb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98389
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-07-09 08:27:53 +02:00
Noel Grandin 71227e2306 framework: create instances with uno constructors 
See tdf#74608 for motivation

Change-Id: I8679b50395d11cb2d807d52526d803df9b0606b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98294
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-07-07 22:13:02 +02:00
Noel Grandin eecf74d417 compact namespace in filter..framework 
Change-Id: Id3c2d9b1fdf9d617adea0fa1ab2fa9a2de12ef50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93727
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-05-08 21:13:05 +02:00
Andrea Gelmini 9c13afe2ee Fix typo 
Change-Id: I935579ee9df56cda1a87816603b23a0562bb1b97
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88256
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2020-02-08 09:30:41 +01:00
Andrea Gelmini a3de0dc158 Fix typo 
Change-Id: I372f5b8fe3d2b1db8e9b672e67709f68b22735b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88253
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2020-02-07 23:27:00 +01:00
Gabor Kelemen e4bf92ae34 tdf#42949 Fix IWYU warnings in framework/*/*hxx 
Also drop unused framework/inc/fwkdllapi.h

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I9e79266f273b778f4a8bd3330b1b0353a2e01a61
Reviewed-on: https://gerrit.libreoffice.org/81927
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2019-11-11 09:48:23 +01:00
Stephan Bergmann 3b16dfd80f Combine LoadEnv's initializeLoading and startLoading 
...as they are only ever called directly one after the other.  Rename the
original initializeLoading to startLoading, and rename the original startLoading
to private start (called at the end of the original initializeLoading).

Change-Id: I5271387450324cc26743195329c4f401cf3aa0f9
Reviewed-on: https://gerrit.libreoffice.org/82308
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-11-08 17:26:46 +01:00
Caolán McNamara 2cd6ff8a54 remove unnecessary includes 
Change-Id: Ia4a622b34ff3f71963cff7a1aa8658a4df12f04f
Reviewed-on: https://gerrit.libreoffice.org/81676
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-10-29 17:27:23 +01:00
Noel Grandin 4e67474a6e loplugin:constmethod in framework..lotuswordpro 
Change-Id: I14a3855a75cf081d86c2a404966db38c617c0256
Reviewed-on: https://gerrit.libreoffice.org/79541
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-09-26 03:04:45 +02:00
Andrea Gelmini 157420e496 Typos 
Mainly fixing '..' and '....'

Change-Id: Ied226ed148c571d278ae65b3f468bd329f557fa9
Reviewed-on: https://gerrit.libreoffice.org/78669
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-09-11 23:43:34 +02:00
Andrea Gelmini ee8f0a1066 Fix '..' 
To complete this:
https://gerrit.libreoffice.org/#/c/78312/

This is a massive replace for
".." instead of "..." between words.

It passed "make check" on Linux.

Change-Id: I144d8061fca9f545c762941551e59dffdd3650e8
Reviewed-on: https://gerrit.libreoffice.org/78357
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
 2019-09-01 12:29:39 +02:00
Andrea Gelmini cdd5869152 Fix typos 
Change-Id: Ibd802e81649373fd9ad6d0309276b8e6ae43dd24
Reviewed-on: https://gerrit.libreoffice.org/77261
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2019-08-12 10:35:29 +02:00
Andrea Gelmini 9aa90b50c8 Fix typos 
Change-Id: I94d0e85c731801b8b0ec844ae2a8f268b2f1022e
Reviewed-on: https://gerrit.libreoffice.org/77256
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-08-12 10:03:23 +02:00
Andrea Gelmini ccecd6644c Fix typo 
Change-Id: Id0d89edfad0ccaae22610c5c999afc6b8686441d
Reviewed-on: https://gerrit.libreoffice.org/74392
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-06-20 09:09:56 +02:00
Andrea Gelmini 8ae297fde9 Fix typo 
Change-Id: I8169fab36b9664f7a820c9f6781e0c61723aeecc
Reviewed-on: https://gerrit.libreoffice.org/74391
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2019-06-20 07:26:20 +02:00
Andrea Gelmini 5d14d4ae2c Fix typo 
Change-Id: I24c9df4caed8fa87a31efb93ab1cb0e88225605e
Reviewed-on: https://gerrit.libreoffice.org/74324
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
 2019-06-19 08:05:23 +02:00
Andrea Gelmini 84fb7b3e4b Fix typo 
Change-Id: Id041587ea926d0fcc289cc9b4c8e57c251aeeecb
Reviewed-on: https://gerrit.libreoffice.org/74323
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
 2019-06-19 08:04:36 +02:00
Stephan Bergmann 3c815c9785 No need for AcceleratorCache::takeOver... 
...as it does the same as the copy assignment op.  And both of those are
apparently already only called with SolarMutex locked, so no need to lock it
again.  So the copy assignment op (as well as the other special memeber
functions) can be left implicitly-declared.  (And some uses of the original
takeOver can be optimized to use move assignment.)

Change-Id: I279a5e3ee85ff2342d6ef5f672108a0712fe116d
Reviewed-on: https://gerrit.libreoffice.org/72831
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-05-23 16:49:15 +02:00
Caolán McNamara fbc038cc4f an uno -> a uno 
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d
Reviewed-on: https://gerrit.libreoffice.org/72105
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-05-10 14:50:59 +02:00
Noel Grandin 3fce6ae224 fix usage of successful/successfully in comments 
Change-Id: If280e1e944c877462cb84b579e19d4fd2ad1900b
Reviewed-on: https://gerrit.libreoffice.org/70813
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-04-16 12:46:55 +02:00
Noel Grandin d55fb1552f loplugin:unusedfields in framework 
Change-Id: I7c633bf3e217a71c51bd3781fe716cb06fe92b0c
Reviewed-on: https://gerrit.libreoffice.org/68227
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-02-24 07:39:23 +01:00
Noel Grandin ef5b895afe loplugin:staticvar in editeng..framework 
Change-Id: I8e555a98f74f61e6e40122564b7ad19ca07a8a91
Reviewed-on: https://gerrit.libreoffice.org/61866
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-10-17 12:07:46 +02:00
Gabor Kelemen cc7280efdb tdf#42949 Fix IWYU warnings in include/cppuhelper/* 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ib420e9216b8313f5ed7634ec375e39ceb741fd45
Reviewed-on: https://gerrit.libreoffice.org/59297
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2018-09-10 09:58:12 +02:00
Noel Grandin 5876b81eaf loplugin:useuniqueptr in AcceleratorConfiguration 
Change-Id: I255005e80ee57638846e353a88477dd54bbbb284
Reviewed-on: https://gerrit.libreoffice.org/59943
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-09-04 09:35:37 +02:00
Abhyudaya Sharma bc5cdc0f12 tdf#108523 Remove @author annotations 
Change-Id: I85e364da59ce70ddd97fdae9bc03a4ea76b007fc
Reviewed-on: https://gerrit.libreoffice.org/55263
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-06-18 11:29:46 +02:00
Jochen Nitschke 8ddca0648a tdf#42949 remove unused compheler includes .. 
and fix the fallout

Change-Id: I15bc5d626f4d157cbc69a87392078b41e621d14e
Reviewed-on: https://gerrit.libreoffice.org/54882
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2018-06-05 10:56:36 +02:00
Jochen Nitschke 9401c7c28a remove unused processfactory.hxx includes 
and fix fallout

Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee
Reviewed-on: https://gerrit.libreoffice.org/52206
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2018-04-01 12:11:26 +02:00
Caolán McNamara 754f6e2fe0 tdf#115683 there are other cases of dialogs before document load 
Change-Id: I97ddbb528927fecb66072b42baa90272de2af39a
Reviewed-on: https://gerrit.libreoffice.org/51704
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-21 15:48:27 +01:00
Noel Grandin b8fe96f1da loplugin:constantparam in desktop..i18npool 
Change-Id: Ie2e1004c1ccc03777a8da9cb1144e89eb28ff313
Reviewed-on: https://gerrit.libreoffice.org/50928
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-08 10:44:29 +01:00
Manuj Vashist 68d9583db4 tdf#108523 Removed @author annotations. 
Change-Id: I6a60128c413beab6cabb857c073607e15ddbc98f
Reviewed-on: https://gerrit.libreoffice.org/49215
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-02-05 11:19:23 +01:00
Andrea Gelmini a452643b43 Fix typos 
Change-Id: I2b4988e1d81fe60f7699362480cd739d2620c053
Reviewed-on: https://gerrit.libreoffice.org/47856
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-01-14 16:31:26 +01:00
Andrea Gelmini dbe0201d3a Fix typos 
Change-Id: I766862d255ac285329ae423629c7445837ddd55f
Reviewed-on: https://gerrit.libreoffice.org/47280
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2018-01-05 11:03:10 +01:00
Andrea Gelmini a2ef65b09d Fix typos 
Change-Id: I0e56430afa65b6b5826d56212ac501c0244fce9b
Reviewed-on: https://gerrit.libreoffice.org/47145
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-12-29 09:56:34 +01:00
Stephan Bergmann a987aa3be7 Make loplugin:salcall look into macros too 
"Indirect" calls to isSallCallFunction (for canonic and overridden
FunctionDecls) already needed to handle many cases of FunctionDecls spanning
macros, so it isn't that much more work to make that also work for cases called
directly from VisitFunctionDecl.

Change-Id: I529f148c8872b86aa1ef082c6cb73db8ab1866e7
Reviewed-on: https://gerrit.libreoffice.org/46367
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-12-13 12:44:31 +01:00