Takeshi Abe
f3c7e69536
scripting: tdf#88206 replace cppu::WeakImplHelper* etc.
...
with the variadic variants.
Change-Id: I2a59d42efbb1aeef5078d0b0744b5a3c0559affa
Reviewed-on: https://gerrit.libreoffice.org/18123
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2015-09-03 17:53:31 +00:00
Stephan Bergmann
049a665bd8
loplugin:stringconstant: OUStringBuffer: appendAscii -> append
...
Change-Id: I4c29e8b2c86816114ea2566348901710f601fd92
2015-08-31 08:02:13 +02:00
Noel Grandin
368a3e45a3
sc: inline some use-once typedefs
...
Change-Id: I332e160dda3f167e61f99da1eb0aa6bd72a48b06
2015-08-04 08:55:56 +02:00
Noel Grandin
01075a7274
inline the "old" SbxErr constants
...
Change-Id: I1c54c792e0397d61c97d5067963b343f912275fc
2015-07-28 08:35:34 +02:00
Noel Grandin
9072c5c855
convert SbxFlagsBits to scoped enum
...
Change-Id: I3dd699ca675be2ff4a8bfb7938bd5d43719b304c
2015-07-28 08:35:34 +02:00
Noel Grandin
90e8ad7ab7
loplugin:unusedmethods scripting,sc
...
Change-Id: I0016aefce1aad3a89bd23dcec6fbab58a7c844d7
Reviewed-on: https://gerrit.libreoffice.org/17263
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-22 07:02:34 +00:00
Stephan Bergmann
35279a7e2d
loplugin:simplifybool
...
Change-Id: Ic179c3012ad99a97b11914bf7aefca58829621e0
2015-07-16 14:00:19 +02:00
Andrea Gelmini
e544f449ed
Fix typos
...
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920
Signed-off-by: Michael Stahl <mstahl@redhat.com >
2015-07-08 12:21:19 +02:00
Caolán McNamara
7462cfde6d
coverity#1308579 Uncaught exception
...
Change-Id: I6bd1f9cdf69865972de9c22106a95e1ebf9a74f7
2015-06-29 09:43:34 +01:00
Caolán McNamara
9202cab167
coverity#1308598 Uncaught exception
...
Change-Id: Id65e076641506e128c27cec4f50bc677e808fa95
2015-06-29 09:43:31 +01:00
Caolán McNamara
8a4d61ceec
coverity#1308560 Uncaught exception
...
Change-Id: Ic5a483ae6de5e072430d8198651177788bf86af9
2015-06-28 21:04:25 +01:00
Caolán McNamara
6f823d85f7
coverity#1308548 Uncaught exception
...
Change-Id: I62d538799a814346df4de00dc232a04376e77ad7
2015-06-28 20:52:35 +01:00
Caolán McNamara
a4fdbaf546
coverity#1308512 Uncaught exception
...
Change-Id: Iacdf2e25fb041ec7e2bae8a505604ef538ee9dac
2015-06-28 17:55:48 +01:00
Andrea Gelmini
5d5dc059cb
Fix typos
...
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9
Reviewed-on: https://gerrit.libreoffice.org/16523
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2015-06-28 12:35:58 +00:00
Andrea Gelmini
f378e723d2
Fix typos
...
Change-Id: I528752dfabeb31d14c350f79819b521537ab9b56
Reviewed-on: https://gerrit.libreoffice.org/16300
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-06-16 11:14:55 +00:00
Noel Grandin
4ea281a3cc
cppcheck:redundantAssignment
...
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-06-15 13:34:14 +02:00
Noel Grandin
0c18bedb73
java: 'final static' to 'static final'
...
this is the canonical order, and it makes the code easier to read
Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470
Reviewed-on: https://gerrit.libreoffice.org/16242
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: David Ostrovsky <david@ostrovsky.org >
2015-06-15 08:45:19 +00:00
Noel Grandin
efd4bfa818
java:regulatize the order of 'final' and public/private
...
Make the order be 'public static' or 'private static'
Just makes the code nicer to read.
Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2
Reviewed-on: https://gerrit.libreoffice.org/16202
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-06-11 09:34:00 +00:00
Noel Grandin
776a3f14f2
convert expressions like 'size() == 0' to 'empty()'
...
Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
2015-06-11 10:07:08 +02:00
Stephan Bergmann
4446cdf20b
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: I14d1c6f703c83bc4a0259ce68e93a315bbfdde4e
2015-06-08 16:27:44 +02:00
Philippe Jung
1379e2feaa
Rewrite all calls like Dialog(params).Execute()
...
Replace all calls looking like
ADialog(some params).Execute()
by
ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute()
Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639
Reviewed-on: https://gerrit.libreoffice.org/15915
Tested-by: Jenkins <ci@libreoffice.org >
Tested-by: Michael Meeks <michael.meeks@collabora.com >
Reviewed-by: Michael Meeks <michael.meeks@collabora.com >
2015-05-28 08:44:31 +00:00
Michael Meeks
e4097762dd
Audit all PostUserEvent calls and instrument for VclPtr.
...
Hold a reference on the VclPtr while we're waiting for the UserEvent.
Change-Id: I55c2671ca12eb14761c6a7dffd551af71547ecbd
2015-05-25 21:38:08 +01:00
Julien Nabet
3aebc670e1
Remove include stdio (part2)
...
Change-Id: Iae58d107d8df1c543a165086fb2b7c288e7121dd
Reviewed-on: https://gerrit.libreoffice.org/15775
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2015-05-18 05:33:52 +00:00
Noel Grandin
12ba9e3cad
loplugin:staticmethods
...
Change-Id: Ib0c0841e48814d1a6e13bcd4575725d86ffa5e5e
2015-04-23 13:08:48 +02:00
Noel Grandin
71b809959b
remove unnecessary use of void in function declarations
...
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
Noel Grandin
ee094bd46f
loplugin:staticmethods
...
Change-Id: If97f01a05294fa7efd59a8934c7b6f65cda5084a
2015-04-13 09:37:12 +02:00
Stephan Bergmann
bbe2923961
Replace remaining getCppuType et al with cppu::UnoType
...
Change-Id: I936ae26f8d5d7cdd32c15e937b7cae6668b6192c
2015-04-01 08:40:47 +02:00
Stephan Bergmann
6b97231ba3
Reduce to static_cast any reinterpret_cast from void pointers
...
Change-Id: I7d6106bda60f8cae3e110e6757b3bf267ce15ec5
2015-03-31 13:16:12 +02:00
Julien Nabet
5584d73f2d
Typos
...
Change-Id: I434be0034b26ac4719590238817538ecd90b8923
2015-03-25 20:42:37 +01:00
Stephan Bergmann
3099c70b11
Fix various XServiceInfo implementations
...
...to match what is recorded in the .component files
Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-17 12:25:11 +01:00
Stephan Bergmann
d1c9e5ee53
tdf#43157: Fix format string violations in OSL_TRACE etc.
...
...for a 32-bit build, similar to what ee11e221d2
"tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit
build
Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
2015-03-13 18:21:36 +01:00
Stephan Bergmann
2358dfc602
Clean up previous commit
...
...and add missing XServiceInfo implementations
Change-Id: I719cd10b6202d94e751805e1b838eb3f193e24d1
2015-03-12 10:48:03 +01:00
Chris Sherlock
6f7b0a1fad
scripting: use constructor syntax in vbaevents.component
...
Change-Id: Ie27ec9ca92137e9f8666d2080fd1bc028417e337
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2015-03-12 10:48:03 +01:00
Michael Stahl
e557b160fd
pyuno, scripting: remove executable bits from python, js, bsh files
...
Change-Id: Id108693d84fbca7764614e126ee1b3b045baec17
2015-03-02 13:26:28 +01:00
Julien Nabet
1101ae6772
Typo: deleteing->deleting
...
Change-Id: I2bdde7524a97039c94a8da5ac5d2eba38c91d71a
2015-02-21 10:56:21 +01:00
Stephan Bergmann
f1f6edaae1
Make LogUtils.getTrace actually work
...
Change-Id: I59e2b93ed1142bac22ead08cc101e27cfa3e02df
2015-02-16 11:27:14 +01:00
Stephan Bergmann
3336a5071b
rhbz#1192732: Revert "From the context of the code, this field should...
...
...not be static." This reverts commit
6d4c1f0d4a . Whatever made the author of that
commit think rhinoWindow shouldn't be static, it clearly needs to be, as in
edit()'s Runnable.run(), the usage of rhinoWindow at the end relies on
rhinoWindow being set via the
new ScriptEditorForJavaScript(context, url)
call to initUI() (or else rhinoWindow already being set from a previous such
call if already editor != null).
2015-02-16 10:45:50 +01:00
Stephan Bergmann
0e882b6513
loplugin:deletedspecial
...
Change-Id: I862b29974c770aea7396f2d650208b1f3e1f4e4b
2015-02-07 12:36:01 +01:00
Michael Stahl
74df327e1e
scripting: remove unnecessary SAL_CALL
...
Change-Id: Ic1fbb36a509ec1dce63f1c7fa4a8955a4780517d
2015-01-29 21:48:11 +01:00
Stephan Bergmann
3f5ccf572a
Fix types of functions called via pointer (-fsanitze=function)
...
Change-Id: Ife0151a04477ce30bb132e6dfae9f4d3a74bf4b0
2015-01-26 15:17:31 +01:00
Noel Grandin
b44cbb26ef
new loplugin: change virtual methods to non-virtual
...
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-26 08:42:28 +02:00
Andras Timar
b55ef81671
typo: langugage -> language
...
Change-Id: Ifabd5a7851946b3e4109e22e6e9a1ff34575c1e5
2015-01-23 15:01:37 +01:00
Noel Grandin
3ab2d3a2c5
fdo#88256 fix crash when running javascript macro
...
caused by my commit 8583da1e93
"java: remove unused fields"
Change-Id: Ibcd6462e8229a0a6cb98ebfd16ce5d2ea45ca931
2015-01-13 10:38:48 +02:00
Julien Nabet
7da92fdcb0
cppcheck: Possible inefficient checking for <var> emptiness
...
Change-Id: I6ca0e477a4429e762c48c721951b9876db3a5c6c
2015-01-04 19:11:13 +01:00
Caolán McNamara
ca8787a981
boost::unordered_map->std::unordered_map
...
Change-Id: I5d458f43616edc395faa8c27edaddc7d515166db
2015-01-04 12:51:09 +00:00
Michael Weghorn
17fc7aa3b8
fdo#39440 reduce scope of local variables
...
This addresses some cppcheck warnings.
Change-Id: I390607e002e93cf7a6babc26d9be084d9f185058
2014-12-21 20:18:17 +01:00
Noel Grandin
e92d3e9007
java: scripting: fix bug in removing model from map
...
found by PMD
Change-Id: I4bd35dd30f6c77aad96932216d8459b812004a88
2014-12-19 10:41:54 +02:00
Stephan Bergmann
b9def20cea
scripting: Use appropriate OUString functions on string constants
...
Change-Id: Iacb434225e779de4911e9acc8431662f5eabcee3
2014-12-18 14:12:30 +01:00
Stephan Bergmann
fe17eb9448
scripting: Use appropriate OUString functions on string constants
...
Change-Id: I8ee8eb92ac95937893c894e67882e9df2c16a67d
2014-12-15 10:15:16 +01:00
Noel Grandin
08ece8d873
java: revert part of commit, scripting/ is public API
...
revert part of my commit
7557f23b31
"java: reduce visibility of fields and methods"
Change-Id: I2049a154b60b165d4d2217495935442d6da66e97
2014-12-11 15:20:09 +02:00