Simon Chenery
478920da08
Add isEmpty() to avoid possible OUString underflow in HelpSearch.cxx
...
Avoid accessing invalid index -1 if OUString queryStr is empty.
It cannot be guaranteed that callers will always pass a non-empty
value for queryStr.
Change-Id: I759a4caea5d52371467f58bb5b95edbd3ff7d4d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181850
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org >
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org >
Tested-by: Jenkins
2025-03-17 16:49:37 +01:00
Gabor Kelemen
c329a1c112
tdf#42949 Fix IWYU warnings in helpcompiler/
...
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: Ie7e20c77a8035c0ee4f0316966d163b9cd7d11f2
Reviewed-on: https://gerrit.libreoffice.org/73006
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com >
2019-05-30 09:00:54 +02:00
Stephan Bergmann
c18e2ea2a5
New loplugin:data
...
...following up on 1453c2c8f1https://gerrit.libreoffice.org/72765
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2019-05-22 16:35:20 +02:00
Noel Grandin
a7369d9899
loplugin:oncevar in helpcompiler..reportdesign
...
Change-Id: I2dc57931fb230953c285aeb18f57c0a41fedafcb
Reviewed-on: https://gerrit.libreoffice.org/30463
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-02 07:12:46 +00:00
Noel Grandin
e5bb67f08d
loplugin:unusedmethods unused return value in include/helpcompiler
...
Change-Id: Ieebbd896bf1ad66cd1950456ca1600f0dd8cda83
2016-01-12 11:47:52 +02:00
Stephan Bergmann
2df257e95e
loplugin:nullptr (automatic rewrite)
...
Change-Id: I6e34abccb0bda1c76e30ab973b8fd827d6c99c72
2015-11-10 10:31:27 +01:00
Noel Grandin
e0b2e6e3f7
loplugin:loopvartoosmall
...
Change-Id: Icbe68b31d4ab04ca3cd9f572e3598413946a75c7
2015-05-29 08:48:41 +02:00
Stephan Bergmann
ad9498f8b8
More -Werror,-Wunused-private-field
...
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html >
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15 15:58:56 +02:00
Michael Meeks
72e5d0c8fb
Move to MPLv2 license headers, with ESC decision and author's permission.
2013-04-30 13:34:06 +01:00
Luboš Luňák
1946794ae0
mass removal of rtl:: prefixes for O(U)String*
...
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Andras Timar
eaa81cc2f0
move help compiler/linker/indexer to a new module
...
we may want to use syntax highlighter class from svtools later,
which is not available for l10ntools
Change-Id: I5a06b77cb6935e3ef68015fb608aa26ac7c53fac
2012-09-16 20:41:26 +02:00
Simon Chenery