295 Commits
Author SHA1 Message Date
Andrea Gelmini e1c80203c5 Fix typos
Change-Id: I024707be2b9a020d4217ef79e9fddb4210c27469
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210158
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2026-08-29 15:15:14 +02:00
Andrea Gelmini 1d13866f77 Fix typos
Change-Id: Ia411390c0f297ce12b282a8f7b858747aa255bd1

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/209818
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2026-08-24 08:52:08 +02:00
Andreas Heinisch 5d8a4ff44c tdf#51727 - Init tab stop property correctly to prevent default tab navigation
In addition, added the test facilities for the forms module.

Change-Id: I8ff70f803a9cd549320f8c46b77e30f65cd327e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/206773
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
2026-06-19 16:01:40 +02:00
Bojidar Marinov 423cdbce04 tdf#128968 Remove redundant SwitchXFormsDesignMode option
Instead, port code to use SwitchControlDesignMode everywhere.

Change-Id: Iaca4bd3c29f9a156c529c526ea7e4e5af64f030f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187620
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
2025-07-15 20:26:39 +02:00
Andrea Gelmini 52aafb61af Fix typo
Change-Id: I6dc27f359ac5b9993d794c15c96712d95c4d476a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169235
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-19 22:57:51 +02:00
Tomaž Vajngerl 197e5f8121 introduce {Char,Fill}ColorThemeReference which uses XThemeColor
Adds a unified UNO property for theme colors *ColorTheme
(CharColorTheme and FillColorTheme) which uses XThemeColor, that
replaces the properties *Theme, *TintOrShade, *LumOff, *LumMod.
The properties are still present for backwards compatibility and
to keep ODF support working in tests as that needs a bigger change.

Reactor the code and tests to accomodate for this change.

Change-Id: If7983decb4ba528b49fe7b5968aa9efc696a9efc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144783
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-13 00:49:24 +00:00
Noel Grandin bd40e50bce fix compile error in java test code
likely caused by
  commit 89340fcb65
  Author: Noel Grandin <noel.grandin@collabora.co.uk>
  Date:   Wed May 20 13:45:07 2020 +0200
  use for-range on Sequence in f*

but since this code appears to be currently unused, was never caught

Change-Id: I0e2f8eade9376ccd18ad9a63e6d5e3012a659938
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103381
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-25 17:56:14 +02:00
Noel Grandin 89340fcb65 use for-range on Sequence in f*
Change-Id: I820255001c1b96d1f4b76a203f3c0f76fa09fe66
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94567
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-21 08:48:26 +02:00
Andrea Gelmini 1dfcec6ae5 Fix typo
Change-Id: Ib72667f1360e190b15eac187b46fc563b9f65524
Reviewed-on: https://gerrit.libreoffice.org/73419
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-04 07:09:06 +02:00
Stephan Bergmann 8ae150d80c Re-enable JunitTest_forms_unoapi_2 forms.ODateModel
f9905401d8 "tdf#125170 Deliver mouse events also
when clicking into document content" had disabled it because its
gerrit_linux_clang_dbgutil Jenkins build had failed it successively like

> LOG> Execute: Date
> LOG> try to set:
> LOG> old = com.sun.star.util.Date@271053e1{1, 1, 1800}
> LOG> new = com.sun.star.util.Date@589838eb{2, 0, 0}
> warn:tools.datetime:303:1063:tools/source/datetime/tdate.cxx:102: Date::setDateFromDMY - sure about 0 year? It's not in the calendar.
> LOG> Property Date is void
> LOG> Value for 'Date' hasn't changed as expected
> LOG> result = com.sun.star.util.Date@42dafa95{1, 1, 1800}
> Method Date finished with state FAILED
> LOG> Date: COMPLETED.FAILED

(<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/32715/>).

But it is unclear how that commit would have affected that test, and at least a
recent local build of mine succeeds with

> LOG> Execute: Date
> LOG> try to set:
> LOG> old = com.sun.star.util.Date@dc24521{0, 0, 0}
> LOG> new = com.sun.star.util.Date@10bdf5e5{1, 0, 0}
> warn:tools.datetime:10048:10220:tools/source/datetime/tdate.cxx:102: Date::setDateFromDMY - sure about 0 year? It's not in the calendar.
> LOG> Property Date is void
> LOG> Property 'Date' OK
> LOG> result = com.sun.star.util.Date@6e1ec318{1, 0, 0}
> Method Date finished with state OK
> LOG> Date: COMPLETED.OK

(note the difference of initial date, {1, 1, 1800} vs. {0, 0, 0}, whether or not
that is relevant), so lets re-enable the test for now and see...

Change-Id: I53b462954650e32de85c795c94f9b8038dc01918
Reviewed-on: https://gerrit.libreoffice.org/72863
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-23 21:43:27 +02:00
Samuel Mehrbrodt f9905401d8 tdf#125170 Deliver mouse events also when clicking into document content
Event listeners are added once VCLXWindow::SetWindow is called.
This never happened for the document content window.
So we need to call Window::GetComponentInterface which will create an XWindowPeer
and then call UnoWrapper::SetWindowInterface which calls VCLXWindow::SetWindow.

After that, event listeners are registered so that we can deliver events.

Change-Id: I2ed01f1ab20d87fedc4803bdbd96f5ef14d40043
Reviewed-on: https://gerrit.libreoffice.org/71948
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-05-16 15:40:11 +02:00
Caolán McNamara 1156f981ac an is used before a vowel sound
not before vowels with a consonant sound so its a url not an url

Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2
Reviewed-on: https://gerrit.libreoffice.org/72062
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-10 10:01:13 +02:00
dennisroczek 783bc62734 fix some openoffice bugzilla links
* remove redirects
* use https links
* replace old attchment links with working ones

Change-Id: Ic9a154f46e142138f0adea7d7b8be3b6cfe8af18
Reviewed-on: https://gerrit.libreoffice.org/52224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-01 22:23:54 +02:00
Johnny_M fd48f39a7e Translate German comments and debug strings (leftovers in f... dirs)
Translates all (leftovers) found using a custom regex, in directories not
shown by /bin/find-german-comments and beginning with "f".

Additionally:
- Fixed translation in formula/source/ui/dlg/funcutl.cxx (translated in
https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=5e04331fc0a6434c61d3d18843cb4f80a44e5989 ),
because clearing an event is quite the opposite of its triggering.

Change-Id: I0fd62193a29883796cd05e5a80ce8a2900636b6c
Reviewed-on: https://gerrit.libreoffice.org/37839
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-05-20 13:43:17 +02:00
Jens Carl ad3681df0a tdf#39468 Translate German comments
Translate German comments and terms in dbaccess/, forms/, fpicker/, framework/,
and idl/

Change-Id: I08b3db9492f16fc1c457e8f5eff838c13561c945
Reviewed-on: https://gerrit.libreoffice.org/35888
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-30 10:27:35 +00:00
Michael Stahl 39ca8c72c2 forms,qadevOOo: dispatch of .uno:SwitchControlDesignMode is async
Follow-up to e19cdeaf7d.

Change-Id: Ic4f8f0373199a4237fa30a830fc89a263eb40d62
2017-01-16 13:42:56 +01:00
Andrea Gelmini 64d624b651 Fix typos
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10 14:17:20 +00:00
Noel Grandin 3f50c6e050 java: remove ((unnecessary)) parentheses
Change-Id: I39fbe3a260c8dbfc203662c54eec4db064b88195
2015-11-05 14:55:16 +02:00
Noel Grandin ff3b3bed94 java: make inner classes static where possible
Change-Id: Icc6444ad15d9f4b50858d8c1b1d3adeaeac40926
2015-11-05 13:43:01 +02:00
Noel Grandin 1716b3a338 remove some useless comments
found with git grep '// /'

Change-Id: I948cf9ae61bbbf2ec706ca5b0572c4f27c58c745
2015-10-13 10:07:49 +02:00
Andrea Gelmini 19b85e90ab Fix typos
Change-Id: Ib30f4e5f16518cbbe71cf03998513ebd8c2a4d1a
Reviewed-on: https://gerrit.libreoffice.org/18949
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
2015-10-02 07:55:15 +00:00
Andrea Gelmini 799cc41b53 Fix typos
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0
Reviewed-on: https://gerrit.libreoffice.org/16834
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-07-08 05:48:18 +00:00
Andrea Gelmini 465489d97a Fix typos
Change-Id: Id884946cae0687d0b71c967e236e58df17567884
Reviewed-on: https://gerrit.libreoffice.org/16707
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-03 09:43:46 +00:00
Noel Grandin efd4bfa818 java:regulatize the order of 'final' and public/private
Make the order be 'public static' or 'private static'
Just makes the code nicer to read.

Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2
Reviewed-on: https://gerrit.libreoffice.org/16202
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11 09:34:00 +00:00
Noel Grandin 275f0c7b25 Let JUnit take care of exceptions
Inspired by commit
4dd0ac6285

Change-Id: I6ca29aecde357a3cb5852acfc9b5443761052960
Reviewed-on: https://gerrit.libreoffice.org/16094
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-05 13:17:50 +00:00
Bjoern Michaelsen 5fe011ae02 split forms unoapi test for performance
- test previously took 2m51s here
- slowest part is now 54s

Change-Id: Ib81fcb1a6e27dd54e0c3a319ff065166d57654ff
Reviewed-on: https://gerrit.libreoffice.org/15959
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2015-05-29 11:54:05 +00:00
Noel Grandin 9b8fb077d2 java: inline some test properties
Change-Id: I8be2ee13652ed7223e41765811db577ecc1c85d6
2015-01-13 08:42:56 +02:00
Noel Grandin 43cc8ad33e java: remove dead code
found by UCDetector

Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2015-01-05 08:23:29 +02:00
Noel Grandin 567592c9e2 java: don't synch on an object and also assign to it
Change-Id: Ie0a098e935e640f10b77d259c96bbd1c604d701e
2014-12-19 10:41:55 +02:00
Noel Grandin f8fbef2653 java: remove more test skeleton code
Change-Id: I37a82554de4f77be7e0fb3e42245a70b53beb83c
Reviewed-on: https://gerrit.libreoffice.org/13476
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-15 12:36:12 +00:00
Noel Grandin 7557f23b31 java: reduce visibility of fields and methods
found by PMD

Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-11 06:09:03 +00:00
Noel Grandin 9adb820158 java: simplify the getMSF() methods
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3
Reviewed-on: https://gerrit.libreoffice.org/13406
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10 08:04:58 +00:00
Noel Grandin 5d60214678 java: remove some comment noise
Change-Id: I1c258b853097448d4a59334d915e94dba4c7eb34
2014-11-25 10:34:27 +02:00
Noel Grandin 1658c017a2 java,framework: remove unused vars and parameters
Change-Id: I7df5ff730436b95cb93af9f813d7bc572da2b951
Reviewed-on: https://gerrit.libreoffice.org/13098
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-25 05:05:24 +00:00
Noel Grandin 0063cf2856 java: make fields final where possible
found by PMD

Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-18 12:44:28 +02:00
Noel Grandin bb437029c1 java: convert fields to local variables where possible
found by PMD

Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542
Reviewed-on: https://gerrit.libreoffice.org/12376
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:03:29 +00:00
Robert Antoni Buj i Gelonch 1e48bfafdd forms: The if statement is redundant
Change-Id: I1d339ea6052e648acf4405d2d40795c82ee043ca
Reviewed-on: https://gerrit.libreoffice.org/11713
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-30 14:24:48 +00:00
Noel Grandin 03c7c26cbe java: final fields that can be static
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-17 08:26:21 +02:00
Noel Grandin 12b01b920f java: no need to call String.valueOf to append to a String
Change-Id: I5ef45b971d24dde814ab8cbb2e9503d9da4f0d73
2014-10-17 08:26:19 +02:00
Noel Grandin 9341bf3dc3 java: when rethrowing, store the original exception
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
2014-10-16 12:27:15 +02:00
Robert Antoni Buj i Gelonch bbd5a30411 java: ensure that the stream is cleaned up before the method returns
Change-Id: Id3efeda2fd66173ba2f5662eaacb3629da54573d
Reviewed-on: https://gerrit.libreoffice.org/11991
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-16 10:25:18 +00:00
Noel Grandin 02ace92aba java: optimise calls to toArray
passing in a correctly sized array requires one less allocation

Change-Id: I6198d226d9b630c99c4e8b6e3d0fdf890c495b44
2014-10-07 13:20:01 +02:00
Robert Antoni Buj i Gelonch 4173bc5f7e forms: enhanced for loop
Change-Id: I0c83d6fce9440f5d8b23e5f1bfca71d8f61d056b
Reviewed-on: https://gerrit.libreoffice.org/11719
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-01 19:44:53 +00:00
Robert Antoni Buj i Gelonch 4badca0740 forms: use Arrays.toString in integration.forms.RadioButtons
Change-Id: I797692857c874d879192ca9a4ff73b98ed5ebd86
Reviewed-on: https://gerrit.libreoffice.org/11721
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-30 17:42:22 +00:00
Robert Antoni Buj i Gelonch 73d6c6b51b forms: replace StringBuffer with StringBuilder
Change-Id: Iee1b7ea214e5ed2fdd8bd5fe93dc16fbaaf312a8
Reviewed-on: https://gerrit.libreoffice.org/11720
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-30 17:42:12 +00:00
Robert Antoni Buj i Gelonch 1c70f59c13 forms: the assigned value is never used
Change-Id: I8eadc27ba8880630ec93c68145969f3e8ba6c189
Reviewed-on: https://gerrit.libreoffice.org/11712
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30 12:19:10 +00:00
Robert Antoni Buj i Gelonch 62bd1d1783 forms: remove import from the same package
Change-Id: Ia15b4586e183bcd24a47c1a072c4d6e8ca280e98
Reviewed-on: https://gerrit.libreoffice.org/11714
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30 12:16:29 +00:00
Robert Antoni Buj i Gelonch bf7ddfdeb7 Fix java.util.Calendar.set in integration.forms.DateValidator
Change-Id: I1bd87c623b923469c325ebfcba4ba82e2a648ae2
Reviewed-on: https://gerrit.libreoffice.org/11694
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-29 12:54:30 +00:00
Robert Antoni Buj i Gelonch 72f50083e7 forms: getMonth() and getYear() are deprecated in java.util.Date
Change-Id: I31664bbd8c1c3b02e8a7381226d4d558b37466a2
Reviewed-on: https://gerrit.libreoffice.org/11690
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-29 12:44:30 +00:00
Robert Antoni Buj i Gelonch 16417688ef forms: Pass array of length equal to the size of the collection
Change-Id: Id880953105f6100b15cd78f48ce0c8dbcb7ffb8d
Reviewed-on: https://gerrit.libreoffice.org/11687
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-29 08:14:26 +00:00