ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
520,958 Commits 3 Branches 3 Tags
main
Commit Graph
24 Commits
Author SHA1 Message Date
George Bateman 08cc983e26 tdf#124176 Use #pragma once in cppu, cppuhelper 
This commit was carried out by a Python script, source of which
is at https://bugs.documentfoundation.org/show_bug.cgi?id=124176#c97.

Change-Id: I0b7c5bec8e56bd21e719c8889fe263e377f3b8ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102547
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2020-09-13 15:28:21 +02:00
Stephan Bergmann a0bc388b38 Use the saner std::condition_variable semantics for JobQueue::m_cndWait 
This avoids the need for the tricky osl::Condition::reset calls.  For example,
the first one (in the "disposed !" case) had been added with
2a3ed89284 "sb132: #i112448# proper clean up in
JobQueue::enter (patch by olistraub)" as

>                  if( 0 == m_lstCallstack.front() )
>                  {
>                      // disposed !
> +                    if( m_lstJob.empty() )
> +                    {
> +                        osl_resetCondition( m_cndWait );
> +                    }
>                      break;
>                  }
>

and then change to

>                  if( 0 == m_lstCallstack.front() )
>                  {
>                      // disposed !
> -                    if( m_lstJob.empty() )
> +                    if( m_lstJob.empty()
> +                        && (m_lstCallstack.empty()
> +                            || m_lstCallstack.front() != 0) )
>                      {
>                          osl_resetCondition( m_cndWait );
>                      }

with cba3ac1eab "Avoid deadlocks when disposing
recursive JobQueue::enter", which prevented the reset from ever hapening
(because m_lstCallstack.front() cannot both be zero and non-zero here at the
same time).  The std::condition_variable semantics nicely avoid any reasoning
whether or not a reset would be necessary here.

Change-Id: Ic9b57b836bb6679829f4aa3b68679256726acf60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96406
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2020-06-16 10:02:24 +02:00
Stephan Bergmann d8feb7738d Model the dispose tokens as void const * instead of sal_Int64 
...which avoids the sal_IntPtr casts

Change-Id: I518fcefc66d297b56c9bd94f7826a44715acb5f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96392
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2020-06-15 22:24:29 +02:00
Noel Grandin 3af500580b loplugin:salcall fix functions 
since cdecl is the default calling convention on Windows for
such functions, the annotation is redundant.

Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d
Reviewed-on: https://gerrit.libreoffice.org/46164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-11 12:13:46 +01:00
Julien Nabet 7db6878a9d Replace lists by vector or deque (cppu) 
+ use for range loops

Change-Id: If0fcba6e06538913031c50ec878b18db3547e06c
Reviewed-on: https://gerrit.libreoffice.org/44894
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-18 07:50:18 +01:00
Tor Lillqvist 6de3688cc6 Drop :: prefix from std in c*/ 
Change-Id: If078cda95fa6ccd37270a5e9d81cfa0b84e71155
Reviewed-on: https://gerrit.libreoffice.org/34324
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2017-02-15 23:01:23 +00:00
Noel Grandin f651ea26ea std::list<sal_Int64> -> std::deque 
Change-Id: Ib34d6bf97fc97ea1c30c184a7de4ace7f533065f
 2016-09-01 11:05:21 +02:00
Caolán McNamara 22b80ac8e2 boost->std 
Change-Id: I3fd9e1599c5ad812879a58cf1dabbcd393105e1c
Reviewed-on: https://gerrit.libreoffice.org/18564
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-09-14 12:54:25 +00:00
Stephan Bergmann 2861d5bedc Some oslCondition -> osl::Condition 
Change-Id: I86cfbefd1cb8b22fca659a158b8e31d5c991de7a
 2015-08-18 08:16:18 +02:00
Thomas Arnhold ed81c7fb25 fixincludeguards.sh: cppu 2014-04-19 11:10:06 +02:00
Stephan Bergmann 34a44156b3 cppu: sal_Bool -> bool 
Change-Id: I1288f1f6f38d1475b4eb5272509e479bd9f2552d
 2014-02-17 17:55:18 +01:00
Michael Meeks c3a6a57fc2 re-base on ALv2 code. 2012-06-13 14:18:29 +01:00
Michael Stahl a860cd108c cppu: JobQueue::enter: add mutex guards for m_nToDo 
Considered replacing it with oslInterlockedCount, but wondered why there is
no osl_getInterlockedCount (similar to glib's g_atomic_int_get)...
 2012-02-27 20:53:20 +01:00
Julien Nabet 6ca25e8192 Some cppcheck cleaning 2011-01-12 13:12:22 +00:00
Sebastian Spaeth a715e1b3d0 Add vim/emacs modelines to all source files 
Fixes #fdo30794
Based on bin/add-modelines script (originally posted in mail
1286706307.1871.1399280959@webmail.messagingengine.com)

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
 2010-10-14 17:04:31 +02:00
Caolán McNamara 521a9f6f76 #i107490# cppu lifecycle cleanup 2010-10-11 12:37:08 +01:00
Jens-Heiner Rechtien 7c80db2eb3 changefileheader2: #i109125#: change source file copyright notice from Sun Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision) 2010-02-12 15:01:35 +01:00
Rüdiger Timm 86b14e7387 INTEGRATION: CWS changefileheader (1.6.84); FILE MERGED 
2008/04/01 15:10:33 thb 1.6.84.2: #i85898# Stripping all external header guards
2008/03/31 07:23:20 rt 1.6.84.1: #i87441# Change license header to LPGL v3.
 2008-04-11 09:33:18 +00:00
Jens-Heiner Rechtien 9b8457a6d2 INTEGRATION: CWS warnings01 (1.2.186); FILE MERGED 
2005/09/22 20:42:35 sb 1.2.186.2: RESYNC: (1.2-1.3); FILE MERGED
2005/08/31 13:43:19 sb 1.2.186.1: #i53898# Made code warning-free.
 2006-06-19 12:12:18 +00:00
Kurt Zenker 54ec29f389 INTEGRATION: CWS jsc9 (1.4.2); FILE MERGED 
2006/04/26 14:15:32 jsc 1.4.2.1: #134738# move fixes back to previous version
 2006-04-26 19:49:54 +00:00
Jens-Heiner Rechtien d675aab65d INTEGRATION: CWS sb49 (1.3.38); FILE MERGED 
2006/03/22 10:14:05 sb 1.3.38.1: #i63397# Keep objects alive long enough so that threads still running while atexit handlers are processed do not access dead objects.
 2006-04-19 12:48:56 +00:00
Rüdiger Timm de6d2c3591 INTEGRATION: CWS ooo19126 (1.2.190); FILE MERGED 
2005/09/05 13:54:25 rt 1.2.190.1: #i54170# Change license header: remove SISSL
 2005-09-08 07:46:23 +00:00
Joachim Lingner 247ed90574 #include <osl/types> replaced by <sal/types.h> 2001-03-20 14:30:39 +00:00
Jens-Heiner Rechtien b525a3115f initial import 2000-09-18 14:29:57 +00:00