From faea8cc858c8fbe2bd23945429ee18a54946fe89 Mon Sep 17 00:00:00 2001 From: Andreas Heinisch Date: Tue, 12 May 2026 22:43:20 +0200 Subject: [PATCH] Move bug fix to the end of the regular function tests to be consistent with other tests for missing/optional parameters Change-Id: I6ee663e594f9c4421532c865a0aed5b5db52597b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205143 Reviewed-by: Andreas Heinisch Tested-by: Jenkins --- basic/qa/vba_tests/optional_paramters.vb | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/basic/qa/vba_tests/optional_paramters.vb b/basic/qa/vba_tests/optional_paramters.vb index d47854d2fb69..d8c497fa865f 100644 --- a/basic/qa/vba_tests/optional_paramters.vb +++ b/basic/qa/vba_tests/optional_paramters.vb @@ -22,12 +22,6 @@ End Function Sub verify_testOptionalsVba() On Error GoTo errorHandler - ' tdf#143707 - check correct initialization of default value for optionals - ' Without the fix in place, this test would have failed with - ' - Expected: 123 - ' - Actual : 123% - TestUtil.AssertEqual(TestOptVariantInit(), 123, "TestOptVariantInit()") - ' optionals with variant datatypes TestUtil.AssertEqual(TestOptVariant(), 123, "TestOptVariant()") TestUtil.AssertEqual(TestOptVariant(123), 246, "TestOptVariant(123)") @@ -114,6 +108,12 @@ Sub verify_testOptionalsVba() ' TestUtil.AssertEqualApprox(TestOptArrayByRefByVal(, aB), 691.2, 1E-5, "TestOptArrayByRefByVal(, B)") TestUtil.AssertEqualApprox(TestOptArrayByRefByVal(aA, aB), 1270.2, 1E-5, "TestOptArrayByRefByVal(A, B)") + ' tdf#143707 - check correct initialization of default value for optionals + ' Without the fix in place, this test would have failed with + ' - Expected: 123 + ' - Actual : 123% + TestUtil.AssertEqual(TestOptVariantInit(), 123, "TestOptVariantInit()") + Exit Sub errorHandler: TestUtil.ReportErrorHandler("verify_testOptionalsVba", Err, Error$, Erl)