Fix typos

Change-Id: I38b80f7bbf93192b7e2e00a426b72b77eb33bf1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/210568
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

sal/qa/rtl/oustring/rtl_ustr.cxx

@@ -196,7 +196,7 @@ namespace rtl_ustr
     CPPUNIT_TEST(compare_003);
     CPPUNIT_TEST(compare_004);
     CPPUNIT_TEST_SUITE_END();
-}; // class compare
+}; // class shortenedCompareIgnoreAsciiCase_WithLength
 
 //
 //
@@ -389,7 +389,7 @@ namespace rtl_ustr
         CPPUNIT_TEST(indexOfStr_001);
         CPPUNIT_TEST(indexOfStr_002);
         CPPUNIT_TEST_SUITE_END();
-    }; // class compare
+    }; // class indexOfStr
 
     class lastIndexOfStr : public CppUnit::TestFixture
     {
@@ -508,7 +508,7 @@ namespace rtl_ustr
         CPPUNIT_TEST(replaceChar_WithLength_001);
         CPPUNIT_TEST(replaceChar_WithLength_002);
         CPPUNIT_TEST_SUITE_END();
-    }; // class replaceChar
+    }; // class replaceChar_WithLength
 
     class toAsciiLowerCase : public CppUnit::TestFixture
     {
@@ -530,7 +530,7 @@ namespace rtl_ustr
         CPPUNIT_TEST_SUITE(toAsciiLowerCase);
         CPPUNIT_TEST(toAsciiLowerCase_001);
         CPPUNIT_TEST_SUITE_END();
-    }; // class replaceChar
+    }; // class toAsciiLowerCase
 
     class toAsciiLowerCase_WithLength : public CppUnit::TestFixture
     {
@@ -558,7 +558,7 @@ namespace rtl_ustr
         CPPUNIT_TEST(toAsciiLowerCase_WithLength_000);
         CPPUNIT_TEST(toAsciiLowerCase_WithLength_001);
         CPPUNIT_TEST_SUITE_END();
-    }; // class replaceChar
+    }; // class toAsciiLowerCase_WithLength
 
     class toAsciiUpperCase : public CppUnit::TestFixture
     {
@@ -580,7 +580,7 @@ namespace rtl_ustr
         CPPUNIT_TEST_SUITE(toAsciiUpperCase);
         CPPUNIT_TEST(toAsciiUpperCase_001);
         CPPUNIT_TEST_SUITE_END();
-    }; // class replaceChar
+    }; // class toAsciiUpperCase
 
     class toAsciiUpperCase_WithLength : public CppUnit::TestFixture
     {
@@ -609,7 +609,7 @@ namespace rtl_ustr
         CPPUNIT_TEST(toAsciiUpperCase_WithLength_000);
         CPPUNIT_TEST(toAsciiUpperCase_WithLength_001);
         CPPUNIT_TEST_SUITE_END();
-    }; // class replaceChar
+    }; // class toAsciiUpperCase_WithLength
 
     class trim_WithLength : public CppUnit::TestFixture
     {
@@ -1041,7 +1041,7 @@ namespace rtl_ustr
         CPPUNIT_TEST_SUITE(getToken);
         CPPUNIT_TEST(getToken_000);
         CPPUNIT_TEST_SUITE_END();
-    }; // class ascii_compareIgnoreAsciiCase
+    }; // class getToken
 
 CPPUNIT_TEST_SUITE_REGISTRATION(rtl_ustr::compare);
 CPPUNIT_TEST_SUITE_REGISTRATION(rtl_ustr::compareIgnoreAsciiCase);

sal/qa/rtl/random/rtl_random.cxx

@@ -43,7 +43,7 @@ public:
 
         rtlRandomPool aPool = rtl_random_createPool();
 
-        // LLA: seems to be that another test is not possible for createPool()
+        // LLA: it seems that no other test is possible for createPool()
         CPPUNIT_ASSERT_MESSAGE("create failed", aPool != nullptr);
 
         rtl_random_destroyPool(aPool);
@@ -72,7 +72,7 @@ public:
     {
         rtlRandomPool aPool = rtl_random_createPool();
 
-        // LLA: seems to be that another test is not possible for createPool()
+        // LLA: it seems that no other test is possible for createPool()
         CPPUNIT_ASSERT_MESSAGE("create failed", aPool != nullptr);
 
         rtl_random_destroyPool(aPool);
@@ -303,7 +303,7 @@ public:
         aStat.build(nCountMax);
         aStat.print();
 
-        CPPUNIT_ASSERT_MESSAGE("deviation should be less average", aStat.getMaxDeviation() < aStat.getAverage());
+        CPPUNIT_ASSERT_MESSAGE("deviation should be less than average", aStat.getMaxDeviation() < aStat.getAverage());
 
         rtl_random_destroyPool(aPool);
     }
@@ -335,7 +335,7 @@ public:
         aStat.build(nCountMax * nBufLen);
         aStat.print();
 
-        CPPUNIT_ASSERT_MESSAGE("deviation should be less average", aStat.getMaxDeviation() < aStat.getAverage());
+        CPPUNIT_ASSERT_MESSAGE("deviation should be less than average", aStat.getMaxDeviation() < aStat.getAverage());
 
         rtl_random_destroyPool(aPool);
     }

sal/qa/rtl/uuid/rtl_Uuid.cxx

@@ -110,7 +110,7 @@ public:
 
         sal_uInt8 pNamedUUID[16], pNamedUUID2[16];
 
-        // Same name does generate the same uuid
+        // Same name generates the same uuid
         rtl_String *pName = nullptr;
         rtl_string_newFromStr( &pName , "this is a bla.blubs.DNS-Name" );
         rtl_createNamedUuid( pNamedUUID , NameSpace_DNS , pName );
@@ -119,15 +119,15 @@ public:
         CPPUNIT_ASSERT_EQUAL_MESSAGE( "Same name should generate the same uuid", sal_Int32(0), rtl_compareUuid( pNamedUUID , pNamedUUID2 ) );
         CPPUNIT_ASSERT_MESSAGE( "Same name should generate the same uuid", ! memcmp( pNamedUUID  , pPriorCalculatedUUID , 16 ) );
 
-        // Different names does not generate the same uuid
+        // Different names do not generate the same uuid
         rtl_string_newFromStr( &pName , "this is a bla.blubs.DNS-Namf" );
         rtl_createNamedUuid( pNamedUUID2 , NameSpace_DNS , pName );
-        CPPUNIT_ASSERT_MESSAGE("Different names does not generate the same uuid.", memcmp( pNamedUUID , pNamedUUID2 , 16 ) );
+        CPPUNIT_ASSERT_MESSAGE("Different names do not generate the same uuid.", memcmp( pNamedUUID , pNamedUUID2 , 16 ) );
 
-        // the same name with different namespace uuid produces different uuids
+        // The same name with different namespace uuid produces different uuids
         rtl_createNamedUuid( pNamedUUID , NameSpace_URL , pName );
-        CPPUNIT_ASSERT_MESSAGE( " same name with different namespace uuid produces different uuids", memcmp( pNamedUUID , pNamedUUID2 , 16 ));
+        CPPUNIT_ASSERT_MESSAGE( "Same name with different namespace uuid produces different uuids", memcmp( pNamedUUID , pNamedUUID2 , 16 ));
-        CPPUNIT_ASSERT_MESSAGE( " same name with different namespace uuid produces different uuids", rtl_compareUuid( pNamedUUID , pNamedUUID2 ) != 0);
+        CPPUNIT_ASSERT_MESSAGE( "Same name with different namespace uuid produces different uuids", rtl_compareUuid( pNamedUUID , pNamedUUID2 ) != 0);
 
         // test compareUuid
         if ( rtl_compareUuid( pNamedUUID , pNamedUUID2 ) > 0 )

sal/qa/systools/test_comtools.cxx

@@ -127,7 +127,7 @@ namespace test_comtools
             CPPUNIT_ASSERT_EQUAL_MESSAGE("COMReference should be empty", static_cast<IUnknown *>(nullptr), r.get());
 
             r = comObjectSource();
-            CPPUNIT_ASSERT_MESSAGE("COMReference should be empty", r.get() != nullptr);
+            CPPUNIT_ASSERT_MESSAGE("COMReference should not be empty", r.get() != nullptr);
             CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong reference count 1 is expected", ULONG(1), reinterpret_cast<COMObject*>(r.get())->GetRefCount());
         }
 
@@ -240,7 +240,7 @@ namespace test_comtools
 
 CPPUNIT_TEST_SUITE_REGISTRATION(test_comtools::test_COMReference);
 
-} // namespace rtl_OUString
+} // namespace test_comtools
 
 CPPUNIT_PLUGIN_IMPLEMENT();
 

sc/inc/dbdata.hxx

@@ -241,7 +241,7 @@ public:
     const OUString& GetTableType() const           { return aTableType; }
 
     void        SetContainer( ScDBDataContainerBase* pContainer ) { mpContainer = pContainer; }
-    /** Returns header row range if has headers, else invalid range. */
+    /** Returns header row range if it has headers, else invalid range. */
     ScRange     GetHeaderArea() const;
     void        StartTableColumnNamesListener();
     void        EndTableColumnNamesListener();
@@ -270,8 +270,8 @@ public:
      */
     sal_Int32   GetColumnNameOffset( const OUString& rName ) const;
 
-    /** Returns table column name if nCol is within column range and name
+    /** Returns table column name if nCol is within column range and the name
-        is stored, else empty string. */
+        is stored, else an empty string. */
     const OUString & GetTableColumnName( SCCOL nCol ) const;
 
     OUString GetSourceString() const;

sc/inc/formulacell.hxx

@@ -206,7 +206,7 @@ public:
 
     /**
      * Transfer the ownership of the passed token array instance to the
-     * formula cell being constructed.  The caller <i>must not</i> pass a NULL
+     * formula cell being constructed.  The caller <i>must not</i> pass a nullptr
      * token array pointer.
      */
     SC_DLLPUBLIC ScFormulaCell( ScDocument& rDoc, const ScAddress& rPos, std::unique_ptr<ScTokenArray> pArray,
@@ -363,13 +363,13 @@ public:
      */
     formula::FormulaCallableRef GetRawCallable() const;
     /**
-     * Get a value without potentially triggering re-calculation. May return NULL if the
+     * Get a value without potentially triggering re-calculation. May return nullptr if the
      * result is not a token.
      */
     formula::FormulaConstTokenRef GetRawResultToken() const;
     /**
      * Get a copy of the token without potentially triggering re-calculation. Will not
-     * return NULL, but the caller is responsible for the reference.
+     * return nullptr, but the caller is responsible for the reference.
      */
     formula::FormulaTokenRef CloneRawResultToken() const;
     const ScMatrix* GetMatrix();

sc/inc/rangenam.hxx

@@ -224,7 +224,7 @@ public:
     void UpdateGrow(const ScRange& rArea, SCCOL nGrowX, SCROW nGrowY);
 
     /** Compile those names that couldn't be resolved during loading and
-        inserting because they may have referred a name that was inserted later.
+        inserting because they may have referred to a name that was inserted later.
      */
     void CompileUnresolvedXML( sc::CompileFormulaContext& rCxt );
 

sc/inc/rangeutl.hxx

@@ -283,7 +283,7 @@ struct SC_DLLPUBLIC ScRangeUpdater
         deleted sheets, within the deleted range to the front of that or set to
         0 (as there is always at least one sheet in a document) if the position
         would result in a negative value, e.g. if position was 0 and (only)
-        sheet 0 is deleted it would had become -1.
+        sheet 0 is deleted it would have become -1.
      */
     static void UpdateDeleteTab(ScAddress& rAddr, const sc::RefUpdateDeleteTabContext& rCxt);
 };

sc/qa/extras/htmlexporttest.cxx

@@ -69,7 +69,7 @@ public:
         CPPUNIT_ASSERT(pDoc);
 
         // Without the fix in place, this test would have failed
-        // i.e. href attribute would have been turned into an absolute file
+        // i.e. href attribute would have been turned into an absolute file URL
         CPPUNIT_ASSERT(!getXPath(pDoc, "//a", "href").startsWith("file:"));
     }
 

sc/qa/uitest/calc_tests/CellDropDownItems.py

@@ -44,7 +44,7 @@ class CellDropDownItems(UITestCase):
 
                 # Close the dialog
 
-            #Launch the Select Menu to view the list and select first item in the list
+            # Launch the Select Menu to view the list and select the first item in the list
             gridwin = xCalcDoc.getChild("grid_window")
             gridwin.executeAction("LAUNCH", mkPropertyValues({"SELECTMENU": "", "COL": "2", "ROW": "9"}))
 
@@ -56,7 +56,7 @@ class CellDropDownItems(UITestCase):
             xListItem.executeAction("DOUBLECLICK" , mkPropertyValues({}) )
             self.assertEqual(get_cell_by_position(document, 0, 2, 9).getString(), "Item1")
 
-            #Launch the Select Menu to view the list and select Third item in the list
+            # Launch the Select Menu to view the list and select the third item in the list
             gridwin = xCalcDoc.getChild("grid_window")
             gridwin.executeAction("LAUNCH", mkPropertyValues({"SELECTMENU": "", "COL": "2", "ROW": "9"}))
 
@@ -68,7 +68,7 @@ class CellDropDownItems(UITestCase):
             xListItem.executeAction("DOUBLECLICK" , mkPropertyValues({}) )
             self.assertEqual(get_cell_by_position(document, 0, 2, 9).getString(), "Item3")
 
-            #Launch the Select Menu to view the list and select Fifth item in the list
+            # Launch the Select Menu to view the list and select the fifth item in the list
             gridwin = xCalcDoc.getChild("grid_window")
             gridwin.executeAction("LAUNCH", mkPropertyValues({"SELECTMENU": "", "COL": "2", "ROW": "9"}))
 

sc/qa/unit/jumbosheets-test.cxx

@@ -227,7 +227,7 @@ void ScJumboSheetsTest::testTdf134553()
     // Without the fix in place, this test would have failed here
     CPPUNIT_ASSERT(pOleObj);
 
-    // Sorry, the charts so severely suffer from DPI dependency, that I can't find motivation
+    // Sorry, the charts suffer so severely from DPI dependency, that I can't find motivation
     // to add huge tolerances (around 350!) here to make it pass on non-default DPI, with no
     // guarantee that the test would have any value after that. So just skip it.
     // FIXME: the DPI check should be removed when either (1) the test is fixed to work with

sc/qa/unit/opencl-test-1.cxx

@@ -1846,7 +1846,7 @@ CPPUNIT_TEST_FIXTURE(ScOpenCLTest1, testMathFormulaArcSin)
     ScDocument* pDocRes = getScDoc2();
     pDoc->CalcAll();
 
-    // Verify ACotH Function
+    // Verify ASin Function
     for (SCROW i = 1; i <= 1000; ++i)
     {
         double fLibre = pDoc->GetValue(1, i, 0);

sc/qa/unit/subsequent_export_test.cxx

@@ -224,7 +224,7 @@ CPPUNIT_TEST_FIXTURE(ScExportTest, testTdf111876)
     CPPUNIT_ASSERT(pDoc);
     OUString sTarget = getXPath(pDoc, "/rels:Relationships/rels:Relationship", "Target");
 
-    // Document is saved to the temporary directory, relative path should be different than original one
+    // Document is saved to the temporary directory, relative path should be different from the original one
     CPPUNIT_ASSERT(sTarget != "../xls/bug-fixes.xls");
 }
 

sc/qa/unit/subsequent_export_test3.cxx

@@ -238,7 +238,7 @@ CPPUNIT_TEST_FIXTURE(ScExportTest3, testBordersExchangeXLSX)
             pDoc->GetBorderLines(nCol + 2, (nRow * 2) + 8, 0, nullptr, &pLineTop, nullptr,
                                  &pLineBottom);
             if ((nCol < 3) && (nRow == 6))
-            { // in this range no lines since minimum size to create a double is 0.5
+            { // in this range there are no lines since minimum size to create a double is 0.5
                 CPPUNIT_ASSERT(!pLineTop);
                 CPPUNIT_ASSERT(!pLineBottom);
                 continue;

sc/qa/unit/subsequent_export_test4.cxx

@@ -738,7 +738,7 @@ CPPUNIT_TEST_FIXTURE(ScExportTest4, testTdf137000_handle_upright)
 {
     // Upright is an xml attribute of xdr:txBody/a:bodyPr. It is set when in a textbox menu we
     // choose, 'do not rotate this element'. Implementations are in tdf#106197 with followup
-    // tdf#137000. tdf#149538, tdf#149551 improve the implementation to export 'upright' instead
+    // tdf#137000; tdf#149538, tdf#149551 improve the implementation to export 'upright' instead
     // of workaround 'rot'.
     createScDoc("xlsx/tdf137000_export_upright.xlsx");
 

sc/qa/unit/subsequent_export_test5.cxx

@@ -1476,8 +1476,8 @@ CPPUNIT_TEST_FIXTURE(ScExportTest5, testTdf170963_row_breaks)
     xmlDocUniquePtr pSheet = parseExport(u"xl/worksheets/sheet1.xml"_ustr);
     CPPUNIT_ASSERT(pSheet);
     const int nMaxRowBreaks = 1023;
-    // Original had 1026 row breaks, but the max Excel handles is 1023
+    // Original had 1026 row breaks, but the max Excel handles is 1023.
-    // Without the fix all 1026 got exported
+    // Without the fix all 1026 got exported.
     assertXPath(pSheet, "/x:worksheet/x:rowBreaks", "count", OUString::number(nMaxRowBreaks));
     CPPUNIT_ASSERT_EQUAL(nMaxRowBreaks, countXPathNodes(pSheet, "/x:worksheet/x:rowBreaks/x:brk"));
 }

sc/qa/unit/subsequent_filters_test.cxx

@@ -90,7 +90,7 @@ void testContentImpl(ScDocument& rDoc, bool bCheckMergedCells)
     OUString aString = rDoc.GetString(1, 0, 0);
 
     //check string import
-    CPPUNIT_ASSERT_EQUAL_MESSAGE("string imported not correctly", u"String1"_ustr, aString);
+    CPPUNIT_ASSERT_EQUAL_MESSAGE("string not imported correctly", u"String1"_ustr, aString);
     aString = rDoc.GetString(1, 1, 0);
     CPPUNIT_ASSERT_EQUAL_MESSAGE("string not imported correctly", u"String2"_ustr, aString);