ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity

new loplugin:unnecessarygetstr

Browse Source 
which prevents constructing unnecessary temporaries via getStr()

Change-Id: I9ca70893a10e954b5ee0e6ad6098660ee24c2bef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150170
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2023-04-09 20:51:44 +02:00
parent 1e79befa61
commit eaf071397a
59 changed files with 314 additions and 143 deletions
Download Patch File Download Diff File Expand all files Collapse all files
xmlhelp/source/cxxhelp/provider/urlparameter.cxx
+5 -8
View File
@@ -737,14 +737,12 @@ InputStreamTransformer::InputStreamTransformer( URLParameter* urlParam,
parString[last++] = "System";
parString[last++] = "'" + urlParam->getByName( "System" ) + "'";
parString[last++] = "productname";
parString[last++] = "'" + OString(
pDatabases->getProductName().getStr(),
pDatabases->getProductName().getLength(),
parString[last++] = "'" + OUStringToOString(
pDatabases->getProductName(),
RTL_TEXTENCODING_UTF8 ) + "'";
parString[last++] = "productversion";
parString[last++] = "'" +
OString( pDatabases->getProductVersion().getStr(),
pDatabases->getProductVersion().getLength(),
OUStringToOString( pDatabases->getProductVersion(),
RTL_TEXTENCODING_UTF8 ) + "'";
parString[last++] = "imgtheme";
@@ -829,9 +827,8 @@ InputStreamTransformer::InputStreamTransformer( URLParameter* urlParam,
OUString xslURL = pDatabases->getInstallPathAsURL();
OString xslURLascii = OString(
xslURL.getStr(),
xslURL.getLength(),
OString xslURLascii = OUStringToOString(
xslURL,
RTL_TEXTENCODING_UTF8) +
"main_transform.xsl";