From e6176fc4f051850ae36ea3958764fa2ad2e8959d Mon Sep 17 00:00:00 2001 From: Neil Roberts Date: Mon, 5 Oct 2026 15:40:54 +0200 Subject: [PATCH] sqliterator: Use rtl::Reference::get() instead of &* MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Using &* can be problematic if the pointer is null. In this case it doesn’t matter, but using Reference::get() is probably easier to understand anyway. This also paves the way for a later compiler plugin to check for this. Change-Id: I2361761496648eaaa1e245912ac19aa130b38863 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/211842 Tested-by: Jenkins Reviewed-by: Neil Roberts --- connectivity/source/parse/sqliterator.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/connectivity/source/parse/sqliterator.cxx b/connectivity/source/parse/sqliterator.cxx index 6166c981934a..b510c06e6bab 100644 --- a/connectivity/source/parse/sqliterator.cxx +++ b/connectivity/source/parse/sqliterator.cxx @@ -769,7 +769,7 @@ void OSQLParseTreeIterator::getColumnRange( const OSQLParseNode* _pColumnRef, OUString& _rTableRange, OUString& _out_rColumnAliasIfPresent ) const { - lcl_getColumnRange( _pColumnRef, m_pImpl->m_xConnection, _rColumnName, _rTableRange, &*m_aSelectColumns, _out_rColumnAliasIfPresent ); + lcl_getColumnRange( _pColumnRef, m_pImpl->m_xConnection, _rColumnName, _rTableRange, m_aSelectColumns.get(), _out_rColumnAliasIfPresent ); }