More loplugin:simplifybool
...found with GCC 9, where the standard library iterator implementations are apparently sufficiently different to older versions of GCC to find more cases of !(... == ...) vs. ... != ... Change-Id: Ibe7c5140049a69d2c5318b4b2371f2e66bd05028 Reviewed-on: https://gerrit.libreoffice.org/68012 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
@@ -157,7 +157,7 @@ OUString StringResourceImpl::implResolveString
|
||||
if( pLocaleItem != nullptr && loadLocale( pLocaleItem ) )
|
||||
{
|
||||
IdToStringMap::iterator it = pLocaleItem->m_aIdToStringMap.find( ResourceID );
|
||||
if( !( it == pLocaleItem->m_aIdToStringMap.end() ) )
|
||||
if( it != pLocaleItem->m_aIdToStringMap.end() )
|
||||
{
|
||||
aRetStr = (*it).second;
|
||||
bSuccess = true;
|
||||
@@ -189,7 +189,7 @@ bool StringResourceImpl::implHasEntryForId( const OUString& ResourceID, LocaleIt
|
||||
if( pLocaleItem != nullptr && loadLocale( pLocaleItem ) )
|
||||
{
|
||||
IdToStringMap::iterator it = pLocaleItem->m_aIdToStringMap.find( ResourceID );
|
||||
if( !( it == pLocaleItem->m_aIdToStringMap.end() ) )
|
||||
if( it != pLocaleItem->m_aIdToStringMap.end() )
|
||||
bSuccess = true;
|
||||
}
|
||||
return bSuccess;
|
||||
@@ -2039,7 +2039,7 @@ bool StringResourcePersistenceImpl::implWritePropertiesFile( LocaleItem const *
|
||||
{
|
||||
OUString aResourceID = *pStr;
|
||||
IdToStringMap::const_iterator it = rHashMap.find( aResourceID );
|
||||
if( !( it == rHashMap.end() ) )
|
||||
if( it != rHashMap.end() )
|
||||
{
|
||||
implWriteStringWithEncoding( aResourceID, xTextOutputStream, true );
|
||||
xTextOutputStream->writeString( "=" );
|
||||
|
||||
Reference in New Issue
Block a user