From e290c3f3e233f03a0b13d19553c637f0a7070fbf Mon Sep 17 00:00:00 2001 From: Muhammet Kara Date: Fri, 13 Dec 2019 16:02:17 +0300 Subject: [PATCH] tdf#129056: No need for catastrophe We can continue working without hurting others in case of an invalid reference. Putting in a warning so that it doesn't become a black hole which silences errors. Change-Id: I6d75edeba227a4293b0ae16217811e49ae336a6b Reviewed-on: https://gerrit.libreoffice.org/85111 Tested-by: Jenkins Reviewed-by: Muhammet Kara --- .../source/controller/sidebar/ChartColorWrapper.cxx | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/chart2/source/controller/sidebar/ChartColorWrapper.cxx b/chart2/source/controller/sidebar/ChartColorWrapper.cxx index 32763beb02e7..31808b1a292b 100644 --- a/chart2/source/controller/sidebar/ChartColorWrapper.cxx +++ b/chart2/source/controller/sidebar/ChartColorWrapper.cxx @@ -72,8 +72,19 @@ ChartColorWrapper::ChartColorWrapper( void ChartColorWrapper::operator()(const OUString& , const NamedColor& rColor) { + if (!mxModel.is()) + { + SAL_WARN("chart2", "Invalid reference to mxModel"); + return; + } + css::uno::Reference xPropSet = getPropSet(mxModel); - assert(xPropSet.is()); + + if (!xPropSet.is()) + { + SAL_WARN("chart2", "Invalid reference to xPropSet"); + return; + } xPropSet->setPropertyValue(maPropertyName, css::uno::makeAny(rColor.first)); }