From dfaee8d8f43f8725a0e999279f99e552eeb0bee2 Mon Sep 17 00:00:00 2001 From: Xisco Fauli Date: Wed, 23 Oct 2024 13:56:41 +0200 Subject: [PATCH] tdf#163486: PVS: enum type as bool V768 The variable 'eType' is of enum type. It is odd that it is used as a variable of a Boolean-type. Change-Id: I38f0302d8edcaef144f6071dc86500937d305591 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175478 Tested-by: Jenkins Reviewed-by: Xisco Fauli --- sc/source/filter/inc/lotform.hxx | 2 +- sc/source/filter/lotus/lotform.cxx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sc/source/filter/inc/lotform.hxx b/sc/source/filter/inc/lotform.hxx index 29751a2f5533..fa618b021da0 100644 --- a/sc/source/filter/inc/lotform.hxx +++ b/sc/source/filter/inc/lotform.hxx @@ -23,7 +23,7 @@ enum FUNC_TYPE { - FT_Return = 0, // End Formula + FT_Return, // End Formula FT_FuncFix0, // Function, 0 Parameter FT_FuncFix1, // Function, 0 Parameter FT_FuncFix2, // Function, 0 Parameter diff --git a/sc/source/filter/lotus/lotform.cxx b/sc/source/filter/lotus/lotform.cxx index b5f9ee055a7a..10bfc67e2da3 100644 --- a/sc/source/filter/lotus/lotform.cxx +++ b/sc/source/filter/lotus/lotform.cxx @@ -426,7 +426,7 @@ void LotusToSc::Convert( std::unique_ptr& rpErg, sal_Int32& rRest nBytesLeft = rRest; - while( eType ) // != FT_Return (==0) + while( eType != FT_Return ) { sal_uInt8 nOc; Read(nOc);