From cb3108f860065928552a86cf8acc4b3a95718ecf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= Date: Wed, 21 Dec 2022 14:10:10 +0000 Subject: [PATCH] cid#1517812 Dereference null return value MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: Ia9cf34f03a18e499f83e495c0f3714b7476c3973 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144687 Tested-by: Jenkins Reviewed-by: Caolán McNamara --- extensions/source/propctrlr/handlerhelper.cxx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/extensions/source/propctrlr/handlerhelper.cxx b/extensions/source/propctrlr/handlerhelper.cxx index 55ffb9182f48..dfa83ff0c6e8 100644 --- a/extensions/source/propctrlr/handlerhelper.cxx +++ b/extensions/source/propctrlr/handlerhelper.cxx @@ -292,9 +292,10 @@ namespace pcr std::unique_ptr PropertyHandlerHelper::makeBuilder(const OUString& rUIFile, const Reference& rContext) { Reference xWindow(rContext->getValueByName("BuilderParent"), UNO_QUERY_THROW); - weld::TransportAsXWindow* rTunnel + weld::TransportAsXWindow* pTunnel = comphelper::getFromUnoTunnel(xWindow); - return Application::CreateBuilder(rTunnel->getWidget(), rUIFile); + assert(pTunnel && "must exist"); + return Application::CreateBuilder(pTunnel->getWidget(), rUIFile); } void PropertyHandlerHelper::setBuilderParent(const css::uno::Reference& rContext, weld::Widget* pParent)